From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Kaushal Modi Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 May 2016 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 23451@debbugs.gnu.org, drew.adams@oracle.com, dgutov@yandex.ru X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" , Drew Adams , Dmitry Gutov Received: via spool by submit@debbugs.gnu.org id=B.146238501419461 (code B ref -1); Wed, 04 May 2016 18:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 4 May 2016 18:03:34 +0000 Received: from localhost ([127.0.0.1]:38137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ay194-00053p-0S for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ay192-00053d-SE for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay18n-0004Rx-6J for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay18m-0004QY-0i for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay18Y-0005Vx-UD for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:03:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay18K-0004Jm-0G for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:02:55 -0400 Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:36417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay18I-0004FK-QH for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:02:47 -0400 Received: by mail-ob0-x236.google.com with SMTP id aq1so19163780obc.3 for ; Wed, 04 May 2016 11:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=T26UevtFRJLqsTVy2G2y5DJ68PPMIUqTpwTYlVdSFt8=; b=PeJpe4jOYNGIrigcacskBXgw5C1zBc3iC0giFux66H8Ue4GT3i7jreyvbp3Gr5EQqZ PBRqFZ5m9HVNWaMp0k1cwLMkaZStLwo3FdhoqLIxx/a3ji4HrFdpc7PYFYxcjnJCbC72 uafOABuApH2X5n1z3842WdloSXB2BqUJ2W26jwhdQqCwuEYrWzxu7iVwu3EMYRQDpphN otFBq2ADYFqnqVdU+NS3DtlKhrrHFGfVmQ5MDH6nlgL6pt95NsI+MH1dqY2pkEi1d6+f +2gcejW/3EuWuQYbQZqmnmnpFl8SuE6K5nZ5Hcj86+FDYN/9XcTJAAQM49iJZJWG0xAM 8dzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=T26UevtFRJLqsTVy2G2y5DJ68PPMIUqTpwTYlVdSFt8=; b=Hft36GdgT0HSKvS+XbMqE9MTh+3UraNmq8619Upmxk0rRX9FHMydX+vOHPuVK1rcd8 8VuHYazivr6bmT9ramEqsnBbEnsmUx6s8Fdln/TUvDARCKyTmA0o2Kv0cE+PUKXqw22Z sopc4ULsO74l1FA2V1gAR999xpPnsCCq8Exc3Gg53oJSuZPNkgWMJSQEWDykth6NCOGj zvOiZ4BLW3ZA/zBh/3hqEMYsBdQtHDNkUyViySZBZ19fTY1aBu5+K/WHme0qUwdT/vrM +aPBE8nFp/79CfuZYBeYzl0PBnsN8vRjGmNW5q3jPeWAy3neekhuVIQBzcrc7itcsIx+ 8DIA== X-Gm-Message-State: AOPr4FWeON/8bPS06wrJ0oWjH4LGFgHgC+eM2G7Ic59PLVEE/UBAfKVUPU9r4QBYqj5K4nQ5ifieY/hU9Q6sxQ== X-Received: by 10.182.224.137 with SMTP id rc9mr4834287obc.39.1462384948811; Wed, 04 May 2016 11:02:28 -0700 (PDT) MIME-Version: 1.0 From: Kaushal Modi Date: Wed, 04 May 2016 18:02:18 +0000 Message-ID: Content-Type: multipart/alternative; boundary=089e0149bff6661f2105320807e7 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e0149bff6661f2105320807e7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable From: kmodi@ulcf41.cld.analog.com (Kaushal.Modi) To: bug-gnu-emacs@gnu.org Subject: --text follows this line-- The changes to the A/Q bindings in dired as discussed and confirmed are not immediately compatible on Windows Ref: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23426#49 Even understanding that users would need to install GNU find & grep on their Windows system to use the new implementations bound to A/Q in dired, I believe that we should have the following: - NOT bind A/Q at all if the right dependencies are not found. I tried the A binding on Windows, it looked like it was grepping for the strings I entered and returned an empty *xref* window. The same search on same files worked as expected in RHEL (to be honest I love this new feature on RHEL, and I might start using the A binding). Currently the implementation on Windows gives an appearance that something was searched for and no results were found. That is misleading! Possible solution? (when (correct-version-of-find-and-grep-found-p) (define-key dired-mode-map (kbd "A") #'dired-do-find-regexp) (define-key dired-mode-map (kbd "A") #'dired-do-find-regexp-and-replace)= ) - Another alternative would be (if we want to keep A/Q bindings) that a user-error or error be thrown if the correct external dependencies are not installed. The user should be let known that they need to install the GNU find/grep executables for their platform in order to use those commands. In the current implementation, the user will just assume that they searched something and nothing got returned. - The requirement to have find/grep installed should also go to backward incompatible changes section in NEWS. (I got an idea of "incompatible change" section in NEWS from this recent commit: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-25&id=3Dc68a09= 107c1f7459c626d38be5e0e991912e57ec ) I would suggest that this bug be made blocking for the release of 25.1. For Windows users, the bindings change for A/Q keys in dired is not apparent to the user. At the very least, an error should be thrown if the correct external dependencies (GNU version of find/grep) are not found on the system PATH. In GNU Emacs 25.0.93.4 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23) of 2016-05-04 built on .. Repository revision: adc80b7e238e09b1b8c392ecf902d2b978d9016d Windowing system distributor 'The X.Org Foundation', version 11.0.60900000 System Description: Red Hat Enterprise Linux Workstation release 6.6 (Santiago) Configured using: 'configure --with-modules --prefix=3D/home/kmodi/usr_local/apps/6/emacs/emacs-25 'CPPFLAGS=3D-fgnu89-inline -I/home/kmodi/usr_local/6/include -I/usr/include/freetype2 -I/usr/include' 'CFLAGS=3D-ggdb3 -O0' 'CXXFLAGS=3D-ggdb3 -O0' 'LDFLAGS=3D-L/home/kmodi/usr_local/6/lib -L/home/kmodi/usr_local/6/lib64 -ggdb3' PKG_CONFIG_PATH=3D/home/kmodi/usr_local/6/lib/pkgconfig:/home/kmodi/usr_lo= cal/6/lib64/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/6/lib/pkgconfig:/cad/a= di/apps/gnu/linux/x86_64/6/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pk= gconfig:/usr/share/pkgconfig:/lib/pkgconfig:/lib64/pkgconfig' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=3Dnone locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 87685 9438) (symbols 48 19756 0) (miscs 40 40 172) (strings 32 14551 3894) (string-bytes 1 435236) (vectors 16 12373) (vector-slots 8 433753 3061) (floats 8 168 95) (intervals 56 243 0) (buffers 976 12) (heap 1024 36573 680)) --=20 --=20 Kaushal Modi --089e0149bff6661f2105320807e7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
From: = kmodi@ulcf41.cld.analog.com (Kaushal.Modi)
Subject:
--text follows this line--

The changes to t= he A/Q bindings in dired as discussed and confirmed are not immediately com= patible on Windows


Even understa= nding that users would need to install GNU find & grep on
the= ir Windows system to use the new implementations bound to A/Q in dired,
I believe that we should have the following:

- NOT bind A/Q at all if the right dependencies are not found. I tried th= e
A binding on Windows, it looked like it was grepping for the st= rings I
entered and returned an empty *xref* window. The same sea= rch on same files
worked as expected in RHEL (to be honest I love= this new feature on RHEL,
and I might start using the A binding)= . Currently the implementation on
Windows gives an appearance tha= t something was searched for and no results
were found. That is m= isleading!

Possible solution?

=
(when (correct-version-of-find-and-grep-found-p)
=C2=A0 =C2= =A0(define-key dired-mode-map (kbd "A") #'dired-do-find-regex= p)
=C2=A0 =C2=A0(define-key dired= -mode-map (kbd "A") #'dired-do-find-regexp-and-replace))

- Another alternative would be (if we want to k= eep A/Q bindings) that a
user-error or error be thrown if the cor= rect external dependencies are not
installed. The user should be = let known that they need to install the GNU
find/grep executables= for their platform in order to use those commands. In
the curren= t implementation, the user will just assume that they searched
so= mething and nothing got returned.

- The requiremen= t to have find/grep installed should also go to backward
incompat= ible changes section in NEWS.

(I got an idea= of "incompatible change" section in NEWS from this recent commit= :=C2=A0http://git.savann= ah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-25&id=3Dc68a09107c1f7459c62= 6d38be5e0e991912e57ec=C2=A0)

I would suggest t= hat this bug be made blocking for the release of 25.1.=C2=A0

=
For Windows users, the bindings change for A/Q keys in dired is = not apparent to the user. At the very least, an error should be thrown if t= he correct external dependencies (GNU version of find/grep) are not found o= n the system PATH.



I= n GNU Emacs 25.0.93.4 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23)
=C2=A0of 2016-05-04 built on ..
Repository revision: adc80b= 7e238e09b1b8c392ecf902d2b978d9016d
Windowing system distributor &= #39;The X.Org Foundation', version 11.0.60900000
System Descr= iption: Red= Hat Enterprise Linux Workstation release 6.6 (Santiago)

Configured using:
=C2=A0'configure --with-modules
=C2=A0--prefix=3D/home/kmodi/usr_local/apps/6/emacs/emacs-25
=C2=A0'CPPFLAGS=3D-fgnu89-inline -I/home/kmodi/usr_local/6/include
=C2=A0-I/usr/include/freetype2 -I/usr/include' 'CFLAGS=3D-g= gdb3 -O0'
=C2=A0'CXXFLAGS=3D-ggdb3 -O0' 'LDFLAGS= =3D-L/home/kmodi/usr_local/6/lib
=C2=A0-L/home/kmodi/usr_local/6/= lib64 -ggdb3'
=C2=A0PKG_CONFIG_PATH=3D/home/kmodi/usr_local/6= /lib/pkgconfig:/home/kmodi/usr_local/6/lib64/pkgconfig:/cad/adi/apps/gnu/li= nux/x86_64/6/lib/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/6/lib64/pkgconfig= :/usr/lib/pkgconfig:/usr/lib64/pkgconfig:/usr/share/pkgconfig:/lib/pkgconfi= g:/lib64/pkgconfig'

Configured features:
=
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS<= /div>
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK2 X11 MODULES

Import= ant settings:
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0= value of $XMODIFIERS: @im=3Dnone
=C2=A0 locale-coding-system: ut= f-8-unix

Major mode: Lisp Interaction
Minor modes in effect:
=C2=A0 tooltip-mode: t
<= div>=C2=A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t
<= div>=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=
=C2=A0 global-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-composition-mode: = t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compressio= n-mode: t
=C2=A0 line-number-mode: t
=C2=A0 transient-m= ark-mode: t

Recent messages:
For informa= tion about GNU Emacs and the GNU system, type C-h C-a.
Making com= pletion list...

Load-path shadows:
None = found.

Features:
(shadow sort mail-extr = emacsbug message dired format-spec rfc822 mml
mml-sec password-ca= che epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-p= arse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc= 2045 ietf-drums mm-util help-fns help-mode easymenu
cl-loaddefs p= case cl-lib mail-prsvr mail-utils time-date mule-util
tooltip eld= oc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x= -win term/common-win x-dnd tool-bar dnd fontset image regexp-opt
= fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cl-generic cham georgian<= /div>
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean<= /div>
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech euro= pean
ethiopic indian cyrillic chinese charscript case-table epa-h= ook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadv= ice
loaddefs button faces cus-face macroexp files text-properties= overlay
sha1 md5 base64 format env code-pages mule custom widget=
hashtable-print-readable backquote dbusbind inotify dynamic-sett= ing
system-font-setting font-render-setting move-toolbar gtk x-to= olkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 87685 9438)
=C2= =A0(symbols 48 19756 0)
=C2=A0(miscs 40 40 172)
=C2=A0(= strings 32 14551 3894)
=C2=A0(string-bytes 1 435236)
= =C2=A0(vectors 16 12373)
=C2=A0(vector-slots 8 433753 3061)
=
=C2=A0(floats 8 168 95)
=C2=A0(intervals 56 243 0)
=C2=A0(buffers 976 12)
=C2=A0(heap 1024 36573 680))
--

--
Kaushal Modi

--089e0149bff6661f2105320807e7-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 04 15:09:49 2016 Received: (at control) by debbugs.gnu.org; 4 May 2016 19:09:49 +0000 Received: from localhost ([127.0.0.1]:38234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ay2BB-0001en-6p for submit@debbugs.gnu.org; Wed, 04 May 2016 15:09:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ay2BA-0001ea-LH for control@debbugs.gnu.org; Wed, 04 May 2016 15:09:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay2Ax-0006b4-7l for control@debbugs.gnu.org; Wed, 04 May 2016 15:09:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay2Ax-0006aL-5K for control@debbugs.gnu.org; Wed, 04 May 2016 15:09:35 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ay2As-00058F-JH for control@debbugs.gnu.org; Wed, 04 May 2016 15:09:30 -0400 Subject: control message for bug 23451 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 04 May 2016 15:09:30 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.1 (-------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.1 (-------) severity 23451 minor From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 00:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kaushal Modi , 23451@debbugs.gnu.org, drew.adams@oracle.com Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.149601643230359 (code B ref 23451); Mon, 29 May 2017 00:08:01 +0000 Received: (at 23451) by debbugs.gnu.org; 29 May 2017 00:07:12 +0000 Received: from localhost ([127.0.0.1]:42288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dF8DI-0007tb-3O for submit@debbugs.gnu.org; Sun, 28 May 2017 20:07:12 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:38391) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dF8DG-0007tO-Di for 23451@debbugs.gnu.org; Sun, 28 May 2017 20:07:10 -0400 Received: by mail-wm0-f41.google.com with SMTP id e127so38560032wmg.1 for <23451@debbugs.gnu.org>; Sun, 28 May 2017 17:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SzIFSj++78+y8jHrkEdoAEbpX3nrrkJttC8nXnUzDlI=; b=FBqHo/Zi3YZ+cHx0gMcckJD/R0MZ1y8/fQ6CUs8JzlHHLfIybzJoGR5A8BcQYguEr1 K4Um6heJGxDXluBQTrSs4/MUtb0XvfOvhrfze1yMOxZZZBkdY4sGEE++UFHy5UOaMlXA WbnKeS9jsZ8vC3rHmI9d66/sotA/gxnCJh3eZvLpqYYFoHAa6f0cYRwyGDMXWsJuYCUE SCFDxG5NuDLPBLvgcG/7Xd6e8ByVEntGAOm5bv/AhgsztWUJDBdWXg0DpscI/haaT+E1 q213J6zLF0qsujWjf9YveoYuC+r0j2nD9QRvaAfnycPWNo7t7++LQU73WJzIYT3hziyN jOsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SzIFSj++78+y8jHrkEdoAEbpX3nrrkJttC8nXnUzDlI=; b=fCV14PIC79ZkkJNdkWvmzae4/8om9umeGItC/wQXTEriNywgP3QTGmfTI5Kpf90KHm Ft3YiSL70GHROFZVKr3USJtaZDDGQmMOdYwPDSyQyDe9KGoZ4rsfihAhhqrGSp/xRjbV VPGzx/4ctx76rzMnDI1tvIJFLfhj/BXlzt4Y4ZYa76VyOeX9cRdpgK9iVz3UoaziMvhX V0CscRBuebHn/3T4Bx8xZj0xNwamwiFaHTHh5QvpNo95rF7aVwRdQtfT01RrxNMfNiL4 D5xQJLbqYwWT2f2c0naMwiw2QrQ5joAogesS6w5gti363x9BKTBKlaDvBDS7sHuzIs4N HGUA== X-Gm-Message-State: AODbwcA8CeYALy9NtQ3uUwPOdU0vbZvzsoHgu3PkZQaAaCA/YRrSg916 ByPykTAcaQHG5A== X-Received: by 10.28.140.74 with SMTP id o71mr20911163wmd.90.1496016424710; Sun, 28 May 2017 17:07:04 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id s29sm6713990wrb.21.2017.05.28.17.07.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 May 2017 17:07:03 -0700 (PDT) References: From: Dmitry Gutov Message-ID: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> Date: Mon, 29 May 2017 03:07:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 5/4/16 9:02 PM, Kaushal Modi wrote: > Another alternative would be (if we want to keep A/Q bindings) that a > user-error or error be thrown if the correct external dependencies are not > installed. The user should be let known that they need to install the GNU > find/grep executables for their platform in order to use those commands. I've made a step toward this in commit 3bc3dc4: if the status is not zero and the process made some output, we signal a user error with whatever output we have. It's not exactly installation instructions, but it will at least tell the user that something is wrong. Previously, I had some problems using this approach, but failed to document them properly. Let's see if someone manages to find them again. Hopefully, the only thing missing before was the (/= (point-min) (point-max)) check. From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 01:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kaushal Modi , 23451@debbugs.gnu.org, drew.adams@oracle.com Cc: Eli Zaretskii Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.14960197032571 (code B ref 23451); Mon, 29 May 2017 01:02:02 +0000 Received: (at 23451) by debbugs.gnu.org; 29 May 2017 01:01:43 +0000 Received: from localhost ([127.0.0.1]:42307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dF942-0000fP-Up for submit@debbugs.gnu.org; Sun, 28 May 2017 21:01:43 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dF941-0000fD-Jc for 23451@debbugs.gnu.org; Sun, 28 May 2017 21:01:41 -0400 Received: by mail-wm0-f65.google.com with SMTP id d127so14029591wmf.1 for <23451@debbugs.gnu.org>; Sun, 28 May 2017 18:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:from:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WWlIS+gDpUnL/sl4uNhHNNOm4h6ab2LNk+EbdXISRwY=; b=aXygHsj0DbUhpQKMvPB1MX7bERu/gP5G4uPlkyW0wTVvAhKhb01b1/gdPUH3Jg4qWu qw4xfwaqHpSsL5yyAx/IEvXFI0UWH8Nw2PKYhrSGfbqtSpknQMccHKHIJsvioqVB3GyB MKWsuVuk2pt03E+PmHLBNrUnHbVU3lBbqCiT2/JK7ZXrxc1NdI8dzSHLmuZimqNrqnRT Hjlnexc/2wLXOnmxpJ6wEAvN1083FhXbTMJHB2JzyI3IbkUIoDQtLPBgnyju72nWzLh1 siiyCeuzg/9UK7DPQVUs3EUwibvrZqDvIm7EARTyWCiGiWEChAwBAsaVSbP3TOJWDoYk /rCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:from:to:references:cc:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WWlIS+gDpUnL/sl4uNhHNNOm4h6ab2LNk+EbdXISRwY=; b=eHzRiZD02EETiuFmFzlb4iBAsw58M2ExKMccyuzXXJImruKO1Khcif6mSebaZkJe63 wfkIWVIHU8KvHDjuZeI+qxo7KQnlzzBBkz5XwSmZwGfExPmgTJt7TdF3afF2ZUj3CjXU g9auNoZGJmhLH1TscSl7Z2y63rGUhTTSlwb1t8PG1nkU420hw0/bUICUinf6tjVHDu8W SsmJZMsXGuPRIbDOuQqpfpyGS/Ztr5dAxA7RHOxWM1ce0BxUb4CWWp1cnztwew1/laOg UVuZCWzoqcmSiNr5/0Ltwnlvpa+YQFYax0UYEiSCjTxuZadj4AteRvgGm5QTtKtOkxlN WYpg== X-Gm-Message-State: AODbwcA65Sd5KqPUKEB4o8RCJh3SZRUHGNa8oSvHQr1dQxFGyoxwHMqu rKcujH4MtGinMg== X-Received: by 10.28.29.205 with SMTP id d196mr19311061wmd.30.1496019695841; Sun, 28 May 2017 18:01:35 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id m38sm10095686wrm.4.2017.05.28.18.01.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 28 May 2017 18:01:34 -0700 (PDT) From: Dmitry Gutov References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> Message-ID: <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> Date: Mon, 29 May 2017 04:01:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On 5/29/17 3:07 AM, Dmitry Gutov wrote: > Previously, I had some problems using this approach, but failed to > document them properly. Let's see if someone manages to find them again. Aaand here it is: 1. Enter the Emacs checkout, pull the latest commit, 'make' to make sure the new change is preloaded. 2. emacs -Q. 3. M-x project-find-regexp, enter 'turn-on-eldoc-mode'. 4. See the user error about status 1, and the message containing four grep hits. Doing this search with Ag confirms the same set of hits (with normal exit status). Could someone please explain why find-grep exits with status 1 here? It's not the command line invocation, or else we'd be getting this exit status for other similar inputs. From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 02:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 23451@debbugs.gnu.org, Eli Zaretskii , drew.adams@oracle.com, Kaushal Modi Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.149602660012396 (code B ref 23451); Mon, 29 May 2017 02:57:01 +0000 Received: (at 23451) by debbugs.gnu.org; 29 May 2017 02:56:40 +0000 Received: from localhost ([127.0.0.1]:42359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFArH-0003Ds-St for submit@debbugs.gnu.org; Sun, 28 May 2017 22:56:40 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:33328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFArG-0003Df-TJ for 23451@debbugs.gnu.org; Sun, 28 May 2017 22:56:39 -0400 Received: by mail-it0-f67.google.com with SMTP id l145so6171326ita.0 for <23451@debbugs.gnu.org>; Sun, 28 May 2017 19:56:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IAFYQPBzryFTOyr1GLSCaRExKj+w+FMVnCVDEVm4i0Q=; b=FCvtW9FzosXF97xEvDACAgupbr5jO9O0Cb5ZgQy25FiIP9bhVlh2RVaSNeKf5S0+8d vc9aMagC2yqiyODMkF6bT3u3+CLCMVLH17L4IiHuclOjtRJeg6+og7yohU0NBbQ4KSPT F3oLIrtdduMXT9iwn7qwU6Z7fcl1QfiRUsQ1It4Pv2E2MbGrFnw735vyWQS5nFx/vtJF FMWeCW6p0EIwwmUPFPWSKN1zyPdlsCZ/bHx4XEf2rXxtrlUdcnkswANFjObiOhlCKv/R pPh2smJZhX1ZxQkm5U0RP4NBiVpl+bVLDKySbOtSg1YkcSCJ4HycGcLFnYKNh585NdfI AM9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=IAFYQPBzryFTOyr1GLSCaRExKj+w+FMVnCVDEVm4i0Q=; b=BNSX/T6YfdBjH1Pwji0vEQv0f+VTd7MII1933VRFzRiBt19dK7+jHDgyt4mNflKoTQ gwVCmGJfGrenhR4JYZ6TFKksRKxgFGpHGPSdbDmqQShZFR6CiMtiJEpdiedYPn9KBZUU bt3xQ3copuICOMZ6jty5PcMFLHhS0QAeJhMQuZb+6WWtEKYUG/H8bw3MtNCWoEzAPe53 P9qUfI1sqPEifr8VFNfBXby1vamdfjMJk59d5KRCHhsBUM4oP9arYpf4Ft4EZN1Ov1Vz rdqyIzJFeftczFCjmSXmBmDaf/Bx0jEGlqEvW8H5nKM60j+eKhqZi3TgWwH8WX4q4IDa tTqQ== X-Gm-Message-State: AODbwcCXdoEJ6wS1o8qxY3Kn1JqxCaoOPM5p2IvLkcMiSeTjC5h9JTy0 hpw51XnHieW+VA== X-Received: by 10.36.200.85 with SMTP id w82mr12818265itf.70.1496026592996; Sun, 28 May 2017 19:56:32 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 73sm3700762ios.40.2017.05.28.19.56.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 May 2017 19:56:31 -0700 (PDT) From: npostavs@users.sourceforge.net References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> Date: Sun, 28 May 2017 22:58:08 -0400 In-Reply-To: <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> (Dmitry Gutov's message of "Mon, 29 May 2017 04:01:32 +0300") Message-ID: <87shjo4ben.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Dmitry Gutov writes: > 4. See the user error about status 1, and the message containing four > grep hits. Doing this search with Ag confirms the same set of hits > (with normal exit status). > > Could someone please explain why find-grep exits with status 1 here? I see the same exit status when running find ... -exec grep ... + from the shell. It seems that -exec + will cause 'find' to exit with status 1 if the exits with status 1: ~$ find . -exec false '{}' + ; echo $? 1 ~$ find . -exec true '{}' + ; echo $? 0 So when is grep, and the number of files is greater than the command line length limit, the exit status is effectively random (it depends on 'find' decides to group the batches of files it passes to 'grep'). From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 04:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: npostavs@users.sourceforge.net,Dmitry Gutov Cc: 23451@debbugs.gnu.org, drew.adams@oracle.com, Kaushal Modi Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.14960316201281 (code B ref 23451); Mon, 29 May 2017 04:21:01 +0000 Received: (at 23451) by debbugs.gnu.org; 29 May 2017 04:20:20 +0000 Received: from localhost ([127.0.0.1]:42387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFCAG-0000Kb-7Z for submit@debbugs.gnu.org; Mon, 29 May 2017 00:20:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFCAE-0000KP-Nq for 23451@debbugs.gnu.org; Mon, 29 May 2017 00:20:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFCA8-0002gh-Me for 23451@debbugs.gnu.org; Mon, 29 May 2017 00:20:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFC9n-0002Z8-Pe; Mon, 29 May 2017 00:19:51 -0400 Received: from [176.13.230.70] (port=38323 helo=[10.136.153.183]) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dFC9m-00074A-Ki; Mon, 29 May 2017 00:19:51 -0400 Date: Mon, 29 May 2017 07:19:46 +0300 User-Agent: K-9 Mail for Android In-Reply-To: <87shjo4ben.fsf@users.sourceforge.net> References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> <87shjo4ben.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Eli Zaretskii Message-ID: <7578C407-59D5-4D05-996A-7E81FCC12A11@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On May 29, 2017 5:58:08 AM GMT+03:00, npostavs@users=2Esourceforge=2Enet wr= ote: >Dmitry Gutov writes: > >> 4=2E See the user error about status 1, and the message containing four >> grep hits=2E Doing this search with Ag confirms the same set of hits >> (with normal exit status)=2E >> >> Could someone please explain why find-grep exits with status 1 here? > >I see the same exit status when running find =2E=2E=2E -exec grep =2E=2E= =2E + from >the shell=2E It seems that -exec + will cause 'find' to exit with >status 1 if the exits with status 1: > > ~$ find =2E -exec false '{}' + ; echo $? > 1 > ~$ find =2E -exec true '{}' + ; echo $? > 0 > >So when is grep, and the number of files is greater than the >command line length limit, the exit status is effectively random (it >depends on 'find' decides to group the batches of files it passes to >'grep')=2E Isn't this simply the consequence of grep returning non-zero status for files that didn't match? From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 08:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , npostavs@users.sourceforge.net Cc: 23451@debbugs.gnu.org, drew.adams@oracle.com, Kaushal Modi Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.149604651723672 (code B ref 23451); Mon, 29 May 2017 08:29:02 +0000 Received: (at 23451) by debbugs.gnu.org; 29 May 2017 08:28:37 +0000 Received: from localhost ([127.0.0.1]:42492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFG2X-00069k-Gl for submit@debbugs.gnu.org; Mon, 29 May 2017 04:28:37 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFG2W-00069Y-5t for 23451@debbugs.gnu.org; Mon, 29 May 2017 04:28:36 -0400 Received: by mail-wm0-f68.google.com with SMTP id k15so15845345wmh.3 for <23451@debbugs.gnu.org>; Mon, 29 May 2017 01:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JLnJYwqZp3qs0MjWi0QqOhNtKv23/XiEXls3hM5hG/A=; b=UcnIadzD4cf/CwZo1BI9lsep8F7X9c3mH9dOsZiuDCJQHyqai1kKzAlsy2Sn/ZaMb5 aAcrljq9o/HWB3WvzjcYVmvQFd6y7GGsJOaJIsVwV+6QrQfkC4n/LkmXQJDb7wNWk5vZ Ot2a73LDi1UPtYds7HCEwLfY2thCrszlaJGKOfC45C1lWHhNNIhq9PcOujY5wL7V/mhL 6ksSYrM02Mti5h7HtcbfuS1X4495iYyr+LfyrbzswgzOztSWqRHwOMuQ+sbOB1pLpg2B sxybkDmxmt0gqmbFyNvsCjEbAKG9VYqWiRkkjk2uGEOn6gmweP72TnH2PFRYcFka5Fh1 mGqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JLnJYwqZp3qs0MjWi0QqOhNtKv23/XiEXls3hM5hG/A=; b=sYI7c6vTAV1ywI+k9O7mt7+asESV9TUbD4+5J6GLSpdMbxd4xICVAFXqrmbYQrIlxd /l0UyBg9j94wkdD1+ov1CdgnUP5vJpmj69xYXTnimUJueg3kPjP895qiLmEExeoiSF0d oijTDKBJRm242rlmokdGzSdf0eJFwRltgHIVUQzheJd230c5VxZgbVeUvGmxnOTKgoPm olvHnucPigL4k8lK6iaA5QuscFQtQf7p+zQXHbeAyrPXEYthF2s+xOEt2vgtsRpDUle0 XO0gYgBksqKKYXU8kfquqJrDoFQb1I3Z1pMgGBUM/34q9icMt959ItTEKCMdH6XN+a2w BDcQ== X-Gm-Message-State: AODbwcBZf3z0NwIog6uWrN+ChUiid4Rbr6laYOpFuC+LVcmGt5n4jEJn bS6o5finHdWRcw== X-Received: by 10.28.152.69 with SMTP id a66mr10151109wme.6.1496046509393; Mon, 29 May 2017 01:28:29 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id 63sm17352944wmt.9.2017.05.29.01.28.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 May 2017 01:28:27 -0700 (PDT) References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> <87shjo4ben.fsf@users.sourceforge.net> <7578C407-59D5-4D05-996A-7E81FCC12A11@gnu.org> From: Dmitry Gutov Message-ID: <0006f04b-dc35-c72d-61f5-91625a6c68fc@yandex.ru> Date: Mon, 29 May 2017 11:28:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <7578C407-59D5-4D05-996A-7E81FCC12A11@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On 5/29/17 7:19 AM, Eli Zaretskii wrote: > Isn't this simply the consequence of grep returning non-zero status > for files that didn't match? The consequence of batching, I'd say. I wasn't 100% clear that Grep is called more than once with this invocation style. From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 08:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: npostavs@users.sourceforge.net Cc: 23451@debbugs.gnu.org, Kaushal Modi Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.149604785325918 (code B ref 23451); Mon, 29 May 2017 08:51:02 +0000 Received: (at 23451) by debbugs.gnu.org; 29 May 2017 08:50:53 +0000 Received: from localhost ([127.0.0.1]:42502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFGO4-0006jy-Lx for submit@debbugs.gnu.org; Mon, 29 May 2017 04:50:52 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:37389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFGO3-0006jm-G6 for 23451@debbugs.gnu.org; Mon, 29 May 2017 04:50:51 -0400 Received: by mail-wm0-f48.google.com with SMTP id d127so49837372wmf.0 for <23451@debbugs.gnu.org>; Mon, 29 May 2017 01:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xySpDV2mwiuU4uYyr+qYSYsrS8jFAla7VEyyd3mG2RA=; b=UkSbV5cGR3ATJXybLuTpqqj4ylXfpxdgsR9yvwmeAz9tk8J9/O3c5bpAfTJnEwfYUq uW+UMWFBPVmce8kFANRpVWPOfNjphNFz+WT0/XgHOtNy1PLNhrSUWNWfqjquJkUJmnct cK7HBx8E7GTW5n8Tme39yZoVfP8ptU3x26zspYzwrVMqKtIvcOH0W58QZEueuSzQqRjj vd99pHf46YC8Sgik5pPKSrjj902fSqDU4KXJQhUWeR2YODUyw8Qi73w7vS/New6G2OC1 k/nkxxJRlgO2e6qIYSjWbE5jBY5SnW4QPl4sTElYW1uAXWOokHfdfF6VZhQikI99TMRu 6owA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xySpDV2mwiuU4uYyr+qYSYsrS8jFAla7VEyyd3mG2RA=; b=sJe2sN+JvwMU59mR0j9AOl7G0YJdxFR/gDXUjpYCZDhsWsw9/DTty6rBaCPrjwb8/x 9goLZuK6//nG2vc9G04dJx+bL/ol3Csb5hgHsW90s3fQlnFYGxKny1qUwp/fF5x1NzkX mk4gqJyqAhmqVDl1G9k8ax0xSdkOJ28QhagGwtKnV6mgnqyTifU6DTf/94Y8tmsL87VG Q3G+KmzR8CpJj5OtG7C2d7HZgBF2N/K0ddwMZQwWD/DnE5fCPO+h97hfw2q5slywYUvR /9HPn5Cj5cHdkP75T3cVphbDeOwR+HFSH5q4wLA+I1Q3vRMVkgTswBsRPrGeROtGxi0d Kipg== X-Gm-Message-State: AODbwcAZ26yZ3OJ6PPPTc4Xj2ScozG9u8UswOfDFIv0ly+y237L9Ieqo qSbNIt8Lmyf+ew== X-Received: by 10.28.87.72 with SMTP id l69mr19364780wmb.111.1496047844612; Mon, 29 May 2017 01:50:44 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id q77sm10628670wmb.4.2017.05.29.01.50.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 May 2017 01:50:43 -0700 (PDT) References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> <87shjo4ben.fsf@users.sourceforge.net> From: Dmitry Gutov Message-ID: <26c7e970-5ca6-65f1-f26d-28e674a01a40@yandex.ru> Date: Mon, 29 May 2017 11:50:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <87shjo4ben.fsf@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 5/29/17 5:58 AM, npostavs@users.sourceforge.net wrote: > So when is grep, and the number of files is greater than the > command line length limit, the exit status is effectively random (it > depends on 'find' decides to group the batches of files it passes to > 'grep'). Can we make Grep exit with 0 no matter if it matched something or not? So that non-zero means an actual problem. There is no suitable command-line option, it seems, but maybe there's a shell-based option? Like 'grep ... || exit 0', but I don't think we want to swallow exit statuses higher than 1. Alternatively, I suppose we can learn to determine that the user has no working find and grep inside grep-compute-defaults, and possibly avoid setting grep-find-template in that case. From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 12:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 23451@debbugs.gnu.org, Kaushal Modi Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.149606175028153 (code B ref 23451); Mon, 29 May 2017 12:43:02 +0000 Received: (at 23451) by debbugs.gnu.org; 29 May 2017 12:42:30 +0000 Received: from localhost ([127.0.0.1]:42636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFK0D-0007K1-Vd for submit@debbugs.gnu.org; Mon, 29 May 2017 08:42:30 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:36086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFK0B-0007Jn-J5 for 23451@debbugs.gnu.org; Mon, 29 May 2017 08:42:28 -0400 Received: by mail-it0-f66.google.com with SMTP id i206so7019380ita.3 for <23451@debbugs.gnu.org>; Mon, 29 May 2017 05:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=n7wD2O0SIyXK8zEL/l8BQphJoACusSX3WktZRoMjA+I=; b=KuqDETKQKUVOJFpJH7ooXTUXMEYrpkYyAIs309Mgi8HklltCVKdHJIKS/AEt2PQx9h kQF2K2SQxpc9awe7eRwUYGi/EU6YAh/tRKEvhQ+r8n+I9lTnYkUDtxMbUaE6coK/nj+V scLL6dXe4eYSVfr1joOnFU8hb9i54aV9O/2hiAgXwfVEYnvPTVOyVUCrfIUcknXE0QuZ hUFhAOO0YVrcDARxWuxvMguU/0nxBrjGzJP1m5/ECOhSWQRMuuOaFCiweEQU/h0GumO4 bOPEynCvt0UatDXN5lhLRXYJ86WpK1SDQ22xpezqMWBsvkrSOkrgbvS6rbewWC5UfDyP z36g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=n7wD2O0SIyXK8zEL/l8BQphJoACusSX3WktZRoMjA+I=; b=owswutT1uVb7K2v6TNyoN9NR2vKiPyB2bpIwqHFXeLFfzKF0BO9+wrsRXB0ioak8xP cWYTCtsi/uSLacYGfs3bfl8rm+urNq01OZZyqlraMtO/dALSAHVINtbhSZYTDG43C+W5 09lbyx412h+Hs1kMvxR+UT48vj9UC0fPNoo3BBsqBeffx/e8T8Rf3aJym08Isd5F/rYa UJSWdpMZowLD4ocUtp/nQoEt0U58tmx7cU3Qi/oIQXajzY0mW3os3SQ+HyHh8zmiGNqT nSb92HZGEy3cQ4btpqFfSVtJfgxo13qYYHVNyen47cpovGrlMm8aIPppsL9DNp9kDMnO 5Zew== X-Gm-Message-State: AODbwcDvXy3b0Pzel7wmr2PzUKd+R6BhwIKjTrOKXlGsCOg6dugrF0Bw El9pOHuAYPY+gg== X-Received: by 10.36.118.17 with SMTP id z17mr31579806itb.74.1496061741842; Mon, 29 May 2017 05:42:21 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id d35sm4097965ioj.5.2017.05.29.05.42.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 May 2017 05:42:20 -0700 (PDT) From: npostavs@users.sourceforge.net References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> <87shjo4ben.fsf@users.sourceforge.net> <26c7e970-5ca6-65f1-f26d-28e674a01a40@yandex.ru> Date: Mon, 29 May 2017 08:43:58 -0400 In-Reply-To: <26c7e970-5ca6-65f1-f26d-28e674a01a40@yandex.ru> (Dmitry Gutov's message of "Mon, 29 May 2017 11:50:42 +0300") Message-ID: <87lgpf4yup.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Dmitry Gutov writes: > On 5/29/17 5:58 AM, npostavs@users.sourceforge.net wrote: > >> So when is grep, and the number of files is greater than the >> command line length limit, the exit status is effectively random (it >> depends on 'find' decides to group the batches of files it passes to >> 'grep'). > > Can we make Grep exit with 0 no matter if it matched something or not? > So that non-zero means an actual problem. > > There is no suitable command-line option, it seems, but maybe there's > a shell-based option? Like 'grep ... || exit 0', but I don't think we > want to swallow exit statuses higher than 1. This seems to work: find ... -exec sh -c 'grep -i -E -nH -e turn-on-eldoc-mode "$@" ; [ $? -le 1 ]' sh '{}' + From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: npostavs@users.sourceforge.net Cc: 23451@debbugs.gnu.org, kaushal.modi@gmail.com, dgutov@yandex.ru Reply-To: Eli Zaretskii Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.14960793643911 (code B ref 23451); Mon, 29 May 2017 17:37:02 +0000 Received: (at 23451) by debbugs.gnu.org; 29 May 2017 17:36:04 +0000 Received: from localhost ([127.0.0.1]:43636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFOaK-000110-8q for submit@debbugs.gnu.org; Mon, 29 May 2017 13:36:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFOaJ-00010X-LQ for 23451@debbugs.gnu.org; Mon, 29 May 2017 13:36:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFOaD-0001xS-NT for 23451@debbugs.gnu.org; Mon, 29 May 2017 13:35:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFOa7-0001us-Ts; Mon, 29 May 2017 13:35:51 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4965 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dFOa6-0001fv-Rx; Mon, 29 May 2017 13:35:51 -0400 Date: Mon, 29 May 2017 20:35:56 +0300 Message-Id: <83inkjftvn.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87lgpf4yup.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> <87shjo4ben.fsf@users.sourceforge.net> <26c7e970-5ca6-65f1-f26d-28e674a01a40@yandex.ru> <87lgpf4yup.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: npostavs@users.sourceforge.net > Date: Mon, 29 May 2017 08:43:58 -0400 > Cc: 23451@debbugs.gnu.org, Kaushal Modi > > This seems to work: > > find ... -exec sh -c 'grep -i -E -nH -e turn-on-eldoc-mode "$@" ; [ $? -le 1 ]' sh '{}' + Who said sh is available? I think we should simply test explicitly for 'find' and 'grep' being available, before we run the command. Otherwise, it sounds like we will increase the complexity and the fragility of the feature, to very little gain. From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: npostavs@users.sourceforge.net Cc: 23451@debbugs.gnu.org, Kaushal Modi Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.149609429614799 (code B ref 23451); Mon, 29 May 2017 21:45:02 +0000 Received: (at 23451) by debbugs.gnu.org; 29 May 2017 21:44:56 +0000 Received: from localhost ([127.0.0.1]:43886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFSTA-0003qd-He for submit@debbugs.gnu.org; Mon, 29 May 2017 17:44:56 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:36448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFST9-0003qQ-9g for 23451@debbugs.gnu.org; Mon, 29 May 2017 17:44:55 -0400 Received: by mail-wm0-f52.google.com with SMTP id 7so69203663wmo.1 for <23451@debbugs.gnu.org>; Mon, 29 May 2017 14:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/Mn1fmpmhmRg6vME0Td3/UWesDabipWh6O192W8ucTY=; b=NW0iRfHiPxadymUqajFeoeErHw8aZBg2oEWglM9KJyMWoZT1QesVai6AAtSzHRh3Kw RayKFxnc8k8YrpHb8Abpw5Lh3lN7Miaz7uTty6T8UocqC8k7bRbPb5/6HSwCXif3EunC L1m9b/segbuMHTpS24oW6bQS64/jqTJm4JKAGFNIZchHxl5mJj8q6jk6KFb2P+QhB4JZ eQLtPN9IsimN+vKaHV5xIUw1RIN7sjjyrgBS3gvXk9V397GBhlHHnhYVB/mILSmwPseV 9kMTZG+na8nO2gBj2/AXg06zqnm82RvvC0eZ86MZXuFh9gOkbbirdRFG3nD3+WJ0pAmp kR+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/Mn1fmpmhmRg6vME0Td3/UWesDabipWh6O192W8ucTY=; b=RxsUuslYr9dxbT41IgFdG+jJ5C/0YrFIpAElYXi0OgJQXvQHsGYH/yhZicpSKI3TzS O4E/SAswBojoF0r/yR+NWeBiAyGaAV3kNNQcrQKtoC8IE0gbgEyx4JAxFEH5YDwOOfBI TeaHkt3rpUvydUsrGKHkBrXVTL39fiPzK9jCGteuzgIPdCZqZmxvun5EDpJOEYXVVq1w GmOmb74bMgmmcf7hEAKbIMcYdGnegHcqufKA4pP0J7ySBsCq7qW17r5GOjOvHGDqj7Xg eg3hF5DuvT9X99EGnxQXEsWV+ozYzmUEDZmXTA/Eli/1/0DtwbHoMPF4VFTqWri2PP96 QfIw== X-Gm-Message-State: AODbwcBieSpG9Jr/1A3ahGhyOh2EGyJlVksMgTF3Y9/09sC5ACK4bPvd 02qKrkCuC+vFmg== X-Received: by 10.28.113.85 with SMTP id m82mr18262588wmc.21.1496094289482; Mon, 29 May 2017 14:44:49 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id h73sm23833849wma.10.2017.05.29.14.44.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 May 2017 14:44:48 -0700 (PDT) References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> <87shjo4ben.fsf@users.sourceforge.net> <26c7e970-5ca6-65f1-f26d-28e674a01a40@yandex.ru> <87lgpf4yup.fsf@users.sourceforge.net> From: Dmitry Gutov Message-ID: Date: Tue, 30 May 2017 00:44:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <87lgpf4yup.fsf@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On 5/29/17 3:43 PM, npostavs@users.sourceforge.net wrote: > This seems to work: > > find ... -exec sh -c 'grep -i -E -nH -e turn-on-eldoc-mode "$@" ; [ $? -le 1 ]' sh '{}' + Thank you for the attempt, but maybe I was asking too much. Seems like we can't rely on sh being available on all supported platforms. I'm inclined to go with a regexp-based approach for now. "program not found" errors rarely look like Grep output. From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 May 2017 22:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , npostavs@users.sourceforge.net Cc: 23451@debbugs.gnu.org, kaushal.modi@gmail.com Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.149609522816200 (code B ref 23451); Mon, 29 May 2017 22:01:02 +0000 Received: (at 23451) by debbugs.gnu.org; 29 May 2017 22:00:28 +0000 Received: from localhost ([127.0.0.1]:43894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFSiC-0004DE-5W for submit@debbugs.gnu.org; Mon, 29 May 2017 18:00:28 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFSiA-0004D2-Rx for 23451@debbugs.gnu.org; Mon, 29 May 2017 18:00:27 -0400 Received: by mail-wm0-f67.google.com with SMTP id d127so20769343wmf.1 for <23451@debbugs.gnu.org>; Mon, 29 May 2017 15:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hZ+7EEy79qmyn3+7nL07CRc+DMTvXVSS4aN6YaPrcoQ=; b=oo/ovXuD1HsFZK3xREhhb9NzRtNPAYasDj8R5T9YwDQZrZ3FZ+QoCl5Ad37LJC/fjS i8opZGVP1Ga5cIzU/t3FfxPkNi3kF7cwWiC/YBs6NXI79zLzQEQ8IxtyJEF7y5QRT90E Z54rpZyr9NgZ0bc0BLFRYJG9XrGiz3Wi+jE1kECnX4p7EoKKKq7tUWjTtYpVXTamts6x j09MWHfSydRvGR7Bjy8ZPB9OzN4Te7YnEkkbHlUWcHgKId4FKTMrerPq0+h9brB/8v05 Xjzb38Lo8ftI4Ww6jymn54rwP/Hnr9u6P/854OPLRJGtWGey8Mt2PQMYnwLcoO3H1HQL g+Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hZ+7EEy79qmyn3+7nL07CRc+DMTvXVSS4aN6YaPrcoQ=; b=tIZCbuLj36GSLqGDseW4JVOLGdRwy4Fxe+10G+CSuKhRkkSyGxeDZGgoyyrCnasge4 b0PmsU0+FwTtjwYk/z2T+swh77KZbb2fnEtRZySqb7aFeWF6Ld4w7EsOfl0hcyHz3QtV u09fB2j9/J3rAicRvjGGDuk5BRVYW8ky46HD+Ao3fKd/YBc5EJwnXGP/Zr8lznCiRNA2 x+HmRO0RU8jaMDDXGldXlHpiyFCO3wVIvhXDBk6EJAUqLkMeVnqFdqXdPyczeS6uGJLu kB7LFWgU3/NVfRaPNaiV/FfRCACZfy+k/CPXanDZZjgyndwkr/ERN7Vc6snxbQAHuwmQ NYrw== X-Gm-Message-State: AODbwcBFq/s1+lwMyxEd+wldJY+1an76jbaceVfOqhsOKjMuoWQOsBup IsiAhzacifH71g== X-Received: by 10.223.138.194 with SMTP id z2mr3700174wrz.66.1496095221054; Mon, 29 May 2017 15:00:21 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id 185sm11035966wmp.1.2017.05.29.15.00.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 May 2017 15:00:20 -0700 (PDT) References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> <87shjo4ben.fsf@users.sourceforge.net> <26c7e970-5ca6-65f1-f26d-28e674a01a40@yandex.ru> <87lgpf4yup.fsf@users.sourceforge.net> <83inkjftvn.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Tue, 30 May 2017 01:00:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <83inkjftvn.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On 5/29/17 8:35 PM, Eli Zaretskii wrote: > I think we should simply test explicitly for 'find' and 'grep' being > available, before we run the command. Windows comes with find.exe, though, one we can't use. > Otherwise, it sounds like we > will increase the complexity and the fragility of the feature, to very > little gain. Agreed, I was hoping for a solution that would more or less fit one of the templates defined in grep.el. See commit 4886b2e for something entirely different. From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2017 06:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 23451@debbugs.gnu.org, kaushal.modi@gmail.com, npostavs@users.sourceforge.net Reply-To: Eli Zaretskii Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.149612399126490 (code B ref 23451); Tue, 30 May 2017 06:00:03 +0000 Received: (at 23451) by debbugs.gnu.org; 30 May 2017 05:59:51 +0000 Received: from localhost ([127.0.0.1]:44059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFaC7-0006tC-4p for submit@debbugs.gnu.org; Tue, 30 May 2017 01:59:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFaC6-0006t0-BS for 23451@debbugs.gnu.org; Tue, 30 May 2017 01:59:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFaC0-0001Eu-BL for 23451@debbugs.gnu.org; Tue, 30 May 2017 01:59:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFaBw-0001EY-Kf; Tue, 30 May 2017 01:59:40 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1728 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dFaBv-0008OH-Np; Tue, 30 May 2017 01:59:40 -0400 Date: Tue, 30 May 2017 08:59:46 +0300 Message-Id: <83ziduevfx.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Dmitry Gutov on Tue, 30 May 2017 01:00:18 +0300) References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> <87shjo4ben.fsf@users.sourceforge.net> <26c7e970-5ca6-65f1-f26d-28e674a01a40@yandex.ru> <87lgpf4yup.fsf@users.sourceforge.net> <83inkjftvn.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 23451@debbugs.gnu.org, kaushal.modi@gmail.com > From: Dmitry Gutov > Date: Tue, 30 May 2017 01:00:18 +0300 > > On 5/29/17 8:35 PM, Eli Zaretskii wrote: > > > I think we should simply test explicitly for 'find' and 'grep' being > > available, before we run the command. > > Windows comes with find.exe, though, one we can't use. Yes, I meant to test it's the find we expect, not the one which comes with Windows out of the box. Which means not just executable-find, but something a bit more sophisticated. From unknown Fri Jun 20 18:24:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2017 08:12:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23451 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 23451@debbugs.gnu.org, kaushal.modi@gmail.com, npostavs@users.sourceforge.net Reply-To: Eli Zaretskii Received: via spool by 23451-submit@debbugs.gnu.org id=B23451.14961319176418 (code B ref 23451); Tue, 30 May 2017 08:12:03 +0000 Received: (at 23451) by debbugs.gnu.org; 30 May 2017 08:11:57 +0000 Received: from localhost ([127.0.0.1]:44124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFcFx-0001fS-AN for submit@debbugs.gnu.org; Tue, 30 May 2017 04:11:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFcFw-0001fH-1a for 23451@debbugs.gnu.org; Tue, 30 May 2017 04:11:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFcFq-0005oW-7C for 23451@debbugs.gnu.org; Tue, 30 May 2017 04:11:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFcFm-0005nx-FF; Tue, 30 May 2017 04:11:46 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1805 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dFcFl-00077Q-3R; Tue, 30 May 2017 04:11:45 -0400 Date: Tue, 30 May 2017 11:11:51 +0300 Message-Id: <83o9uaepbs.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Dmitry Gutov on Tue, 30 May 2017 01:00:18 +0300) References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> <87shjo4ben.fsf@users.sourceforge.net> <26c7e970-5ca6-65f1-f26d-28e674a01a40@yandex.ru> <87lgpf4yup.fsf@users.sourceforge.net> <83inkjftvn.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 23451@debbugs.gnu.org, kaushal.modi@gmail.com > From: Dmitry Gutov > Date: Tue, 30 May 2017 01:00:18 +0300 > > See commit 4886b2e for something entirely different. Thanks, looks good to me. From unknown Fri Jun 20 18:24:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kaushal Modi Subject: bug#23451: closed (Re: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools) Message-ID: References: X-Gnu-PR-Message: they-closed 23451 X-Gnu-PR-Package: emacs Reply-To: 23451@debbugs.gnu.org Date: Mon, 09 Oct 2017 14:31:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1507559462-17590-1" This is a multi-part message in MIME format... ------------=_1507559462-17590-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #23451: 25.0.93; Clarify the dependency on find/grep for platforms not havi= ng those tools which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 23451@debbugs.gnu.org. --=20 23451: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23451 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1507559462-17590-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 23451-done) by debbugs.gnu.org; 9 Oct 2017 14:30:47 +0000 Received: from localhost ([127.0.0.1]:58429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1Z4w-0004ZG-Rn for submit@debbugs.gnu.org; Mon, 09 Oct 2017 10:30:47 -0400 Received: from mail-qt0-f181.google.com ([209.85.216.181]:54255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1Z4v-0004Z4-04 for 23451-done@debbugs.gnu.org; Mon, 09 Oct 2017 10:30:45 -0400 Received: by mail-qt0-f181.google.com with SMTP id n61so15458537qte.10 for <23451-done@debbugs.gnu.org>; Mon, 09 Oct 2017 07:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uX+FY82ZdjQw00LC6XrUpFcnKP1giHn1ui05SexF1ig=; b=utZeYdEvfBF6gzG4IOxcyt+YRyoR4wZ8zRntUmlo3p9WBauhEMsJkK/BznFz6RuDTZ +yseXdPBag4Imi9q4v5nT/jDaCZBmA/bORDaAOY10WKikuSjp0NknWpB0U/aNIBsa+eS Z6dpILAbC+sy4YpGp6Zh2SHIsurkFkgnEoTB5MeWMbFdIbjAyft3RrflH6NQlAChzSvB 0G5KtsrVBFrml+UpURvji/7RveqXL2kFEcHGLKms1Wd+cXXiJ0f+qjrrcLshzuByzlDm FdoXrK9sJxb0dDGmNNxfpT+jwscaGicfqWo1gtcvA1heiT7ojwkLoftrFO+nB281DADE LzLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uX+FY82ZdjQw00LC6XrUpFcnKP1giHn1ui05SexF1ig=; b=erSXydoxGNm0IrS2fMPM5Hibb6bHXBn+Vezz4yC6ajJJulcqg/js2c6RVC4cqIKOk3 bUtxacM3l2YwbBno7MirwwxUqKUA63Ti9dpXAleDA6tP1XFvLGlJoOnvUVnSaHrCRP1m 9gjYcwt5t1AqiHJGN7X7uqfCwxazaLEJAFzpLuJ71YopCJc7y8Ts+4cG0caJX9tRgGdD XFF2HD/HnLBSXlw6d0zeoDp/wFGum6bxk6AG0V+ZKpeUqa0EoT3FzyXAGSJ6Vn7Duo4H 2XYmVCZj9II/ye+1PLHJ8MxLuu24hq0zbVG+G9o8WLqFRkv15r2HCxJ+WjoTS8T9rD0i xUIQ== X-Gm-Message-State: AMCzsaUBMVI7Qg1B/zQqpHl05UARcnf0MWjLmXlIUPkkT+0QbVYqrnAZ QeB4Cg155TZK/PkDFWhRKDw6PMpo0oB4IpG7bOk= X-Google-Smtp-Source: AOwi7QCxOzuzxuNVl6PuhxydG5dFqNTXgIX5xqg5hU6V78QRWg5ILqyg9xjCtAu5M2sTtkUeUPXMu3QzgKBFI+0lCpk= X-Received: by 10.129.169.9 with SMTP id g9mr8729133ywh.501.1507559437906; Mon, 09 Oct 2017 07:30:37 -0700 (PDT) MIME-Version: 1.0 References: <2d674c13-6626-bbd6-e461-c4de963167c4@yandex.ru> <8c71b311-263a-6e2c-3160-f1bbaa14e979@yandex.ru> <87shjo4ben.fsf@users.sourceforge.net> <26c7e970-5ca6-65f1-f26d-28e674a01a40@yandex.ru> <87lgpf4yup.fsf@users.sourceforge.net> <83inkjftvn.fsf@gnu.org> <83o9uaepbs.fsf@gnu.org> In-Reply-To: <83o9uaepbs.fsf@gnu.org> From: Kaushal Modi Date: Mon, 09 Oct 2017 14:30:27 +0000 Message-ID: Subject: Re: bug#23451: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools To: 23451-done@debbugs.gnu.org Content-Type: multipart/alternative; boundary="001a114ae65ac63a50055b1e083a" X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 23451-done Cc: Eli Zaretskii , Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) --001a114ae65ac63a50055b1e083a Content-Type: text/plain; charset="UTF-8" On Tue, May 30, 2017 at 4:11 AM Eli Zaretskii wrote: > > Cc: 23451@debbugs.gnu.org, kaushal.modi@gmail.com > > From: Dmitry Gutov > > Date: Tue, 30 May 2017 01:00:18 +0300 > > > > See commit 4886b2e for something entirely different. > > Thanks, looks good to me. > Closing this bug was long overdue .. was fixed in http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-26&id=4886b2ed52249597d1ea638f20c0ceb689075e72 -- Kaushal Modi --001a114ae65ac63a50055b1e083a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, May 30= , 2017 at 4:11 AM Eli Zaretskii <eliz@gn= u.org> wrote:
> Cc: 23451@debbugs.gnu.org= , kaushal.m= odi@gmail.com
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Tue, 30 May 2017 01:00:18 +0300
>
> See commit 4886b2e for something entirely different.

Thanks, looks good to me.

--

Kaushal Modi

--001a114ae65ac63a50055b1e083a-- ------------=_1507559462-17590-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 4 May 2016 18:03:34 +0000 Received: from localhost ([127.0.0.1]:38137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ay194-00053p-0S for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ay192-00053d-SE for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay18n-0004Rx-6J for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay18m-0004QY-0i for submit@debbugs.gnu.org; Wed, 04 May 2016 14:03:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay18Y-0005Vx-UD for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:03:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ay18K-0004Jm-0G for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:02:55 -0400 Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:36417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ay18I-0004FK-QH for bug-gnu-emacs@gnu.org; Wed, 04 May 2016 14:02:47 -0400 Received: by mail-ob0-x236.google.com with SMTP id aq1so19163780obc.3 for ; Wed, 04 May 2016 11:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to; bh=T26UevtFRJLqsTVy2G2y5DJ68PPMIUqTpwTYlVdSFt8=; b=PeJpe4jOYNGIrigcacskBXgw5C1zBc3iC0giFux66H8Ue4GT3i7jreyvbp3Gr5EQqZ PBRqFZ5m9HVNWaMp0k1cwLMkaZStLwo3FdhoqLIxx/a3ji4HrFdpc7PYFYxcjnJCbC72 uafOABuApH2X5n1z3842WdloSXB2BqUJ2W26jwhdQqCwuEYrWzxu7iVwu3EMYRQDpphN otFBq2ADYFqnqVdU+NS3DtlKhrrHFGfVmQ5MDH6nlgL6pt95NsI+MH1dqY2pkEi1d6+f +2gcejW/3EuWuQYbQZqmnmnpFl8SuE6K5nZ5Hcj86+FDYN/9XcTJAAQM49iJZJWG0xAM 8dzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=T26UevtFRJLqsTVy2G2y5DJ68PPMIUqTpwTYlVdSFt8=; b=Hft36GdgT0HSKvS+XbMqE9MTh+3UraNmq8619Upmxk0rRX9FHMydX+vOHPuVK1rcd8 8VuHYazivr6bmT9ramEqsnBbEnsmUx6s8Fdln/TUvDARCKyTmA0o2Kv0cE+PUKXqw22Z sopc4ULsO74l1FA2V1gAR999xpPnsCCq8Exc3Gg53oJSuZPNkgWMJSQEWDykth6NCOGj zvOiZ4BLW3ZA/zBh/3hqEMYsBdQtHDNkUyViySZBZ19fTY1aBu5+K/WHme0qUwdT/vrM +aPBE8nFp/79CfuZYBeYzl0PBnsN8vRjGmNW5q3jPeWAy3neekhuVIQBzcrc7itcsIx+ 8DIA== X-Gm-Message-State: AOPr4FWeON/8bPS06wrJ0oWjH4LGFgHgC+eM2G7Ic59PLVEE/UBAfKVUPU9r4QBYqj5K4nQ5ifieY/hU9Q6sxQ== X-Received: by 10.182.224.137 with SMTP id rc9mr4834287obc.39.1462384948811; Wed, 04 May 2016 11:02:28 -0700 (PDT) MIME-Version: 1.0 From: Kaushal Modi Date: Wed, 04 May 2016 18:02:18 +0000 Message-ID: Subject: 25.0.93; Clarify the dependency on find/grep for platforms not having those tools To: "bug-gnu-emacs@gnu.org" , Drew Adams , Dmitry Gutov Content-Type: multipart/alternative; boundary=089e0149bff6661f2105320807e7 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e0149bff6661f2105320807e7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable From: kmodi@ulcf41.cld.analog.com (Kaushal.Modi) To: bug-gnu-emacs@gnu.org Subject: --text follows this line-- The changes to the A/Q bindings in dired as discussed and confirmed are not immediately compatible on Windows Ref: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23426#49 Even understanding that users would need to install GNU find & grep on their Windows system to use the new implementations bound to A/Q in dired, I believe that we should have the following: - NOT bind A/Q at all if the right dependencies are not found. I tried the A binding on Windows, it looked like it was grepping for the strings I entered and returned an empty *xref* window. The same search on same files worked as expected in RHEL (to be honest I love this new feature on RHEL, and I might start using the A binding). Currently the implementation on Windows gives an appearance that something was searched for and no results were found. That is misleading! Possible solution? (when (correct-version-of-find-and-grep-found-p) (define-key dired-mode-map (kbd "A") #'dired-do-find-regexp) (define-key dired-mode-map (kbd "A") #'dired-do-find-regexp-and-replace)= ) - Another alternative would be (if we want to keep A/Q bindings) that a user-error or error be thrown if the correct external dependencies are not installed. The user should be let known that they need to install the GNU find/grep executables for their platform in order to use those commands. In the current implementation, the user will just assume that they searched something and nothing got returned. - The requirement to have find/grep installed should also go to backward incompatible changes section in NEWS. (I got an idea of "incompatible change" section in NEWS from this recent commit: http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-25&id=3Dc68a09= 107c1f7459c626d38be5e0e991912e57ec ) I would suggest that this bug be made blocking for the release of 25.1. For Windows users, the bindings change for A/Q keys in dired is not apparent to the user. At the very least, an error should be thrown if the correct external dependencies (GNU version of find/grep) are not found on the system PATH. In GNU Emacs 25.0.93.4 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23) of 2016-05-04 built on .. Repository revision: adc80b7e238e09b1b8c392ecf902d2b978d9016d Windowing system distributor 'The X.Org Foundation', version 11.0.60900000 System Description: Red Hat Enterprise Linux Workstation release 6.6 (Santiago) Configured using: 'configure --with-modules --prefix=3D/home/kmodi/usr_local/apps/6/emacs/emacs-25 'CPPFLAGS=3D-fgnu89-inline -I/home/kmodi/usr_local/6/include -I/usr/include/freetype2 -I/usr/include' 'CFLAGS=3D-ggdb3 -O0' 'CXXFLAGS=3D-ggdb3 -O0' 'LDFLAGS=3D-L/home/kmodi/usr_local/6/lib -L/home/kmodi/usr_local/6/lib64 -ggdb3' PKG_CONFIG_PATH=3D/home/kmodi/usr_local/6/lib/pkgconfig:/home/kmodi/usr_lo= cal/6/lib64/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/6/lib/pkgconfig:/cad/a= di/apps/gnu/linux/x86_64/6/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pk= gconfig:/usr/share/pkgconfig:/lib/pkgconfig:/lib64/pkgconfig' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=3Dnone locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 87685 9438) (symbols 48 19756 0) (miscs 40 40 172) (strings 32 14551 3894) (string-bytes 1 435236) (vectors 16 12373) (vector-slots 8 433753 3061) (floats 8 168 95) (intervals 56 243 0) (buffers 976 12) (heap 1024 36573 680)) --=20 --=20 Kaushal Modi --089e0149bff6661f2105320807e7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
From: = kmodi@ulcf41.cld.analog.com (Kaushal.Modi)
Subject:
--text follows this line--

The changes to t= he A/Q bindings in dired as discussed and confirmed are not immediately com= patible on Windows


Even understa= nding that users would need to install GNU find & grep on
the= ir Windows system to use the new implementations bound to A/Q in dired,
I believe that we should have the following:

- NOT bind A/Q at all if the right dependencies are not found. I tried th= e
A binding on Windows, it looked like it was grepping for the st= rings I
entered and returned an empty *xref* window. The same sea= rch on same files
worked as expected in RHEL (to be honest I love= this new feature on RHEL,
and I might start using the A binding)= . Currently the implementation on
Windows gives an appearance tha= t something was searched for and no results
were found. That is m= isleading!

Possible solution?

=
(when (correct-version-of-find-and-grep-found-p)
=C2=A0 =C2= =A0(define-key dired-mode-map (kbd "A") #'dired-do-find-regex= p)
=C2=A0 =C2=A0(define-key dired= -mode-map (kbd "A") #'dired-do-find-regexp-and-replace))

- Another alternative would be (if we want to k= eep A/Q bindings) that a
user-error or error be thrown if the cor= rect external dependencies are not
installed. The user should be = let known that they need to install the GNU
find/grep executables= for their platform in order to use those commands. In
the curren= t implementation, the user will just assume that they searched
so= mething and nothing got returned.

- The requiremen= t to have find/grep installed should also go to backward
incompat= ible changes section in NEWS.

(I got an idea= of "incompatible change" section in NEWS from this recent commit= :=C2=A0http://git.savann= ah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-25&id=3Dc68a09107c1f7459c62= 6d38be5e0e991912e57ec=C2=A0)

I would suggest t= hat this bug be made blocking for the release of 25.1.=C2=A0

=
For Windows users, the bindings change for A/Q keys in dired is = not apparent to the user. At the very least, an error should be thrown if t= he correct external dependencies (GNU version of find/grep) are not found o= n the system PATH.



I= n GNU Emacs 25.0.93.4 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.23)
=C2=A0of 2016-05-04 built on ..
Repository revision: adc80b= 7e238e09b1b8c392ecf902d2b978d9016d
Windowing system distributor &= #39;The X.Org Foundation', version 11.0.60900000
System Descr= iption: Red= Hat Enterprise Linux Workstation release 6.6 (Santiago)

Configured using:
=C2=A0'configure --with-modules
=C2=A0--prefix=3D/home/kmodi/usr_local/apps/6/emacs/emacs-25
=C2=A0'CPPFLAGS=3D-fgnu89-inline -I/home/kmodi/usr_local/6/include
=C2=A0-I/usr/include/freetype2 -I/usr/include' 'CFLAGS=3D-g= gdb3 -O0'
=C2=A0'CXXFLAGS=3D-ggdb3 -O0' 'LDFLAGS= =3D-L/home/kmodi/usr_local/6/lib
=C2=A0-L/home/kmodi/usr_local/6/= lib64 -ggdb3'
=C2=A0PKG_CONFIG_PATH=3D/home/kmodi/usr_local/6= /lib/pkgconfig:/home/kmodi/usr_local/6/lib64/pkgconfig:/cad/adi/apps/gnu/li= nux/x86_64/6/lib/pkgconfig:/cad/adi/apps/gnu/linux/x86_64/6/lib64/pkgconfig= :/usr/lib/pkgconfig:/usr/lib64/pkgconfig:/usr/share/pkgconfig:/lib/pkgconfi= g:/lib64/pkgconfig'

Configured features:
=
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS<= /div>
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK2 X11 MODULES

Import= ant settings:
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0= value of $XMODIFIERS: @im=3Dnone
=C2=A0 locale-coding-system: ut= f-8-unix

Major mode: Lisp Interaction
Minor modes in effect:
=C2=A0 tooltip-mode: t
<= div>=C2=A0 global-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t
<= div>=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=
=C2=A0 global-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 auto-composition-mode: = t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compressio= n-mode: t
=C2=A0 line-number-mode: t
=C2=A0 transient-m= ark-mode: t

Recent messages:
For informa= tion about GNU Emacs and the GNU system, type C-h C-a.
Making com= pletion list...

Load-path shadows:
None = found.

Features:
(shadow sort mail-extr = emacsbug message dired format-spec rfc822 mml
mml-sec password-ca= che epg epg-config gnus-util mm-decode mm-bodies
mm-encode mail-p= arse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc= 2045 ietf-drums mm-util help-fns help-mode easymenu
cl-loaddefs p= case cl-lib mail-prsvr mail-utils time-date mule-util
tooltip eld= oc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x= -win term/common-win x-dnd tool-bar dnd fontset image regexp-opt
= fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register
page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock
font-lock syntax facemenu font-core frame cl-generic cham georgian<= /div>
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean<= /div>
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech euro= pean
ethiopic indian cyrillic chinese charscript case-table epa-h= ook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadv= ice
loaddefs button faces cus-face macroexp files text-properties= overlay
sha1 md5 base64 format env code-pages mule custom widget=
hashtable-print-readable backquote dbusbind inotify dynamic-sett= ing
system-font-setting font-render-setting move-toolbar gtk x-to= olkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 87685 9438)
=C2= =A0(symbols 48 19756 0)
=C2=A0(miscs 40 40 172)
=C2=A0(= strings 32 14551 3894)
=C2=A0(string-bytes 1 435236)
= =C2=A0(vectors 16 12373)
=C2=A0(vector-slots 8 433753 3061)
=
=C2=A0(floats 8 168 95)
=C2=A0(intervals 56 243 0)
=C2=A0(buffers 976 12)
=C2=A0(heap 1024 36573 680))
--

--
Kaushal Modi

--089e0149bff6661f2105320807e7-- ------------=_1507559462-17590-1--