From debbugs-submit-bounces@debbugs.gnu.org Tue May 03 17:33:31 2016 Received: (at submit) by debbugs.gnu.org; 3 May 2016 21:33:31 +0000 Received: from localhost ([127.0.0.1]:35908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axhwh-0007hZ-0Z for submit@debbugs.gnu.org; Tue, 03 May 2016 17:33:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axhwf-0007hN-UR for submit@debbugs.gnu.org; Tue, 03 May 2016 17:33:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axhwR-0004PU-Ab for submit@debbugs.gnu.org; Tue, 03 May 2016 17:33:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axhwR-0004Ok-7q for submit@debbugs.gnu.org; Tue, 03 May 2016 17:33:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axhwF-00025U-2z for bug-gnu-emacs@gnu.org; Tue, 03 May 2016 17:33:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axhw1-0004Hy-5s for bug-gnu-emacs@gnu.org; Tue, 03 May 2016 17:32:55 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:24184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axhw0-0004E7-UL for bug-gnu-emacs@gnu.org; Tue, 03 May 2016 17:32:49 -0400 Received: from localhost (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1462311150151455.5310412901332; Tue, 3 May 2016 14:32:30 -0700 (PDT) From: Hong Xu To: bug-gnu-emacs@gnu.org Subject: [PATCH] Use the true name of a file to determine responsible vc. Date: Tue, 3 May 2016 14:32:25 -0700 Message-Id: <1462311145-5959-1-git-send-email-hong@topbug.net> X-Mailer: git-send-email 2.8.2 X-ZohoMail: Z_47435160 SPT_1 Z_47435159 SPT_1 SLF_D X-Zoho-Virus-Status: 2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Hong Xu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) In many cases, e.g., a symbolic link to a directory inside a vc tracked directory, vc-responsible-backend would fail to know the true backend. --- There is probably a better fix than this... Feel free to do so. --- lisp/vc/vc.el | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 25b41e34e645..1b060b4d1374 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -960,14 +960,15 @@ If FILE is already registered, return the backend of FILE. If FILE is not registered, then the first backend in `vc-handled-backends' that declares itself responsible for FILE is returned." - (or (and (not (file-directory-p file)) (vc-backend file)) + (let ((file-path (file-truename file))) + (or (and (not (file-directory-p file-path)) (vc-backend file-path)) (catch 'found - ;; First try: find a responsible backend. If this is for registration, - ;; it must be a backend under which FILE is not yet registered. - (dolist (backend vc-handled-backends) - (and (vc-call-backend backend 'responsible-p file) - (throw 'found backend)))) - (error "No VC backend is responsible for %s" file))) + ;; First try: find a responsible backend. If this is for registration, + ;; it must be a backend under which FILE is not yet registered. + (dolist (backend vc-handled-backends) + (and (vc-call-backend backend 'responsible-p file-path) + (throw 'found backend)))) + (error "No VC backend is responsible for %s" file-path)))) (defun vc-expand-dirs (file-or-dir-list backend) "Expands directories in a file list specification. -- 2.8.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 19 15:20:14 2016 Received: (at submit) by debbugs.gnu.org; 19 Oct 2016 19:20:14 +0000 Received: from localhost ([127.0.0.1]:40050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwwPO-00075i-3x for submit@debbugs.gnu.org; Wed, 19 Oct 2016 15:20:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwwPM-00075N-2r for submit@debbugs.gnu.org; Wed, 19 Oct 2016 15:20:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwwPF-0008WL-QT for submit@debbugs.gnu.org; Wed, 19 Oct 2016 15:20:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48174) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwwPF-0008Vz-Nh for submit@debbugs.gnu.org; Wed, 19 Oct 2016 15:20:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwwPD-0006oY-FZ for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 15:20:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwwPA-0008Tn-9w for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 15:20:03 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21386) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwwP9-0008TQ-W2 for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 15:20:00 -0400 Received: from [192.168.88.2] (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1476904795949216.28129094457574; Wed, 19 Oct 2016 12:19:55 -0700 (PDT) Subject: Re: [PATCH] Use the true name of a file to determine responsible vc. To: bug-gnu-emacs@gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> From: Hong Xu Message-ID: <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> Date: Wed, 19 Oct 2016 12:19:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1462311145-5959-1-git-send-email-hong@topbug.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ptwnC7sawV0a6xdhNaP9hXpwQ7iVTXVDu" X-Zoho-Virus-Status: 1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ptwnC7sawV0a6xdhNaP9hXpwQ7iVTXVDu Content-Type: multipart/mixed; boundary="q6E9Ch7Sn3qLoemEmwSnvwoLrlV90e88a"; protected-headers="v1" From: Hong Xu To: bug-gnu-emacs@gnu.org Message-ID: <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> Subject: Re: [PATCH] Use the true name of a file to determine responsible vc. References: <1462311145-5959-1-git-send-email-hong@topbug.net> In-Reply-To: <1462311145-5959-1-git-send-email-hong@topbug.net> --q6E9Ch7Sn3qLoemEmwSnvwoLrlV90e88a Content-Type: multipart/mixed; boundary="------------08A9F019FE8B13849704840A" This is a multi-part message in MIME format. --------------08A9F019FE8B13849704840A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable A better version of the fix is attached. On 05/03/2016 02:32 PM, Hong Xu wrote: > In many cases, e.g., a symbolic link to a directory inside a vc tracked= > directory, vc-responsible-backend would fail to know the true backend. >=20 > --- >=20 > There is probably a better fix than this... Feel free to do so. >=20 > --- > lisp/vc/vc.el | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) >=20 > diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el > index 25b41e34e645..1b060b4d1374 100644 > --- a/lisp/vc/vc.el > +++ b/lisp/vc/vc.el > @@ -960,14 +960,15 @@ If FILE is already registered, return the > backend of FILE. If FILE is not registered, then the > first backend in `vc-handled-backends' that declares itself > responsible for FILE is returned." > - (or (and (not (file-directory-p file)) (vc-backend file)) > + (let ((file-path (file-truename file))) > + (or (and (not (file-directory-p file-path)) (vc-backend file-path)= ) > (catch 'found > - ;; First try: find a responsible backend. If this is for registratio= n, > - ;; it must be a backend under which FILE is not yet registered. > - (dolist (backend vc-handled-backends) > - (and (vc-call-backend backend 'responsible-p file) > - (throw 'found backend)))) > - (error "No VC backend is responsible for %s" file))) > + ;; First try: find a responsible backend. If this is for regi= stration, > + ;; it must be a backend under which FILE is not yet registered= =2E > + (dolist (backend vc-handled-backends) > + (and (vc-call-backend backend 'responsible-p file-path) > + (throw 'found backend)))) > + (error "No VC backend is responsible for %s" file-path)))) > =20 > (defun vc-expand-dirs (file-or-dir-list backend) > "Expands directories in a file list specification. >=20 --------------08A9F019FE8B13849704840A Content-Type: text/x-patch; name="vc.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="vc.patch" diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index af875e89907f..368c89fb2557 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -964,9 +964,10 @@ vc-responsible-backend (catch 'found ;; First try: find a responsible backend. If this is for registration,= ;; it must be a backend under which FILE is not yet registered. - (dolist (backend vc-handled-backends) - (and (vc-call-backend backend 'responsible-p file) - (throw 'found backend)))) + (dolist (file-path (list file (file-truename file))) + (dolist (backend vc-handled-backends) + (and (vc-call-backend backend 'responsible-p file-path) + (throw 'found backend))))) (error "No VC backend is responsible for %s" file))) =20 (defun vc-expand-dirs (file-or-dir-list backend) --------------08A9F019FE8B13849704840A-- --q6E9Ch7Sn3qLoemEmwSnvwoLrlV90e88a-- --ptwnC7sawV0a6xdhNaP9hXpwQ7iVTXVDu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYB8dbAAoJECZsfTOCL4R4XdgQANd0yAT/Q5tyPm4q4mee8X9D v27odV2+b/F03Sqhc8glOS+gqjAVkGhcw12sBmXg3F/GasKdT8DUWwceXWEiD1W8 XSbfZ0cgt1Xt604I2UNVO4aCdoKjtDk7tllIahyNYT3ZZvph6/tJpBGUE8VU3saS 99ntZSx/04V8xmkqY2ufri+pC6DRPhOAFnZrdxPWA+CrFyqw3DOgkjvd3mPtPyDn gQMCEp6DH7n2h4ErEapgnIK9kXFbBFDXVDH+zY4iHSIqbVhIP5ewvQ2X5oPknE7E Rxk1ju+c3vr7c4HLjjQ/+gJxh8C40tcMnGnZJCPAzzQSFmZmh25EpeMAZ8CSSheV D06hLErQTrUBUEW4K6KtmZZeeIUC/GUm2uR3GW93UXwKZ00BeVCdgD8rS+5yc1gk ejHuatfTyuqYqudAx7EJrgTsb6JuRGCkiayn0VFujMGwP55A6IBdEfLXz7a1jeQ4 q2wfqA2WhDUoRzOJvxCYP/7/cQF+yNib+vZ97lFJRJxAEOim4BmAf18Jbt8iVaNg 0CbPMSmyVLpE1kk2bsv19oawW8bprUbu+d7as7XBbJ5F2mGR5que9E2MNpzkx19W K7n12I+/U5cvuPwUI04V5W1UOYJnG8izDL3/X9rIpPBAjeFRw/XnIYzQQXFQ55Tv pbbasdoM6MdRcMPz+jMV =g1Nz -----END PGP SIGNATURE----- --ptwnC7sawV0a6xdhNaP9hXpwQ7iVTXVDu-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 19 15:34:22 2016 Received: (at submit) by debbugs.gnu.org; 19 Oct 2016 19:34:22 +0000 Received: from localhost ([127.0.0.1]:40055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwwd4-0007RQ-ET for submit@debbugs.gnu.org; Wed, 19 Oct 2016 15:34:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwwd2-0007RE-LR for submit@debbugs.gnu.org; Wed, 19 Oct 2016 15:34:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwwcw-0006ee-C1 for submit@debbugs.gnu.org; Wed, 19 Oct 2016 15:34:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50052) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwwcw-0006ea-9I for submit@debbugs.gnu.org; Wed, 19 Oct 2016 15:34:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwwcv-0003Am-7q for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 15:34:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwwcq-0006bT-7L for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 15:34:13 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21365) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwwcp-0006ZS-W3 for bug-gnu-emacs@gnu.org; Wed, 19 Oct 2016 15:34:08 -0400 Received: from [192.168.88.2] (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1476905643330943.9877149837293; Wed, 19 Oct 2016 12:34:03 -0700 (PDT) Subject: Re: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: bug-gnu-emacs@gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> From: Hong Xu Message-ID: Date: Wed, 19 Oct 2016 12:33:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="G4vG15uRQI0NcsSKmMSTGBUXAmv5UCJuG" X-Zoho-Virus-Status: 1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --G4vG15uRQI0NcsSKmMSTGBUXAmv5UCJuG Content-Type: multipart/mixed; boundary="XeEbISOOg1QV1kFk5T0aVGKIcWQk1I1FQ"; protected-headers="v1" From: Hong Xu To: bug-gnu-emacs@gnu.org Message-ID: Subject: Re: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> In-Reply-To: <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> --XeEbISOOg1QV1kFk5T0aVGKIcWQk1I1FQ Content-Type: multipart/mixed; boundary="------------D092460B30549E804886345A" This is a multi-part message in MIME format. --------------D092460B30549E804886345A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Another updated version... --------------D092460B30549E804886345A Content-Type: text/x-patch; name="vc.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="vc.patch" diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index af875e89907f..db9b0db39c6b 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -962,11 +962,13 @@ vc-responsible-backend responsible for FILE is returned." (or (and (not (file-directory-p file)) (vc-backend file)) (catch 'found - ;; First try: find a responsible backend. If this is for registration,= - ;; it must be a backend under which FILE is not yet registered. - (dolist (backend vc-handled-backends) - (and (vc-call-backend backend 'responsible-p file) - (throw 'found backend)))) + ;; First try: find a responsible backend. If this is for + ;; registration, it must be a backend under which FILE is not + ;; yet registered. + (dolist (file-path (list file (file-truename file))) + (dolist (backend vc-handled-backends) + (and (vc-call-backend backend 'responsible-p file-path) + (throw 'found backend))))) (error "No VC backend is responsible for %s" file))) =20 (defun vc-expand-dirs (file-or-dir-list backend) --------------D092460B30549E804886345A-- --XeEbISOOg1QV1kFk5T0aVGKIcWQk1I1FQ-- --G4vG15uRQI0NcsSKmMSTGBUXAmv5UCJuG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYB8qqAAoJECZsfTOCL4R4vRQP/2wwIYf32FltfZK154TceZXT MU9BlrVMCXPXMUN3a8qd8ICxo5wkNPs1IA7bLuwlc4ddLsXwAviA3tNRpI2scRRY GzPwB6MHRdfiJFQLvHGdPaRT+tOyPHcUTzQ8bwhmaBkBbXLQmRNqsr3wyYxWu2/v jEfG68Z2sywOfvDux3Xc7J2hUWff3Nffr60tOG3ZKStl783x7PxfHYgW4tCXSgPc 2v8ga6xY/pnJAA4OgJBIyCusaewIfdUIoMwD2gj5BCk1OyEfRw/Ay7a9X0n8uFuJ Rs1GKMNYy9AuxeJCzPONNm14gcNUCkFRcmTUobW4Ok1V+Le7VwDt/hFUjsK1sQxj TfiHWweJe4wOVzmzF0BE1Tc5MASILfkfU4O58lvGwpBqdu5jPLJJFB4rIRiKaJFS m+Hisrm97ZxSgZ3Pf8mlTmZjEX0RvyHp+r5wdHWQ+HJ3tdksy85qA1suigvuvRLu E7x3HHAZM1A8IMqtRIxe1/zfmxmcsLJijOvrwMz0FnrAMqjoxv5Eq0bCzcZzgbKP 6FRjpP+hYiB8wDUrKjKN4lYS5njUtTxCBUZ7cR1pV3LKHBE0j8QEx0JTkKvbOsPq K1P8UDRgtX+ixnEOQyAVImz4WDeyAck44O1j8LJ1IJMROt1qbyIr44GChiVggYkz 91TLhEOsOkMDRI39ZMbk =Wzgb -----END PGP SIGNATURE----- --G4vG15uRQI0NcsSKmMSTGBUXAmv5UCJuG-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 19 19:37:24 2016 Received: (at 23436) by debbugs.gnu.org; 19 Oct 2016 23:37:24 +0000 Received: from localhost ([127.0.0.1]:40147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0QG-0006XV-Gj for submit@debbugs.gnu.org; Wed, 19 Oct 2016 19:37:24 -0400 Received: from mail-lf0-f43.google.com ([209.85.215.43]:36842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0QE-0006XJ-TG for 23436@debbugs.gnu.org; Wed, 19 Oct 2016 19:37:23 -0400 Received: by mail-lf0-f43.google.com with SMTP id b75so48948490lfg.3 for <23436@debbugs.gnu.org>; Wed, 19 Oct 2016 16:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=q+0OfaZYiHxCqta3IfDm+F3CEFtjEQ6HurJqgx4SJEY=; b=O5htI4tUdYiEgRiUWq3MjJnkrOUYgJG7vCJ4I7hiAZk55SqyX00ccP7cIQg7mOy4Nq /Qz7kenTAbgDUeFvjQqJEj0rx0cmRU/fVRtC0W9WOux4gpWPT4qw8F47/mPVmlvt5roL hre5orfXvaZ054gTd0kMv7n+ukM+NNfELCjkUwlzgCMOiIKOc/ERe/xbAmSGM5se3iEO lNiim139akSC4KEC+opBfO7ACeLb/RUGa8NEuRDLKXjl487hMtl1B9ByMXrg2xo/ko53 qjjXE5FQ2e2eSBbkb0EFzq77g3ktMw5HMLdk+6lCflb4K2qWIxj0++H1FVGsLyyQruoz 3XGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q+0OfaZYiHxCqta3IfDm+F3CEFtjEQ6HurJqgx4SJEY=; b=aGgbW4nU/z+wCl/sivgydAFS89vIcCyEfe2qyaBaJaGz57rMX/K7SyHtmsSXQHVUMz rGzlYpaN58kVNCvN5gnHu7jkk2/sQCG2OntMBX/1G9uJT8GicFf2ugJNTQXU9Bzxx4Z5 ODbF4ox3Q+0jNX1UZE3YmAVDzBnLX0vDSWwLSWWMZf05i+yNza2DH6dhXzVn0Nryj1dQ hJIhfS2yYToCvng3t7QJN2O8Cjty85U3Tblw1tE1r/MsaY5P/RWl8x0nV8mxY9T07XTe mxUim6m/ktY3/FzzOkRzG6/foT4VvUZ7dHmO/FT3yjhOalw2/57TowL0RlzAu1zDIwqc juZA== X-Gm-Message-State: AA6/9RmJxe877gJ88TTyc3oPZ/Haf2iig4R9nTg9sIYfzSUhq5APGYJQDVfZui4ZZ5rDtQ== X-Received: by 10.194.55.65 with SMTP id q1mr5711853wjp.45.1476920236618; Wed, 19 Oct 2016 16:37:16 -0700 (PDT) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id bl3sm73156773wjc.26.2016.10.19.16.37.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Oct 2016 16:37:15 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Hong Xu , 23436@debbugs.gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> From: Dmitry Gutov Message-ID: Date: Thu, 20 Oct 2016 02:37:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 23436 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 19.10.2016 22:33, Hong Xu wrote: > + (dolist (file-path (list file (file-truename file))) Why not just use the true name? From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 19 19:49:25 2016 Received: (at 23436) by debbugs.gnu.org; 19 Oct 2016 23:49:25 +0000 Received: from localhost ([127.0.0.1]:40155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0bs-0006op-VI for submit@debbugs.gnu.org; Wed, 19 Oct 2016 19:49:25 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0bs-0006oe-2m for 23436@debbugs.gnu.org; Wed, 19 Oct 2016 19:49:24 -0400 Received: from [10.120.10.85] (guest-wireless-207-151-035-036.usc.edu [207.151.35.36]) by mx.zohomail.com with SMTPS id 1476920956948485.3812079842925; Wed, 19 Oct 2016 16:49:16 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Dmitry Gutov , 23436@debbugs.gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> From: Hong Xu Message-ID: <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> Date: Wed, 19 Oct 2016 16:49:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u3FdlrT24CqiQ2PkneJ4qebMvGDP0D0ah" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 23436 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --u3FdlrT24CqiQ2PkneJ4qebMvGDP0D0ah Content-Type: multipart/mixed; boundary="FkXAS1DAPCWTftcwero4n1HBxd4b5EgmN"; protected-headers="v1" From: Hong Xu To: Dmitry Gutov , 23436@debbugs.gnu.org Message-ID: <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> In-Reply-To: --FkXAS1DAPCWTftcwero4n1HBxd4b5EgmN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/19/2016 04:37 PM, Dmitry Gutov wrote: > On 19.10.2016 22:33, Hong Xu wrote: >> + (dolist (file-path (list file (file-truename file))) >=20 > Why not just use the true name? Because sometimes we track symlinks specifically. The symlink files may link to a file in a different repo, for example a git submodule. --FkXAS1DAPCWTftcwero4n1HBxd4b5EgmN-- --u3FdlrT24CqiQ2PkneJ4qebMvGDP0D0ah Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYCAZ7AAoJECZsfTOCL4R4aSUP/2ZWSgaKf3eQs3UtMEkAWA8F kDLwQTO4T8yfAVpZjJ9/lv84GZ7OKrTxAmsdc388tyLP7UAPF1NukfqVP+8RGjzg wF+soR9PNGp5JlmmD4uNetO7Ea4t1kO1cShNhxGlXvHtzlu1IVSXBLNy4wu5kns+ JpEt/S+2+b7mxpyzy2qA5r4+GVuTrbLjF8R26PvDWa6ENIGYjS53rllSbgefvgm8 hXuEnfrMUrXoGpkXf023q4k1PC1UyQq496216Bneb7Juj2IuBEQ9jZKUUCquqiOK KSEr0TPg7thVmo4eb1d7T1QnPfb6/WwkesKPAnubOUwBV3UG3hz52WEy+vToH+yW XQP55V46lWh7tXvUxJIxsUFobo1KqltBQKgGt6Scv9FsDD3HFIFzifDcV/gX9RxU qBzv79AXBi4jq1rnW+3w+5zyNiKp558FkR2+2K+/VfVIfZbW9gxKVMADB2YTLvgf jKihe38ko9errg8UmijPQ/hhbhFWEcu45Y3tX0j9NA5I1hV6z4DuDFnEsmWiXkOl fkFAnz3QPzN9hvCNp2lxcF6w+lfTFOUm507NdhKvYDgUHbqXrVLdYLcpArKCubR4 OUT61TtHN4uyEPBwRz5CWgkYsTbxh8uIkox4yfTmbMGIiqD84JhQNKL4GMcbNEpN tWAcIEkd7LvFs6BjE+6N =mbsc -----END PGP SIGNATURE----- --u3FdlrT24CqiQ2PkneJ4qebMvGDP0D0ah-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 19 19:58:24 2016 Received: (at 23436) by debbugs.gnu.org; 19 Oct 2016 23:58:24 +0000 Received: from localhost ([127.0.0.1]:40165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0ka-00072R-5K for submit@debbugs.gnu.org; Wed, 19 Oct 2016 19:58:24 -0400 Received: from mail-lf0-f43.google.com ([209.85.215.43]:35951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx0kZ-00072E-3h for 23436@debbugs.gnu.org; Wed, 19 Oct 2016 19:58:23 -0400 Received: by mail-lf0-f43.google.com with SMTP id b75so49826167lfg.3 for <23436@debbugs.gnu.org>; Wed, 19 Oct 2016 16:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=a+nFhruCPFmQYFiXZ6fiMBnFsQw10zHTbuPZ/q56sz8=; b=v3e5XjCtEZors7kvUMtxd/+QA6XV8D0XgYSjWkwcXXlvZQrxMM0PJxoSTpgXLUc8CN 7QErnX257xZ2pUGA11679d0Td/3G4GFU3k3PpI3gpR8Ce84uq3hkQ0sAhcMZ6wxXZklx km+ZsGCAlPPMCNJLugVguzr2so3KZ/dfo5m9sEVxPzNfekV1L0uyImZArfAwl3E2sONN rLggwPrWw14sRCrUOEJXbqWOxDPrWQNRcGHKIEUaI3P8Ei+qViyuggGbRtMToWmU+3/I uRXCae8UPyHYpKHngRy621alfHRQugHiGHIPkjK+V+XHMoJ6iJd/QvC0oJFxB1agmFpq 4mvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=a+nFhruCPFmQYFiXZ6fiMBnFsQw10zHTbuPZ/q56sz8=; b=Hyu3hCIrZFIyhcPObibp6GxJy30qVoauDRFv04t+4s9SzBIQfYK6UEe1nJ5yvZHJ1s eCgkX/NFKXRChYrkX14fu78nuBB+xjQKX+bnCLErshXEyOw1CVgCQav0T2mNMEr3MrnI 4PpUJMO4qmETMB2lvtO76Pi8GqUcj30A5UTjHmPcr1L90+y/bkqi4wcVojr0+PzVKr4h d0iHqq44CWLEU7gkEcI+zv7dhJ+ZGpBGYNgJJ057YdGOoc3oNyXjcoeDsJ/F51t3hwRs MtFO1FqntF1O7Di3PssfDrOWZSJQEhunaUFtV6VlZApP9ywi2SDtelCAICQ/Ew8BPlif QTtQ== X-Gm-Message-State: AA6/9RlvolOW6B/p8I7ubBP2nz0MYHnoZAs0ryR6Tjj9DDaov9Ko9wfaLqhhbyvx65//1A== X-Received: by 10.28.195.196 with SMTP id t187mr4096922wmf.29.1476921496996; Wed, 19 Oct 2016 16:58:16 -0700 (PDT) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id f2sm73140395wjr.2.2016.10.19.16.58.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Oct 2016 16:58:16 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Hong Xu , 23436@debbugs.gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> From: Dmitry Gutov Message-ID: <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> Date: Thu, 20 Oct 2016 02:58:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 23436 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 20.10.2016 02:49, Hong Xu wrote: > On 10/19/2016 04:37 PM, Dmitry Gutov wrote: >> On 19.10.2016 22:33, Hong Xu wrote: >>> + (dolist (file-path (list file (file-truename file))) >> >> Why not just use the true name? > > Because sometimes we track symlinks specifically. The symlink files may > link to a file in a different repo, for example a git submodule. I'm not sure I understand. Please outline a problem scenario. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 19 20:17:17 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 00:17:18 +0000 Received: from localhost ([127.0.0.1]:40170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx12r-0007Y9-Nc for submit@debbugs.gnu.org; Wed, 19 Oct 2016 20:17:17 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx12q-0007Y1-2H for 23436@debbugs.gnu.org; Wed, 19 Oct 2016 20:17:16 -0400 Received: from [10.120.10.85] (guest-wireless-207-151-035-036.usc.edu [207.151.35.36]) by mx.zohomail.com with SMTPS id 1476922628541645.2695014676456; Wed, 19 Oct 2016 17:17:08 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Dmitry Gutov , 23436@debbugs.gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> From: Hong Xu Message-ID: Date: Wed, 19 Oct 2016 17:16:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JCgWTtMLRSFcOcH777pMdTjVWacXB2pXA" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 23436 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JCgWTtMLRSFcOcH777pMdTjVWacXB2pXA Content-Type: multipart/mixed; boundary="xlgvI6oqEsq4hmLUeGFs7o8rRcsCpO4Jk"; protected-headers="v1" From: Hong Xu To: Dmitry Gutov , 23436@debbugs.gnu.org Message-ID: Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> In-Reply-To: <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> --xlgvI6oqEsq4hmLUeGFs7o8rRcsCpO4Jk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/19/2016 04:58 PM, Dmitry Gutov wrote: > On 20.10.2016 02:49, Hong Xu wrote: >> On 10/19/2016 04:37 PM, Dmitry Gutov wrote: >>> On 19.10.2016 22:33, Hong Xu wrote: >>>> + (dolist (file-path (list file (file-truename file))) >>> >>> Why not just use the true name? >> >> Because sometimes we track symlinks specifically. The symlink files ma= y >> link to a file in a different repo, for example a git submodule. >=20 > I'm not sure I understand. Please outline a problem scenario. mkdir my-repo && cd my-repo hg init git clone git://git.savannah.gnu.org/emacs.git ln -s emacs/README README_emacs hg add README_emacs README_emacs is tracked in the repo "my-repo" but README is tracked in the emacs repo. If true name is directly used, we would fail to obtain the correct responsible backend. --xlgvI6oqEsq4hmLUeGFs7o8rRcsCpO4Jk-- --JCgWTtMLRSFcOcH777pMdTjVWacXB2pXA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYCA0DAAoJECZsfTOCL4R4EmMQAKu7XU0Bk674h4HOShc7rM7b 2UCluF5PEAiHslLcMVecb9D9FriW6tn71SfsuWiYPDE2qfiYrUMyggIidZgO+GIY NbtQrjMOoTfpkpa0g+HdIYefMVo1S5zwn3DJpcdN+rRej6kFIcUcN2i70Y2cfwO5 Cr0bgRdy5WaLNyc+oC5vKsECAljRK4f05fegIlQcwC1K4MvtBFnZPk2Tvhjy9OFT 7w7Zaoo7XX1L+LG7ed44MmLjohevzKIAFREElFkcnOUlxbbHI19KuCf9hyMkG3DD QBwu+zjp67MTWijb01CuusmWWVoWA7cC5uAz98GPlR442/g0KUWVFkJOdf1Vd5Rb VrwIFDBjA2WsN1r134oWYYokE7eB17L1+9H+fDnbUHKoHSS91L+LTrjsqn3rQs8E vH1zkSJTP8kCWkmFdCiL4g0k5McOqLCKJVgCnBo9yc/dQLdIGoq6LzwamGcRtb08 5Ob9/TF4zK6Q2S3EkEclqB+XF6/eQXlxstLMQwIrzgEcylOYsbZu5t0Z1v3RIydJ 7tDZb6tTVH8u1FJAfDC4vS/5EoPjwZRyc0FZtV6aw98kuuUkuXoWrDO5WnesaTcU axyn6vIWBXE7B9Eq+PE9cAOa4HnKP7zbWrfsTdtfBkqg8i4bj6bIke18K3vPj/BY w7CNn0qM4gxoILtDa1om =xeNR -----END PGP SIGNATURE----- --JCgWTtMLRSFcOcH777pMdTjVWacXB2pXA-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 02:58:36 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 06:58:36 +0000 Received: from localhost ([127.0.0.1]:40253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx7JE-0000BC-36 for submit@debbugs.gnu.org; Thu, 20 Oct 2016 02:58:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx7JD-0000Ay-3Y for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 02:58:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bx7J4-00025o-SC for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 02:58:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bx7J4-00025e-Oy; Thu, 20 Oct 2016 02:58:26 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4649 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bx7J3-0000nl-Ni; Thu, 20 Oct 2016 02:58:26 -0400 Date: Thu, 20 Oct 2016 09:58:13 +0300 Message-Id: <837f93v75m.fsf@gnu.org> From: Eli Zaretskii To: Hong Xu In-reply-to: (message from Hong Xu on Wed, 19 Oct 2016 17:16:58 -0700) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Hong Xu > Date: Wed, 19 Oct 2016 17:16:58 -0700 > > >>>> + (dolist (file-path (list file (file-truename file))) > >>> > >>> Why not just use the true name? > >> > >> Because sometimes we track symlinks specifically. The symlink files may > >> link to a file in a different repo, for example a git submodule. > > > > I'm not sure I understand. Please outline a problem scenario. > > mkdir my-repo && cd my-repo > hg init > git clone git://git.savannah.gnu.org/emacs.git > ln -s emacs/README README_emacs > hg add README_emacs > > README_emacs is tracked in the repo "my-repo" but README is tracked in > the emacs repo. If true name is directly used, we would fail to obtain > the correct responsible backend. What is the correct backend in this case? You seem to assume it's the one that maintains the symlink, but why is that assumption true? The backend is determined for certain operations. Did you make sure all of them will indeed want the backend of my-repo and not the other one. And what is the semantics of such a situation, anyway? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 03:21:54 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 07:21:54 +0000 Received: from localhost ([127.0.0.1]:40275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx7fm-0000kk-3J for submit@debbugs.gnu.org; Thu, 20 Oct 2016 03:21:54 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx7fk-0000kb-Uz for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 03:21:53 -0400 Received: from [192.168.88.14] (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 147694810431464.95100491800781; Thu, 20 Oct 2016 00:21:44 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Eli Zaretskii References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <837f93v75m.fsf@gnu.org> From: Hong Xu Message-ID: Date: Thu, 20 Oct 2016 00:21:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <837f93v75m.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HhDoBnDRnPnou1iUQd9BcLT7c1gnox85O" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HhDoBnDRnPnou1iUQd9BcLT7c1gnox85O Content-Type: multipart/mixed; boundary="unXSKCX4xE0SpR6nVxRJuwuqR7WwCPFvI"; protected-headers="v1" From: Hong Xu To: Eli Zaretskii Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org Message-ID: Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <837f93v75m.fsf@gnu.org> In-Reply-To: <837f93v75m.fsf@gnu.org> --unXSKCX4xE0SpR6nVxRJuwuqR7WwCPFvI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/19/2016 11:58 PM, Eli Zaretskii wrote: >> From: Hong Xu >> Date: Wed, 19 Oct 2016 17:16:58 -0700 >> >>>>>> + (dolist (file-path (list file (file-truename file))) >>>>> >>>>> Why not just use the true name? >>>> >>>> Because sometimes we track symlinks specifically. The symlink files = may >>>> link to a file in a different repo, for example a git submodule. >>> >>> I'm not sure I understand. Please outline a problem scenario. >> >> mkdir my-repo && cd my-repo >> hg init >> git clone git://git.savannah.gnu.org/emacs.git >> ln -s emacs/README README_emacs >> hg add README_emacs >> >> README_emacs is tracked in the repo "my-repo" but README is tracked in= >> the emacs repo. If true name is directly used, we would fail to obtain= >> the correct responsible backend. >=20 > What is the correct backend in this case? You seem to assume it's the > one that maintains the symlink, but why is that assumption true? >=20 > The backend is determined for certain operations. Did you make sure > all of them will indeed want the backend of my-repo and not the other > one. I agree that this assumption is quite controversial even for myself -- it depends on what this function is used for. Adding an option may be the best way to resolve it. > And what is the semantics of such a situation, anyway? For example, one may manage the home directory configuration with one type of VC. For configuration files for some applications, she may rarely use them, so she simply cloned/checked out someone else's configuration using a different VC, and symlink the file in the home dir to the actual configuration file. Another example: one may have a repository that contains files linking to non-tracked files -- create a repository that link to common configuration files such as the ones in /etc for easier management. --unXSKCX4xE0SpR6nVxRJuwuqR7WwCPFvI-- --HhDoBnDRnPnou1iUQd9BcLT7c1gnox85O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYCHCHAAoJECZsfTOCL4R4ONAQAJ+tcOrdWhmVE2C54NWjnO8c gjAe2wKcicuLp6iCtpE3LTA+kN4n43N/Vb2tFncVAUKuNbY0hnJ/30yeg4PdAj9q lUlU+zUHrl9TsZ8S4IU2iregAXst11GgucSixgqXBd3fxz6wH9LhpjmFscb9SiIB pBw+DmpHYwZ3Ag2vnf1VsldUt/1QQloalfzTrWlW8z5gJQeezX895BwoG9NkV4Iq WH0tXd19yc24nZvIyWFIZRjhrMAtj6XxS1y9uGLsVbKs7Vl65mK26B+03jcoMKHk VKMynr50GrW1Wut1LJvTr79RPjThoohYGH+wxPceKGHbUA+KjhNpwOOLRXLrjl/w QNk0Fy/SHiFTnqYk6GOMO6nZ2d3hPtxH6FRH8iLtbN8eEeXCi6NxnktYYQEd6oPt zFqdu8OISpEOf4xp9OzWaKdprWqnuOScW92WJCg4rIzHw7GoF7Nluyl9C6YVfF20 tZ9NM8Q8UPwOhZnralIrA1xSjObqYrpKcRBXa9iWFGDRlMoX/YdccA/ndGNWIOyo M83U9lAMuV2Ncyf7YEO5Z8zYrSoQSxO3sCkbwhrjXkWLoz/WYkF45t9rVHdfS01M 3WtYzhPUUxc06HMu1fErugGKM/5nFkB/f8qA/io06FUle2UpgumgNL0Er0ih7a9C 6FViM3vJ5ZP5QDZ5xv7/ =VXtn -----END PGP SIGNATURE----- --HhDoBnDRnPnou1iUQd9BcLT7c1gnox85O-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 04:23:59 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 08:23:59 +0000 Received: from localhost ([127.0.0.1]:40322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx8dr-0002GC-He for submit@debbugs.gnu.org; Thu, 20 Oct 2016 04:23:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx8dq-0002Fz-AE for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 04:23:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bx8dh-0002Kp-T5 for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 04:23:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bx8dh-0002Kh-Pr; Thu, 20 Oct 2016 04:23:49 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4769 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bx8dg-0000dq-N6; Thu, 20 Oct 2016 04:23:49 -0400 Date: Thu, 20 Oct 2016 11:23:36 +0300 Message-Id: <83pomvtomv.fsf@gnu.org> From: Eli Zaretskii To: Hong Xu In-reply-to: (message from Hong Xu on Thu, 20 Oct 2016 00:21:31 -0700) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <837f93v75m.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org > From: Hong Xu > Date: Thu, 20 Oct 2016 00:21:31 -0700 > > On 10/19/2016 11:58 PM, Eli Zaretskii wrote: > >> From: Hong Xu > >> Date: Wed, 19 Oct 2016 17:16:58 -0700 > >> > >>>>>> + (dolist (file-path (list file (file-truename file))) > >>>>> > >>>>> Why not just use the true name? > >>>> > >>>> Because sometimes we track symlinks specifically. The symlink files may > >>>> link to a file in a different repo, for example a git submodule. > >>> > >>> I'm not sure I understand. Please outline a problem scenario. > >> > >> mkdir my-repo && cd my-repo > >> hg init > >> git clone git://git.savannah.gnu.org/emacs.git > >> ln -s emacs/README README_emacs > >> hg add README_emacs > >> > >> README_emacs is tracked in the repo "my-repo" but README is tracked in > >> the emacs repo. If true name is directly used, we would fail to obtain > >> the correct responsible backend. > > > > What is the correct backend in this case? You seem to assume it's the > > one that maintains the symlink, but why is that assumption true? > > > > The backend is determined for certain operations. Did you make sure > > all of them will indeed want the backend of my-repo and not the other > > one. > > I agree that this assumption is quite controversial even for myself -- > it depends on what this function is used for. Adding an option may be > the best way to resolve it. What bothers me is that the use case where there really is no backend will now take twice as much time as it did before. Can we avoid trying the 2nd search by detecting that the truename and the original name specify the same file? Or maybe by detecting the file types that could justify the second search in the first place? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 04:50:19 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 08:50:19 +0000 Received: from localhost ([127.0.0.1]:40330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx93L-0002si-0o for submit@debbugs.gnu.org; Thu, 20 Oct 2016 04:50:19 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:35145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx93K-0002sV-1y for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 04:50:18 -0400 Received: by mail-lf0-f42.google.com with SMTP id l131so68916266lfl.2 for <23436@debbugs.gnu.org>; Thu, 20 Oct 2016 01:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=edxNEDA+yzj72JnMcfIPiag6yCIoEWBQQ2O25NH+LjU=; b=bU2c+dtwl/+LLGXXXhLKxeSEv0CkaMUeW43iIJH76hA+v/E0aXYgPnfKvqg4PSsH0J WfoTAkrmWTR0fMjW/pQFRELz0p50qbmlSUOFW3yf0U2QceIqsUy7ivhWT0ug2Hy2SxA8 ev99T7Tgh5iZCif+0DLs/cAz/NAsFjMBxjaxk+3JffiiK2GIfnDnwVX/l7G0Vc5eM+Jd cYNoNb1K9LSVqJyLJliYnEBM31Jg5D2SRTFh8f4J0SQVG51gEQmUbmyl1gXh/6p/gxCj v+HNJb74aghIen0FXJAPaTSnwUBd1D52+V2PNbMxGg5696vlf/kPdIOgvrs/E02RCriT GVdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=edxNEDA+yzj72JnMcfIPiag6yCIoEWBQQ2O25NH+LjU=; b=TWbN/ZRorxo8L/pQeuxmPfPi2cKzg/4yvXdEtyPv4OhLiOmhsFNQW2OUdZPO90LeFR AxstGKJ4TzhuG3S5u0s9+KLXnicnk51LofUd6KxYTWeqEoLyD50lfCN0t9n4iIvSITBA qCG60Ako7b+OoWtGGZKRVG5fVV0U6MhlcTWcn5ooJsUVI2nMmvwvBhNadrUcWFI6SZ1+ 1sZRTAsNEKDoPuXlomiscDv77St2GTi9syWTHzN3/k78DbW3PSRlaby4UCUpC8T/xk7/ ETbIpIn0wKwo3eoQDg9yFsPNjZngKACPjbKzOGG3iUa5qAyRPNNXwdI9jaGKEq8ngDRa srEg== X-Gm-Message-State: AA6/9RkHp/SkUmHJLAkJvhBOIJDFpZu0vkUaUAnsyPsISRsiyLEdiDWas5m/7628cFOOAw== X-Received: by 10.25.76.7 with SMTP id z7mr10954313lfa.126.1476953411102; Thu, 20 Oct 2016 01:50:11 -0700 (PDT) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id 75sm11651249lja.34.2016.10.20.01.50.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2016 01:50:10 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Eli Zaretskii , Hong Xu References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <837f93v75m.fsf@gnu.org> <83pomvtomv.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Thu, 20 Oct 2016 11:50:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <83pomvtomv.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 20.10.2016 11:23, Eli Zaretskii wrote: > What bothers me is that the use case where there really is no backend > will now take twice as much time as it did before. That is my main concern as well. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 05:46:53 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 09:46:53 +0000 Received: from localhost ([127.0.0.1]:40343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx9w5-0004BM-LI for submit@debbugs.gnu.org; Thu, 20 Oct 2016 05:46:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:58627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx9w4-0004BF-50 for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 05:46:52 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 261DCAC56; Thu, 20 Oct 2016 09:46:51 +0000 (UTC) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <837f93v75m.fsf@gnu.org> <83pomvtomv.fsf@gnu.org> X-Yow: Is it clean in other dimensions? Date: Thu, 20 Oct 2016 11:46:50 +0200 In-Reply-To: <83pomvtomv.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 20 Oct 2016 11:23:36 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 23436 Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org, Hong Xu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) On Okt 20 2016, Eli Zaretskii wrote: > What bothers me is that the use case where there really is no backend > will now take twice as much time as it did before. Perhaps only do that if the file is a symlink? Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 05:47:15 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 09:47:15 +0000 Received: from localhost ([127.0.0.1]:40347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx9wQ-0004CK-SQ for submit@debbugs.gnu.org; Thu, 20 Oct 2016 05:47:15 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:34059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx9wO-0004C7-TH for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 05:47:13 -0400 Received: by mail-lf0-f66.google.com with SMTP id x23so6672019lfi.1 for <23436@debbugs.gnu.org>; Thu, 20 Oct 2016 02:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FFl1ORqddxW1HtJqF1sJBLOpPIRIJ3HqFWV+EqZlutY=; b=Fc3SYURATUt5IxltwJJ7q+386rx2bm+SxoIZd3ymj1uH7yS4A8zDmrWu2UikNw0I7z oXH8guuzZBhW+6oScz9vzDGt8qCTP25hsJHWQ5PibWg94JVTvuXbBE8le5666jeK0uQm 4VE8gGc3MLT3chP4yOo4vTQfnHcVeiUc2KbdtQDYvTVFZu14es0JvdfkfqAqDCkQfvgn XrjKgsMzrcHeUuSJR0R26FN+vMlqt/xFjaaz/rsNkYoH1+A8JA/cO9VV7iVQtwZidbOG 2DTMK7uFqyD/PsxpfSfa5m4ZhV6efYqMRy/XsASNVJYWH5DKGOobd7Jqd+4XRD+fr2aM DNWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FFl1ORqddxW1HtJqF1sJBLOpPIRIJ3HqFWV+EqZlutY=; b=CII6mpkg4HtvW8vPKGuLcjE6IvDClq9ijjFOYj9JDzgNrUqZAgHVXY81yomt7yaOQy XjysLsQOeMRchqOMFV8iUrVYvF/qIUnj1MeuPMwwXA2iQfRtD4VSrOraOxKFq7GSRtKU i+NKG04TbZy3T57bI6c7WRVQWVzUNK1GfHLx5pBzdWv9wMXQtwwmcwC5eB6OFdoRtPV3 gH+XcLU8JcpeFyJ8CzJ2Jd2MD8iVKUVob61AT4HgRVzDbKMl9/2fV5uCwieA1j7QEPNm qAc3NwqI9xJ9aIu6qChZyaKNoUOg8R/0+Ui3w5ihFzZIo+kZf0l4xgjfDVlbquCXmVeb xZXg== X-Gm-Message-State: AA6/9RnCg2ts1thmtMv2G/758SI82jK1Yg3/IbZAwqcpjrY+gceQmO7h46IG2OCSbpz5tA== X-Received: by 10.25.24.154 with SMTP id 26mr230036lfy.3.1476956826617; Thu, 20 Oct 2016 02:47:06 -0700 (PDT) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id i136sm9861228lfg.36.2016.10.20.02.47.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2016 02:47:05 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Hong Xu , 23436@debbugs.gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> From: Dmitry Gutov Message-ID: Date: Thu, 20 Oct 2016 12:47:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23436 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 20.10.2016 03:16, Hong Xu wrote: > mkdir my-repo && cd my-repo > hg init > git clone git://git.savannah.gnu.org/emacs.git > ln -s emacs/README README_emacs > hg add README_emacs > > README_emacs is tracked in the repo "my-repo" but README is tracked in > the emacs repo. If true name is directly used, we would fail to obtain > the correct responsible backend. OK, thanks. Regarding the user option, though, wouldn't it be almost as good if you could call vc-follow-link interactively? Not sure if vc-follow-link works for directories, but a new command could. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 06:03:22 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 10:03:22 +0000 Received: from localhost ([127.0.0.1]:40356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxABy-0004Zx-FY for submit@debbugs.gnu.org; Thu, 20 Oct 2016 06:03:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxABu-0004ZZ-04 for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 06:03:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxABk-0006cK-DJ for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 06:03:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxABk-0006cG-Ak; Thu, 20 Oct 2016 06:03:04 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4906 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bxABj-0000kK-Ge; Thu, 20 Oct 2016 06:03:03 -0400 Date: Thu, 20 Oct 2016 13:02:51 +0300 Message-Id: <83mvhztk1g.fsf@gnu.org> From: Eli Zaretskii To: Andreas Schwab In-reply-to: (message from Andreas Schwab on Thu, 20 Oct 2016 11:46:50 +0200) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <837f93v75m.fsf@gnu.org> <83pomvtomv.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: 23436 Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org, hong@topbug.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > From: Andreas Schwab > Cc: Hong Xu , dgutov@yandex.ru, 23436@debbugs.gnu.org > Date: Thu, 20 Oct 2016 11:46:50 +0200 > > On Okt 20 2016, Eli Zaretskii wrote: > > > What bothers me is that the use case where there really is no backend > > will now take twice as much time as it did before. > > Perhaps only do that if the file is a symlink? Something like that, yes. Wouldn't a hard link also be a candidate? Are there any others? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 06:59:21 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 10:59:21 +0000 Received: from localhost ([127.0.0.1]:40384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxB4D-0005y3-C0 for submit@debbugs.gnu.org; Thu, 20 Oct 2016 06:59:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxB4C-0005xl-Da for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 06:59:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxB46-0003wB-DS for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 06:59:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxB40-0003uW-Ak; Thu, 20 Oct 2016 06:59:08 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4776 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bxB3z-0000Um-BA; Thu, 20 Oct 2016 06:59:07 -0400 Date: Thu, 20 Oct 2016 13:58:55 +0300 Message-Id: <83lgxjthg0.fsf@gnu.org> From: Eli Zaretskii To: schwab@suse.de, hong@topbug.net In-reply-to: <83mvhztk1g.fsf@gnu.org> (message from Eli Zaretskii on Thu, 20 Oct 2016 13:02:51 +0300) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <837f93v75m.fsf@gnu.org> <83pomvtomv.fsf@gnu.org> <83mvhztk1g.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: 23436 Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) > Date: Thu, 20 Oct 2016 13:02:51 +0300 > From: Eli Zaretskii > Cc: hong@topbug.net, 23436@debbugs.gnu.org, dgutov@yandex.ru > > > > What bothers me is that the use case where there really is no backend > > > will now take twice as much time as it did before. > > > > Perhaps only do that if the file is a symlink? > > Something like that, yes. Wouldn't a hard link also be a candidate? > Are there any others? Actually, I think the symlink case is the only one we should care about, as long as we use file-truename. So yes, doing the second test only for symlink sounds like the way to avoid doubling the search time. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 12:40:00 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 16:40:00 +0000 Received: from localhost ([127.0.0.1]:40820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxGNs-0007Ad-1I for submit@debbugs.gnu.org; Thu, 20 Oct 2016 12:40:00 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxGNp-0007AU-Qe for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 12:39:58 -0400 Received: from [192.168.88.88] (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1476981589579883.5738328465951; Thu, 20 Oct 2016 09:39:49 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Dmitry Gutov , 23436@debbugs.gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> From: Hong Xu Message-ID: Date: Thu, 20 Oct 2016 09:39:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="47NG60tktUOCBwS1FKg4n2KNnnLo9fFuL" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 23436 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --47NG60tktUOCBwS1FKg4n2KNnnLo9fFuL Content-Type: multipart/mixed; boundary="JnIXT4dc8FcRmmSmvOpkN2hEAFBphH9b3"; protected-headers="v1" From: Hong Xu To: Dmitry Gutov , 23436@debbugs.gnu.org Message-ID: Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> In-Reply-To: --JnIXT4dc8FcRmmSmvOpkN2hEAFBphH9b3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/20/2016 02:47 AM, Dmitry Gutov wrote: > On 20.10.2016 03:16, Hong Xu wrote: >=20 >> mkdir my-repo && cd my-repo >> hg init >> git clone git://git.savannah.gnu.org/emacs.git >> ln -s emacs/README README_emacs >> hg add README_emacs >> >> README_emacs is tracked in the repo "my-repo" but README is tracked in= >> the emacs repo. If true name is directly used, we would fail to obtain= >> the correct responsible backend. >=20 > OK, thanks. >=20 > Regarding the user option, though, wouldn't it be almost as good if you= > could call vc-follow-link interactively? Not sure if vc-follow-link > works for directories, but a new command could. Regarding the performance and user options, this might be the best way (or consider adding a function that wraps the two calls). If this is the way to go, can you add a little explanation in the doc string? People may not be aware of it. Thanks. --JnIXT4dc8FcRmmSmvOpkN2hEAFBphH9b3-- --47NG60tktUOCBwS1FKg4n2KNnnLo9fFuL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYCPNUAAoJECZsfTOCL4R4DvQP/3DCBHOyUeqGA1H8Qpbd9abD kLUxelqjfpaH7r9yvLo/YzU2yM468XO398UM8ce7WAiXtLlxlY1A304cOCawAfPv qLC6fi1pU33vZ1T2WLUD2A7ws9fd2MWDFv18ohjwDeb5zXPT5ezN7hV4CvYjaS2Z EcFdq76WzlfKW0+c4ASyvH7lSxnQLWhR1S5pLkNfC+6OIgTHcLejkJKDoYI6Ji+I D0aN+VQ1HqVtCMty2bAFp/qyi2wZ2iFNo5jL7U169o9uXMZmyGYqXcE98Vaip+5z b/Rnk1950GVqnqBwp1xXHLlwnzFJBqBs10pS62zOgnsyEjyNldqeUsebdAudE12H z/mfgDD2aPUdH2scQySZmnBUu33NmdURGpnLY5Vj9zHR4ZMp8VQEANYw5318lTCl 7Eln2/iofuc+N5G8bZ7ydShmGX8/JKdNKgIEkX6fY6joOXmLh+T6n1rssMvYJNjo cAJQh/b5s964ScK7rQIducdRxTOYjIqpv9tmxT9TzvO5jm9zoU3NRP+snXIdvxPD E2ceb7Miz1heu9+w4QCbv7OQiYuqtTmamjQWV3m43o3RX7n97KwRxkXzZnISCzb8 WIhia9yDftPRIJeh1BiUtHI7NZMn32ESFxVsXD1mLs21HwNWRHttd10rtVQw1odf mx1hg/un8EHwy6xeMtdf =xaRN -----END PGP SIGNATURE----- --47NG60tktUOCBwS1FKg4n2KNnnLo9fFuL-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 18:34:33 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 22:34:33 +0000 Received: from localhost ([127.0.0.1]:42558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxLuz-0005YD-7J for submit@debbugs.gnu.org; Thu, 20 Oct 2016 18:34:33 -0400 Received: from mail-lf0-f53.google.com ([209.85.215.53]:34879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxLuy-0005Xy-4x for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 18:34:32 -0400 Received: by mail-lf0-f53.google.com with SMTP id l131so102683452lfl.2 for <23436@debbugs.gnu.org>; Thu, 20 Oct 2016 15:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2fs2ceEHxZwuV0L8iZeiiZcsMjoiW7ZshgFHYC+B/XA=; b=O/dnrzPiLoxz6HLTLzvCXy7llP6jsBEFwvuVfUSDFl8SvbFTmbPfJCURSxVfRkklUK X3KyZ2R8AFpyDi3sZoRagi3WWW7CR4vXSOX9qH6vTZOIdjSuZeEx6k4UTNB/VcqcZOqb LCmuxBbjQqW23zs1pUMgdh2+6fSI/lnt+M4wurCR3hAhqeUuimVVrj5ly51ilb1Lqm/X pbuuSNYWC6CDRVbPXibYTLkYz0+BECNInbSc848mSuH44BwoCbxP+zV4JEdolEfA1Z+f F05EAQjDqxstirgpAlCTO+nyhw0IJcpSQoVtCKcuy/6xNr4C8uJ309G5lpBd8N1TUZ/T jAfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2fs2ceEHxZwuV0L8iZeiiZcsMjoiW7ZshgFHYC+B/XA=; b=koxnWJLzrNFDGm43gbAw4pTgXW1g8btjSAY19rkAK28oLKh1DXHohW1ALTZ/SoyAMh cetp5fbSmmVuJH4KfL5gLKvISi1uZUn4ziUVfz+WdsJo9Mdf4a83eDQww+trdDYridWI ebG4q3R3wdQh5esgaCkvmDj4tuR90HvepXhH++PqB3+cs7kf70Dxe0H9y2PgqtsyqW6U uDZqceYROm106TKKr0XJaHSYqi621yyHqCB7azSp+4REPGJH4rFyQm/jmtsP/GiliA9i QcR7rCKDFJF9bdP2f2MRL5pTrkKM878/WJI0PhqCSXi229SPsyAdl+n6kEzcrri1W/BR //BA== X-Gm-Message-State: AA6/9RkiRR69Ce0UlUWyK8X7qj2Zi58d09H+5FlaOmrFd+c5KQcdnJCZIhfhKExlL68F2g== X-Received: by 10.28.69.209 with SMTP id l78mr311191wmi.116.1477002866160; Thu, 20 Oct 2016 15:34:26 -0700 (PDT) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id c4sm852867wmh.4.2016.10.20.15.34.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2016 15:34:25 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Hong Xu , 23436@debbugs.gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> From: Dmitry Gutov Message-ID: <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> Date: Fri, 21 Oct 2016 01:34:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 23436 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 20.10.2016 19:39, Hong Xu wrote: > Regarding the performance and user options, this might be the best way > (or consider adding a function that wraps the two calls). If this is the > way to go, can you add a little explanation in the doc string? People > may not be aware of it. Thanks. Sorry, what might be the best way? A new command? What would you like to see clarified in its docstring? From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 19:04:16 2016 Received: (at 23436) by debbugs.gnu.org; 20 Oct 2016 23:04:17 +0000 Received: from localhost ([127.0.0.1]:42577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxMNk-0006FR-Ox for submit@debbugs.gnu.org; Thu, 20 Oct 2016 19:04:16 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxMNi-0006FI-HP for 23436@debbugs.gnu.org; Thu, 20 Oct 2016 19:04:15 -0400 Received: from [10.120.13.215] (guest-wireless-207-151-035-021.usc.edu [207.151.35.21]) by mx.zohomail.com with SMTPS id 147700464751864.51187349376744; Thu, 20 Oct 2016 16:04:07 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Dmitry Gutov , 23436@debbugs.gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> From: Hong Xu Message-ID: Date: Thu, 20 Oct 2016 16:04:02 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="w8JJBUgxTwP41aub4ht7uC0sBvnpG1SbC" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 23436 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --w8JJBUgxTwP41aub4ht7uC0sBvnpG1SbC Content-Type: multipart/mixed; boundary="RJEBb5U62QF7JRGrIikmS3QvfnMdR7t37"; protected-headers="v1" From: Hong Xu To: Dmitry Gutov , 23436@debbugs.gnu.org Message-ID: Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> In-Reply-To: <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> --RJEBb5U62QF7JRGrIikmS3QvfnMdR7t37 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/20/2016 03:34 PM, Dmitry Gutov wrote: > On 20.10.2016 19:39, Hong Xu wrote: >=20 >> Regarding the performance and user options, this might be the best way= >> (or consider adding a function that wraps the two calls). If this is t= he >> way to go, can you add a little explanation in the doc string? People >> may not be aware of it. Thanks. >=20 > Sorry, what might be the best way? A new command? What would you like t= o > see clarified in its docstring? Sorry for the confusion. Either keeping what it was or adding a new command [which essentially calls (vc-responsible-backend (vc-follow-link file)) ] would be the best option regarding performance. e need to clarify that symlinks are not followed in vc-responsible-backend, and If the first option is adopted, mention that vc-follow-link should be used if link following is desired. --RJEBb5U62QF7JRGrIikmS3QvfnMdR7t37-- --w8JJBUgxTwP41aub4ht7uC0sBvnpG1SbC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYCU1mAAoJECZsfTOCL4R4ZuAP/2MTg/9j4a3oEbuU8bxr5fCT fMmycneWbZ6C2VzsOIgpW6+SkPuls/NwhDmpFhkKJ88ebglRl5A2WT1AQbFcpSed qRmd3Bghyly4DmmwHfu3wIM0YEa3zWtfcFKMmQHD+YLa7Z1y6oIkvOv8REapsflN 5dyqrXm6yVUzFLHX6Tj51mYlR+b3VCm/g8ntk+rfpON9AIIfNMMM3X47Bq4S4q/p RyQEcVETlEO6aJx+gTZypMBm6mUddmwkWqEulXhJeqQ9p8v2PquOaEbreQUewCf4 Narfn+Z34NoXlrWJpEgtprg3LyJiDJxY7JLiEgX10fm8iaDOIU1h8HNTQ2E/bulS baCNEHClVlpJuqBatI3/HlH8z1B+kJvCJlhSG+ypF2+CBzr6zyhyMXRoF/wJsZLp JtQBaMKXJ29aSw+m/FZC9FbhRqvrxsSIMWdnO5DH7xqN7yZCtlwWn1hANu+YP7NM 6VmxOjNaXeC/Q7JQg0hXORpyVUUzAOVOjUsCAmTnhyJzetOLC9FDxHtGPE/Zkq5r 6+CcJ4yMS/Mldzq4eRqjcFJB+5h3DPzUEHtFDsx43YM3OpUSBBvHNAXv/uNG8sa5 XI7FOcYihHMxZEi3xvF4D1/b+xPkfbe3NgvWdSERfPiNJ/ivPa39r/oNKn2vP0GY n9U7e78u0hNoCv/sO8U7 =XXxb -----END PGP SIGNATURE----- --w8JJBUgxTwP41aub4ht7uC0sBvnpG1SbC-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 24 19:41:40 2016 Received: (at 23436) by debbugs.gnu.org; 24 Oct 2016 23:41:40 +0000 Received: from localhost ([127.0.0.1]:55555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byos8-00052Q-AE for submit@debbugs.gnu.org; Mon, 24 Oct 2016 19:41:40 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:34884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1byos7-00052D-2i for 23436@debbugs.gnu.org; Mon, 24 Oct 2016 19:41:39 -0400 Received: by mail-wm0-f46.google.com with SMTP id c78so131244781wme.0 for <23436@debbugs.gnu.org>; Mon, 24 Oct 2016 16:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=n7IdjK1t7RLZlnEKgjVsQjVUiCoz8qvqwGcrfG+sd4U=; b=oNLp6B/rhREXjAAlMlRLZEgOv1o01D5RMi04d9My/AZvkNuxGeeU7pdvPh53MPNhCy BYlzz3EIPvHdNzZqe94nlZEM3IDP4+GuyEjQP2Zz5C+x5Ohs/ZEqTdgOBmV99r+iMwzy Y/ootHdu2OvKmoKqR9/HyiqSwyNHXUTjJHfrPld58Z+8PJad1OK8/ZNOVl4mdraIKTV0 RQleiBG/jgCexswrE/Py6StEZ39cYqhYez7FwWBhdTL4j9xkxDGfhdrh2U8YC/JIO9XE U2qdR23/iaNabJ1UbYktJTq6KUdsMd1xuTZ9+WgePYbKc91u3RI2W7kbUG5fQQozW+sQ zCtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=n7IdjK1t7RLZlnEKgjVsQjVUiCoz8qvqwGcrfG+sd4U=; b=kT/AW6rZK+tb5DpjxHy0hm3J8J5Sla5x9ZvY8WaoaUQGCxXHXPKDGAVm4OzvmmxHH0 DyXwxtOlyHj63MDMUV2DkdzEXUKktv7xE1DMAHYdNE+8OwpvHKAvOQT4QkQJt8aDsmkn Lki5OzGLZExglXERedXemzYm5qKhh1wuDXU3+fEbdf3aOdEwmwVegUeodtDJu9ac438a J+w/ThOOYtLO80WoaZLT1majCmjaYxLsH/hUx/Zn1mk6+OA3nsejQaZp8EP+mqiNZxMQ KA7XBzeu3Rm8e8jDQWfLsBb7kvvgUW0h7hEbVnzWbhiPmjTpmW8HaGG6lGbyQ4BQzx/e /haw== X-Gm-Message-State: ABUngvfEvneAacooyXGqrQBG5cKkpsYRFZBiswVU+IqqV/09EORK1ehs2tyHra23VzxC1w== X-Received: by 10.194.148.7 with SMTP id to7mr13990364wjb.31.1477352493255; Mon, 24 Oct 2016 16:41:33 -0700 (PDT) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id k74sm357124wmd.18.2016.10.24.16.41.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Oct 2016 16:41:32 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Hong Xu , 23436@debbugs.gnu.org References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> From: Dmitry Gutov Message-ID: <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> Date: Tue, 25 Oct 2016 02:41:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 23436 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 21.10.2016 02:04, Hong Xu wrote: > Sorry for the confusion. Either keeping what it was or adding a new > command [which essentially calls (vc-responsible-backend (vc-follow-link > file)) ] would be the best option regarding performance. Shouldn't the command call find-alternate-file instead? Then you can continue working with buffer-file-name and default-directory inside the symlink target directory. And if you visit any nearby files there, you won't have to call the vc-follow-link for each of them again? What are the downsides to this approach? > e need to > clarify that symlinks are not followed in vc-responsible-backend, and If > the first option is adopted, mention that vc-follow-link should be used > if link following is desired. OK, mention where? From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 25 15:06:03 2016 Received: (at 23436) by debbugs.gnu.org; 25 Oct 2016 19:06:03 +0000 Received: from localhost ([127.0.0.1]:56712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz72w-00078g-Uh for submit@debbugs.gnu.org; Tue, 25 Oct 2016 15:06:03 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bz72v-00078E-C2 for 23436@debbugs.gnu.org; Tue, 25 Oct 2016 15:06:01 -0400 Received: from localhost (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1477422353772339.5827330561558; Tue, 25 Oct 2016 12:05:53 -0700 (PDT) References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> User-agent: mu4e 0.9.17; emacs 25.1.50.5 From: Hong Xu To: Dmitry Gutov Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. In-reply-to: <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> Date: Tue, 25 Oct 2016 12:05:49 -0700 Message-ID: <87zilss0z6.fsf@topbug.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, Oct 24 2016, Dmitry Gutov wrote: > On 21.10.2016 02:04, Hong Xu wrote: > >> Sorry for the confusion. Either keeping what it was or adding a new >> command [which essentially calls (vc-responsible-backend (vc-follow-link >> file)) ] would be the best option regarding performance. > > Shouldn't the command call find-alternate-file instead? Then you can=20 > continue working with buffer-file-name and default-directory inside the=20 > symlink target directory. And if you visit any nearby files there, you=20 > won't have to call the vc-follow-link for each of them again? > > What are the downsides to this approach? I don't understand why find-alternate-file should be used. The reason we used (vc-follow-link) is to pass the correct file path to vc-responsible-backend. I don't see how find-alternate-file can be used her= e. > >> e need to >> clarify that symlinks are not followed in vc-responsible-backend, and If >> the first option is adopted, mention that vc-follow-link should be used >> if link following is desired. > > OK, mention where? In the doc string. Maybe we should also mention `vc-responsible-backend' in the info doc "Supported Version Control Systems" in general. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJYD60NAAoJECZsfTOCL4R42lQP/RzC0EjMgRZm4mK+5AxlOo6z gs0DhIUkfI5JE49+Z2gJX5zX18GrrDkOGl/J35VvyaFv8XXsxBytfOAPdf1AU+Pp jzLsmpel6HaxFG65dBJRJzN4id2hYmpN9hHIFhThbC8zt9ciqCPxyW7CK+pDtPKK 1HINJYfE2C7phDrqyqVv3657yEJ7CTBbxaRUIxaX0OlPEcJ7LHNXlFNl4VcoYVs+ jDkxzZlilmc3wbm3zyE/RuIntaV44K3BOXupRw1T0t0gHAL4bwWGt/tTf+V+lnUG jatF5bhuGHtR7XLUDGD1gwCHV1RtEtB8cliMgGCKQhg97GTDtE482TlDm8z7sogv wg7Ys1YV6tWmx82gMJguIrQSuUtz5L1IP81hBcoZm7mMbN8D5iuPYtXbcL7y1WQH EwSUfwjGlbiAdXhG3ohQMlj9VweSVxpUGtjjh/ceqpBrZOoeXkapNObybrtriI/y +8z0vdt38+nULTrD3R/if4epZ85VhLQrRxQtLDqsVoEEyVih/5ZPjIcE7me5HGsj 9Z+UpvWSdmlKidW5i33aJOBEKq4pGmrXwX2nt3gLnGoofekvmRvcs6+akKVnhfRK ewnaPoPdLmB646DOjPnx1Fv5evJC5IaOBXH+yU79TiK+0JX6Olsb275Q2nQ2IWiL pXaKt9Wb81986lOUNsNd =XLzU -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 25 19:12:31 2016 Received: (at 23436) by debbugs.gnu.org; 25 Oct 2016 23:12:31 +0000 Received: from localhost ([127.0.0.1]:56840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzAtS-0004SZ-Qi for submit@debbugs.gnu.org; Tue, 25 Oct 2016 19:12:30 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:38895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bzAtR-0004SM-A3 for 23436@debbugs.gnu.org; Tue, 25 Oct 2016 19:12:29 -0400 Received: by mail-wm0-f44.google.com with SMTP id d128so54751085wmf.1 for <23436@debbugs.gnu.org>; Tue, 25 Oct 2016 16:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=r0nBgM+5ZPU5kj6IYHHkkTgHWfuCQrCJ1FZrY6R9Maw=; b=0pwVQlBea9nBJdq+9TL/yTdcJdkBGAuzmAUjpMyimKi67bsOZ+kZZYM6ZlOcQw2doy 0EuVxOR6b1ybUS3YGUVb/mcRPQs4jN0BGmGFzKRMCq90euwTp9uhceTsTfgVsaYshEO8 4KoI8tFxukkZ0215OeOZNboi/XnifMyBAPchovZVDefyl1akoojR4OT/1Wk1pA6iHtGP ta3RpK35XLQN5aXW9fwehm0s5YCVrcuSfPp3DKMl0qQxyE3k+UN+jZ5jODJK4idWfDPv 4yIsfjmuiXO+WGJ2e77scxEO9PULW/XZgowasDtY+UbpvIJvfsY40r119krk0XLgrRWM IK/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=r0nBgM+5ZPU5kj6IYHHkkTgHWfuCQrCJ1FZrY6R9Maw=; b=I+VuskU6ykoCxfyzz7YCDByHWBeTF7HDxyztirIUbPGOsjP/UjOxwVvmwCBC7tGyxg AHzM5nFqTJfrGGmBv6Jeu6j6eR4vk9rgarGIUZXpvwmZ6p30maQXCHI3dsD0qi3nIimz 3djcnMVDOLH025Tj64Uycl35Pby0mUR3y1cBnDrC+q8xQDwev+0WCDpfqwBKuZ8X/RMQ awEBYEffgb0lAl/SRyffqqig8jw4zlbrogoWvL/8+j5tcDzAE24BMBowz7mDODKd7tF1 LnOO3hnYGNsouIFHuVBEW3+3mBu9Udi0vrP3IJIzkXUSPTfanEh3J7JvOWb8DsXGx+7O rw3Q== X-Gm-Message-State: ABUngvfXWUNyA/K6c2mDz9EN6d3Y/0Hs5ksAn5ZXePyJq7OAFVHvWcX9Y47CQFqIIY2wbA== X-Received: by 10.194.102.100 with SMTP id fn4mr4222915wjb.199.1477437143392; Tue, 25 Oct 2016 16:12:23 -0700 (PDT) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id x127sm6087182wmd.21.2016.10.25.16.12.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Oct 2016 16:12:22 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Hong Xu References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> From: Dmitry Gutov Message-ID: Date: Wed, 26 Oct 2016 02:12:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <87zilss0z6.fsf@topbug.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) On 25.10.2016 22:05, Hong Xu wrote: > I don't understand why find-alternate-file should be used. For no reason other than the resulting command could be useful in more situations than just this one. > The reason we > used (vc-follow-link) is to pass the correct file path to > vc-responsible-backend. I don't see how find-alternate-file can be used here. It would open the file (or directory) than is the true name of the currently visited file (or directory), and kill the previous buffer. vc-responsible-backend would be called with the true name automatically. This is close to what vc-follow-link does already. But if that's definitely not what you want, how about a command like this? (defun vc-refresh-as-link-target () (interactive) (let ((buffer-file-name (file-truename buffer-file-name))) (vc-refresh-state))) By the way, please remind us why vc-follow-symlinks (the variable) with the default value `ask' is not sufficient for you? >> OK, mention where? > > In the doc string. The docstring of what? Please be more precise, the less I have to think about or make choices regarding documentation, the happier I am. > Maybe we should also mention `vc-responsible-backend' > in the info doc "Supported Version Control Systems" in general. Care to send the proposed addition in the form of a patch? From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 29 20:42:18 2016 Received: (at 23436) by debbugs.gnu.org; 30 Oct 2016 00:42:18 +0000 Received: from localhost ([127.0.0.1]:36892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0eCY-0000VL-DQ for submit@debbugs.gnu.org; Sat, 29 Oct 2016 20:42:18 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0eCW-0000VC-Jk for 23436@debbugs.gnu.org; Sat, 29 Oct 2016 20:42:17 -0400 Received: from localhost (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1477788129215315.99542122911805; Sat, 29 Oct 2016 17:42:09 -0700 (PDT) References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> User-agent: mu4e 0.9.17; emacs 25.1.50.8 From: Hong Xu To: Dmitry Gutov Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. In-reply-to: Date: Sat, 29 Oct 2016 17:42:01 -0700 Message-ID: <87funefz1i.fsf@topbug.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2016-10-25 Tue 16:12 GMT-0700, Dmitry Gutov wrote: > On 25.10.2016 22:05, Hong Xu wrote: > >> I don't understand why find-alternate-file should be used. > > For no reason other than the resulting command could be useful in more=20 > situations than just this one. > >> The reason we >> used (vc-follow-link) is to pass the correct file path to >> vc-responsible-backend. I don't see how find-alternate-file can be used = here. > > It would open the file (or directory) than is the true name of the=20 > currently visited file (or directory), and kill the previous buffer. > > vc-responsible-backend would be called with the true name automatically.= =20 > This is close to what vc-follow-link does already. > > But if that's definitely not what you want, how about a command like this? > > (defun vc-refresh-as-link-target () > (interactive) > (let ((buffer-file-name (file-truename buffer-file-name))) > (vc-refresh-state))) > > By the way, please remind us why vc-follow-symlinks (the variable) with=20 > the default value `ask' is not sufficient for you? OK, I think I have screwed it up. vc-responsible-backend looks like a funct= ion mainly provided for elisp programming purpose, which people can make use in their own customization. Thus, none of these functions should be used. Instead, file-truename or file-chase-links should be used. That is, (vc-responsible-backend (file-chase-links file)) > >>> OK, mention where? >> >> In the doc string. > > The docstring of what? Please be more precise, the less I have to think=20 > about or make choices regarding documentation, the happier I am. > >> Maybe we should also mention `vc-responsible-backend' >> in the info doc "Supported Version Control Systems" in general. > > Care to send the proposed addition in the form of a patch? The attachment is a draft of my proposed doc change. Feel free to adjust the contents and the language. Hong --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=vc-doc.patch Content-Transfer-Encoding: quoted-printable diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi index aca29910b7d3..8f31fa168c23 100644 =2D-- a/doc/emacs/maintaining.texi +++ b/doc/emacs/maintaining.texi @@ -223,7 +223,7 @@ Version Control Systems @cindex SRC @cindex src @item =2DSRC (src) is RCS, reloaded - a specialized version-control system +SRC (src) is RCS, reloaded---a specialized version-control system designed for single-file projects worked on by only one person. It allows multiple files with independent version-control histories to exist in one directory, and is thus particularly well suited for @@ -233,6 +233,22 @@ Version Control Systems supports almost all SRC operations. @end itemize =20 +@defun vc-responsible-backend file +This function can be used to determine the responsible VC backend of +the given file path @var{file}. For example, if @code{emacs.c} is a +file tracked by git, @code{(vc-responsible-backend "emacs.c")} returns +@code{"Git"}. Note that if @var{file} is a symbolic link, +@code{vc-responsible-backend} will not resolve it---it always reports +the backend of the symbolic link file itself. Instead, to get the +backend VC of the file to which @var{file} refers, wrap @var{file} +with a symbolic link resolving function such as +@code{file-chase-links}: + +@smallexample +(vc-responsible-backend (file-chase-links "emacs.c")) +@end smallexample +@end defun + @node VCS Concepts @subsubsection Concepts of Version Control =20 diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index ac020d095397..a1e4388f6e5c 100644 =2D-- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -959,7 +959,11 @@ vc-responsible-backend If FILE is already registered, return the backend of FILE. If FILE is not registered, then the first backend in `vc-handled-backends' that declares itself =2Dresponsible for FILE is returned." +responsible for FILE is returned. + +Note that if FILE is a symbolic link, it will not be resolved -- +it will report the responsible backend system for the symbolic +link itself." (or (and (not (file-directory-p file)) (vc-backend file)) (catch 'found ;; First try: find a responsible backend. If this is for registration, --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJYFUHZAAoJECZsfTOCL4R4NVcP/jrU3hpEPXdsdhN8mZQklcqK Fc/7Dsn6sDxZkthYpUiRG/5vzvwQ2Fk+Mwg7NUdVAjaaCJ9B7R5Vq8xOiMPGTV7+ wkvrYFZ+sQSkCCBc99yPkGxfhgpUiQjswvaPRkm5WwwdbCKQCowcvCsZE/fQGFhR CS5/UboUzXiGBiCyRNjPVkvsYuoT+8NZcRbO8lbQoUQV8EQ9rjwYdEJ3mv+EMmOm VuqJNtvfKBLaqt931aUraerflXni+Qxx2ax02qzHgLGVEDy+ZGGZd9LZScuxsAq7 lxpume26fD7jLhyUoqa2grNDPj9LUQ4M4F+4YLTLfj+2pTM7Rk3LhZiQ9KlKkC+d RHbM1VrDS6HnH9yvHpjPr1UA5OYxORv4rLboxCzDwFsk4waqT1ELhgSXWcYPQqNc A7pCDZHvsxktg5baSfZ2QC0OTgzwN+VsDpz94zSpsqwGzHgsNeAlHruq4tZIar1b 6apcSZVSKnyGKA+IQrDYrndoJFgS/x7BEnqDo0IXf/PL01JSRUzwmYHd1at6MVkL hFMsOFM3RGd23kcJ3tfNia2SCMSp6k3PxORZho1rxMA8Dj9bXfEbvsuBd6qfLlnv LE2Q4a8kuH6vPiacBNQUhF55S8UhpCT1aOXBxedWcJq7hpaJisMuyRByF/QC1BJ5 X0ap9Xv/lRgN2R+/2tAY =QCzP -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 30 12:21:21 2016 Received: (at 23436) by debbugs.gnu.org; 30 Oct 2016 16:21:21 +0000 Received: from localhost ([127.0.0.1]:37318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0srI-00023B-PS for submit@debbugs.gnu.org; Sun, 30 Oct 2016 12:21:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0srH-00022x-IE for 23436@debbugs.gnu.org; Sun, 30 Oct 2016 12:21:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0sr7-0007al-NA for 23436@debbugs.gnu.org; Sun, 30 Oct 2016 12:21:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0sr7-0007ag-JX; Sun, 30 Oct 2016 12:21:09 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2469 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c0sr6-0004NG-KU; Sun, 30 Oct 2016 12:21:09 -0400 Date: Sun, 30 Oct 2016 18:21:19 +0200 Message-Id: <83twbtq03k.fsf@gnu.org> From: Eli Zaretskii To: Hong Xu In-reply-to: <87funefz1i.fsf@topbug.net> (message from Hong Xu on Sat, 29 Oct 2016 17:42:01 -0700) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> <87funefz1i.fsf@topbug.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.5 (------) > From: Hong Xu > Date: Sat, 29 Oct 2016 17:42:01 -0700 > Cc: 23436@debbugs.gnu.org > > The attachment is a draft of my proposed doc change. Feel free to adjust > the contents and the language. Thanks, see a few comments below. > diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi > index aca29910b7d3..8f31fa168c23 100644 > --- a/doc/emacs/maintaining.texi > +++ b/doc/emacs/maintaining.texi This should go to the ELisp manual, not the Emacs User manual. > +@defun vc-responsible-backend file > +This function can be used to determine the responsible VC backend of > +the given file path @var{file}. GNU coding standards frown on using "path" for anything that isn't a PATH-style list of directories. We use "file name" instead, but in this case you don't need even that: just say "the given @var{file}". > For example, if @code{emacs.c} is a emacs.c is a file, so it should have the @file markup, not @code. > +file tracked by git, @code{(vc-responsible-backend "emacs.c")} returns > +@code{"Git"}. ^^^^^^^^^^^^ You want @samp{Git} here, without the quotes. The quotes might mislead someone into thinking the result is a string. Last, but not least: documentation changes need ChangeLog-style commit log messages as well (just use "C-x 4 a" to get a preformatted skeleton from which you could start). From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 30 18:51:15 2016 Received: (at 23436) by debbugs.gnu.org; 30 Oct 2016 22:51:16 +0000 Received: from localhost ([127.0.0.1]:37487 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0ywd-00052P-Mm for submit@debbugs.gnu.org; Sun, 30 Oct 2016 18:51:15 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c0ywb-00052E-LX for 23436@debbugs.gnu.org; Sun, 30 Oct 2016 18:51:14 -0400 Received: from localhost (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1477867861356156.11433812219457; Sun, 30 Oct 2016 15:51:01 -0700 (PDT) References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> <87funefz1i.fsf@topbug.net> <83twbtq03k.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 25.1.50.8 From: Hong Xu To: Eli Zaretskii Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. In-reply-to: <83twbtq03k.fsf@gnu.org> Date: Sun, 30 Oct 2016 15:50:56 -0700 Message-ID: <87vaw9bgdr.fsf@topbug.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain On 2016-10-30 Sun 09:21 GMT-0700, Eli Zaretskii wrote: >> diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi >> index aca29910b7d3..8f31fa168c23 100644 >> --- a/doc/emacs/maintaining.texi >> +++ b/doc/emacs/maintaining.texi > > This should go to the ELisp manual, not the Emacs User manual. > I don't know how to resolve this issue: there seems no proper place to insert the defun section. I'm gonna leave my updated version of the defun section here in this email, and updated all other parts in the new version of the patch (as attached). You may decide where to put this part. --------------------- vc-responsible-backend defun ------------------------- @defun vc-responsible-backend file This function can be used to determine the responsible VC backend of the given @var{file}. For example, if @file{emacs.c} is a file tracked by git, @code{(vc-responsible-backend "emacs.c")} returns @samp{Git}. Note that if @var{file} is a symbolic link, @code{vc-responsible-backend} will not resolve it---the backend of the symbolic link file itself is reported. Instead, to get the backend VC of the file to which @var{file} refers, wrap @var{file} with a symbolic link resolving function such as @code{file-chase-links}: @smallexample (vc-responsible-backend (file-chase-links "emacs.c")) @end smallexample @end defun --------------------- vc-responsible-backend defun ENDS--------------------- > Last, but not least: documentation changes need ChangeLog-style commit > log messages as well (just use "C-x 4 a" to get a preformatted > skeleton from which you could start). Fixed in the new patch. The new version now also mentions `vc-responsible-backend' in a different way in maintaining.texi. Feel free to review again. Thanks! --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-doc-1.patch Content-Transfer-Encoding: quoted-printable diff --git a/doc/emacs/ChangeLog.1 b/doc/emacs/ChangeLog.1 index 3f746ebd763f..c5d150af8124 100644 =2D-- a/doc/emacs/ChangeLog.1 +++ b/doc/emacs/ChangeLog.1 @@ -1,3 +1,8 @@ +2016-10-30 Hong Xu + + * maintaining.texi (Version Control Systems): Mention + `vc-responsible-backend' when explaining VC back ends. + 2015-03-29 Dani Moncayo =20 * files.texi (Diff Mode): Doc fix. diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi index aca29910b7d3..884d40be5634 100644 =2D-- a/doc/emacs/maintaining.texi +++ b/doc/emacs/maintaining.texi @@ -223,7 +223,7 @@ Version Control Systems @cindex SRC @cindex src @item =2DSRC (src) is RCS, reloaded - a specialized version-control system +SRC (src) is RCS, reloaded---a specialized version-control system designed for single-file projects worked on by only one person. It allows multiple files with independent version-control histories to exist in one directory, and is thus particularly well suited for @@ -233,6 +233,10 @@ Version Control Systems supports almost all SRC operations. @end itemize =20 +@findex vc-responsible-backend +To determine which back end is in charge of a file, the function +@code{vc-responsible-backend} can be used. + @node VCS Concepts @subsubsection Concepts of Version Control =20 diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index ac020d095397..2ddf4e19e1f7 100644 =2D-- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -959,7 +959,11 @@ vc-responsible-backend If FILE is already registered, return the backend of FILE. If FILE is not registered, then the first backend in `vc-handled-backends' that declares itself =2Dresponsible for FILE is returned." +responsible for FILE is returned. + +Note that if FILE is a symbolic link, it will not be resolved -- +the responsible backend system for the symbolic link itself will +be reported." (or (and (not (file-directory-p file)) (vc-backend file)) (catch 'found ;; First try: find a responsible backend. If this is for registration, --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJYFnlQAAoJECZsfTOCL4R4JwAQAJ1C4rNT3XzYc7LII/+nKpBT BRulh7Dctx/E2gDIVeK4J4qW63qFuoES4VqttH8zOVjT1DC7u4lP0lyN2UcRIbWl 7CS5UfjlTTbXmghuC8+n0zwDKW+aMr77eeK4lRKzZa4K7gkJdRySbEUlEcZSZN7C VnWWqEerRhwNPhDFJdIEZf32b7QfFI+4Y9SSGgLiDLY1+HogpKmP9eBF5gYldUdZ YqXzEbczsyoSWIDmbtks77R9nw0m6kAKtgnC9hc3ndqsQ42X9phzMlNYdfG0RLLL XPEwhMUeyxOJ25TZTNB2ce09VL4avv7pH6j9FQIKMcNuQ7vjM7/Fsz/yZn10UvIE Ykeug8jdR96frjpw2E/M+zv4mlcHl4esN4dYwZ4DY/0WFUBrQVMV84ValgeMmOM2 m+o5U2I5DhgR7L6R9c4AikjItIzUvW30s9GwsHoe8ds04+AGwWOhTC/B4GtWYSMg ajTyNv8GZaSSsK4+TUHukESOpVs73wg7pU+tpkWkHQEpTn9FhFe2/yc1INQaC2NG tQEiWL/CWftIdc99G54bnnFCQHsihoxZwzzdIPmMSHsZDtTFSBgvQB7/xsR2CysJ +BEEj51i/5s0K+eUyh/nwKqtcfwZLq/Jw0mkopwo7xmrTB5WbEcjfQQp6VYe7s/z 1/rfkEm614Iyy6HFLuJM =Djss -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 07:34:48 2016 Received: (at 23436) by debbugs.gnu.org; 31 Oct 2016 11:34:48 +0000 Received: from localhost ([127.0.0.1]:37705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1ArY-00023M-N0 for submit@debbugs.gnu.org; Mon, 31 Oct 2016 07:34:48 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1ArX-00023A-Cs for 23436@debbugs.gnu.org; Mon, 31 Oct 2016 07:34:47 -0400 Received: by mail-wm0-f50.google.com with SMTP id t79so44007922wmt.0 for <23436@debbugs.gnu.org>; Mon, 31 Oct 2016 04:34:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Jvj5W+6el6wu6qgWftTDuQgWEHzFClNji6DKpV8ea5k=; b=Cicm3IuONrKjrMwZre7le/aLDMzo63HnDsrp1qQbnOhirm0etHPmENYwgaAlgw8xG7 KioQ0szf6csciDz60sHUyv65IW69TETvNTSK4e01mS1ZoJvNHN4qV+9TYbNKBpW4n+qq tJMw9jIfBpO/wYwz6xSSkPhlgMmX9GC72h2Kv4VWtjpI03GvIKyBMn7aGua+M8K3vZGg WP8o8obNif+53ILwC/z3++i5zH64wVHMnR4kPb6cX4A9Gz0HKkr164I/ue65ygn3Iltq DOKKrPWALQhBFogkzUOp0QvOS12vCWH6znF52mbXz0mDbyYrkP9fpCrlV5VAnRqiDXdu txoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Jvj5W+6el6wu6qgWftTDuQgWEHzFClNji6DKpV8ea5k=; b=e38vrrTi62Hk5SQO3mSIlU5MWYwWvxtelIsTkJL9wmSCW04Cf+brmOa2EeN56KvSQG WrYe8wNOxDFZfbaM1GwpLJOx/0U4UlqnYwkIc7ZgaF+vNBA+PukFkAaX+65bE+6GEYRI vcezvnYgnylWMyWcJS/yTATMyQQeM+szv4n4HGkyozmEgA7neWdyN261in+0hpu9GrmA jOp7Sf70IBZvR9mrZbQfUrr3iG9W5TVXDir8o3czsBBjxMBfcAcf+LIZVfO2VGxcNMwx JDvRN9Qv+wVKUv7SGNoTUPG3yogg1FqSYt8Wx6ZKoqTPdvCTqaJIok6h3SIAe0C7ZnqT 1Ulw== X-Gm-Message-State: ABUngveNRa4io+g/UUv8M7288NjuBdOu8LqExZfx4trL9Ggykw1C5piVoT7VK8VowrR3oQ== X-Received: by 10.28.129.81 with SMTP id c78mr1327495wmd.94.1477913681316; Mon, 31 Oct 2016 04:34:41 -0700 (PDT) Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id w203sm24152879wmw.16.2016.10.31.04.34.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Oct 2016 04:34:40 -0700 (PDT) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. To: Hong Xu References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> <87funefz1i.fsf@topbug.net> From: Dmitry Gutov Message-ID: <75b4d7dc-e7b8-b1da-7b30-772aa0fdc180@yandex.ru> Date: Mon, 31 Oct 2016 13:34:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <87funefz1i.fsf@topbug.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 30.10.2016 03:42, Hong Xu wrote: > OK, I think I have screwed it up. vc-responsible-backend looks like a function > mainly provided for elisp programming purpose, which people can make use > in their own customization. Thus, none of these functions should be > used. Instead, file-truename or file-chase-links should be used. Please clarify: will you be satisfied with a documentation-only change? From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 11:43:44 2016 Received: (at 23436) by debbugs.gnu.org; 31 Oct 2016 15:43:45 +0000 Received: from localhost ([127.0.0.1]:38212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1EkS-0007tN-NU for submit@debbugs.gnu.org; Mon, 31 Oct 2016 11:43:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1EkR-0007tB-L1 for 23436@debbugs.gnu.org; Mon, 31 Oct 2016 11:43:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1EkI-0006P3-9f for 23436@debbugs.gnu.org; Mon, 31 Oct 2016 11:43:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1EkI-0006Oy-68; Mon, 31 Oct 2016 11:43:34 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3121 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c1EkH-0000Ox-9o; Mon, 31 Oct 2016 11:43:33 -0400 Date: Mon, 31 Oct 2016 17:43:47 +0200 Message-Id: <83h97splqk.fsf@gnu.org> From: Eli Zaretskii To: Hong Xu In-reply-to: <87vaw9bgdr.fsf@topbug.net> (message from Hong Xu on Sun, 30 Oct 2016 15:50:56 -0700) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> <87funefz1i.fsf@topbug.net> <83twbtq03k.fsf@gnu.org> <87vaw9bgdr.fsf@topbug.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.7 (-------) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.7 (-------) > From: Hong Xu > Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org > Date: Sun, 30 Oct 2016 15:50:56 -0700 > > > This should go to the ELisp manual, not the Emacs User manual. > > > > I don't know how to resolve this issue: there seems no proper place to > insert the defun section. The node "Truenames" sounds like a good place. This version of the patch is fine with me, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 15:24:36 2016 Received: (at 23436) by debbugs.gnu.org; 31 Oct 2016 19:24:36 +0000 Received: from localhost ([127.0.0.1]:38314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1ICC-0006Gk-7J for submit@debbugs.gnu.org; Mon, 31 Oct 2016 15:24:36 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1ICA-0006Gb-Er for 23436@debbugs.gnu.org; Mon, 31 Oct 2016 15:24:34 -0400 Received: from localhost (guest-wireless-207-151-035-021.usc.edu [207.151.35.21]) by mx.zohomail.com with SMTPS id 1477941864154383.61563905356536; Mon, 31 Oct 2016 12:24:24 -0700 (PDT) References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> <87funefz1i.fsf@topbug.net> <75b4d7dc-e7b8-b1da-7b30-772aa0fdc180@yandex.ru> User-agent: mu4e 0.9.17; emacs 25.1.50.8 From: Hong Xu To: Dmitry Gutov Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. Message-ID: <87ins8qqbc.fsf@topbug.net> In-reply-to: <75b4d7dc-e7b8-b1da-7b30-772aa0fdc180@yandex.ru> Date: Mon, 31 Oct 2016 12:24:23 -0700 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.6 (/) --=-=-= Content-Type: text/plain On 2016-10-31 Mon 04:34 GMT-0700, Dmitry Gutov wrote: > On 30.10.2016 03:42, Hong Xu wrote: > >> OK, I think I have screwed it up. vc-responsible-backend looks like a function >> mainly provided for elisp programming purpose, which people can make use >> in their own customization. Thus, none of these functions should be >> used. Instead, file-truename or file-chase-links should be used. > > Please clarify: will you be satisfied with a documentation-only change? Yes, IMO it should be good enough. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJYF5pnAAoJECZsfTOCL4R4kK0P/0dxQACAS+l0DO6yFlvZGY75 TdinuMTCz8R7ZaL6+CjT75thgp8SDZ6pQwvPDqfvqMo7iRh9+Wu45wQV4URezzmU Uwc2LwD7cEChEH0tbqnTTHc6l0ZblF3Kl8++4FOmVbpvlMcYvGk3jtvKr+ABnByx RA5M9xzuexNjJmsri7bhin6YCM0POZdXw9KkTJ36X/XXYUWIzcGmRX+wkQMD3uy9 /xXY3hywmkT9vXe56NEcDONBiwx+xchZm+Zcp6z5fi/6bIG0NoYaZhd1K65wZr9E qPlmbz+uKAbwRoUc31l46cI5sfFhkK5tsw+QbIxPOi/OW+s7RKS3q8v6wzYJo0QM H2PVq4/gaE8rebLw+l+YoHdN3LQw23ny629BUcLWn6OMqGyjkNzElq8R+y/nR76k PBvDObt98JuLJ4ks9IN2KnjdyoE1MLr+zYrwM+sJtmM3exVpdEdX+PIThhEcrG/U Ov9/Eq4qOcpIiaXlZbivkeul6ZhGBZyNfZCfuF5bvF5my8EDg/neAIAB3PJrx/8H j0WhhFggihv/mLNLugnY8Ci3D7YsdzTEm6JpHxHKPCvh/byhJKruEMHBTz5/GI/K 04nHhQiz8dLW+ViYKpNwyRU/Cl8mKkYU7xMk81u9E2pQDhox7k1DI+eDQsDtALSw AH87ZQa7QBYUX2vRFXMQ =O5aQ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 31 15:38:56 2016 Received: (at 23436) by debbugs.gnu.org; 31 Oct 2016 19:38:56 +0000 Received: from localhost ([127.0.0.1]:38334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1IQ3-0006cq-UH for submit@debbugs.gnu.org; Mon, 31 Oct 2016 15:38:56 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21413) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1IQ2-0006cf-Bj for 23436@debbugs.gnu.org; Mon, 31 Oct 2016 15:38:54 -0400 Received: from localhost (guest-wireless-207-151-035-036.usc.edu [207.151.35.36]) by mx.zohomail.com with SMTPS id 1477942725265339.6286850926175; Mon, 31 Oct 2016 12:38:45 -0700 (PDT) References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> <87funefz1i.fsf@topbug.net> <83twbtq03k.fsf@gnu.org> <87vaw9bgdr.fsf@topbug.net> <83h97splqk.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 25.1.50.8 From: Hong Xu To: Eli Zaretskii Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. Message-ID: <87a8dkqpmo.fsf@topbug.net> In-reply-to: <83h97splqk.fsf@gnu.org> Date: Mon, 31 Oct 2016 12:38:42 -0700 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.6 (/) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain On 2016-10-31 Mon 08:43 GMT-0700, Eli Zaretskii wrote: > > The node "Truenames" sounds like a good place. > Added in the new patch now (along with the change of the previous version). --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-doc-2.patch Content-Transfer-Encoding: quoted-printable diff --git a/doc/emacs/ChangeLog.1 b/doc/emacs/ChangeLog.1 index 3f746ebd763f..c5d150af8124 100644 =2D-- a/doc/emacs/ChangeLog.1 +++ b/doc/emacs/ChangeLog.1 @@ -1,3 +1,8 @@ +2016-10-30 Hong Xu + + * maintaining.texi (Version Control Systems): Mention + `vc-responsible-backend' when explaining VC back ends. + 2015-03-29 Dani Moncayo =20 * files.texi (Diff Mode): Doc fix. diff --git a/doc/emacs/maintaining.texi b/doc/emacs/maintaining.texi index aca29910b7d3..884d40be5634 100644 =2D-- a/doc/emacs/maintaining.texi +++ b/doc/emacs/maintaining.texi @@ -223,7 +223,7 @@ Version Control Systems @cindex SRC @cindex src @item =2DSRC (src) is RCS, reloaded - a specialized version-control system +SRC (src) is RCS, reloaded---a specialized version-control system designed for single-file projects worked on by only one person. It allows multiple files with independent version-control histories to exist in one directory, and is thus particularly well suited for @@ -233,6 +233,10 @@ Version Control Systems supports almost all SRC operations. @end itemize =20 +@findex vc-responsible-backend +To determine which back end is in charge of a file, the function +@code{vc-responsible-backend} can be used. + @node VCS Concepts @subsubsection Concepts of Version Control =20 diff --git a/doc/lispref/ChangeLog.1 b/doc/lispref/ChangeLog.1 index 610e7541e7de..2d00ac7e7d32 100644 =2D-- a/doc/lispref/ChangeLog.1 +++ b/doc/lispref/ChangeLog.1 @@ -1,3 +1,8 @@ +2016-10-31 Hong Xu + + * files.texi (Truenames): Add documentation for + `vc-responsible-backend'. + 2015-03-29 Glenn Morris =20 * objects.texi (Equality Predicates): Fix typo in example. diff --git a/doc/lispref/files.texi b/doc/lispref/files.texi index 6b7ee19d5f39..0be8b83831b2 100644 =2D-- a/doc/lispref/files.texi +++ b/doc/lispref/files.texi @@ -1138,6 +1138,21 @@ Truenames name an existing directory, the return value is @code{nil}. @end defun =20 +@defun vc-responsible-backend file +This function determines the responsible VC backend of the given +@var{file}. For example, if @file{emacs.c} is a file tracked by git, +@code{(vc-responsible-backend "emacs.c")} returns @samp{Git}. Note +that if @var{file} is a symbolic link, @code{vc-responsible-backend} +will not resolve it---the backend of the symbolic link file itself is +reported. Instead, to get the backend VC of the file to which +@var{file} refers, wrap @var{file} with a symbolic link resolving +function such as @code{file-chase-links}: + +@smallexample +(vc-responsible-backend (file-chase-links "emacs.c")) +@end smallexample +@end defun + @node File Attributes @subsection File Attributes @cindex file attributes diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index ac020d095397..2ddf4e19e1f7 100644 =2D-- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -959,7 +959,11 @@ vc-responsible-backend If FILE is already registered, return the backend of FILE. If FILE is not registered, then the first backend in `vc-handled-backends' that declares itself =2Dresponsible for FILE is returned." +responsible for FILE is returned. + +Note that if FILE is a symbolic link, it will not be resolved -- +the responsible backend system for the symbolic link itself will +be reported." (or (and (not (file-directory-p file)) (vc-backend file)) (catch 'found ;; First try: find a responsible backend. If this is for registration, --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJYF53CAAoJECZsfTOCL4R4Ow0P/jO9+ZpugtNQ79pX/Oab2xKz COW0ld+Qs4NXmNwZL7DRL9NqXEbbRrB5e0apl/7MkfWkn9ALTg2UyOw5rjeY2QPK s2QYW0ABFS49zMxVL72HILMyxgp7mK8rg23kxWiW/lF/XwsyxKq7bOtI4m6ON0Ux VB7mWWTeC/gv+TRkzfhU1WVDp/vqSFvBnM+E+YZGGjAG4ZM8VHj/7OOncunCrDQF CF1ca2qUpQOWqtqDsq7XummrPDyiwMlMcl6fJERoapFkQVB2g6CrdyKAciYIvvfH Yk4oK2oZTZfe9E+EmE6T+8sG/AXCtKbNkXm0BTgzv3ZwT6NiiKSLIC7qbqWx8IMC q8sXOGEgnPfjJeNxqXE+qVPa3QUC7dL7s59RpE0kpUzB3wGw3PlKqS0Oog9+jH4y DnIVNS+Ficzup+VlV6PsKBOIriB3BV1qr6VsDZYEJljKd55x2pN6BBnndHtr6aD0 ocDtyH1VocfpDxLRJXFEL3SYopEyGCbGlCfqhKL0X8ZYOlSjaHU/0TTdIJzZDhF+ I/Ys1z7C5XdB6Uh2XD8kGIsnuMdz8qzG2SLjmUSMmzmq+okRaamTYs/75VwKxLyu y3aKAUfPuTg0FMmwwjooLZxvOam5tsMOtMsG07BRYtmeDH3M5sRKb2ujEGgcp04E V+SDMVdDXbd5Ul+4ddiE =aAmB -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 14:47:30 2016 Received: (at 23436) by debbugs.gnu.org; 1 Nov 2016 18:47:30 +0000 Received: from localhost ([127.0.0.1]:39326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1e5q-0000KS-AQ for submit@debbugs.gnu.org; Tue, 01 Nov 2016 14:47:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c1e5o-0000KF-JR for 23436@debbugs.gnu.org; Tue, 01 Nov 2016 14:47:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c1e5g-0008Dm-Fs for 23436@debbugs.gnu.org; Tue, 01 Nov 2016 14:47:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c1e5g-0008Dd-Bx; Tue, 01 Nov 2016 14:47:20 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4323 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c1e5d-0007n3-IW; Tue, 01 Nov 2016 14:47:20 -0400 Date: Tue, 01 Nov 2016 20:47:19 +0200 Message-Id: <834m3rniko.fsf@gnu.org> From: Eli Zaretskii To: Hong Xu In-reply-to: <87a8dkqpmo.fsf@topbug.net> (message from Hong Xu on Mon, 31 Oct 2016 12:38:42 -0700) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> <87funefz1i.fsf@topbug.net> <83twbtq03k.fsf@gnu.org> <87vaw9bgdr.fsf@topbug.net> <83h97splqk.fsf@gnu.org> <87a8dkqpmo.fsf@topbug.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.5 (-------) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.5 (-------) > From: Hong Xu > Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org > Date: Mon, 31 Oct 2016 12:38:42 -0700 > > On 2016-10-31 Mon 08:43 GMT-0700, Eli Zaretskii wrote: > > > > The node "Truenames" sounds like a good place. > > Added in the new patch now (along with the change of the previous version). LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 03:46:19 2016 Received: (at 23436) by debbugs.gnu.org; 4 Nov 2016 07:46:19 +0000 Received: from localhost ([127.0.0.1]:42878 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2ZCc-0007y9-MW for submit@debbugs.gnu.org; Fri, 04 Nov 2016 03:46:18 -0400 Received: from sender163-mail.zoho.com ([74.201.84.163]:21383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2ZCa-0007y0-F2 for 23436@debbugs.gnu.org; Fri, 04 Nov 2016 03:46:16 -0400 Received: from localhost (cpe-104-32-170-214.socal.res.rr.com [104.32.170.214]) by mx.zohomail.com with SMTPS id 1478245567045421.16293019056036; Fri, 4 Nov 2016 00:46:07 -0700 (PDT) References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> <87funefz1i.fsf@topbug.net> <83twbtq03k.fsf@gnu.org> <87vaw9bgdr.fsf@topbug.net> <83h97splqk.fsf@gnu.org> <87a8dkqpmo.fsf@topbug.net> <834m3rniko.fsf@gnu.org> User-agent: mu4e 0.9.17; emacs 25.1.50.3 From: Hong Xu To: Eli Zaretskii Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. In-reply-to: <834m3rniko.fsf@gnu.org> Date: Fri, 04 Nov 2016 00:46:05 -0700 Message-ID: <87zilfwuv6.fsf@topbug.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Zoho-Virus-Status: 1 X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 23436 Cc: 23436@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.6 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 2016-11-01 Tue 11:47 GMT-0700, Eli Zaretskii wrote: >> From: Hong Xu >> Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org >> Date: Mon, 31 Oct 2016 12:38:42 -0700 >>=20 >> On 2016-10-31 Mon 08:43 GMT-0700, Eli Zaretskii wrote: >> > >> > The node "Truenames" sounds like a good place. >>=20 >> Added in the new patch now (along with the change of the previous versio= n). > > LGTM, thanks. Can we apply the patch if it is good enough? Thanks. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJYHDy+AAoJECZsfTOCL4R4oesQAMpbmk8QDHwuEaW5aOJAguoU fP5XrYLSNAwb2kYy+7PU4r1ADEB0h5xwQ5FBavGGHJh0aybOH8GNt1XUu9wlUQlH CjviAzIbZ+zNkvJoXiJMgO3Gq/SYnDC/6ELMMs/mL0zn51fpFgURu6yLQU53tW57 lvI6ACgqX1k+ecRCp0hwPH4g04wvp1xxugEtYgfWbU9B8dCy85XJ6ByZNXXDmndY /k/jVIpPoyPY9i4LCHlzfArfgHOXIRZcW1cs7ZoVRMOifgxra5XfJsFSPmqkVg55 Y2G3coIE/ntn1/H3a/HP0m+U+odIFVU7cUT2JkWnB0n+UOz0/PWc5G0MOhdZbtL1 ieLD178cUEmdHWt7aNhm5EEiG9qezlikymdmXZMf7ofjyn2hdLZBsDugGP02cvyS wRW+HzLuiEcvqRrLDnO6N6DJEvjk2/c0ZNaw/afQC/iojnvRcFzG7sBDhnIbLCnp HezBKAH7rtAZ1+YWhbd6MYe5fMHVio8Nw1hb//KeW73FOoUUs1+1+RTGpm2kk6dx 7P6c5+a8csrNX8tu9WGJbISL/G1o6GkGgY4urTnai4P2/pZzcf4KSWBzAMZipWPt RG/7LlhS1gJKE0tS/v1CNkKjDpuEhpNOH5GRWWqlijrzbDkbTNb3n4VT55JIctBT 588jDwjkHWKOoyJyksN6 =SskE -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 04 06:08:49 2016 Received: (at 23436-done) by debbugs.gnu.org; 4 Nov 2016 10:08:49 +0000 Received: from localhost ([127.0.0.1]:43302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2bQX-0002uo-4T for submit@debbugs.gnu.org; Fri, 04 Nov 2016 06:08:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2bQV-0002ub-BU for 23436-done@debbugs.gnu.org; Fri, 04 Nov 2016 06:08:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2bQM-0006Gc-4w for 23436-done@debbugs.gnu.org; Fri, 04 Nov 2016 06:08:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2bQM-0006GU-1d; Fri, 04 Nov 2016 06:08:38 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2188 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c2bQK-0002qq-4B; Fri, 04 Nov 2016 06:08:37 -0400 Date: Fri, 04 Nov 2016 12:08:59 +0200 Message-Id: <834m3nlfpg.fsf@gnu.org> From: Eli Zaretskii To: Hong Xu In-reply-to: <87zilfwuv6.fsf@topbug.net> (message from Hong Xu on Fri, 04 Nov 2016 00:46:05 -0700) Subject: Re: bug#23436: [PATCH] Attemp to use the true name of a file to determine responsible vc if the genuine name does not work. References: <1462311145-5959-1-git-send-email-hong@topbug.net> <85f11f8a-1799-befd-3e5b-f7d7a6eac660@topbug.net> <072a649f-d11a-7c82-b3ae-32d9a92c8f8b@topbug.net> <5d653522-49bd-8b48-e3d6-0c09d1c65fae@yandex.ru> <377f4ee1-54a9-b10c-dc18-3acea6492bec@yandex.ru> <1ad97145-d21e-5d64-8b6c-4b4b2bc2ab49@yandex.ru> <87zilss0z6.fsf@topbug.net> <87funefz1i.fsf@topbug.net> <83twbtq03k.fsf@gnu.org> <87vaw9bgdr.fsf@topbug.net> <83h97splqk.fsf@gnu.org> <87a8dkqpmo.fsf@topbug.net> <834m3rniko.fsf@gnu.org> <87zilfwuv6.fsf@topbug.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.3 (-------) X-Debbugs-Envelope-To: 23436-done Cc: 23436-done@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.3 (-------) > From: Hong Xu > Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org > Date: Fri, 04 Nov 2016 00:46:05 -0700 > > On 2016-11-01 Tue 11:47 GMT-0700, Eli Zaretskii wrote: > > >> From: Hong Xu > >> Cc: dgutov@yandex.ru, 23436@debbugs.gnu.org > >> Date: Mon, 31 Oct 2016 12:38:42 -0700 > >> > >> On 2016-10-31 Mon 08:43 GMT-0700, Eli Zaretskii wrote: > >> > > >> > The node "Truenames" sounds like a good place. > >> > >> Added in the new patch now (along with the change of the previous version). > > > > LGTM, thanks. > > Can we apply the patch if it is good enough? Thanks. Pushed now. Please note that I generally wait for a week or so since the last comment before pushing changes, to let people enough time to comment or object. From unknown Sun Jun 22 22:48:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 Dec 2016 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator