GNU bug report logs - #23429
25.0.90; `dired-do-find-regexp' doc string

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Mon, 2 May 2016 17:59:02 UTC

Severity: minor

Found in version 25.0.90

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23429 in the body.
You can then email your comments to 23429 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#23429; Package emacs. (Mon, 02 May 2016 17:59:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 02 May 2016 17:59:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.90; `dired-do-find-regexp' doc string
Date: Mon, 2 May 2016 10:57:31 -0700 (PDT)

  "Find all matches for REGEXP in all marked files, recursively."

What does it mean to find matches in a particular marked file,
_recursively_?  This seems to be a nonsense description.

If what you mean is that the marked files in a marked _subdirectory_
are searched, and so on for its marked subdirs, recursively - then
say so.

If you don't mean something like that then I cannot imagine what this
means.  How can a _file_ (marked or not) be searched recursively?


In GNU Emacs 25.0.90.4 (i686-w64-mingw32)
 of 2016-03-20
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --host=i686-w64-mingw32 --without-dbus
 --without-compress-install CFLAGS=-static'
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23429; Package emacs. (Mon, 02 May 2016 18:10:01 GMT) Full text and rfc822 format available.

Message #8 received at 23429 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Drew Adams <drew.adams <at> oracle.com>, 23429 <at> debbugs.gnu.org
Subject: Re: bug#23429: 25.0.90; `dired-do-find-regexp' doc string
Date: Mon, 2 May 2016 21:09:08 +0300

On 05/02/2016 08:57 PM, Drew Adams wrote:

> If what you mean is that the marked files in a marked _subdirectory_
> are searched, and so on for its marked subdirs, recursively - then
> say so.

Care to propose an exact wording?

> If you don't mean something like that then I cannot imagine what this
> means.  How can a _file_ (marked or not) be searched recursively?

A file can be a directory, in Emacs and in general Unix parlance.

Those marked files that are, are searched recursively. The regular files 
are searched, period.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23429; Package emacs. (Mon, 02 May 2016 18:27:01 GMT) Full text and rfc822 format available.

Message #11 received at 23429 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>, 23429 <at> debbugs.gnu.org
Subject: RE: bug#23429: 25.0.90; `dired-do-find-regexp' doc string
Date: Mon, 2 May 2016 11:26:11 -0700 (PDT)

> > If what you mean is that the marked files in a marked _subdirectory_
> > are searched, and so on for its marked subdirs, recursively - then
> > say so.
> 
> Care to propose an exact wording?

Nope. Dunno what the command does, and don't have the time to
study the code more.

> > If you don't mean something like that then I cannot imagine what this
> > means.  How can a _file_ (marked or not) be searched recursively?
> 
> A file can be a directory, in Emacs and in general Unix parlance.

You mean that a directory is, or can be, a file.  But it is a
particular kind of file.  If you mean a directory then say a
directory.

And even for a directory, if regarded as a file it cannot be
searched recursively.  The _contents_ of a directory can be
searched, and the contents of its subdirectories can be searched,
and so on.

> Those marked files that are, are searched recursively. The regular files
> are searched, period.

  Search marked files, including marked subdirs.  Act recursively
  on marked subdirs.

But you need to specify whether ALL files and ALL subdirs in
a marked subdir are acted on, or just the marked files and 
marked subdirs in a marked subdir.

Here's one possibility (from Dired+):

  The files searched are those that are marked in the current
  Dired buffer.  Marked subdirectories are handled recursively
  in the same way.

Dunno whether that is the behavior you have, but you see that
there are several possibilities.
Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Mon, 02 May 2016 20:00:02 GMT) Full text and rfc822 format available.
Notification sent to Drew Adams <drew.adams <at> oracle.com>:
bug acknowledged by developer. (Mon, 02 May 2016 20:00:03 GMT) Full text and rfc822 format available.

Message #16 received at 23429-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 23429-done <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#23429: 25.0.90; `dired-do-find-regexp' doc string
Date: Mon, 02 May 2016 22:58:59 +0300

> Date: Mon, 2 May 2016 11:26:11 -0700 (PDT)
> From: Drew Adams <drew.adams <at> oracle.com>
> 
> But you need to specify whether ALL files and ALL subdirs in
> a marked subdir are acted on, or just the marked files and 
> marked subdirs in a marked subdir.
> 
> Here's one possibility (from Dired+):
> 
>   The files searched are those that are marked in the current
>   Dired buffer.  Marked subdirectories are handled recursively
>   in the same way.
> 
> Dunno whether that is the behavior you have, but you see that
> there are several possibilities.

Fixed, thanks.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23429; Package emacs. (Mon, 02 May 2016 20:13:02 GMT) Full text and rfc822 format available.

Message #19 received at 23429 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: 23429 <at> debbugs.gnu.org, eliz <at> gnu.org, drew.adams <at> oracle.com
Subject: Re: bug#23429: 25.0.90; `dired-do-find-regexp' doc string
Date: Mon, 2 May 2016 23:11:52 +0300

On 05/02/2016 10:58 PM, Eli Zaretskii wrote:

> Fixed, thanks.

Thanks, Eli.

Should the docstrings mention that some files and subdirectories do get 
ignored, according to vc-directory-exclusion-list and 
grep-find-ignored-files?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23429; Package emacs. (Mon, 02 May 2016 20:15:01 GMT) Full text and rfc822 format available.

Message #22 received at 23429 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>, 23429 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: RE: bug#23429: 25.0.90; `dired-do-find-regexp' doc string
Date: Mon, 2 May 2016 13:14:03 -0700 (PDT)

> Should the docstrings mention that some files and subdirectories do get
> ignored, according to vc-directory-exclusion-list and
> grep-find-ignored-files?

I'm not Eli, but yes.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23429; Package emacs. (Mon, 02 May 2016 20:43:02 GMT) Full text and rfc822 format available.

Message #25 received at 23429 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Drew Adams <drew.adams <at> oracle.com>, 23429 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: Re: bug#23429: 25.0.90; `dired-do-find-regexp' doc string
Date: Mon, 2 May 2016 23:42:05 +0300

On 05/02/2016 11:14 PM, Drew Adams wrote:
>> Should the docstrings mention that some files and subdirectories do get
>> ignored, according to vc-directory-exclusion-list and
>> grep-find-ignored-files?
>
> I'm not Eli, but yes.

Would you like to propose the wording?

Should both dired-do-find-regexp and dired-do-find-regexp-and-replace's 
docstrings contain the same sentences for that information?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23429; Package emacs. (Mon, 02 May 2016 20:59:02 GMT) Full text and rfc822 format available.

Message #28 received at 23429 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>, 23429 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: RE: bug#23429: 25.0.90; `dired-do-find-regexp' doc string
Date: Mon, 2 May 2016 13:58:38 -0700 (PDT)

> >> Should the docstrings mention that some files and subdirectories do get
> >> ignored, according to vc-directory-exclusion-list and
> >> grep-find-ignored-files?
> >
> > I'm not Eli, but yes.
> 
> Would you like to propose the wording?

Presumably something like this (?).

 Files with names matching the values of `vc-directory-exclusion-list'
 or `grep-find-ignored-files' are not searched.

> Should both dired-do-find-regexp and dired-do-find-regexp-and-replace's
> docstrings contain the same sentences for that information?

If the meaning/behavior is the same, why not?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23429; Package emacs. (Mon, 02 May 2016 21:03:02 GMT) Full text and rfc822 format available.

Message #31 received at 23429 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Drew Adams <drew.adams <at> oracle.com>, 23429 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: Re: bug#23429: 25.0.90; `dired-do-find-regexp' doc string
Date: Tue, 3 May 2016 00:02:04 +0300

On 05/02/2016 11:58 PM, Drew Adams wrote:

> Presumably something like this (?).
>
>  Files with names matching the values of `vc-directory-exclusion-list'
>  or `grep-find-ignored-files' are not searched.

Do you not mind that `vc-directory-exclusion-list' enumerates directory 
names, and not regular files?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23429; Package emacs. (Mon, 02 May 2016 22:46:01 GMT) Full text and rfc822 format available.

Message #34 received at 23429 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>, 23429 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: RE: bug#23429: 25.0.90; `dired-do-find-regexp' doc string
Date: Mon, 2 May 2016 15:45:30 -0700 (PDT)

> > Presumably something like this (?).
> >
> >  Files with names matching the values of `vc-directory-exclusion-list'
> >  or `grep-find-ignored-files' are not searched.
> 
> Do you not mind that `vc-directory-exclusion-list' enumerates directory
> names, and not regular files?

I said "presumably" because I was presuming that the regexp matched file names. Adjust the language accordingly, if it is somehow enough to match a directory name (?).
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23429; Package emacs. (Tue, 03 May 2016 16:18:02 GMT) Full text and rfc822 format available.

Message #37 received at 23429 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: drew.adams <at> oracle.com, 23429 <at> debbugs.gnu.org
Subject: Re: bug#23429: 25.0.90; `dired-do-find-regexp' doc string
Date: Tue, 03 May 2016 19:16:12 +0300

> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Mon, 2 May 2016 23:11:52 +0300
> 
> On 05/02/2016 10:58 PM, Eli Zaretskii wrote:
> 
> > Fixed, thanks.
> 
> Thanks, Eli.
> 
> Should the docstrings mention that some files and subdirectories do get 
> ignored, according to vc-directory-exclusion-list and 
> grep-find-ignored-files?

Added, thanks.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 01 Jun 2016 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 9 years and 17 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.