GNU bug report logs - #23408
25.0.90; bookmark.el: incorrect use of `define-error'

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Sat, 30 Apr 2016 19:37:01 UTC

Severity: minor

Tags: easy, fixed, patch

Found in version 25.0.90

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.90; bookmark.el: incorrect use of `define-error'
Date: Sat, 30 Apr 2016 11:35:42 -0800 (GMT-08:00)

See bug #20625.

Summary:

bookmark.el uses `define-error' without passing a string for argument
MESSAGE.

Emacs Dev had decided that this is incorrect usage, and thus that
`define-error' does not provide the same functionality as you get by
using property `error-conditions' directly.

Either change the bookmark.el code to use `error-conditions' directly
(as before) or change it to provide a string MESSAGE arg for the
definition of `bookmark-errors'.


In GNU Emacs 25.0.90.4 (i686-w64-mingw32)
 of 2016-03-20
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --host=i686-w64-mingw32 --without-dbus
 --without-compress-install CFLAGS=-static'
This bug report was last modified 5 years and 342 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.