GNU bug report logs - #23408
25.0.90; bookmark.el: incorrect use of `define-error'

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Sat, 30 Apr 2016 19:37:01 UTC

Severity: minor

Tags: easy, fixed, patch

Found in version 25.0.90

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #10 received at 23408 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 23408 <at> debbugs.gnu.org
Subject: Re: bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'
Date: Wed, 12 Jun 2019 18:47:15 +0200

[Message part 1 (text/plain, inline)]
Drew Adams <drew.adams <at> oracle.com> writes:
> bookmark.el uses `define-error' without passing a string for argument
> MESSAGE.
>
> Emacs Dev had decided that this is incorrect usage, and thus that
> `define-error' does not provide the same functionality as you get by
> using property `error-conditions' directly.

The attached patch should fix this.

Thanks,
Stefan Kangas

[0001-Add-MESSAGE-string-to-bookmark-errors-bug-23408.patch (application/octet-stream, attachment)]
This bug report was last modified 5 years and 342 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.