From unknown Fri Jun 20 07:13:34 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23408 <23408@debbugs.gnu.org> To: bug#23408 <23408@debbugs.gnu.org> Subject: Status: 25.0.90; bookmark.el: incorrect use of `define-error' Reply-To: bug#23408 <23408@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:13:34 +0000 retitle 23408 25.0.90; bookmark.el: incorrect use of `define-error' reassign 23408 emacs submitter 23408 Drew Adams severity 23408 minor tag 23408 easy patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 15:36:51 2016 Received: (at submit) by debbugs.gnu.org; 30 Apr 2016 19:36:51 +0000 Received: from localhost ([127.0.0.1]:58461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awah9-00086s-L1 for submit@debbugs.gnu.org; Sat, 30 Apr 2016 15:36:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awah7-00086e-Mp for submit@debbugs.gnu.org; Sat, 30 Apr 2016 15:36:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awagt-0000yw-3l for submit@debbugs.gnu.org; Sat, 30 Apr 2016 15:36:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,XPRIO autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awagt-0000xp-14 for submit@debbugs.gnu.org; Sat, 30 Apr 2016 15:36:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awagh-0006dV-CZ for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 15:36:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awagT-0000rf-KT for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 15:36:15 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awagT-0000kN-Ar for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 15:36:09 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3UJZiqq020473 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 30 Apr 2016 19:35:44 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u3UJZiUZ017508 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 30 Apr 2016 19:35:44 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u3UJZhP6008111 for ; Sat, 30 Apr 2016 19:35:44 GMT MIME-Version: 1.0 Message-ID: Date: Sat, 30 Apr 2016 11:35:42 -0800 (GMT-08:00) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 25.0.90; bookmark.el: incorrect use of `define-error' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) See bug #20625. Summary: bookmark.el uses `define-error' without passing a string for argument MESSAGE. Emacs Dev had decided that this is incorrect usage, and thus that `define-error' does not provide the same functionality as you get by using property `error-conditions' directly. Either change the bookmark.el code to use `error-conditions' directly (as before) or change it to provide a string MESSAGE arg for the definition of `bookmark-errors'. In GNU Emacs 25.0.90.4 (i686-w64-mingw32) of 2016-03-20 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --host=3Di686-w64-mingw32 --without-dbus --without-compress-install CFLAGS=3D-static' From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 11 19:53:08 2017 Received: (at control) by debbugs.gnu.org; 11 Jun 2017 23:53:08 +0000 Received: from localhost ([127.0.0.1]:41545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKCfM-0001n1-7P for submit@debbugs.gnu.org; Sun, 11 Jun 2017 19:53:08 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:32959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKCfJ-0001mW-Mc for control@debbugs.gnu.org; Sun, 11 Jun 2017 19:53:06 -0400 Received: by mail-io0-f170.google.com with SMTP id t87so29398427ioe.0 for ; Sun, 11 Jun 2017 16:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=YqJUge6XrS8b/ktsKrRz0MSyj+LIA8udsbLXmRdEJ6M=; b=gbgnhALQ/rK3o2zjFeMMGDod7NWoRWETAPKRE2cXEy80ipSA7MD95WdvmhPWxz9caH qTS6An+jGh3j74SJwB+VyfKAHb3zYMtl0GR5bPs5/4EtCD6D+UdW5Z7JkVUdSkAOWwrG t3YfUvsoczfCFcmsHLL8fY2sv3CT1KFfrjoO0dilu7maE7yoipU1+FhVQbp1IzoRnJFb I22+g8+8Yz2kJuIyqz6ehdQO+0D49fPXApKKKPEwDQOjbIhaq6GoHN6sN6oOrxntlLTe 4gbezAZBZrgH9ddQb3V8KukWZmDa8DW7wlOgFkvqQftcs97/iD8iAxX3UrpON5BdG/7V wfog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=YqJUge6XrS8b/ktsKrRz0MSyj+LIA8udsbLXmRdEJ6M=; b=jQ5jVpR2FS/16lmdWE6Dxko+yygAZHs1w2RnbCC2cDCHs/QmwC3vUB5gnPnX3VXytO 1aoPcuRDwC5UboIgEi7kIwSK2aEi07FH0l8E7Si73cbqHFxJNqtEY2/goIL4n7pKhgiL pm98E5NnJj7T7Y0c3RVHGRh3Al0bTJq3JWEleX7oHED8JbIU2+5M8JEYa9UTXMaIfEqj Rf1tPXOV/FVOI95ehGnyBnMrPN9kKhYhMEsnZTJ6STeVluUAC4v8KYT01gLsz7h5/9JF Ly0X5/PdKdYKpoXsxaKwbH8UVl6o4DEAC0kboZQrMVe0+/HgryrTfwLU/iYkJnVRxY7D dHBA== X-Gm-Message-State: AKS2vOx9alXfy0pD7mEuC7CWqdILDQrUz+iHI4qC9Ge8yskEMHy2/MoA h1lAPN+ldva9fA8y X-Received: by 10.107.161.146 with SMTP id k140mr5369735ioe.174.1497225179907; Sun, 11 Jun 2017 16:52:59 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id l130sm3934781iol.49.2017.06.11.16.52.58 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 11 Jun 2017 16:52:59 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #23408 Date: Sun, 11 Jun 2017 19:54:37 -0400 Message-ID: <87k24iulky.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 23408 + easy quit From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 12:47:37 2019 Received: (at 23408) by debbugs.gnu.org; 12 Jun 2019 16:47:37 +0000 Received: from localhost ([127.0.0.1]:33979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6PP-0004lS-OL for submit@debbugs.gnu.org; Wed, 12 Jun 2019 12:47:37 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:37832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6PN-0004lD-GO for 23408@debbugs.gnu.org; Wed, 12 Jun 2019 12:47:33 -0400 Received: by mail-wm1-f49.google.com with SMTP id 22so7263889wmg.2 for <23408@debbugs.gnu.org>; Wed, 12 Jun 2019 09:47:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=JPMzS666xAuyFG8MWLq9CxOmFDQtXSPSIoPjnzaq574=; b=lg02mUrEeL5+aemoc2qIwq4I9EP6K4GU6cVuK979DNpLNVzOzSW1BoD6Jb5r34ELw/ J/8hRd9iljTlPpzobuB+Ro5lT1Gx0Sd7Fjz2t5mhuamB8JsmvaH2Ur71FNV8Leq6qnSA a03YpmONGfcYqF1HEc7LHCsowxTuwQ3NiUsWkSN37b86Kwf0VArY5uKh5dolLI+iowZe 5OmsCOFzEhqRBiTnmb7nhKMsmlX7Q5iR8450J0oBJ36Zq++y/G/ebzMevs0Y9ATLLJ3F ayzcJI8ydjqxvXaCcjseTd1N9ccZzDgPPRKIdBAYKDIn9Fj7aQpTjTFu4LBhfK+HYtZj 7oZQ== X-Gm-Message-State: APjAAAVEssICucMs+1gJZ6EWxSc8BZjKvZ3326T9T1ttfsc2nqHgPrLK 4TKQH+Dr0RGOKsKBC7EPpDXfeJYzkXO/GL35qbhQkFs9 X-Google-Smtp-Source: APXvYqxVc98vVP27+jAk0gpHhoQ+XeRTCMuH8JONtusgXYlG9NkiWIOLwvBo33Pr1mGVUg7jLWsq7DioJFWEAF8i6Cg= X-Received: by 2002:a1c:9696:: with SMTP id y144mr83577wmd.73.1560358047194; Wed, 12 Jun 2019 09:47:27 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Wed, 12 Jun 2019 18:47:15 +0200 Message-ID: Subject: Re: bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error' To: 23408@debbugs.gnu.org Content-Type: multipart/mixed; boundary="00000000000020598c058b232b60" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 23408 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --00000000000020598c058b232b60 Content-Type: text/plain; charset="UTF-8" Drew Adams writes: > bookmark.el uses `define-error' without passing a string for argument > MESSAGE. > > Emacs Dev had decided that this is incorrect usage, and thus that > `define-error' does not provide the same functionality as you get by > using property `error-conditions' directly. The attached patch should fix this. Thanks, Stefan Kangas --00000000000020598c058b232b60 Content-Type: application/octet-stream; name="0001-Add-MESSAGE-string-to-bookmark-errors-bug-23408.patch" Content-Disposition: attachment; filename="0001-Add-MESSAGE-string-to-bookmark-errors-bug-23408.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jwtgua9w0 RnJvbSBiOTFlZDlhYjUyMmY0ODE4MzA4Yzk4NGNhZDZmMTVmNTA5N2Y2ZWVmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBXZWQsIDEyIEp1biAyMDE5IDE4OjQyOjQ2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QWRkIE1FU1NBR0Ugc3RyaW5nIHRvIGJvb2ttYXJrLWVycm9ycyAoYnVnIzIzNDA4KQoKKiBsaXNw L2Jvb2ttYXJrLmVsIChib29rbWFyay1lcnJvcnMpOiBBZGQgTUVTU0FHRSBwYXJhbWV0ZXIgc3Ry aW5nLgotLS0KIGxpc3AvYm9va21hcmsuZWwgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvYm9va21hcmsuZWwg Yi9saXNwL2Jvb2ttYXJrLmVsCmluZGV4IDVhOTg1OWQ4M2QuLmE2OTkxOWNjMDggMTAwNjQ0Ci0t LSBhL2xpc3AvYm9va21hcmsuZWwKKysrIGIvbGlzcC9ib29rbWFyay5lbApAQCAtMTE3Miw3ICsx MTcyLDggQEAgYm9va21hcmstaGFuZGxlLWJvb2ttYXJrCiAgICAgKHNldHEgYm9va21hcmstY3Vy cmVudC1ib29rbWFyayBib29rbWFyay1uYW1lLW9yLXJlY29yZCkpCiAgIG5pbCkKIAotKGRlZmlu ZS1lcnJvciAnYm9va21hcmstZXJyb3JzIG5pbCkKKyhkZWZpbmUtZXJyb3IgJ2Jvb2ttYXJrLWVy cm9ycworICAiQm9va21hcmsgZXJyb3IiKQogKGRlZmluZS1lcnJvciAnYm9va21hcmstZXJyb3It bm8tZmlsZW5hbWUKICAgIkJvb2ttYXJrIGhhcyBubyBhc3NvY2lhdGVkIGZpbGUgKG9yIGRpcmVj dG9yeSkiICdib29rbWFyay1lcnJvcnMpCiAKLS0gCjIuMjEuMAoK --00000000000020598c058b232b60-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 13:13:11 2019 Received: (at 23408) by debbugs.gnu.org; 12 Jun 2019 17:13:11 +0000 Received: from localhost ([127.0.0.1]:34002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6oB-0005Ue-Ea for submit@debbugs.gnu.org; Wed, 12 Jun 2019 13:13:11 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:36828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6o7-0005UO-VK for 23408@debbugs.gnu.org; Wed, 12 Jun 2019 13:13:10 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5CH9jgB026387; Wed, 12 Jun 2019 17:13:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=vT/fdp1ckgtUvvHOxeyGlhBnnibtahpFDWUotBYiX9A=; b=Rp38lrcnznJ1c4NgKh794bNj4lev1vQY+30ZWbEDlfqaLJNQNU//9UTht90qqsy1GChm MlCR7qXGnSE1STiWOZz7GfFsgt86MTK+mBd8z0G2+SOf35WEwVukrw/SDTXLlzE4nuif 2QIrZnVBdyweui1zzcrpP1pcj4GHsZXcyiKuVMTciFTEuHY26IIGN64NUdF3hVyvmCm+ aEzcUqVYNlEIM8lozYvVzQy7WrFODWg1PZpb6MymTMdY8xT6CXAc6sLrpDX47Vk+ahnC aUJgAc/+hZtlUgwPmJ49PKTUn+hguAJMnDERyZu7QJVMt+6KA9h6DdeYTUSzRf7WJ5El yA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 2t02hew2tj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 17:13:01 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5CHCGOk012508; Wed, 12 Jun 2019 17:13:01 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 2t0p9ryy9j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Jun 2019 17:13:01 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x5CHCvs4021185; Wed, 12 Jun 2019 17:12:59 GMT MIME-Version: 1.0 Message-ID: <896f7600-de72-4ba6-a4da-c3156d0bcd16@default> Date: Wed, 12 Jun 2019 10:12:56 -0700 (PDT) From: Drew Adams To: Stefan Kangas , 23408@debbugs.gnu.org Subject: RE: bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error' References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9286 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=786 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120115 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9286 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=843 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120116 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 23408 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The attached patch should fix this. LGTM. Thx. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 12 13:13:27 2019 Received: (at control) by debbugs.gnu.org; 12 Jun 2019 17:13:27 +0000 Received: from localhost ([127.0.0.1]:34005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6oQ-0005VI-QR for submit@debbugs.gnu.org; Wed, 12 Jun 2019 13:13:27 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:37982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hb6oO-0005Uw-Lq for control@debbugs.gnu.org; Wed, 12 Jun 2019 13:13:25 -0400 Received: by mail-wm1-f42.google.com with SMTP id s15so7345082wmj.3 for ; Wed, 12 Jun 2019 10:13:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=SOJzMwv0jfVvtVT5K4YicSRw3M055qFeKQvlN1yUteg=; b=oO3nly9yuNJ9LpMEPQn2jBnKlX5o44KLvPY3FtkZyGisq8srTadImRAfjCAPxQ/UdC qqRud9zxY44UNXSGrcCE57O36BZcNqK+4ThRZdxpNm/sygO2ZBEZlCeK6DVJwqt+U70s eYjfb+lQvr70OVm89l1A65eKyK11mPJIiZwiyypZE6UnEMerijbEGMubTYNXnjIDRh6G MIrChhivBVlSc3sF91nmFCNdnm+Dvu4/joiu69gwQyVBoFpol5Og4ZgKA1xKhbkH6cOA z1ejQ/q6uNEyWyKHm5l1cUZR0Mt1Syjx41DPItEQCwF9wWmoEbHmgYRj17mlj1VNGku6 a3ow== X-Gm-Message-State: APjAAAXIXRghntV/EJ2N56C5SAWRyJUeeHJ0n5tk0GftfYgLXczTBHap HjopsyrJrfLGaqShIsKi5uN1JmoOo7syNVh9OS052WHB X-Google-Smtp-Source: APXvYqx41WWmtzGRwGYmPwUe+lMWXZT3ErpZhflLv9ZUubdGO68WNrS1kro/YF8bTLoIe6k/raUSf3kTLolvV8bfTnk= X-Received: by 2002:a1c:b6d4:: with SMTP id g203mr172444wmf.19.1560359598557; Wed, 12 Jun 2019 10:13:18 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Wed, 12 Jun 2019 19:13:07 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 23408 + patch quit Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.42 listed in list.dnswl.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 BLANK_SUBJECT Subject is present but empty 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 23408 + patch quit Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.128.42 listed in list.dnswl.org] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 2.0 BLANK_SUBJECT Subject is present but empty -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different tags 23408 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 15 17:45:56 2019 Received: (at 23408) by debbugs.gnu.org; 15 Jun 2019 21:45:56 +0000 Received: from localhost ([127.0.0.1]:39293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcGUm-0007yC-Dh for submit@debbugs.gnu.org; Sat, 15 Jun 2019 17:45:56 -0400 Received: from mail-io1-f54.google.com ([209.85.166.54]:40212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcGUi-0007xY-52; Sat, 15 Jun 2019 17:45:54 -0400 Received: by mail-io1-f54.google.com with SMTP id n5so13384638ioc.7; Sat, 15 Jun 2019 14:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7fY13S3ElqKF0dkEjVfqITvkZiNbL5Wl6w4DZYbiPds=; b=LJ5nVkyusV+Dg3CLMCUguxndlvmanBQcJyPSVkKJfzgpzWuEjCnneRSf6SsCZKrmLP L8TpfI7vQs07KUFP9wtL3Wg2IRYky5KfUctL/otgBzuyl8J4OdqfVJx92YePKej+Cipl 5TA0rYQdtvbgX6Ap36kuxaIYZ921NODWn9FpcskJGDPUVcFTrh6vIA1C59aIfJvYNvLg NQ0Q63c1IXPNBQd8mPPGXAya35dCCFfqEy2AMT05XdU82peSaEux4TN4alBCsqWRVE+t 0YExn+pjK5TqLGF1daBDb8Pf1tuBifuxw1PEqKxqQrpnSibp59oUmOjWwAFMOD6lCYCx oOxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=7fY13S3ElqKF0dkEjVfqITvkZiNbL5Wl6w4DZYbiPds=; b=sljnWerz6BsIySB8HGhV3fZpEM29iDBdtQqJf2VsVfTquvTom7uVqghYMIz5bfeKTG U6WK68viXgG7Crfnw7bb2onSpfMbZtqKJRlEDgdcWcys842nhy+VSzIs57bMf2K+vl9o Qsd+zZwVBZK+jrSueb2FTbuWBie0SM5Zwf1TCtT8+vijEgTGH9Qwga/gI2/KRhaEGYK2 zbuekZkdlirsNO4wB0kggVzHytpX3EHMKne0J36d/8/hmurKNm43IsV+yEPFK7YKYr4/ NKA85Pc/l20qCK0MsC++UCbcM1KodLEi/mKbNSj6sW4rl159OiOKijsHWlCusNmBv2Wt uARQ== X-Gm-Message-State: APjAAAUneQO7LgDSMLwLbJ84GbN+1cj9KPjtrZtAseCRaqV8Z6Z32GLW AfdUwPbRGC3dJoPbPTlS/kJWfFNa X-Google-Smtp-Source: APXvYqxE9JblAC2iD7MhbO5dvqxSxImVcEf4VYTn8JVn5ZcQ6TDJV37zHwfxVbSRjNRkEOnZ4YSLDA== X-Received: by 2002:a6b:6012:: with SMTP id r18mr22383243iog.241.1560635146366; Sat, 15 Jun 2019 14:45:46 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id q1sm6822271ios.86.2019.06.15.14.45.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Jun 2019 14:45:45 -0700 (PDT) From: Noam Postavsky To: Drew Adams Subject: Re: bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error' References: <896f7600-de72-4ba6-a4da-c3156d0bcd16@default> Date: Sat, 15 Jun 2019 17:45:44 -0400 In-Reply-To: <896f7600-de72-4ba6-a4da-c3156d0bcd16@default> (Drew Adams's message of "Wed, 12 Jun 2019 10:12:56 -0700 (PDT)") Message-ID: <877e9mzfnb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23408 Cc: 23408@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 23408 fixed close 23408 27.1 quit Drew Adams writes: >> The attached patch should fix this. > > > LGTM. Thx. Pushed to master. cdd8cb3a9e 2019-06-15T17:08:58-04:00 "Add MESSAGE string to bookmark-errors (bug#23408)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cdd8cb3a9e18f87da31e52236fd2c4ebfcd676bd From unknown Fri Jun 20 07:13:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 14 Jul 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator