From unknown Thu Jun 19 14:33:18 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23384: [PATCH] Support completion of color functions in CSS mode Resent-From: "Etienne Prud'homme" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Apr 2016 23:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23384 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 23384@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14617139933132 (code B ref -1); Tue, 26 Apr 2016 23:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 Apr 2016 23:39:53 +0000 Received: from localhost ([127.0.0.1]:49185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avCa8-0000oQ-MI for submit@debbugs.gnu.org; Tue, 26 Apr 2016 19:39:53 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avBkY-0007P9-29 for submit@debbugs.gnu.org; Tue, 26 Apr 2016 18:46:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avBkS-0005XJ-2N for submit@debbugs.gnu.org; Tue, 26 Apr 2016 18:46:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avBkR-0005XF-Vc for submit@debbugs.gnu.org; Tue, 26 Apr 2016 18:46:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avBkQ-0005RH-S5 for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 18:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avBkN-0005Wh-Kg for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 18:46:26 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:35422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avBkN-0005Wc-Fw for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 18:46:23 -0400 Received: by mail-qk0-x244.google.com with SMTP id b63so1843342qkg.2 for ; Tue, 26 Apr 2016 15:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:message-id:mime-version; bh=l01izk84bzOn86YKLOjnk8a/3t+9AQUKnDM+5GMS75s=; b=PxmMkZSC31p2CjMAHf0ZLd1BUYn934xpFaYSj+9EfBWsIX1+VREu4XdNnTOcX/vPMu Aj20sW60IWchXzAyITXK0qEc4ifiX/MBqMhitlggT9EDkh/X+8ktZLOdW/aiEGU1jXMK X4PF2afXwS8+V7pf9ttLD7ylKUoGmyKmxnYvDeT77OXpClrd6OE16gL5kPZVtiIXBXrk j6GrRV/cvLF0kur7/7SQ5l25QDZ4eaS10p9eqJglwa+PYMWcxZKc5euDOwkZsm9zhqNg g+W5TXBbYOjq/jGq/6uVtoougIDS7TfDscSGWBIZh8rtIGgil9ObjUgjwtM2bsDhcAIV xhNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:subject:message-id:mime-version; bh=l01izk84bzOn86YKLOjnk8a/3t+9AQUKnDM+5GMS75s=; b=TfoBPypl+xYvgcIP66Du8eEXNS069RYfw4cWeLrTPLA/zdBgw3hThm8lJ6VGmEr0Sv eb3cgMnt8FXrSp0/HV5e/nr+hcVQjnQ/Q3hgVVPaAKCIoGwa59NgYHlGxJDTp8yRhdqk iy+LSO/8C2nw4PXWpriSFmK0/ctG7Zk3saQQmF5qERb8Ec1wm6uW9sdKQ2hvQggLuD8Z w5UnyLLiCtjx9mMSciD24rQEZtAeGnbn/eH807JDuYAvV1xHH6I1ycWrKcqww7Cnl0wj gIAWzTpSt3wbRTOvQZ5HgZuIEoq+k3wz0Hwt72gw3xEs+AfdoyPUmneM3MVVWx0rAoS6 MFzQ== X-Gm-Message-State: AOPr4FW8FLvyGQoHOKNRIG7R3xY5VH3Th7RdEAyIJdhgDets3moK52+eqo//gn1kPRq8Eg== X-Received: by 10.55.160.215 with SMTP id j206mr5160123qke.108.1461710782808; Tue, 26 Apr 2016 15:46:22 -0700 (PDT) Received: from ThinkPax ([172.98.67.78]) by smtp.gmail.com with ESMTPSA id h75sm298993qge.30.2016.04.26.15.46.22 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 26 Apr 2016 15:46:22 -0700 (PDT) From: "Etienne Prud'homme" X-Google-Original-From: Etienne Prud'homme Date: Tue, 26 Apr 2016 18:46:18 -0400 Message-ID: <20160426184618.5d8fd906@ThinkPax> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/FVTwd1BfAUn60luUuT=BnMd" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Tue, 26 Apr 2016 19:39:50 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --MP_/FVTwd1BfAUn60luUuT=BnMd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline The attached patch adds completion for CSS color functions such as `rgb()'. Values were taken from the =E2=80=9CCSS Color Module Level 4=E2=80= =9D. It can be found at: https://drafts.csswg.org/css-color/#color-type As a sidenote, how should we handle functions? Since they use parentheses, the point is going to be outside of parentheses. Eg. rgba()* ^(point) Also, should we include the parameters number? --MP_/FVTwd1BfAUn60luUuT=BnMd Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-Add-completion-of-color-functions-in-CSS-mode.patch >From 52cc18080206fcd0d154a6c75c458a39bdcdfcbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Etienne=20Prud=E2=80=99homme?= Date: Tue, 26 Apr 2016 18:44:08 -0400 Subject: [PATCH] Add completion of color functions in CSS mode * lisp/textmodes/css-mode.el (css-value-class-alist): Add CSS color functions as candidates for color values. --- lisp/textmodes/css-mode.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index e30fb3e..78d4736 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -463,7 +463,8 @@ further value candidates, since that list would be infinite.") (color "aqua" "black" "blue" "fuchsia" "gray" "green" "lime" "maroon" "navy" "olive" "orange" "purple" "red" "silver" "teal" "white" - "yellow" "transparent") + "yellow" "transparent" color-functions) + (color-functions "color-mod()" "device-cmyk()" "gray()" "hsl()" "hsla()" "hwb()" "rgb()" "rgba()") (common-lig-values "common-ligatures" "no-common-ligatures") (contextual-alt-values "contextual" "no-contextual") (counter "counter()" "counters()") -- 2.8.1 --MP_/FVTwd1BfAUn60luUuT=BnMd-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 19:54:37 2016 Received: (at control) by debbugs.gnu.org; 26 Apr 2016 23:54:37 +0000 Received: from localhost ([127.0.0.1]:49190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avCoP-0001AV-5r for submit@debbugs.gnu.org; Tue, 26 Apr 2016 19:54:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avCoN-0001AJ-Qe for control@debbugs.gnu.org; Tue, 26 Apr 2016 19:54:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avCoH-0005JB-SG for control@debbugs.gnu.org; Tue, 26 Apr 2016 19:54:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avCoH-0005J6-Or for control@debbugs.gnu.org; Tue, 26 Apr 2016 19:54:29 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1avCoH-0004Oe-DJ for control@debbugs.gnu.org; Tue, 26 Apr 2016 19:54:29 -0400 Subject: control message for bug 23384 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 26 Apr 2016 19:54:29 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) merge 23383 23384 severity 23384 wishlist