GNU bug report logs - #23383
[PATCH] Support completion of color functions in CSS mode

Previous Next

Package: emacs;

Reported by: Etienne Prud'homme <e.e.f.prudhomme <at> gmail.com>

Date: Tue, 26 Apr 2016 22:50:01 UTC

Severity: wishlist

Tags: patch

Merged with 23384

Done: Simen Heggestøyl <simenheg <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#23384: closed ([PATCH] Support completion of color functions
 in CSS mode)
Date: Sun, 22 May 2016 11:04:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 22 May 2016 13:03:26 +0200
with message-id <1463915006.23837.0 <at> smtp.gmail.com>
and subject line Re: bug#23383: [PATCH] Support completion of color functions in CSS mode
has caused the debbugs.gnu.org bug report #23383,
regarding [PATCH] Support completion of color functions in CSS mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
23383: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23383
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: "Etienne Prud'homme" <yuicopr <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Support completion of color functions in CSS mode
Date: Tue, 26 Apr 2016 18:46:18 -0400
[Message part 3 (text/plain, inline)]
The attached patch adds completion for CSS color functions such as
`rgb()'. Values were taken from the “CSS Color Module Level 4”. It can
be found at: https://drafts.csswg.org/css-color/#color-type

As a sidenote, how should we handle functions? Since they use
parentheses, the point is going to be outside of parentheses.

Eg.
rgba()*
      ^(point)

Also, should we include the parameters number?
[0001-Add-completion-of-color-functions-in-CSS-mode.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Etienne Prud'homme <e.e.f.prudhomme <at> gmail.com>
Cc: 23383-done <at> debbugs.gnu.org
Subject: Re: bug#23383: [PATCH] Support completion of color functions in CSS
 mode
Date: Sun, 22 May 2016 13:03:26 +0200
[Message part 6 (text/plain, inline)]
On Sun, May 22, 2016 at 12:43 AM, Etienne Prud'homme 
<e.e.f.prudhomme <at> gmail.com> wrote:
> Oops! I've attached the new patch now.

Thanks, looks good. Installed in master.

-- Simen
[Message part 7 (text/html, inline)]

This bug report was last modified 9 years and 3 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.