GNU bug report logs - #23383
[PATCH] Support completion of color functions in CSS mode

Previous Next

Full log

Message #18 received at 23383 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Etienne Prud'homme <e.e.f.prudhomme <at> gmail.com>
Cc: 23383 <at> debbugs.gnu.org
Subject: Re: bug#23383: [PATCH] Support completion of color functions in CSS
 mode
Date: Thu, 28 Apr 2016 19:51:37 +0200

[Message part 1 (text/plain, inline)]

Thanks for the revision, Etienne.

There are still a couple of issues that need to be resolved.

- I think we should stick to the current CSS Color Module Level 3
 recommendation [1]. The functions apart from `rgb()', `rgba()',
 `hsl()', and `hsla()' are only present in an Editor's Draft. I find no
 other resources about them, so I don't think we should include them
 until the new spec becomes at least a Candidate Recommendation.

- I think there's little use in completing `#' since it's only one
 character.

- `namedColor' must be changed to `named-color' to match the name of the
 value class.

- The new color names need to be double-checked. For instance I see that
 `limegreen' has become `limeg een' and `salmon' has become `sa mon'.

- The test `css-test-property-values' in
 test/lisp/textmodes/css-mode-tests.el needs a small update.

[1] https://www.w3.org/TR/css3-color/

-- Simen

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.