GNU bug report logs - #23383
[PATCH] Support completion of color functions in CSS mode

Previous Next

Full log

View this message in rfc822 format

From: Etienne Prud'homme <e.e.f.prudhomme <at> gmail.com>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: 23383 <at> debbugs.gnu.org
Subject: bug#23383: [PATCH] Support completion of color functions in CSS mode
Date: Wed, 27 Apr 2016 20:17:45 -0400

[Message part 1 (text/plain, inline)]

On Wed, 27 Apr 2016 21:16:58 +0200,
Simen Heggestøyl <simenheg <at> gmail.com> wrote:

> - In the completion definitions we've tried to stay as close as
> possible to the structure used in the CSS spec. This means that
> instead of introducing `color-functions' we should make `color'
> complete directly to "rgb()", "rgba()", and so on, then `hex-color',
> `named-color' and the literal `currentcolor' (I think we can skip
>   `deprecated-system-color'). `named-color' will then contain the
>   literal color names like `color' does now.
That’s a good point. Since I saw that `color' lacked most of
them, I wasn’t sure where we were going.

> - One of the tests in test/lisp/textmodes/css-mode-tests.el needs
>   updating. To see this, run `make lisp/textmodes/css-mode-tests' from
>   the test directory.
> 
> - Please wrap lines around column 70 or so to stay in line with the
> rest of the file.
Thanks for reminding me! I completely forgot. Much easier to read.

I’ve made a second patch according to your recommendations. Color
functions are now part of `color' and `named-color' is now a separate
entity. I’ve tried to follow CSSWG ordering, but it’s not always the
same order in the specifications. I also found two more functions not
present earlier.

[0001-Add-completion-of-colors-in-CSS-mode.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.