From unknown Sat Jun 21 03:13:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23383 <23383@debbugs.gnu.org> To: bug#23383 <23383@debbugs.gnu.org> Subject: Status: [PATCH] Support completion of color functions in CSS mode Reply-To: bug#23383 <23383@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:13:36 +0000 retitle 23383 [PATCH] Support completion of color functions in CSS mode reassign 23383 emacs submitter 23383 Etienne Prud'homme severity 23383 wishlist tag 23383 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 18:49:09 2016 Received: (at submit) by debbugs.gnu.org; 26 Apr 2016 22:49:09 +0000 Received: from localhost ([127.0.0.1]:49160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avBn3-00080L-8b for submit@debbugs.gnu.org; Tue, 26 Apr 2016 18:49:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avBn1-0007zt-JJ for submit@debbugs.gnu.org; Tue, 26 Apr 2016 18:49:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avBmv-0006Nf-EW for submit@debbugs.gnu.org; Tue, 26 Apr 2016 18:49:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42517) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avBmv-0006NV-B7 for submit@debbugs.gnu.org; Tue, 26 Apr 2016 18:49:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avBmu-0000HJ-D3 for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 18:49:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avBmr-0006NH-85 for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 18:49:00 -0400 Received: from mail-qg0-x241.google.com ([2607:f8b0:400d:c04::241]:34340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avBmr-0006N8-2d for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 18:48:57 -0400 Received: by mail-qg0-x241.google.com with SMTP id d90so1929450qgd.1 for ; Tue, 26 Apr 2016 15:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version; bh=elzthgTR8uCSjEsUyMhWwHfIwn4bvd20UhDWwVdXICs=; b=k+n0k5UDyz4h6AVNcyCqJgUrMztOkpFypTPw/YCTCR2csC6i3qSk6fh5y1ufbTJW70 yu4RlgmZaF+xapjZyBLCFTTPILA/NUzGvJDJv9FPcfVa6CnOSdj+pJZzMYeUH/kHQpfh c26FIWfyMU7E2H806NOTT0KC4Y9S6kI6Y21qcAo/jH1OfgyQ6br943sz2QDMd6kuLCdF 9/D4DgMEMz5aEkHax4Dt41FOZ6pPrTFOW1Uccp+2p8oPXlFxidcsjrfkDV7XU1K3Oc4w x0XKxHxBxap77EgvpKSs96ITtVJTEPTwTIKb/eRFvFAuy7gnbZBZYaE1UMf6/qZJNm8Q hK7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version; bh=elzthgTR8uCSjEsUyMhWwHfIwn4bvd20UhDWwVdXICs=; b=dZaihgFo7vNXTY15po/0xOPay6/GGSXiKyo77ym5VKgaIu9D5VYhW+6I72D+CghcTG geHh3dbrE9c467zGPd2GKXCIS+6IoAq9GCsfIR/83AIqUC8CIgi5XjwUzOv8UaRs2OoM wnR8uZzqQq3i70LpaOzv+8WK5oBjixd/uB35WBx++QfGyHO++sR31KuNLN7KbJrbGjMh A5KKUuNQUz7odcOmHVTYpRRDS6OewFmzAoMMrK5kpQDdKwHDpigwU06qUHYVv1AmmVIe FEPZ90cnbWRXwhZZHkqUdcPCE7/OhodB5B8+CGceuj1ASQby9iZJpGjWmPt/rsFe0KiC 7LCg== X-Gm-Message-State: AOPr4FWKu3qw0CkvmwX8jibrIyjq6Uwlmn01tIOSMHXp3VfYX2V6ubZ1Y6H/aXNQ98V9ow== X-Received: by 10.140.168.193 with SMTP id o184mr5259874qho.9.1461710935211; Tue, 26 Apr 2016 15:48:55 -0700 (PDT) Received: from ThinkPax ([172.98.67.78]) by smtp.gmail.com with ESMTPSA id g3sm318550qge.1.2016.04.26.15.48.54 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 26 Apr 2016 15:48:54 -0700 (PDT) Date: Tue, 26 Apr 2016 18:48:52 -0400 From: Etienne Prud'homme To: bug-gnu-emacs@gnu.org Subject: [PATCH] Support completion of color functions in CSS mode Message-ID: <20160426184852.391f744d@ThinkPax> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_//T.h_DihfLd+AlsUkx73sJ9" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --MP_//T.h_DihfLd+AlsUkx73sJ9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline The attached patch adds completion for CSS color functions such as `rgb()'. Values were taken from the =E2=80=9CCSS Color Module Level 4=E2=80= =9D. It can be found at: https://drafts.csswg.org/css-color/#color-type As a sidenote, how should we handle functions? Since they use parentheses, the point is going to be outside of parentheses. Eg. rgba()* ^(point) Also, should we include the parameters number? --MP_//T.h_DihfLd+AlsUkx73sJ9 Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-Add-completion-of-color-functions-in-CSS-mode.patch >From 52cc18080206fcd0d154a6c75c458a39bdcdfcbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Etienne=20Prud=E2=80=99homme?= Date: Tue, 26 Apr 2016 18:44:08 -0400 Subject: [PATCH] Add completion of color functions in CSS mode * lisp/textmodes/css-mode.el (css-value-class-alist): Add CSS color functions as candidates for color values. --- lisp/textmodes/css-mode.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index e30fb3e..78d4736 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -463,7 +463,8 @@ further value candidates, since that list would be infinite.") (color "aqua" "black" "blue" "fuchsia" "gray" "green" "lime" "maroon" "navy" "olive" "orange" "purple" "red" "silver" "teal" "white" - "yellow" "transparent") + "yellow" "transparent" color-functions) + (color-functions "color-mod()" "device-cmyk()" "gray()" "hsl()" "hsla()" "hwb()" "rgb()" "rgba()") (common-lig-values "common-ligatures" "no-common-ligatures") (contextual-alt-values "contextual" "no-contextual") (counter "counter()" "counters()") -- 2.8.1 --MP_//T.h_DihfLd+AlsUkx73sJ9-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 19:54:37 2016 Received: (at control) by debbugs.gnu.org; 26 Apr 2016 23:54:37 +0000 Received: from localhost ([127.0.0.1]:49190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avCoP-0001AV-5r for submit@debbugs.gnu.org; Tue, 26 Apr 2016 19:54:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avCoN-0001AJ-Qe for control@debbugs.gnu.org; Tue, 26 Apr 2016 19:54:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avCoH-0005JB-SG for control@debbugs.gnu.org; Tue, 26 Apr 2016 19:54:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avCoH-0005J6-Or for control@debbugs.gnu.org; Tue, 26 Apr 2016 19:54:29 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1avCoH-0004Oe-DJ for control@debbugs.gnu.org; Tue, 26 Apr 2016 19:54:29 -0400 Subject: control message for bug 23384 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 26 Apr 2016 19:54:29 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) merge 23383 23384 severity 23384 wishlist From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 15:17:08 2016 Received: (at 23383) by debbugs.gnu.org; 27 Apr 2016 19:17:08 +0000 Received: from localhost ([127.0.0.1]:50600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avUxQ-0007HP-Ay for submit@debbugs.gnu.org; Wed, 27 Apr 2016 15:17:08 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:33513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avUxP-0007DC-4l for 23383@debbugs.gnu.org; Wed, 27 Apr 2016 15:17:07 -0400 Received: by mail-lf0-f42.google.com with SMTP id y84so60915790lfc.0 for <23383@debbugs.gnu.org>; Wed, 27 Apr 2016 12:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=lNNfhgB6Q0BsuR/dGekv1gwguVNeQfdupUxJqHEk0gs=; b=fWb86cyQ/b+Ce/pJTp3oo8stOPqKQ7rUubNHdsmeGDfB/lL5baQofy8L/Pu8Z7t90F yLGtYUa26zFu4s9qEuXAkceuUBUJg6+emNLWEwgIie/HcnNRSVaHLsjoz1+ieqdtB8y8 2NgRddDqnRhGrWH00oeDviMW1Ht1Qq/U+6fJIVB3/AtdczvzrG7lPhzCa/mon9ZP2raH 9HBlcc+a48b3kxM4WoBS3V2WKqxfAnPeEm8wCvv9cUKXZSL8AIqEt9BMLpZLNMq97icq hX2q3BKe18l1ZgDAaJMHhjH1Xi0QPfP+EoRqskYFYk/UoVxka0YPXxQKbgTHbMbOREM1 2CJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=lNNfhgB6Q0BsuR/dGekv1gwguVNeQfdupUxJqHEk0gs=; b=kc/Xe6AZFKtBUZCat4liOVlQBCif1KQ8ozCQiADyEmR87E6lDr9OVQ2WE4/6NW02r4 R53Yfj5xzZ8Ftl14TOol0JWPQBsq8cuFSObyknrd5NYMK6z5y5ZJvWhe4z8JWjqzy0I2 R/Zy358cT4Vgb5Y5Mod0iGof04bt8MYaOOJE7pZNLJdQe6TmyzO/C7Y1Wx8A3M3Bk6j1 nbb/QXwBvHOfjiDJGkUzWkf8HdyJhGTvraSFNGAZ4bOKBPBXRTIGbFrS3rcFgxsqalKR iZvv/kHiNL4WaoF3Jooy1JZUOpmR/NIsKQLBj1/LkeIviILVFfaGRd5VxS3fbGzaPR/d qWEQ== X-Gm-Message-State: AOPr4FUOD30hT/mfhSra+umWE4732DWMWHRq/jCWDKOE95TrupVpQDA/y06kIW8+2SzrIw== X-Received: by 10.112.125.201 with SMTP id ms9mr4391645lbb.141.1461784621179; Wed, 27 Apr 2016 12:17:01 -0700 (PDT) Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id i6sm1049574lbc.8.2016.04.27.12.16.59 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Apr 2016 12:17:00 -0700 (PDT) Date: Wed, 27 Apr 2016 21:16:58 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#23383: [PATCH] Support completion of color functions in CSS mode To: Etienne Prud'homme Message-Id: <1461784618.2119.2@smtp.gmail.com> In-Reply-To: <20160426184852.391f744d@ThinkPax> References: <20160426184852.391f744d@ThinkPax> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-bAzn4TZ5KABmMhM0F4Yq" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23383 Cc: 23383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-bAzn4TZ5KABmMhM0F4Yq Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hello Etienne, thanks for the patch. On Wed, Apr 27, 2016 at 12:48 AM, Etienne Prud'homme=20 wrote: > The attached patch adds completion for CSS color functions such as > `rgb()'. Values were taken from the =E2=80=9CCSS Color Module Level 4=E2= =80=9D.=20 > It can > be found at: https://drafts.csswg.org/css-color/#color-type It will be nice to have completion for those new color functions. Some feedback regarding the patch follows. - In the completion definitions we've tried to stay as close as possible to the structure used in the CSS spec. This means that instead of introducing `color-functions' we should make `color' complete directly to "rgb()", "rgba()", and so on, then `hex-color', `named-color' and the literal `currentcolor' (I think we can skip `deprecated-system-color'). `named-color' will then contain the literal color names like `color' does now. - One of the tests in test/lisp/textmodes/css-mode-tests.el needs updating. To see this, run `make lisp/textmodes/css-mode-tests' from the test directory. - Please wrap lines around column 70 or so to stay in line with the rest of the file. > As a sidenote, how should we handle functions? Since they use > parentheses, the point is going to be outside of parentheses. >=20 > Eg. > rgba()* > ^(point) True, I'm not sure how to best solve it. > Also, should we include the parameters number? I think that's rather a job for something like ElDoc (I'm currently working on adding ElDoc support to CSS mode). -- Simen = --=-bAzn4TZ5KABmMhM0F4Yq Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Etienne, thanks for the patch.

On Wed, Apr 27, 2016 at 12:48 A= M, Etienne Prud'homme <e.e.f.prudhomme@gmail.com> wrote:
The attached patch adds completion for CSS color functions such as `rgb()'. Values were taken from the =E2=80=9CCSS Color Module Level 4=E2=80= =9D. It can be found at: htt= ps://drafts.csswg.org/css-color/#color-type

=
It will be nice to have completion for those new color func= tions. Some
feedback regarding the patch follows.

<= /div>
- In the completion definitions we've tried to stay as close as p= ossible
  to the structure used in the CSS spec. This means = that instead of
  introducing `color-functions' we should ma= ke `color' complete directly
  to "rgb()", "rgba()", and so = on, then `hex-color', `named-color' and
  the literal `curre= ntcolor' (I think we can skip
  `deprecated-system-color'). = `named-color' will then contain the
  literal color names li= ke `color' does now.

- One of the tests in test/li= sp/textmodes/css-mode-tests.el needs
  updating. To see this= , run `make lisp/textmodes/css-mode-tests' from
  the test d= irectory.

- Please wrap lines around column 70 or = so to stay in line with the rest
  of the file.
<= br>
As a sidenote, how should we handle functions? Since they use parentheses, the point is going to be outside of parentheses. Eg. rgba()* ^(point)

True, I'm not sure how= to best solve it.

Also, should we include the parameters= number?

I think that's rather a job for so= mething like ElDoc (I'm currently
working on adding ElDoc support= to CSS mode).

-- Simen
= --=-bAzn4TZ5KABmMhM0F4Yq-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 20:17:56 2016 Received: (at 23383) by debbugs.gnu.org; 28 Apr 2016 00:17:56 +0000 Received: from localhost ([127.0.0.1]:50989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avZeW-0007Mp-I5 for submit@debbugs.gnu.org; Wed, 27 Apr 2016 20:17:56 -0400 Received: from mail-qg0-f65.google.com ([209.85.192.65]:34052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avZeV-0007Ma-20 for 23383@debbugs.gnu.org; Wed, 27 Apr 2016 20:17:55 -0400 Received: by mail-qg0-f65.google.com with SMTP id d90so4385102qgd.1 for <23383@debbugs.gnu.org>; Wed, 27 Apr 2016 17:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=/ArLKwb34588CC4sR1Z/y4B9rglqoF4og2geLUtnJCs=; b=HmpEUrE2HiJvghpoiF4u0tnbdB1jqQyb+5Cb2h+V27cq4F8TtZlxjQ3gXpSe000nxe ipZW/hB5B/sCjKgN4MU7JU7brDkyCnO1TUR7jDUsA2aCeuAITIwe7qNCjKNJqfUs9BzU ndqGGUjxU3JJGwoHHb5t87TE3ungeziJHHJbieb1ApKy3pGNmd01i1wFouFjNYiav1MK u9sENIQVutxJdJT8/alT1Lz/m2gHwIUgBnrEum5gwSzB8cpl2nFjCj5EnaXJbniKhkL5 tNnZPuRpB8O1ceQ57rGkqY1GsmU3if/uYCNXUkfRJKhNr5BpbZO1/6LyjEBJVKqEam4R CaVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=/ArLKwb34588CC4sR1Z/y4B9rglqoF4og2geLUtnJCs=; b=Kji2oyFP2czHXDTM35M8lkIOWOFUi/+D4VsEB/VNrKOtUtXyS98T5f3U5ERiPVRnVw cr1CaZWbK67H6SXUwyCJVSm3Gd4klLgN6TwyWLm2RUbAbSMduvO1crbCQlqGnUM75rLz vC4PLBGHbdLxaPD5GFMyG7jhvyh47UduAo9iQcI/ji6WngauPZrPgj4uEj0rF7je11Ql KmXnwfLycDOWzN9tnEZYwDRn6FZ+f1mRLuhLbl4CQ1PakgflSNoB3YYMCbEczPHY3RP2 KO2HgnvU6cZuoBZFIkt8fmM6fF7UOHdtW7+9YIZhE0p1edY9UVjVyWkOcAiwOYaXhrsv n1sQ== X-Gm-Message-State: AOPr4FX34+/kkSdjFRwYIaSXXPf5xfHdcc+q/wJFNGg+HQUHlfOreExyxMJBiL0cBLojlw== X-Received: by 10.140.105.182 with SMTP id c51mr11423524qgf.78.1461802669741; Wed, 27 Apr 2016 17:17:49 -0700 (PDT) Received: from ThinkPax ([172.98.67.125]) by smtp.gmail.com with ESMTPSA id p143sm2003816qke.38.2016.04.27.17.17.49 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 27 Apr 2016 17:17:49 -0700 (PDT) Date: Wed, 27 Apr 2016 20:17:45 -0400 From: Etienne Prud'homme To: Simen =?UTF-8?B?SGVnZ2VzdMO4eWw=?= Subject: Re: bug#23383: [PATCH] Support completion of color functions in CSS mode Message-ID: <20160427201745.09dd0967@ThinkPax> In-Reply-To: <1461784618.2119.2@smtp.gmail.com> References: <20160426184852.391f744d@ThinkPax> <1461784618.2119.2@smtp.gmail.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/9t8pmh3We4OimSnoL0NV1CA" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23383 Cc: 23383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --MP_/9t8pmh3We4OimSnoL0NV1CA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wed, 27 Apr 2016 21:16:58 +0200, Simen Heggest=C3=B8yl wrote: > - In the completion definitions we've tried to stay as close as > possible to the structure used in the CSS spec. This means that > instead of introducing `color-functions' we should make `color' > complete directly to "rgb()", "rgba()", and so on, then `hex-color', > `named-color' and the literal `currentcolor' (I think we can skip > `deprecated-system-color'). `named-color' will then contain the > literal color names like `color' does now. That=E2=80=99s a good point. Since I saw that `color' lacked most of them, I wasn=E2=80=99t sure where we were going. > - One of the tests in test/lisp/textmodes/css-mode-tests.el needs > updating. To see this, run `make lisp/textmodes/css-mode-tests' from > the test directory. >=20 > - Please wrap lines around column 70 or so to stay in line with the > rest of the file. Thanks for reminding me! I completely forgot. Much easier to read. I=E2=80=99ve made a second patch according to your recommendations. Color functions are now part of `color' and `named-color' is now a separate entity. I=E2=80=99ve tried to follow CSSWG ordering, but it=E2=80=99s not a= lways the same order in the specifications. I also found two more functions not present earlier. --MP_/9t8pmh3We4OimSnoL0NV1CA Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-Add-completion-of-colors-in-CSS-mode.patch >From 3e000ab30b3c6a4cd8cc1f76bd98c5f7c5aa0c30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Etienne=20Prud=E2=80=99homme?= Date: Wed, 27 Apr 2016 19:52:28 -0400 Subject: [PATCH] Add completion of colors in CSS mode * lisp/textmodes/css-mode.el (css-value-class-alist): Add CSS colors candidates from "CSS Color Module Level 4". --- lisp/textmodes/css-mode.el | 38 ++++++++++++++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index e30fb3e..3b795fd 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -460,10 +460,9 @@ css-value-class-alist (bg-layer bg-image position repeat-style attachment box) (bg-size length percentage "auto" "cover" "contain") (box "border-box" "padding-box" "content-box") - (color - "aqua" "black" "blue" "fuchsia" "gray" "green" "lime" "maroon" - "navy" "olive" "orange" "purple" "red" "silver" "teal" "white" - "yellow" "transparent") + (color "rgb()" "rgba()" "hsl()" "hsla()" "hwb()" "gray()" "lab()" + "lch()" "device-cmyk()" "color-mod()" "#" namedColor + "transparent" "currentColor") (common-lig-values "common-ligatures" "no-common-ligatures") (contextual-alt-values "contextual" "no-contextual") (counter "counter()" "counters()") @@ -502,6 +501,37 @@ css-value-class-alist (line-width length "thin" "medium" "thick") (linear-gradient "linear-gradient()") (margin-width "auto" length percentage) + (named-color + "aliceblue" "antiquewhite" "aqua" "aquamarine" "azure" "beige" + "bisque" "black" "blanchedalmond" "blue" "blueviolet" "brown" + "burlywood" "cadetblue" "chartreuse" "chocolate" "coral" + "cornflowerblue" "cornsilk" "crimson" "cyan" "darkblue" + "darkcyan" "darkgoldenrod" "darkgray" "darkgreen" "darkgrey" + "darkkhaki" "darkmagenta" "darkolivegreen" "darkorange" + "darkorchid" "darkred" "darksalmon" "darkseagreen" + "darkslateblue" "darkslategray" "darkslategrey" "darkturquoise" + "darkviolet" "deeppink" "deepskyblue" "dimgray" "dimgrey" + "dodgerblue" "firebrick" "floralwhite" "forestgreen" "fuchsia" + "gainsboro" "ghostwhite" "gold" "goldenrod" "gray" "green" + "greenyellow" "grey" "honeydew" "hotpink" "indianred" "indigo" + "ivory" "khaki" "lavender" "lavenderblush" "lawn reen" + "lemonchiffon" "lightblue" "lightcoral" "lightcyan" + "lightgoldenrodyellow" "lightgray" "lightgreen" "lightgrey" + "lightpi k" "lightsalmon" "lightseagreen" "lightskyblue" + "lightslategray" "lightslategrey" "lightsteelblue" "lightyellow" + "lime" "limeg een" "linen" "magenta" "maroon" "mediumaquamarine" + "mediumblue" "mediumorchid" "mediumpurple" "mediumseagreen" + "mediumslateblu " "mediumspringgreen" "mediumturquoise" + "mediumvioletred" "midnightblue" "mintcream" "mistyrose" + "moccasin" "navajowhite" "nav " "oldlace" "olive" "olivedrab" + "orange" "orangered" "orchid" "palegoldenrod" "palegreen" + "paleturquoise" "palevioletred" "pap yawhip" "peachpuff" "peru" + "pink" "plum" "powderblue" "purple" "rebeccapurple" "red" + "rosybrown" "royalblue" "saddlebrown" "sa mon" "sandybrown" + "seagreen" "seashell" "sienna" "silver" "skyblue" "slateblue" + "slategray" "slategrey" "snow" "springgreen" " teelblue" "tan" + "teal" "thistle" "tomato" "turquoise" "violet" "wheat" "white" + "whitesmoke" "yellow" "yellowgreen") (number "calc()") (numeric-figure-values "lining-nums" "oldstyle-nums") (numeric-fraction-values "diagonal-fractions" "stacked-fractions") -- 2.8.1 --MP_/9t8pmh3We4OimSnoL0NV1CA-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 28 13:51:48 2016 Received: (at 23383) by debbugs.gnu.org; 28 Apr 2016 17:51:48 +0000 Received: from localhost ([127.0.0.1]:53539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avq6N-0002EH-Un for submit@debbugs.gnu.org; Thu, 28 Apr 2016 13:51:48 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:36441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avq6M-0002Dz-7m for 23383@debbugs.gnu.org; Thu, 28 Apr 2016 13:51:46 -0400 Received: by mail-lf0-f47.google.com with SMTP id u64so92583693lff.3 for <23383@debbugs.gnu.org>; Thu, 28 Apr 2016 10:51:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=dqWSe0SU+SmYUsbwdRZ6OXomhrmz978F82eD/PRUni8=; b=KRkhniSFzZ9wSFH4IJL9ZTvx/N/kPB4Utfy0urbYPH1HMhJd70PC0CPSAs8c3M2va4 a+Z7dpl6pVvGgi0nNuzALC5LYF+w3QZcBAdD2z09+UNFlc3G0zNOp4c3mXpr7Ju3fBun vzIBAv+bziY0uWYOgXfAB+zQBUgn9WzP6/sZXo7Ecqw3aIYAVh5YlAZnH6lYuBtLW9F7 hI2MJDBjyxGV7CrLc8BtD159YFsFpH/C2IcKnJNABCw2S6ocvzw5C/LeLwYl6qIsNTHZ bc9oV93LknJSjvszjvDpcD2yM/5uIZcotSj6lmnLNdnfHdeEegrlAflBqIv/Uhf7QKc7 JBlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=dqWSe0SU+SmYUsbwdRZ6OXomhrmz978F82eD/PRUni8=; b=FVqZhvI2+rRUoKCErjsV7PtHsmlB9lO2yJyd0HNG6xGAmS0VEZBmuquofBZm4tRhRX YL5InGPQrSMP4N4ktdn/fWJ8fe6qXsZ2RgIVHvmA2qACNkn6OupqWh1UaLJY+c+j753g +Jk74OUYI3uF6zFFu/GU6ucPo7l3NUtjsyRt0Eoz0kTHG1bDhHLSEsanX2xuZ1YEmtj5 fI+rrYMuE1aof9l3n3yM36dKhWPUZaNLPy/F+VtCAX0fa4DKlQb3cOrrH4ffSM1CfHom 0zniObb9X+CMips07Bp2DW2rFiinVwM7/0XCANhzanR6YAdol+Pg1pXdB0n2BHfZ7K09 9Y/Q== X-Gm-Message-State: AOPr4FWg8nh4HtUJ1RGaVOVWm2RlLof82SYvjV13H2nvCrViXUMqmcLl0fO2KhExyvFkRw== X-Received: by 10.25.18.102 with SMTP id h99mr6888827lfi.127.1461865900243; Thu, 28 Apr 2016 10:51:40 -0700 (PDT) Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id mz2sm1832952lbb.18.2016.04.28.10.51.38 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Apr 2016 10:51:39 -0700 (PDT) Date: Thu, 28 Apr 2016 19:51:37 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#23383: [PATCH] Support completion of color functions in CSS mode To: Etienne Prud'homme Message-Id: <1461865897.9211.0@smtp.gmail.com> In-Reply-To: <20160427201745.09dd0967@ThinkPax> References: <20160426184852.391f744d@ThinkPax> <1461784618.2119.2@smtp.gmail.com> <20160427201745.09dd0967@ThinkPax> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-hNYYvTG/5IjE3bzLECIV" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23383 Cc: 23383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-hNYYvTG/5IjE3bzLECIV Content-Type: text/plain; charset=utf-8; format=flowed Thanks for the revision, Etienne. There are still a couple of issues that need to be resolved. - I think we should stick to the current CSS Color Module Level 3 recommendation [1]. The functions apart from `rgb()', `rgba()', `hsl()', and `hsla()' are only present in an Editor's Draft. I find no other resources about them, so I don't think we should include them until the new spec becomes at least a Candidate Recommendation. - I think there's little use in completing `#' since it's only one character. - `namedColor' must be changed to `named-color' to match the name of the value class. - The new color names need to be double-checked. For instance I see that `limegreen' has become `limeg een' and `salmon' has become `sa mon'. - The test `css-test-property-values' in test/lisp/textmodes/css-mode-tests.el needs a small update. [1] https://www.w3.org/TR/css3-color/ -- Simen --=-hNYYvTG/5IjE3bzLECIV Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Thanks for the revision, Etienne.

There are s= till a couple of issues that need to be resolved.

= - I think we should stick to the current CSS Color Module Level 3
  recommendation [1]. The functions apart from `rgb()', `rgba()',
  `hsl()', and `hsla()' are only present in an Editor's Draft. = I find no
  other resources about them, so I don't think we = should include them
  until the new spec becomes at least a = Candidate Recommendation.

- I think there's little= use in completing `#' since it's only one
  character.

- `namedColor' must be changed to `named-color' to mat= ch the name of the
  value class.

-= The new color names need to be double-checked. For instance I see that
  `limegreen' has become `limeg een' and `salmon' has become `s= a mon'.

- The test `css-test-property-values' in
  test/lisp/textmodes/css-mode-tests.el needs a small update.=


-- Simen

= --=-hNYYvTG/5IjE3bzLECIV-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 20 15:37:38 2016 Received: (at 23383) by debbugs.gnu.org; 20 May 2016 19:37:38 +0000 Received: from localhost ([127.0.0.1]:59349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3qEs-0000XW-83 for submit@debbugs.gnu.org; Fri, 20 May 2016 15:37:38 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:36254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b3qEq-0000XJ-IP for 23383@debbugs.gnu.org; Fri, 20 May 2016 15:37:37 -0400 Received: by mail-qk0-f174.google.com with SMTP id x7so72863274qkd.3 for <23383@debbugs.gnu.org>; Fri, 20 May 2016 12:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=DK7spjmjiUJ/OCwAa06poUzeVRxn4U0uLpWlcnyOQas=; b=S0P274ASkWDi0R+SywaMZxPykqFTFaZuKAwsZsvXKaNMVc1XaHgcWJ/GMJa/OLBIAJ gKVB26yudb/tTVVbcPQug6ksfeCDUDo0zwJpib+PFPr4sHwnnwodVm1LmP6CNrYfBe0H IjfsEVQ62SZ47JrFPUWYyqfSC1ZL5FDkzLIBFXshE+fZ2d7B240JM4IyxnGlG74a6MXb th2eGKZyhlD008ZLDaJRoe3Z3Cn6FXI0s2u3xzMvKYSzGYc1661GIYoBNhd8IDOwUuEE oGS3Beid9pbcpfT2526O0zvHcbTUVITxSqjs3HtRUK53ZAh+KGvhoIyGq1n2yPv+dRTn rrfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=DK7spjmjiUJ/OCwAa06poUzeVRxn4U0uLpWlcnyOQas=; b=jtx2T40HOeMm5XH+3hZZ6J/u1NE1Itmks6/idJ0lQoDyeuC2NjJaXbH+4DbGBFtZ8j iCh/1vzlMJoF+YkmuLocZM3haSahIvsjn5KIEBsx2dtitwrkiPnp3q5sMCMLBpxP1fqV mKk4kPes98XfkFPHs2+i9oDA6EiGBG/YskQxPG595WXiyWtwdBYgoiA3fvSdV5xkAZ7h Dp8Z/p5az+waAYBqcIKc3nj1jJMgG2CG3V43Wxp9zvK7hEIvz4dDxscVifk5VYHiSufi 5hDWyprnlGP7fKMid/JxOWn6P67oureHK/b1j+grXKq9UZiHuwyEKRzKj239fvXTAm3J gWWw== X-Gm-Message-State: AOPr4FX+0S5CZhfObZxTujQGkF+dQU4UapZen0vE70uEkU6sBsFsfQ+ZQhLiFS0RWaVFMA== X-Received: by 10.55.82.195 with SMTP id g186mr5486092qkb.47.1463773050990; Fri, 20 May 2016 12:37:30 -0700 (PDT) Received: from thinkpax (modemcable048.82-20-96.mc.videotron.ca. [96.20.82.48]) by smtp.gmail.com with ESMTPSA id a123sm9439922qkc.23.2016.05.20.12.37.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 May 2016 12:37:30 -0700 (PDT) Date: Fri, 20 May 2016 15:37:28 -0400 From: Etienne Prud'homme To: Simen =?UTF-8?B?SGVnZ2VzdMO4eWw=?= Subject: Re: bug#23383: [PATCH] Support completion of color functions in CSS mode Message-ID: <20160520153728.612ac2bd@thinkpax> In-Reply-To: <1461865897.9211.0@smtp.gmail.com> References: <20160426184852.391f744d@ThinkPax> <1461784618.2119.2@smtp.gmail.com> <20160427201745.09dd0967@ThinkPax> <1461865897.9211.0@smtp.gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/TptRt3N6XE4GhSjbKZUX4/V" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23383 Cc: 23383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --MP_/TptRt3N6XE4GhSjbKZUX4/V Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline I've attached the current patch. > - I think we should stick to the current CSS Color Module Level 3 > recommendation [1]. The functions apart from `rgb()', `rgba()', > `hsl()', and `hsla()' are only present in an Editor's Draft. I find > no other resources about them, so I don't think we should include them > until the new spec becomes at least a Candidate Recommendation. Thanks. I didn't realize the high probability most of them won't be in the recommendation > - I think there's little use in completing `#' since it's only one > character. I was also thinking the same thing. I interpreted: "and so on, then `hex-color'" too literally. > - `namedColor' must be changed to `named-color' to match the name of > the value class. Thanks for pointing that out. > - The new color names need to be double-checked. For instance I see > that `limegreen' has become `limeg een' and `salmon' has become `sa > mon'. I made the list with a macro. I was too tired to double check 140 colors. The current list was generated from Dough Crockford's color list [1] using: | var list = ""; | for(var i=0, len=colors.length; i - The test `css-test-property-values' in > test/lisp/textmodes/css-mode-tests.el needs a small update. I updated the list length to 147 since there's 141 namedColors and 6 values in color. However, I can't make the test execute since my Git repository is broken and the remote doesn't work as of now. Thanks for your patience. [1] http://www.crockford.com/wrrrld/color.html [2] https://en.wikipedia.org/wiki/IIFE Etienne --MP_/TptRt3N6XE4GhSjbKZUX4/V Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-Add-completion-of-colors-in-CSS-mode.patch >From 3e000ab30b3c6a4cd8cc1f76bd98c5f7c5aa0c30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Etienne=20Prud=E2=80=99homme?= Date: Wed, 27 Apr 2016 19:52:28 -0400 Subject: [PATCH] Add completion of colors in CSS mode * lisp/textmodes/css-mode.el (css-value-class-alist): Add CSS colors candidates from "CSS Color Module Level 4". --- lisp/textmodes/css-mode.el | 38 ++++++++++++++++++++++++++++++++++---- 1 file changed, 34 insertions(+), 4 deletions(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index e30fb3e..3b795fd 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -460,10 +460,9 @@ css-value-class-alist (bg-layer bg-image position repeat-style attachment box) (bg-size length percentage "auto" "cover" "contain") (box "border-box" "padding-box" "content-box") - (color - "aqua" "black" "blue" "fuchsia" "gray" "green" "lime" "maroon" - "navy" "olive" "orange" "purple" "red" "silver" "teal" "white" - "yellow" "transparent") + (color "rgb()" "rgba()" "hsl()" "hsla()" "hwb()" "gray()" "lab()" + "lch()" "device-cmyk()" "color-mod()" "#" namedColor + "transparent" "currentColor") (common-lig-values "common-ligatures" "no-common-ligatures") (contextual-alt-values "contextual" "no-contextual") (counter "counter()" "counters()") @@ -502,6 +501,37 @@ css-value-class-alist (line-width length "thin" "medium" "thick") (linear-gradient "linear-gradient()") (margin-width "auto" length percentage) + (named-color + "aliceblue" "antiquewhite" "aqua" "aquamarine" "azure" "beige" + "bisque" "black" "blanchedalmond" "blue" "blueviolet" "brown" + "burlywood" "cadetblue" "chartreuse" "chocolate" "coral" + "cornflowerblue" "cornsilk" "crimson" "cyan" "darkblue" + "darkcyan" "darkgoldenrod" "darkgray" "darkgreen" "darkgrey" + "darkkhaki" "darkmagenta" "darkolivegreen" "darkorange" + "darkorchid" "darkred" "darksalmon" "darkseagreen" + "darkslateblue" "darkslategray" "darkslategrey" "darkturquoise" + "darkviolet" "deeppink" "deepskyblue" "dimgray" "dimgrey" + "dodgerblue" "firebrick" "floralwhite" "forestgreen" "fuchsia" + "gainsboro" "ghostwhite" "gold" "goldenrod" "gray" "green" + "greenyellow" "grey" "honeydew" "hotpink" "indianred" "indigo" + "ivory" "khaki" "lavender" "lavenderblush" "lawn reen" + "lemonchiffon" "lightblue" "lightcoral" "lightcyan" + "lightgoldenrodyellow" "lightgray" "lightgreen" "lightgrey" + "lightpi k" "lightsalmon" "lightseagreen" "lightskyblue" + "lightslategray" "lightslategrey" "lightsteelblue" "lightyellow" + "lime" "limeg een" "linen" "magenta" "maroon" "mediumaquamarine" + "mediumblue" "mediumorchid" "mediumpurple" "mediumseagreen" + "mediumslateblu " "mediumspringgreen" "mediumturquoise" + "mediumvioletred" "midnightblue" "mintcream" "mistyrose" + "moccasin" "navajowhite" "nav " "oldlace" "olive" "olivedrab" + "orange" "orangered" "orchid" "palegoldenrod" "palegreen" + "paleturquoise" "palevioletred" "pap yawhip" "peachpuff" "peru" + "pink" "plum" "powderblue" "purple" "rebeccapurple" "red" + "rosybrown" "royalblue" "saddlebrown" "sa mon" "sandybrown" + "seagreen" "seashell" "sienna" "silver" "skyblue" "slateblue" + "slategray" "slategrey" "snow" "springgreen" " teelblue" "tan" + "teal" "thistle" "tomato" "turquoise" "violet" "wheat" "white" + "whitesmoke" "yellow" "yellowgreen") (number "calc()") (numeric-figure-values "lining-nums" "oldstyle-nums") (numeric-fraction-values "diagonal-fractions" "stacked-fractions") -- 2.8.1 --MP_/TptRt3N6XE4GhSjbKZUX4/V-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 06:42:28 2016 Received: (at 23383) by debbugs.gnu.org; 21 May 2016 10:42:28 +0000 Received: from localhost ([127.0.0.1]:59547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b44MW-0005KS-5y for submit@debbugs.gnu.org; Sat, 21 May 2016 06:42:28 -0400 Received: from mail-lf0-f46.google.com ([209.85.215.46]:33006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b44MV-0005KD-F2 for 23383@debbugs.gnu.org; Sat, 21 May 2016 06:42:27 -0400 Received: by mail-lf0-f46.google.com with SMTP id e131so9352731lfb.0 for <23383@debbugs.gnu.org>; Sat, 21 May 2016 03:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=EBo4i1t16EuGYfa7We1W+ccHPy1glW5BhVf8trWqFlQ=; b=Z47xY4kLP+EWBKhMKmYoSBfDKo81YtMEqyCcpIIuO1YG7Dhq43TUZM9mGxhfBO9VK2 4fZIeyvcJ3TDbRiJAL9DwZJlraPUhpezy9alOa4e4TV/b3zA5Y5KM9fjBdeyYql5g62N uXx1kQWJ3f2SKsUYvhkGvQ1XNzKqj40bP8FRaYy1jLxMkYnHM3iQC55DP6b1JMjzdNp8 D+/Y6x5H4KqUh2BHSKrE1+Qjxjunuj3dafKrSJPVXHC/gRplJXtqry19+2g9U5p/Ahtf C/LS7724pMMFERe8kCFDSvRuOeLmzD0YBdGudgIGaure925ZO2a+g35nBwGngNQBHwDf wEBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=EBo4i1t16EuGYfa7We1W+ccHPy1glW5BhVf8trWqFlQ=; b=S4jaxFYyJ5/b2mKIL7B5fGSV+Mt2XVF6OTHeqETI1u8H6t66NOGdOy2/0kIVvcuujR a0Djm+tPKrX3KrC8xAhejMZwJFObg3CF8BYG7EsjFvU6IlFVh/+FPGbZn/nQtUtvUGT9 BOz16KhWAtOETxjtzVnSaEOTOoMRAFdStC0kD+x+HkK2WS8KFCe0um3kIiLPZVDv+9NJ tfrhdaBgH8Xz5FXDgLb92F230mS/IDpS2LwGCIogt1/qqAQ8hiuT/uZlqGEnNS8SGpwW QxDd5VfkXDtzdpzdf6H8j1EQyUCT2FGIpX0gXCl7aQQORGmqNb36aAXx54YplY03i+jp Cdew== X-Gm-Message-State: AOPr4FXA5zMdxwpFyy3ZjVkKB/RtfT27BkyTtutrZgBt1iFm8iA9E3J36LRv7Owtze17sw== X-Received: by 10.25.22.89 with SMTP id m86mr2744475lfi.25.1463827341360; Sat, 21 May 2016 03:42:21 -0700 (PDT) Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id qi4sm3887900lbb.9.2016.05.21.03.42.20 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 21 May 2016 03:42:20 -0700 (PDT) Date: Sat, 21 May 2016 12:42:19 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#23383: [PATCH] Support completion of color functions in CSS mode To: Etienne Prud'homme Message-Id: <1463827339.3189.0@smtp.gmail.com> In-Reply-To: <20160520153728.612ac2bd@thinkpax> References: <20160426184852.391f744d@ThinkPax> <1461784618.2119.2@smtp.gmail.com> <20160427201745.09dd0967@ThinkPax> <1461865897.9211.0@smtp.gmail.com> <20160520153728.612ac2bd@thinkpax> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-599xFSvvJWGEq4oMVVys" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23383 Cc: 23383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-599xFSvvJWGEq4oMVVys Content-Type: text/plain; charset=utf-8; format=flowed On Fri, May 20, 2016 at 9:37 PM, Etienne Prud'homme wrote: > I've attached the current patch. Thank you, Etienne, but it looks like the wrong patch was attached. It is the same as the one from April. -- Simen --=-599xFSvvJWGEq4oMVVys Content-Type: text/html; charset=utf-8 On Fri, May 20, 2016 at 9:37 PM, Etienne Prud'homme <e.e.f.prudhomme@gmail.com> wrote:
I've attached the current patch.

Thank you, Etienne, but it looks like the wrong patch was attached. It
is the same as the one from April.

-- Simen
--=-599xFSvvJWGEq4oMVVys-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 21 18:43:37 2016 Received: (at 23383) by debbugs.gnu.org; 21 May 2016 22:43:37 +0000 Received: from localhost ([127.0.0.1]:60267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4FcP-0003X1-9M for submit@debbugs.gnu.org; Sat, 21 May 2016 18:43:37 -0400 Received: from mail-qk0-f175.google.com ([209.85.220.175]:35069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4FcO-0003Wm-8v for 23383@debbugs.gnu.org; Sat, 21 May 2016 18:43:36 -0400 Received: by mail-qk0-f175.google.com with SMTP id n62so77037096qkc.2 for <23383@debbugs.gnu.org>; Sat, 21 May 2016 15:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=vX6gfMlXKckLoX7k41TwtbyXJ6a3IggaA5L29oDC28E=; b=GjDX2cWYd5KRkJHzVkriEhXN3Qu3IBdhMU1vfOvJZR1yy5LFWknhO9BWoHnq4ZFnGF tgdUfqD6X6Ps86b017dOo8x5clyD8a51/szyWhoK+yjwlK9iuagVaS7FRCxv5W9dKMyw 5ZXKRsEhWjn+hrFePfnqwtFMQAfHY9BwJvCWwBiwDECD+bccaN9UqoCQ3mf9DYbtXskI Lb0tW70ZlFZ3+U6yLtx3CdBGHr2Q9IzWgfn9v8m9iyYqDNyCjKAdESbbYwynNcb2svut vaYx6UkK4VmFJB5Se/W4ZZI5kidoQMButAYWr47zB2jynw6uewBnAn1ORGRnagH51nCr /bJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=vX6gfMlXKckLoX7k41TwtbyXJ6a3IggaA5L29oDC28E=; b=Rk/JMNA+gtmZu+YDbXq0a6GNClGWEmpnF26cLRNkVcN+G/ZZeddQjBOLOhUIY360ta 91ghdcqUFqOmZ00BlZDOF2myDupd5y/6JZVIQMZkbsNZ7y7C6m6EeB7zVEGx36mlzpsC Hk9ryNgeeeTISNxMRVfNVrhBjnYCCGWuPjGOhB3Ke4I85EWrJsXjW0L28R20gakb5Wgd 9gusItx2mz05Eq7toxAox23NtFTOsaYxDjgYq0BatpYn53bkyaTFVYehPrl9DvQs2yxo XQUNkJtIkCPOJmEXIjC2E46VIeFpnwUXQDH5ESgjn7e7rdMZS3rIDX9aoTH8SXbgeNE4 x1iQ== X-Gm-Message-State: AOPr4FUWd1/Vb7cfMGFPZR5s65pZ9umsuJloCnHJDONPDpGXPCqZJa/aRXt2bSX7Vd6bTw== X-Received: by 10.200.52.35 with SMTP id u32mr5693048qtb.8.1463870610867; Sat, 21 May 2016 15:43:30 -0700 (PDT) Received: from thinkpax (modemcable105.49-20-96.mc.videotron.ca. [96.20.49.105]) by smtp.gmail.com with ESMTPSA id b77sm10921027qha.8.2016.05.21.15.43.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 May 2016 15:43:30 -0700 (PDT) Date: Sat, 21 May 2016 18:43:28 -0400 From: Etienne Prud'homme To: Simen =?UTF-8?B?SGVnZ2VzdMO4eWw=?= Subject: Re: bug#23383: [PATCH] Support completion of color functions in CSS mode Message-ID: <20160521184328.1779ac46@thinkpax> In-Reply-To: <1463827339.3189.0@smtp.gmail.com> References: <20160426184852.391f744d@ThinkPax> <1461784618.2119.2@smtp.gmail.com> <20160427201745.09dd0967@ThinkPax> <1461865897.9211.0@smtp.gmail.com> <20160520153728.612ac2bd@thinkpax> <1463827339.3189.0@smtp.gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/UokDFOXrraT7P41UVT//brX" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23383 Cc: 23383@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --MP_/UokDFOXrraT7P41UVT//brX Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline > Thank you, Etienne, but it looks like the wrong patch was attached. It > is the same as the one from April. Oops! I've attached the new patch now. Etienne --MP_/UokDFOXrraT7P41UVT//brX Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-Add-completion-of-colors-in-CSS-mode.patch >From 024683b111b1459c440da5a67582720b0d119457 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Etienne=20Prud=E2=80=99homme?= Date: Fri, 20 May 2016 14:10:46 -0400 Subject: [PATCH] Add completion of colors in CSS mode * lisp/textmodes/css-mode.el (css-value-class-alist): Add CSS colors from "CSS Color Module Level 3". --- lisp/textmodes/css-mode.el | 35 ++++++++++++++++++++++++++++++++--- test/lisp/textmodes/css-mode-tests.el | 2 +- 2 files changed, 33 insertions(+), 4 deletions(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index cf407ef..060af33 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -463,9 +463,8 @@ css-value-class-alist (bg-size length percentage "auto" "cover" "contain") (box "border-box" "padding-box" "content-box") (color - "aqua" "black" "blue" "fuchsia" "gray" "green" "lime" "maroon" - "navy" "olive" "orange" "purple" "red" "silver" "teal" "white" - "yellow" "transparent") + "rgb()" "rgba()" "hsl()" "hsla()" named-color "transparent" + "currentColor") (common-lig-values "common-ligatures" "no-common-ligatures") (contextual-alt-values "contextual" "no-contextual") (counter "counter()" "counters()") @@ -504,6 +503,36 @@ css-value-class-alist (line-width length "thin" "medium" "thick") (linear-gradient "linear-gradient()") (margin-width "auto" length percentage) + (named-color + "aliceblue" "antiquewhite" "aqua" "aquamarine" "azure" "beige" + "bisque" "black" "blanchedalmond" "blue" "blueviolet" "brown" + "burlywood" "cadetblue" "chartreuse" "chocolate" "coral" + "cornflowerblue" "cornsilk" "crimson" "cyan" "darkblue" + "darkcyan" "darkgoldenrod" "darkgray" "darkgreen" "darkkhaki" + "darkmagenta" "darkolivegreen" "darkorange" "darkorchid" + "darkred" "darksalmon" "darkseagreen" "darkslateblue" + "darkslategray" "darkturquoise" "darkviolet" "deeppink" + "deepskyblue" "dimgray" "dodgerblue" "firebrick" "floralwhite" + "forestgreen" "fuchsia" "gainsboro" "ghostwhite" "gold" + "goldenrod" "gray" "green" "greenyellow" "honeydew" "hotpink" + "indianred" "indigo" "ivory" "khaki" "lavender" "lavenderblush" + "lawngreen" "lemonchiffon" "lightblue" "lightcoral" "lightcyan" + "lightgoldenrodyellow" "lightgray" "lightgreen" "lightpink" + "lightsalmon" "lightseagreen" "lightskyblue" "lightslategray" + "lightsteelblue" "lightyellow" "lime" "limegreen" "linen" + "magenta" "maroon" "mediumaquamarine" "mediumblue" "mediumorchid" + "mediumpurple" "mediumseagreen" "mediumslateblue" + "mediumspringgreen" "mediumturquoise" "mediumvioletred" + "midnightblue" "mintcream" "mistyrose" "moccasin" "navajowhite" + "navy" "oldlace" "olive" "olivedrab" "orange" "orangered" + "orchid" "palegoldenrod" "palegreen" "paleturquoise" + "palevioletred" "papayawhip" "peachpuff" "peru" "pink" "plum" + "powderblue" "purple" "rebeccapurple" "red" "rosybrown" + "royalblue" "saddlebrown" "salmon" "sandybrown" "seagreen" + "seashell" "sienna" "silver" "skyblue" "slateblue" "slategray" + "snow" "springgreen" "steelblue" "tan" "teal" "thistle" "tomato" + "turquoise" "violet" "wheat" "white" "whitesmoke" "yellow" + "yellowgreen") (number "calc()") (numeric-figure-values "lining-nums" "oldstyle-nums") (numeric-fraction-values "diagonal-fractions" "stacked-fractions") diff --git a/test/lisp/textmodes/css-mode-tests.el b/test/lisp/textmodes/css-mode-tests.el index 80d678a..fd86fd2 100644 --- a/test/lisp/textmodes/css-mode-tests.el +++ b/test/lisp/textmodes/css-mode-tests.el @@ -58,7 +58,7 @@ ;; Check that the `color' property doesn't cause infinite recursion ;; because it refers to the value class of the same name. - (should (= (length (css--property-values "color")) 18))) + (should (= (length (css--property-values "color")) 147))) (ert-deftest css-test-property-value-cache () "Test that `css--property-value-cache' is in use." -- 2.7.4 --MP_/UokDFOXrraT7P41UVT//brX-- From debbugs-submit-bounces@debbugs.gnu.org Sun May 22 07:03:37 2016 Received: (at 23383-done) by debbugs.gnu.org; 22 May 2016 11:03:37 +0000 Received: from localhost ([127.0.0.1]:60391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4RAX-0005t7-Es for submit@debbugs.gnu.org; Sun, 22 May 2016 07:03:37 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:35035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4RAV-0005su-2U for 23383-done@debbugs.gnu.org; Sun, 22 May 2016 07:03:35 -0400 Received: by mail-lf0-f44.google.com with SMTP id e126so38197739lfg.2 for <23383-done@debbugs.gnu.org>; Sun, 22 May 2016 04:03:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=6QMPF1CO2n86OXgh3YmbiPdzOVTRm9SHEuH85giaoZc=; b=SFSU4Yv3lZ2uXPSVPwR+7j3li8CJ54LaBk3RaMuhHDxaitbUDgA/i9nsgs/WuPjpLZ CuSxACZq4K9ZxYss5RF1aRs/gMyaZlPcgWUukSvcxFhJDX+zM0Vd4tZrl8KcVv9D8aFH 8p2D5nJNk94fnB1KHPsf5QRV0VBrwi0eav1/ZWvYrUfJ51u1LwVtE5Q4U6f89sNItP4a MU94/2bGxzkESKL/m+v0sEGh+rprPIXE7lZXioHAQZOl5M/eKwdAEbYtGlbShm1vlwS7 OKDZn7bKfSBBq9UFLKOoDxoIE/HjTeT2kmke0rWI8/cdfp6+jWkcD+vxsztiZGFoUZGs M6Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=6QMPF1CO2n86OXgh3YmbiPdzOVTRm9SHEuH85giaoZc=; b=AfSLsRzluhOMM/UHUvrfy97t/kpOewcyCWqTzmmhjiN688+An2O7qVZ5QHf/K8Afby WqTazByWFrEXdrqkYOfUUVKcDVDKJH/Kp8xI3rqi0FvXHsExS1hEtsW+Y16g1R8fwKw+ 4YSfZWUPFWMR57WeEQ/pZ+aU7MdGHX8yRllE8FCZ9DICMLEZQzL+s9f6ADssDt+IICy0 GKMsG9h7rKmC5+VgCW72sQ5dvAnlcsO++NSSEckssLAt6atk1Z4uon1Ti/5bQWUWFhlO VcOi2OenBHb4q8UbkBKY6eOR3RmINkt4VwTUS4Nl+LcS+czwbT66X1QbFtU0mRPyDC2Q tQpg== X-Gm-Message-State: AOPr4FU6P/3vfYJ2MKHfnxRpWtEe7LJDFlspEEpexP4cR3oDd2VenzSQZ6pyV79m34z3yw== X-Received: by 10.25.30.7 with SMTP id e7mr3481528lfe.137.1463915008910; Sun, 22 May 2016 04:03:28 -0700 (PDT) Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id d63sm3334840lfb.48.2016.05.22.04.03.27 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 22 May 2016 04:03:27 -0700 (PDT) Date: Sun, 22 May 2016 13:03:26 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#23383: [PATCH] Support completion of color functions in CSS mode To: Etienne Prud'homme Message-Id: <1463915006.23837.0@smtp.gmail.com> In-Reply-To: <20160521184328.1779ac46@thinkpax> References: <20160426184852.391f744d@ThinkPax> <1461784618.2119.2@smtp.gmail.com> <20160427201745.09dd0967@ThinkPax> <1461865897.9211.0@smtp.gmail.com> <20160520153728.612ac2bd@thinkpax> <1463827339.3189.0@smtp.gmail.com> <20160521184328.1779ac46@thinkpax> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-pYKh8E8rSq8qSrP04ogn" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23383-done Cc: 23383-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-pYKh8E8rSq8qSrP04ogn Content-Type: text/plain; charset=utf-8; format=flowed On Sun, May 22, 2016 at 12:43 AM, Etienne Prud'homme wrote: > Oops! I've attached the new patch now. Thanks, looks good. Installed in master. -- Simen --=-pYKh8E8rSq8qSrP04ogn Content-Type: text/html; charset=utf-8 On Sun, May 22, 2016 at 12:43 AM, Etienne Prud'homme <e.e.f.prudhomme@gmail.com> wrote:
Oops! I've attached the new patch now.

Thanks, looks good. Installed in master.

-- Simen
--=-pYKh8E8rSq8qSrP04ogn-- From unknown Sat Jun 21 03:13:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 Jun 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator