GNU bug report logs - #23374
auth-source-macos-keychain-search pass in port only if it's provided

Previous Next

Package: emacs;

Reported by: "Jun Hao" <jun_hao <at> aol.com>

Date: Mon, 25 Apr 2016 15:12:01 UTC

Severity: normal

Tags: fixed

Fixed in version 26.1

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23374 in the body.
You can then email your comments to 23374 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#23374; Package emacs. (Mon, 25 Apr 2016 15:12:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to "Jun Hao" <jun_hao <at> aol.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 25 Apr 2016 15:12:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Jun Hao" <jun_hao <at> aol.com>
To: bug-gnu-emacs <at> gnu.org
Subject: auth-source-macos-keychain-search pass in port only if it's provided
Date: Mon, 25 Apr 2016 23:11:02 +0800

[Message part 1 (text/plain, inline)]
Hi,

When calling auth-source-search without port on OSX, current code will
bind port to "nil" and generate wrong command. E.g:

(auth-source-search :user "test") will yield command:

/usr/bin/security find-generic-password -g -a "test" -s "nil"

The correct one should be:

/usr/bin/security find-generic-password -g -a "test"

Please see attachment for this simple patch

Thanks - Jun


[0001-Pass-in-port-only-if-provided-by-caller.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23374; Package emacs. (Mon, 25 Apr 2016 16:03:01 GMT) Full text and rfc822 format available.

Message #8 received at 23374 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: "Jun Hao" <jun_hao <at> aol.com>
Cc: 23374 <at> debbugs.gnu.org
Subject: Re: bug#23374: auth-source-macos-keychain-search pass in port only if
 it's provided
Date: Mon, 25 Apr 2016 18:02:23 +0200

"Jun Hao" <jun_hao <at> aol.com> writes:

> When calling auth-source-search without port on OSX, current code will
> bind port to "nil" and generate wrong command. E.g:
>
> (auth-source-search :user "test") will yield command:

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 25 Apr 2016 16:03:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 25.2, send any further explanations to 23374 <at> debbugs.gnu.org and "Jun Hao" <jun_hao <at> aol.com> Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 25 Apr 2016 16:03:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 24 May 2016 11:24:04 GMT) Full text and rfc822 format available.
bug unarchived. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:11 GMT) Full text and rfc822 format available.
bug Marked as fixed in versions 26.1. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:11 GMT) Full text and rfc822 format available.
bug No longer marked as fixed in versions 25.2. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sun, 04 Dec 2016 02:50:11 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 01 Jan 2017 12:24:22 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 228 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.