GNU bug report logs - #23358
merging byte to wide char caches in gawk

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23358 in the body.
You can then email your comments to 23358 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aharon Robbins <arnold <at> skeeve.com>
To: bug-grep <at> gnu.org
Subject: merging byte to wide char caches in gawk
Date: Sun, 24 Apr 2016 19:40:55 +0300

[Message part 1 (text/plain, inline)]

Hi.

Here is my proposed patch for merging the byte to w.c. caches in gawk
by using the one in dfa.

I renamed the one in dfa to 'btowc_cache' since it caches bytes,
not multibyte characters.   This compiles and gets through the test
suite.

I also changed the check for the return of mbrtowc since it returns
unsigned.

Thanks,

Arnold

[dfa.diff (text/x-diff, attachment)]

Message #8 received at 23358 <at> debbugs.gnu.org (full text, mbox):

From: arnold <at> skeeve.com
To: arnold <at> skeeve.com, 23358 <at> debbugs.gnu.org
Subject: Re: bug#23358: merging byte to wide char caches in gawk
Date: Tue, 26 Apr 2016 01:12:13 -0600

The silence in response to this has been thundering. :-(

Ignoring the gawk bits, is the grep team willing to incorporate the
dfa.[ch] changes?

Should this wait until after other pending changes to dfa are applied?

Thanks,

Arnold

Aharon Robbins <arnold <at> skeeve.com> wrote:

> Hi.
>
> Here is my proposed patch for merging the byte to w.c. caches in gawk
> by using the one in dfa.
>
> I renamed the one in dfa to 'btowc_cache' since it caches bytes,
> not multibyte characters.   This compiles and gets through the test
> suite.
>
> I also changed the check for the return of mbrtowc since it returns
> unsigned.
>
> Thanks,
>
> Arnold

Message #15 received at 23358-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Aharon Robbins <arnold <at> skeeve.com>
Cc: 23358-done <at> debbugs.gnu.org
Subject: Re: merging byte to wide char caches in gawk
Date: Fri, 2 Sep 2016 15:46:53 -0700

> The silence in response to this has been thundering. :-(

Yes, it was pretty quiet....

I think we just now finally got around to incorporating all the ideas behind the 
patch in Bug#23358, albeit in a different way, so I'm boldly closing the bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.