From unknown Thu Sep 11 23:47:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23356: [PATCH] Cache results of `css--property-values' Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Apr 2016 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23356 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 23356@debbugs.gnu.org Cc: Dmitry Gutov X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.146150190928119 (code B ref -1); Sun, 24 Apr 2016 12:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Apr 2016 12:45:09 +0000 Received: from localhost ([127.0.0.1]:44596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auJPR-0007JD-IB for submit@debbugs.gnu.org; Sun, 24 Apr 2016 08:45:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auJPQ-0007DK-I3 for submit@debbugs.gnu.org; Sun, 24 Apr 2016 08:45:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auJPK-00020V-DJ for submit@debbugs.gnu.org; Sun, 24 Apr 2016 08:45:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJPK-00020P-AP for submit@debbugs.gnu.org; Sun, 24 Apr 2016 08:45:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJPJ-0003Ng-B7 for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 08:45:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auJPE-0001zt-Ca for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 08:45:01 -0400 Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:33631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJPD-0001zc-Gs for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 08:44:56 -0400 Received: by mail-lb0-x22d.google.com with SMTP id jj5so15789880lbc.0 for ; Sun, 24 Apr 2016 05:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:mime-version; bh=f7BIxLGtLqbp/s0dr6CwMD631N6bgT2mYUkZ8713ujU=; b=TiD2F0U9ofdRJLI/kKgFSmYGnAZ2MDA84xOxQsUkWIpIUuayhSrUpE1StvC14+G0eC GOn24D1/SeAoJxeMWnIW60Q3lgEor0uvGRk08vkVQXEvjQhBtPnT7EkDoSw+OhHzzQXf +dG/RpiYXTuL79Gusjdc48laWcVVzvxubKZx0xU3mKgCb9Zb2CJnwJ1yo7lAZhx8FRQ8 ZQ9yL2WOV9FJdFB++6FkkPukB6e8GAGdpRVB+DgLTG/nSrAmER2qAIVkogPrLOBzG9RG D3RxF3mHqmqzpa5Vgcl7yMpAAgvSmU/Q39yMHDpWGRvoWXPIfMBXpQgZyAA9gSTNQ9Y+ fCUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:mime-version; bh=f7BIxLGtLqbp/s0dr6CwMD631N6bgT2mYUkZ8713ujU=; b=O5snCg/oBE0LnZTeQk0Q0QzrWN5n9kPAxiTUX6EBfhCtZJxBTNb/jPULbN0aCjass1 8TVZJell9d32NKM8gzfyo9JCHipLGGfAS+QD1mkts0FdpXsXbwhzV8NCJbcPvIhbAENC VcQG25Bi4AX7rfAipe5uX0ARncAFgxoQNu/T5KguDpdN0bLOqlGuCtrwa2Q62F5Yz++g sqPFemgO+rRZCDRBsExsqTquuEY2GRpEZHAQ0/yOrevqPu25TaaAtfF/I9Lcm9jboFOh ifdlzzSlyY71xtIZA2HpfSVbI+gjezJG7rgcufpodw1L3upfRFKlgIHgar9axiEaXJ7I mctA== X-Gm-Message-State: AOPr4FVFVMIK1B3x3uUgs/0JgSd2IZxVuhQuBa++RMze3ItBdKqRFNA4DckZDrTID2Qdrg== X-Received: by 10.112.189.73 with SMTP id gg9mr3331591lbc.109.1461501893042; Sun, 24 Apr 2016 05:44:53 -0700 (PDT) Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id zw6sm3401843lbb.14.2016.04.24.05.44.51 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 24 Apr 2016 05:44:52 -0700 (PDT) Date: Sun, 24 Apr 2016 14:44:50 +0200 From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Message-Id: <1461501890.5416.0@smtp.gmail.com> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-a72qar+NfWiVeYU/5DY8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.4 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-a72qar+NfWiVeYU/5DY8 Content-Type: multipart/alternative; boundary="=-k9zCCzwXuZXceKJfZnzx" --=-k9zCCzwXuZXceKJfZnzx Content-Type: text/plain; charset=utf-8; format=flowed During one of the iterations for 269d5631 (Support completion of attribute values in CSS mode), the code that actually updates the `css--property-value-cache' cache in `css--property-values' got lost. The attached patch reintroduces it along with a regression test. --Simen --=-k9zCCzwXuZXceKJfZnzx Content-Type: text/html; charset=utf-8
During one of the iterations for 269d5631 (Support completion of
attribute values in CSS mode), the code that actually updates the
`css--property-value-cache' cache in `css--property-values' got lost.
The attached patch reintroduces it along with a regression test.

--Simen
--=-k9zCCzwXuZXceKJfZnzx-- --=-a72qar+NfWiVeYU/5DY8 Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Cache-results-of-css-property-values.patch >From 03296601a423ddd0a9a82bc6baf91b484c1ca92b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= Date: Sun, 24 Apr 2016 11:03:22 +0200 Subject: [PATCH] Cache results of `css--property-values' * lisp/textmodes/css-mode.el (css--property-values): Cache computed values. * test/lisp/textmodes/css-mode-tests.el (css-test-property-value-cache): New regression test for the above. --- lisp/textmodes/css-mode.el | 16 +++++++++------- test/lisp/textmodes/css-mode-tests.el | 7 +++++++ 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 2a61fe3..8a4daac 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -792,13 +792,15 @@ css--property-values Completion candidates are looked up in `css-property-alist' by the string PROPERTY." (or (gethash property css--property-value-cache) - (seq-mapcat - (lambda (value) - (if (stringp value) - (list value) - (or (css--value-class-lookup value) - (css--property-values (symbol-name value))))) - (cdr (assoc property css-property-alist))))) + (let ((values + (seq-mapcat + (lambda (value) + (if (stringp value) + (list value) + (or (css--value-class-lookup value) + (css--property-values (symbol-name value))))) + (cdr (assoc property css-property-alist))))) + (puthash property values css--property-value-cache)))) (defun css--complete-property-value () "Complete property value at point." diff --git a/test/lisp/textmodes/css-mode-tests.el b/test/lisp/textmodes/css-mode-tests.el index 9c5953d..805364c 100644 --- a/test/lisp/textmodes/css-mode-tests.el +++ b/test/lisp/textmodes/css-mode-tests.el @@ -57,6 +57,13 @@ ;; because it refers to the value class of the same name. (should (= (length (css--property-values "color")) 18))) +(ert-deftest css-test-property-value-cache () + "Test that `css--property-value-cache' is in use." + (should-not (gethash "word-wrap" css--property-value-cache)) + (let ((word-wrap-values (css--property-values "word-wrap"))) + (should (equal (gethash "word-wrap" css--property-value-cache) + word-wrap-values)))) + (ert-deftest css-test-value-class-lookup () (should (equal (sort (css--value-class-lookup 'position) #'string-lessp) -- 2.8.0.rc3 --=-a72qar+NfWiVeYU/5DY8-- From unknown Thu Sep 11 23:47:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23356: [PATCH] Cache results of `css--property-values' Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Apr 2016 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23356 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= , 23356@debbugs.gnu.org Received: via spool by 23356-submit@debbugs.gnu.org id=B23356.14615028112929 (code B ref 23356); Sun, 24 Apr 2016 13:01:02 +0000 Received: (at 23356) by debbugs.gnu.org; 24 Apr 2016 13:00:11 +0000 Received: from localhost ([127.0.0.1]:44606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auJdz-0000lB-9q for submit@debbugs.gnu.org; Sun, 24 Apr 2016 09:00:11 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auJdx-0000kC-Ap for 23356@debbugs.gnu.org; Sun, 24 Apr 2016 09:00:09 -0400 Received: by mail-wm0-f66.google.com with SMTP id n3so17624330wmn.1 for <23356@debbugs.gnu.org>; Sun, 24 Apr 2016 06:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=2KnqWBaw5lsiEccin8G+8VVD/XS5sztmPCxKFLUcWwQ=; b=oD8V725EsV15PvVZ3IVRBy4UPPTItig6kAb6ii3/QE447VkdCV9FblDAQOpC+/Dbgn CYkzyd3B8aEVVazMNoaWDrn7/ZxsYV7cL03lchYxmy5SflvLaSsIeVEaQyyLM2R0eqRs uB872B19GF42vL2GnPlwifUIxOFwmdlifqaZ3JhyOF20j4lXGjORwGdqH/T/CWZeLPLC Csc74gJCNX9Xt+Uk4l8qIbmp5vOP+vkQwOTjxrh+IDU9Rj25Inj2tt1mGxzLKSM53yLH mfUd5fGjw4E7TWG9E3EhNTSc7D6Yfk1opPEA4SnJq6fc0PtBB0JLhtAxxPFyVZrN5TRs yibg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=2KnqWBaw5lsiEccin8G+8VVD/XS5sztmPCxKFLUcWwQ=; b=HKf2uRSD9/FW6QnWaZZc/HZfTLCex8bdEF0knvhGR/NNN9/TgiOkSyQMSWDuOXuM81 z3dISjjuV6WP1cghvrtd/QnqsOHrjmIsjWEygFmgksNnF4UfcO9uF19ASvWNJGnEpMAE mJdrPLNoRPbu+GIm7LQjyN9b1h7ASYbEmlA/BvWRNrhbWtYso1QuPy4ubDZZQ1cJc1YG S3sY5aUI5HZqdvVfrOHnJIYvjhAtIrQBOzBCSOMOGIM/FtiyB+nJgS/dzkU1YM2laVMp sxhPP1qK8hmvNUODDNQePz1z79Yew9YKZROh5Gv+xBhsl6opB8sc5Iy8ZV084QROhQQR EX8A== X-Gm-Message-State: AOPr4FV6+I/98JyahUraMwZ+HnJoJVP02gEEjYbYxGnXkJX7OzWCOi7UjR6m5Hu16CoCYQ== X-Received: by 10.194.231.104 with SMTP id tf8mr28893554wjc.5.1461502803131; Sun, 24 Apr 2016 06:00:03 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id r75sm12944464wme.18.2016.04.24.06.00.02 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 24 Apr 2016 06:00:02 -0700 (PDT) References: <1461501890.5416.0@smtp.gmail.com> From: Dmitry Gutov Message-ID: Date: Sun, 24 Apr 2016 16:00:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1461501890.5416.0@smtp.gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/24/2016 03:44 PM, Simen Heggestøyl wrote: > During one of the iterations for 269d5631 (Support completion of > attribute values in CSS mode), the code that actually updates the > `css--property-value-cache' cache in `css--property-values' got lost. > The attached patch reintroduces it along with a regression test. LGTM. You should be able to push this kind of changes without going through review anyway. From unknown Thu Sep 11 23:47:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Subject: bug#23356: closed (Re: bug#23356: [PATCH] Cache results of `css--property-values') Message-ID: References: <1461503270.5416.2@smtp.gmail.com> <1461501890.5416.0@smtp.gmail.com> X-Gnu-PR-Message: they-closed 23356 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 23356@debbugs.gnu.org Date: Sun, 24 Apr 2016 13:08:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1461503281-3638-1" This is a multi-part message in MIME format... ------------=_1461503281-3638-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #23356: [PATCH] Cache results of `css--property-values' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 23356@debbugs.gnu.org. --=20 23356: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23356 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1461503281-3638-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 23356-done) by debbugs.gnu.org; 24 Apr 2016 13:08:00 +0000 Received: from localhost ([127.0.0.1]:44614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auJlY-0000wT-8c for submit@debbugs.gnu.org; Sun, 24 Apr 2016 09:08:00 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:36591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auJlV-0000wC-TA for 23356-done@debbugs.gnu.org; Sun, 24 Apr 2016 09:07:58 -0400 Received: by mail-lf0-f51.google.com with SMTP id u64so3632864lff.3 for <23356-done@debbugs.gnu.org>; Sun, 24 Apr 2016 06:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=ZiN1Z0suqmM6rpqU/GrOR2djYUIBRJoaPFwpePiyy/0=; b=zHpkxAiXKHo+SzEUWhDo9EJRmMvf3Q91bb7VfbyVkF2t7qPOrJPQD2/fM9Txa3Z/Ic 51qoIgNjcaWbVYF+XWwJwulX6qgyHAmxWG9R+mtRJm/RMS2Q85xOM+BO2wsF5SIkuBEN XbnbQ48I55ymV35Bm8kliNNrAiVtfo1TsfBRtVIXrfLQzP3RrIKpQZaICVgbb8XGJVCD r0nxWURe0tnmRpq9+F8LqXScv6nlR3NjkIAVSfAPG2vEGR/sGYqCceuAO7hTgYw4P6Q0 W7XMsXcXa0+BlrSn3YZ2F6r+f7wMPlgjchahiR9QomltjVc4GdsjIkOmTKg39CIEOhEV srGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=ZiN1Z0suqmM6rpqU/GrOR2djYUIBRJoaPFwpePiyy/0=; b=iB/NS48brZ1I/RgO38Vfx4/NWk2MkVp4kGe4AhChCSMH0+Tzug8or0YsCmm/DIf34D pWxAenLLKlx8saeMVUDRuk54q4FRudeoprUl86LdeP1mBax1KfDYJy1nJvaYnpQbmG7u hUEDwca4MT2bUnQ/cTQ335BdCXudkJumyJnbbFD3oB2DMNgJaWkYLbCPFpuX5aYEXiw/ wgKFKkwsm9WMFdAiwAlNpQ549isNdn/fd4Pt2WTROuDnF1SmfGIA648X7choSwcQoAfB B62DoXQv5lrjq3aKAPtSScnGZ7JEa3L97++MaIQM6rxl6oh0HmHX1gDe95mC+fdloxwD 5mSw== X-Gm-Message-State: AOPr4FU9Lspb/wKCXMg0FrtmQXycCArRIFZTlc6Z+dBe1vWdjXh5A1SvHJdRu+7CCk78fw== X-Received: by 10.25.27.200 with SMTP id b191mr13009350lfb.8.1461503272118; Sun, 24 Apr 2016 06:07:52 -0700 (PDT) Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id k190sm3440119lfb.34.2016.04.24.06.07.50 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 24 Apr 2016 06:07:51 -0700 (PDT) Date: Sun, 24 Apr 2016 15:07:50 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#23356: [PATCH] Cache results of `css--property-values' To: Dmitry Gutov Message-Id: <1461503270.5416.2@smtp.gmail.com> In-Reply-To: References: <1461501890.5416.0@smtp.gmail.com> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-3dqI5iCPUZ3cev6i6CMw" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23356-done Cc: 23356-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-3dqI5iCPUZ3cev6i6CMw Content-Type: text/plain; charset=utf-8; format=flowed On Sun, Apr 24, 2016 at 3:00 PM, Dmitry Gutov wrote: > LGTM. Thanks for the review, installed in master. > You should be able to push this kind of changes without going through > review anyway. I thought so too, but I wasn't entirely sure. I'll adjust my threshold then for what I can go ahead with without a review. -- Simen --=-3dqI5iCPUZ3cev6i6CMw Content-Type: text/html; charset=utf-8 On Sun, Apr 24, 2016 at 3:00 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
LGTM.

Thanks for the review, installed in master.

You should be able to push this kind of changes without going through review anyway.

I thought so too, but I wasn't entirely sure. I'll adjust my threshold
then for what I can go ahead with without a review.

-- Simen
--=-3dqI5iCPUZ3cev6i6CMw-- ------------=_1461503281-3638-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Apr 2016 12:45:09 +0000 Received: from localhost ([127.0.0.1]:44596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auJPR-0007JD-IB for submit@debbugs.gnu.org; Sun, 24 Apr 2016 08:45:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auJPQ-0007DK-I3 for submit@debbugs.gnu.org; Sun, 24 Apr 2016 08:45:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auJPK-00020V-DJ for submit@debbugs.gnu.org; Sun, 24 Apr 2016 08:45:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56461) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJPK-00020P-AP for submit@debbugs.gnu.org; Sun, 24 Apr 2016 08:45:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJPJ-0003Ng-B7 for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 08:45:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auJPE-0001zt-Ca for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 08:45:01 -0400 Received: from mail-lb0-x22d.google.com ([2a00:1450:4010:c04::22d]:33631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auJPD-0001zc-Gs for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 08:44:56 -0400 Received: by mail-lb0-x22d.google.com with SMTP id jj5so15789880lbc.0 for ; Sun, 24 Apr 2016 05:44:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:mime-version; bh=f7BIxLGtLqbp/s0dr6CwMD631N6bgT2mYUkZ8713ujU=; b=TiD2F0U9ofdRJLI/kKgFSmYGnAZ2MDA84xOxQsUkWIpIUuayhSrUpE1StvC14+G0eC GOn24D1/SeAoJxeMWnIW60Q3lgEor0uvGRk08vkVQXEvjQhBtPnT7EkDoSw+OhHzzQXf +dG/RpiYXTuL79Gusjdc48laWcVVzvxubKZx0xU3mKgCb9Zb2CJnwJ1yo7lAZhx8FRQ8 ZQ9yL2WOV9FJdFB++6FkkPukB6e8GAGdpRVB+DgLTG/nSrAmER2qAIVkogPrLOBzG9RG D3RxF3mHqmqzpa5Vgcl7yMpAAgvSmU/Q39yMHDpWGRvoWXPIfMBXpQgZyAA9gSTNQ9Y+ fCUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:mime-version; bh=f7BIxLGtLqbp/s0dr6CwMD631N6bgT2mYUkZ8713ujU=; b=O5snCg/oBE0LnZTeQk0Q0QzrWN5n9kPAxiTUX6EBfhCtZJxBTNb/jPULbN0aCjass1 8TVZJell9d32NKM8gzfyo9JCHipLGGfAS+QD1mkts0FdpXsXbwhzV8NCJbcPvIhbAENC VcQG25Bi4AX7rfAipe5uX0ARncAFgxoQNu/T5KguDpdN0bLOqlGuCtrwa2Q62F5Yz++g sqPFemgO+rRZCDRBsExsqTquuEY2GRpEZHAQ0/yOrevqPu25TaaAtfF/I9Lcm9jboFOh ifdlzzSlyY71xtIZA2HpfSVbI+gjezJG7rgcufpodw1L3upfRFKlgIHgar9axiEaXJ7I mctA== X-Gm-Message-State: AOPr4FVFVMIK1B3x3uUgs/0JgSd2IZxVuhQuBa++RMze3ItBdKqRFNA4DckZDrTID2Qdrg== X-Received: by 10.112.189.73 with SMTP id gg9mr3331591lbc.109.1461501893042; Sun, 24 Apr 2016 05:44:53 -0700 (PDT) Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id zw6sm3401843lbb.14.2016.04.24.05.44.51 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 24 Apr 2016 05:44:52 -0700 (PDT) Date: Sun, 24 Apr 2016 14:44:50 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: [PATCH] Cache results of `css--property-values' To: bug-gnu-emacs@gnu.org Message-Id: <1461501890.5416.0@smtp.gmail.com> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-a72qar+NfWiVeYU/5DY8" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: submit Cc: Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-a72qar+NfWiVeYU/5DY8 Content-Type: multipart/alternative; boundary="=-k9zCCzwXuZXceKJfZnzx" --=-k9zCCzwXuZXceKJfZnzx Content-Type: text/plain; charset=utf-8; format=flowed During one of the iterations for 269d5631 (Support completion of attribute values in CSS mode), the code that actually updates the `css--property-value-cache' cache in `css--property-values' got lost. The attached patch reintroduces it along with a regression test. --Simen --=-k9zCCzwXuZXceKJfZnzx Content-Type: text/html; charset=utf-8
During one of the iterations for 269d5631 (Support completion of
attribute values in CSS mode), the code that actually updates the
`css--property-value-cache' cache in `css--property-values' got lost.
The attached patch reintroduces it along with a regression test.

--Simen
--=-k9zCCzwXuZXceKJfZnzx-- --=-a72qar+NfWiVeYU/5DY8 Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Cache-results-of-css-property-values.patch >From 03296601a423ddd0a9a82bc6baf91b484c1ca92b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= Date: Sun, 24 Apr 2016 11:03:22 +0200 Subject: [PATCH] Cache results of `css--property-values' * lisp/textmodes/css-mode.el (css--property-values): Cache computed values. * test/lisp/textmodes/css-mode-tests.el (css-test-property-value-cache): New regression test for the above. --- lisp/textmodes/css-mode.el | 16 +++++++++------- test/lisp/textmodes/css-mode-tests.el | 7 +++++++ 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 2a61fe3..8a4daac 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -792,13 +792,15 @@ css--property-values Completion candidates are looked up in `css-property-alist' by the string PROPERTY." (or (gethash property css--property-value-cache) - (seq-mapcat - (lambda (value) - (if (stringp value) - (list value) - (or (css--value-class-lookup value) - (css--property-values (symbol-name value))))) - (cdr (assoc property css-property-alist))))) + (let ((values + (seq-mapcat + (lambda (value) + (if (stringp value) + (list value) + (or (css--value-class-lookup value) + (css--property-values (symbol-name value))))) + (cdr (assoc property css-property-alist))))) + (puthash property values css--property-value-cache)))) (defun css--complete-property-value () "Complete property value at point." diff --git a/test/lisp/textmodes/css-mode-tests.el b/test/lisp/textmodes/css-mode-tests.el index 9c5953d..805364c 100644 --- a/test/lisp/textmodes/css-mode-tests.el +++ b/test/lisp/textmodes/css-mode-tests.el @@ -57,6 +57,13 @@ ;; because it refers to the value class of the same name. (should (= (length (css--property-values "color")) 18))) +(ert-deftest css-test-property-value-cache () + "Test that `css--property-value-cache' is in use." + (should-not (gethash "word-wrap" css--property-value-cache)) + (let ((word-wrap-values (css--property-values "word-wrap"))) + (should (equal (gethash "word-wrap" css--property-value-cache) + word-wrap-values)))) + (ert-deftest css-test-value-class-lookup () (should (equal (sort (css--value-class-lookup 'position) #'string-lessp) -- 2.8.0.rc3 --=-a72qar+NfWiVeYU/5DY8-- ------------=_1461503281-3638-1--