From unknown Sat Jun 21 05:13:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23326: shell-resync-dirs does not handle dirs with whitespace Resent-From: Noah Friedman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Apr 2016 06:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23326 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 23326@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: Noah Friedman Received: via spool by submit@debbugs.gnu.org id=B.146121859713563 (code B ref -1); Thu, 21 Apr 2016 06:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Apr 2016 06:03:17 +0000 Received: from localhost ([127.0.0.1]:41872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1at7ht-0003Wh-02 for submit@debbugs.gnu.org; Thu, 21 Apr 2016 02:03:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1at5R9-0008E6-61 for submit@debbugs.gnu.org; Wed, 20 Apr 2016 23:37:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1at5R3-0008FE-Aq for submit@debbugs.gnu.org; Wed, 20 Apr 2016 23:37:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at5R3-0008F9-7i for submit@debbugs.gnu.org; Wed, 20 Apr 2016 23:37:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at5R2-00072g-Eh for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2016 23:37:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1at5Qz-0008EX-A6 for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2016 23:37:44 -0400 Received: from bacon-event-horizon.splode.com ([2600:3c01::f03c:91ff:fe96:f92b]:54172 helo=splode.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at5Qy-0008EA-VJ for bug-gnu-emacs@gnu.org; Wed, 20 Apr 2016 23:37:41 -0400 Received: from unexploded-cow.prv.splode.com (prv.splode.com [173.8.128.9]) (authenticated bits=0) by splode.com (8.15.2/8.15.2) with ESMTPSA id u3L2kPji026533 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Wed, 20 Apr 2016 19:46:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=splode.com; s=splode-20130101; t=1461206786; bh=aYfqWXn+m59fM2El2z2q5oRlHhOSSCv8VA9tPYHpYM8=; h=From:To:Subject:Reply-To:Date:From; b=JyiW2XqBEEdNyv4nvd4XhYgd0WjHhlVMnC1PmG7PTIRn8ghGRhTfeGJsZVc6G33qv 8I7XEkKQ/uPtG+THaCyVox119uM5DgfsHSEHsOLbON+81oCTM5MKQEH0XtSRU+kQvA o6blEewQBDoPox8KkglpLe0pjvx61du8suU4Pe9M= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Noah Friedman Date: Wed, 20 Apr 2016 19:46:25 -0700 (PDT) Message-Id: <20160420194625.330701.FMU1050@unexploded-cow.prv.splode.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -1.4 (-) X-Mailman-Approved-At: Thu, 21 Apr 2016 02:03:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) My apologies. There is an instance of the symbol `tem' that should be `tem1' in my previously submitted patch. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 21 11:34:13 2016 Received: (at control) by debbugs.gnu.org; 21 Apr 2016 15:34:13 +0000 Received: from localhost ([127.0.0.1]:42476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1atGcP-00050Q-1c for submit@debbugs.gnu.org; Thu, 21 Apr 2016 11:34:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1atGcN-00050D-6M for control@debbugs.gnu.org; Thu, 21 Apr 2016 11:34:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1atGcC-0007a6-Nh for control@debbugs.gnu.org; Thu, 21 Apr 2016 11:34:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atGcC-0007a2-Kv for control@debbugs.gnu.org; Thu, 21 Apr 2016 11:34:00 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1atGcC-0006FY-7i for control@debbugs.gnu.org; Thu, 21 Apr 2016 11:34:00 -0400 Subject: control message for bug 23324 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Thu, 21 Apr 2016 11:34:00 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) merge 23326 23324 severity 23324 minor From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 25 19:19:38 2016 Received: (at control) by debbugs.gnu.org; 25 Apr 2016 23:19:39 +0000 Received: from localhost ([127.0.0.1]:47097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aupn0-0001kI-Pq for submit@debbugs.gnu.org; Mon, 25 Apr 2016 19:19:38 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:49616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aupmz-0001kA-7k for control@debbugs.gnu.org; Mon, 25 Apr 2016 19:19:37 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.84_2) (envelope-from ) id 1aupmx-0001Ji-3y for control@debbugs.gnu.org; Tue, 26 Apr 2016 01:19:36 +0200 Date: Tue, 26 Apr 2016 01:19:34 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #23324 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 23324 patch From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 03 13:08:59 2018 Received: (at control) by debbugs.gnu.org; 3 Sep 2018 17:08:59 +0000 Received: from localhost ([127.0.0.1]:44553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwsLT-000838-Gh for submit@debbugs.gnu.org; Mon, 03 Sep 2018 13:08:59 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:43742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fwsLS-00082p-0p; Mon, 03 Sep 2018 13:08:58 -0400 Received: by mail-io0-f174.google.com with SMTP id y10-v6so861007ioa.10; Mon, 03 Sep 2018 10:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=T6qj1C40tG4OdcLoUDc+gRpO48rv0znfcvT57bb+VxY=; b=TJI8MOTCX6bPAfUHldsuQBkI5CX9W6IztLQrBQ8nKDtNntVq57XjbgbRgLctHWr1x3 rBfFrxoSNDEsk0kAJaLzIGS/1dgqSfnPTtKH497jSq3zadTVbjVbMjKJWgXDVR2xHUev rbiOlFhKGK+fx8co7N8cLlnp7QF1ZL8pNejMfm/Ag6foc/vLP7OTrh3U2eXe9RSkeKlb OSi4b170NDIAyBtXMCuE20XUtwaOwoVs+gTuFDNuII9m5UCVSa3adkk3jABCOi5BguRJ LbxHT/opS6tFqMVOuiRFZBNWW4b7snS7ctcnYNGFMlU8TMpLsAk+fcr0p4FLTFUXsnUZ 9LMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=T6qj1C40tG4OdcLoUDc+gRpO48rv0znfcvT57bb+VxY=; b=QtgfoljrkFL3+6gMPOhy5joYk96H6LsEz0Q2Xl+ZE2kxVKmamhQUyALicListOteCb LT9fnL3McYiXbe/kFXOAYEQ6Ai1LdVICLxACx0YB316guFf4I4nhdrxFmp32qYU2/Ymg N0lX1HCbVZJXp5w5ry2SlbpgMJbVmljafa/NK8SXjhk63c32rPCtdjOjTGZuNlRdOTvd JBzhvXecnDavZEIq/hIxKl+LF72UBtDDTMacjxbOZEbpksFcT6+JSol9OKOvYNXsQeOq 36pbfNRW+AWJPEKQJYkWTHdcPyqB6LTBrq6MB0vi0ta9cEDRJ2Y1QhMxKpUnkgMI/RBB WbPw== X-Gm-Message-State: APzg51DXSYepRB5R/T1RS6iacOJ/lNoSkD/mNfY/BvRUjyhqv2i717Ro TXSKggtV3+1sr/i0Nibji5ILq11W X-Google-Smtp-Source: ANB0Vdbrq/+fVHnHIzeRx5WfwRaKY/akf1KQqWzffHtcz2d66MHwTPQNv/FnjgM3Mm7monp48C8WjQ== X-Received: by 2002:a5e:890f:: with SMTP id k15-v6mr5801343ioj.9.1535994532237; Mon, 03 Sep 2018 10:08:52 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id n140-v6sm6692198itb.37.2018.09.03.10.08.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Sep 2018 10:08:51 -0700 (PDT) From: Noam Postavsky To: Noah Friedman Subject: Re: bug#23324: shell-resync-dirs does not handle dirs with whitespace References: <20160420193843.651480.FMU1050@unexploded-cow.prv.splode.com> Date: Mon, 03 Sep 2018 13:08:42 -0400 In-Reply-To: <20160420193843.651480.FMU1050@unexploded-cow.prv.splode.com> (Noah Friedman's message of "Wed, 20 Apr 2016 19:38:43 -0700 (PDT)") Message-ID: <8736uqik4l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control Cc: 23324@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 23324 11608 9379 quit Noah Friedman writes: > I have a fix for this, but I'd like for someone else to look over it and > perhaps sanity check it before I commit it. Volunteers? > This is a very old limitation. By now this is a fairly old patch, but still in need of review it seems. > + (let* ((dls (buffer-substring-no-properties (match-beginning 0) (1- (match-end 0)))) > + (dlsl '()) > + (pos 0) > + (ds '())) > + ;; Split the dirlist into whitespace and non-whitespace chunks. > + ;; dlsl will be a reversed list of tokens. > + (while (string-match "\\(\\S-+\\|\\s-+\\)" dls pos) > + (push (match-string 1 dls) dlsl) > + (setq pos (match-end 1))) > + > + ;; prepend trailing entries until they form an existing directory, > + ;; whitespace and all. discard the next whitespace and repeat. I think this loop is going in the wrong direction (i.e., it should rather be appending leading entries). Because of this, it can be fooled by subdirectories with a name matching a substring of a dirs entry: ~$ mkdir -p 'foo bar/bar/' ~$ cd 'foo bar/' ~/foo bar$ command dirs # M-x dirs # infloops... > + (let ((newelt "") > + tem1 tem2) I'm also not a fan of the somewhat inscrutable tem1 & tem2 names. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 27 12:26:00 2019 Received: (at control) by debbugs.gnu.org; 27 Jun 2019 16:26:01 +0000 Received: from localhost ([127.0.0.1]:39388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgXDk-0008Ax-Ms for submit@debbugs.gnu.org; Thu, 27 Jun 2019 12:26:00 -0400 Received: from quimby.gnus.org ([80.91.231.51]:44976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgXDj-0008Aq-8c for control@debbugs.gnu.org; Thu, 27 Jun 2019 12:25:59 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hgXDg-0007av-Nv for control@debbugs.gnu.org; Thu, 27 Jun 2019 18:25:58 +0200 Date: Thu, 27 Jun 2019 18:25:56 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #9379 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 9379 + confirmed quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 9379 + confirmed quit From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 19 10:01:16 2020 Received: (at control) by debbugs.gnu.org; 19 Aug 2020 14:01:16 +0000 Received: from localhost ([127.0.0.1]:40577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8OeS-00085c-G6 for submit@debbugs.gnu.org; Wed, 19 Aug 2020 10:01:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8OeP-0007x0-71 for control@debbugs.gnu.org; Wed, 19 Aug 2020 10:01:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tf+AitrA493OHDSwqNidCYTfIWZxcdl/O0KUziUXAXE=; b=qaoz4MvLymzKk7/kEKBgU4wgLq CMh48ctbEBVZJa+GXHUi6YzILMuITJxtyQ1TruP3gBRd7/if2mdwmOgM6M0jmix4vQwHK+h1nk5Tc 6DmOieverQA2rN9cNeJiP44Oc8pScmdYd21Ra1E8meno2f506qFrv+krHr8NkbpEOue4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8OeD-0005S3-HE for control@debbugs.gnu.org; Wed, 19 Aug 2020 16:01:07 +0200 Date: Wed, 19 Aug 2020 16:01:00 +0200 Message-Id: <87mu2q20rn.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #11608 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 11608 fixed close 11608 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 11608 fixed close 11608 28.1 quit