GNU bug report logs - #23325
25.0.92; insert-char: cannot find all chars if input is unicode name

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23325 in the body.
You can then email your comments to 23325 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.92; insert-char: cannot find all chars if input is unicode name
Date: Thu, 21 Apr 2016 13:40:01 +0900 (JST)

Hello,

Interactive calls to `insert-char' cannot find all
characters when CHARACTER is the unicode character name.

IOW, it finds all characters when CHARACTER is the
code point.


emacs -Q:
M-x insert-char RET cjk SPC TAB
;; Buffer "*Completions*" just shows entries starting
;; with 'CJK RADICAL' or 'CJK STROKE'.

M-x insert-char RET 2eea RET
;; ok
M-x insert-char RET cjk SPC radical SPC c-simplified SPC frog RET
;; ok
M-x insert-char RET 79c1 RET
;; ok
M-x insert-char RET cjk SPC ideograph-79c1 RET
;; Signal error 'Invalid character'


In GNU Emacs 25.0.92.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.30)
 of 2016-04-21 built on calancha-pc
Repository revision: a77cf24ada2f89194c0ac64aae27bcdf7021e697

Message #8 received at 23325 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 23325 <at> debbugs.gnu.org
Subject: Re: bug#23325: 25.0.92;
 insert-char: cannot find all chars if input is unicode name
Date: Thu, 21 Apr 2016 17:00:12 +0300

> Date: Thu, 21 Apr 2016 13:40:01 +0900 (JST)
> From: Tino Calancha <f92capac <at> gmail.com>
> 
> Interactive calls to `insert-char' cannot find all
> characters when CHARACTER is the unicode character name.
> 
> IOW, it finds all characters when CHARACTER is the
> code point.
> 
> 
> emacs -Q:
> M-x insert-char RET cjk SPC TAB
> ;; Buffer "*Completions*" just shows entries starting
> ;; with 'CJK RADICAL' or 'CJK STROKE'.
> 
> M-x insert-char RET 2eea RET
> ;; ok
> M-x insert-char RET cjk SPC radical SPC c-simplified SPC frog RET
> ;; ok
> M-x insert-char RET 79c1 RET
> ;; ok
> M-x insert-char RET cjk SPC ideograph-79c1 RET
> ;; Signal error 'Invalid character'

It's a feature, see ucs-names.  We deliberately filter out
non-descriptive names like "CJK COMPATIBILITY IDEOGRAPH-2F803",
because (a) if we didn't the list of completions would be sometimes
much longer; and (b) it makes very little sense to show these names as
completions candidates, because those names include the codepoint, so
if you know which of these you need to insert, you can insert it by
the codepoint.

Message #11 received at 23325 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Tino Calancha <f92capac <at> gmail.com>, 23325 <at> debbugs.gnu.org
Subject: Re: bug#23325: 25.0.92; insert-char: cannot find all chars if input
 is unicode name
Date: Thu, 21 Apr 2016 23:32:49 +0900 (JST)

> It's a feature, see ucs-names.  We deliberately filter out
> non-descriptive names like "CJK COMPATIBILITY IDEOGRAPH-2F803",

Yes, that was my guess, and actually i would not cache such
trivial key val relations either.

Then a minor detail is as follows:

M-x insert-char 79c1 RET
;; ok character appear
C-b
M-x describe-char RET
;; Line 8 shows:
;; to input: type "C-x 8 RET 79c1" or "C-x 8 RET CJK IDEOGRAPH-79C1"

Shouldn't `describe-char' omit the input method by unicode name in 
those cases?

Message #14 received at 23325 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 23325 <at> debbugs.gnu.org
Subject: Re: bug#23325: 25.0.92; insert-char: cannot find all chars if input
 is unicode name
Date: Thu, 21 Apr 2016 18:44:29 +0300

> Date: Thu, 21 Apr 2016 23:32:49 +0900 (JST)
> From: Tino Calancha <f92capac <at> gmail.com>
> cc: Tino Calancha <f92capac <at> gmail.com>, 23325 <at> debbugs.gnu.org
> 
> M-x describe-char RET
> ;; Line 8 shows:
> ;; to input: type "C-x 8 RET 79c1" or "C-x 8 RET CJK IDEOGRAPH-79C1"
> 
> Shouldn't `describe-char' omit the input method by unicode name in 
> those cases?

Yes, it should show a method that works; patches welcome.

Message #17 received at 23325 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Tino Calancha <f92capac <at> gmail.com>, 23325 <at> debbugs.gnu.org
Subject: Re: bug#23325: 25.0.92; insert-char: cannot find all chars if input
 is unicode name
Date: Fri, 22 Apr 2016 02:39:24 +0900 (JST)

[Message part 1 (text/plain, inline)]

> Yes, it should show a method that works; patches welcome.

With attached patch:

`describe-char' on 0x79c1 shows:
to input: type "C-x 8 RET 79c1"

IOH, for catched entries in `ucs-names' (e.g. 0x304d) it shows as usual:
to input: type "C-x 8 RET 304d" or "C-x 8 RET HIRAGANA LETTER KI"

[descr-text.patch (text/plain, attachment)]

Message #20 received at 23325 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 23325 <at> debbugs.gnu.org
Subject: Re: bug#23325: 25.0.92; insert-char: cannot find all chars if input
 is unicode name
Date: Thu, 21 Apr 2016 22:42:42 +0300

> Date: Fri, 22 Apr 2016 02:39:24 +0900 (JST)
> From: Tino Calancha <f92capac <at> gmail.com>
> cc: Tino Calancha <f92capac <at> gmail.com>, 23325 <at> debbugs.gnu.org
> 
> > Yes, it should show a method that works; patches welcome.
> 
> With attached patch:
> 
> `describe-char' on 0x79c1 shows:
> to input: type "C-x 8 RET 79c1"
> 
> IOH, for catched entries in `ucs-names' (e.g. 0x304d) it shows as usual:
> to input: type "C-x 8 RET 304d" or "C-x 8 RET HIRAGANA LETTER KI"

Thanks.  But I think it would be better if the code didn't have to
define in yet another place which characters are omitted; instead, how
about checking if the character is in the ucs-names list?

Message #23 received at 23325 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Tino Calancha <f92capac <at> gmail.com>, 23325 <at> debbugs.gnu.org
Subject: Re: bug#23325: 25.0.92; insert-char: cannot find all chars if input
 is unicode name
Date: Fri, 22 Apr 2016 12:08:31 +0900 (JST)

[Message part 1 (text/plain, inline)]

> It would be better if the code didn't have to
> define in yet another place which characters are omitted; instead, how
> about checking if the character is in the ucs-names list?

Absolutely.  Implemented in the new patch.

[0001-describe-char-fix-insert-char-documentation.patch (text/plain, attachment)]

Message #26 received at 23325 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 23325 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#23325: 25.0.92;
 insert-char: cannot find all chars if input is unicode name
Date: Fri, 22 Apr 2016 09:32:20 +0200

Tino Calancha <f92capac <at> gmail.com> writes:

> +                                     (assoc-string name (or ucs-names (ucs-names))))

There is no need to refer to the variable ucs-names as the function uses
it anyway.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #29 received at 23325 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: Tino Calancha <f92capac <at> gmail.com>, 23325 <at> debbugs.gnu.org,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#23325: 25.0.92; insert-char: cannot find all chars if input
 is unicode name
Date: Fri, 22 Apr 2016 16:56:33 +0900 (JST)

[Message part 1 (text/plain, inline)]

> There is no need to refer to the variable ucs-names as the function uses
> it anyway.
Thank you.  Corrected in the attached new patch.

Cheers,
Tino

[0001-describe-char-fix-insert-char-documentation.patch (text/plain, attachment)]

Message #34 received at 23325-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 23325-done <at> debbugs.gnu.org
Subject: Re: bug#23325: 25.0.92; insert-char: cannot find all chars if input,
 is unicode name
Date: Sat, 23 Apr 2016 12:52:27 -0700

Thanks, I installed that patch and am closing the bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.