From unknown Sat Aug 09 04:56:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23294 <23294@debbugs.gnu.org> To: bug#23294 <23294@debbugs.gnu.org> Subject: Status: 25.0.92; modify-file-local-variable-prop-line adds extra "; " Reply-To: bug#23294 <23294@debbugs.gnu.org> Date: Sat, 09 Aug 2025 11:56:28 +0000 retitle 23294 25.0.92; modify-file-local-variable-prop-line adds extra "; " reassign 23294 emacs submitter 23294 "Mohammed Sadik P. K." severity 23294 minor tag 23294 patch fixed easy confirmed thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 15 01:13:57 2016 Received: (at submit) by debbugs.gnu.org; 15 Apr 2016 05:13:57 +0000 Received: from localhost ([127.0.0.1]:36035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqw4r-0004lM-5V for submit@debbugs.gnu.org; Fri, 15 Apr 2016 01:13:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqswx-0008Qr-I9 for submit@debbugs.gnu.org; Thu, 14 Apr 2016 21:53:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqswr-0003bE-7p for submit@debbugs.gnu.org; Thu, 14 Apr 2016 21:53:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqswr-0003bA-4Q for submit@debbugs.gnu.org; Thu, 14 Apr 2016 21:53:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqswp-0003jU-Vr for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 21:53:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqswm-0003Zr-MQ for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 21:53:27 -0400 Received: from md-77.webhostbox.net ([199.79.62.63]:36074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqswm-0003AN-H4 for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2016 21:53:24 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:37913) by md-77.webhostbox.net with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1aqsw5-000sGM-5f for bug-gnu-emacs@gnu.org; Fri, 15 Apr 2016 01:52:41 +0000 Received: by mail-wm0-f52.google.com with SMTP id u206so11953945wme.1 for ; Thu, 14 Apr 2016 18:52:41 -0700 (PDT) X-Gm-Message-State: AOPr4FUj49EWfYNMBd5KaQODtV3J+kQpfs977d2Dmfijo6Jg6eYT5fvJit3r+VNKZxafAx5eMj6jC47UYN60QQ== MIME-Version: 1.0 X-Received: by 10.28.169.196 with SMTP id s187mr1452684wme.63.1460685160419; Thu, 14 Apr 2016 18:52:40 -0700 (PDT) Received: by 10.194.74.227 with HTTP; Thu, 14 Apr 2016 18:52:40 -0700 (PDT) Date: Fri, 15 Apr 2016 07:22:40 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: 25.0.92; modify-file-local-variable-prop-line adds extra "; " From: "Mohammed Sadik P. K." To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-Authenticated_sender: sadiq@sadiqpk.org X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - md-77.webhostbox.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - sadiqpk.org X-Get-Message-Sender-Via: md-77.webhostbox.net: authenticated_id: sadiq@sadiqpk.org X-Authenticated-Sender: md-77.webhostbox.net: sadiq@sadiqpk.org X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 15 Apr 2016 01:13:56 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) For the function modify-file-local-variable-prop-line if run with 'add-or-replace as the third argument, it should replace the current values. It does, but along with replacing the values, it adds an extra "; " at the beginning of the variable. Eg.: my current first line: /* -*- mode: c; indent-tabs-mode: t; -*- */ I executed (modify-file-local-variable-prop-line 'indent-tabs-mode 'nil 'add-or-replace) The result was: /* -*- mode: c; ; indent-tabs-mode: nil; -*- */ Expected result: /* -*- mode: c; indent-tabs-mode: nil; -*- */ Each time I run the function, an "; " is added. In GNU Emacs 25.0.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.18.9) of 2016-04-13 built on fedora.localdomain Windowing system distributor 'Fedora Project', version 11.0.11800000 Configured features: XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LC_MONETARY: en_IN.UTF-8 value of $LC_NUMERIC: en_IN.UTF-8 value of $LC_TIME: en_IN.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: C/l Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent messages: Undo! (No changes need to be saved) For this change to take effect revisit file using M-x revert-buffer Saving file /home/sadiq/test.c... Wrote /home/sadiq/test.c Making completion list... [2 times] nil Saving file /home/sadiq/test.c... Wrote /home/sadiq/test.c Making completion list... Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils thingatpt help-fns debug files-x cl-extra help-mode cc-mode cc-fonts easymenu cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 107079 7193) (symbols 48 21723 0) (miscs 40 82 182) (strings 32 20174 4378) (string-bytes 1 689608) (vectors 16 14280) (vector-slots 8 449743 7625) (floats 8 168 213) (intervals 56 281 16) (buffers 976 14) (heap 1024 54266 1231)) From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 15 03:56:14 2016 Received: (at 23294) by debbugs.gnu.org; 15 Apr 2016 07:56:14 +0000 Received: from localhost ([127.0.0.1]:36131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqybu-000051-LB for submit@debbugs.gnu.org; Fri, 15 Apr 2016 03:56:14 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqybs-0008WS-IW for 23294@debbugs.gnu.org; Fri, 15 Apr 2016 03:56:12 -0400 Received: by mail-pf0-f194.google.com with SMTP id r187so9257824pfr.2 for <23294@debbugs.gnu.org>; Fri, 15 Apr 2016 00:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=+nH5hGt39NnBZXJjZTPJqH6oxsC4lNK+it6/TyMPERg=; b=bKXw6kGpC1WFK1kc+heDPM5Zcry1y09pDWXkxvWMCYdM2P3lZ5VwxfdOUpxeungyNF 5aeE8sU9RAw5sWbw+/qL3Nr2tNQfGsOTGOuEcQq7ax0VYRlXKffSyGgkSy+3cCTtRyJy 5TeTnwqAPrp/CcHkYvr3CC2/mQDwh1g6wK1jNYS2T0RBkwCrJx7g2ATHkPRaYOqcffl5 LmX5S97cBJOXnlK0X1Woy+ITcW8JNpXH2OKEOoyzvjvTsyutveihTDG2URzktG48pUmh lYRQwY4o+HupC43KcRVJxYQh1x4vIHMOvfWz4ZO6pWC4kDYL9ysjlX5j/DBUPAd2IyWJ W9/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=+nH5hGt39NnBZXJjZTPJqH6oxsC4lNK+it6/TyMPERg=; b=NixIXxrAOmgXcLVIRYXtzkYvApqOu32rLaBntZvLmI5ZKb/BfJFzegGnpukYbSn+Wb VQGO9nDwQHJuHGP4vjuTt5RuL3bvbwnCTa3HR/DLVmMfk13vZQU7Y1Ap1SHA2hN6J2+Q EMRxT04cRv8QufEhuj7FEoxoUhs6X2NKrm7mbGtz6GzlJxsyrTcHVyw4GHntQGoOLAVs jWKml5iFJYPBrCd0t7qyzHEjE0Qtokzux+/FUYxSkIDAY4n337+nXqn1+URRngYqx599 bav8uVxvufrSP7Y3UYZXUj85hCCIL3q1wWDY+I51Km3+FV4t7/npnofQFliOpWSeUsld +OCQ== X-Gm-Message-State: AOPr4FVUiiLJIxSPPRLNrO5r7XFMHqd6TK+lr0eSkr+mcig9lhvyxrbJadHOG7AdejiX+g== X-Received: by 10.98.10.74 with SMTP id s71mr27638270pfi.86.1460706966758; Fri, 15 Apr 2016 00:56:06 -0700 (PDT) Received: from localhost (CPE-58-161-15-29.cqqy2.win.bigpond.net.au. [58.161.15.29]) by smtp.gmail.com with ESMTPSA id y7sm62716581pfa.82.2016.04.15.00.56.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Apr 2016 00:56:06 -0700 (PDT) References: User-agent: mu4e 0.9.16; emacs 24.5.3 From: Alexis To: "Mohammed Sadik P. K." Subject: Re: bug#23294: 25.0.92; modify-file-local-variable-prop-line adds extra "; " In-reply-to: Date: Fri, 15 Apr 2016 17:55:58 +1000 Message-ID: <871t67uwz5.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23294 Cc: 23294@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Mohammed Sadik P. K. writes: > For the function modify-file-local-variable-prop-line if run > with 'add-or-replace as the third argument, it should replace > the current values. It does, but along with replacing the > values, it adds an extra "; " at the beginning of the variable. > > Eg.: > > my current first line: > /* -*- mode: c; indent-tabs-mode: t; -*- */ > > I executed (modify-file-local-variable-prop-line > 'indent-tabs-mode 'nil 'add-or-replace) > > The result was: > > /* -*- mode: c; ; indent-tabs-mode: nil; -*- */ > > Expected result: > > /* -*- mode: c; indent-tabs-mode: nil; -*- */ > > Each time I run the function, an "; " is added. Reproduced on 24.5 (Debian Jessie x86_64). From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 05 19:52:10 2018 Received: (at 23294) by debbugs.gnu.org; 5 Jun 2018 23:52:10 +0000 Received: from localhost ([127.0.0.1]:35630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQLkH-0005O3-Vx for submit@debbugs.gnu.org; Tue, 05 Jun 2018 19:52:10 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:50576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fQLkE-0005NP-Ls; Tue, 05 Jun 2018 19:52:07 -0400 Received: by mail-it0-f47.google.com with SMTP id u4-v6so5802106itg.0; Tue, 05 Jun 2018 16:52:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=G3uBgaSUyfp0WwbnCnudjCcJzAhaoaWz1YraAyOr5sY=; b=HSmIrapl/wry6jarebkmHi7tFTQm2JlTJMOYm6ypB0ju105hcwG4OGcTwMwxEHPMxD wNKTQlCmLC39GOOkHb8yqhbkRMedp8WmgoszM71BM+J4Mv7iCaNuQnZGertJq+5Kyi2x w4gt26J0DCzVZK3Y+GYH5dD1gUDozZAERAp8wywqhlh91/Zv67KbckXtms7lAhv1lN4s vroob88JL17bkw9IwnN8/6vHb0Z5fvWd0tXaybtj3b00WLoVy6ijSxGquZY8Uh+fQXso A55IYmNhNhrQ0IPosSKCnqB4REUp+Hz/La5BCud2ELLmvLPqCNzd7OccwSS12dulEe8x Uc4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=G3uBgaSUyfp0WwbnCnudjCcJzAhaoaWz1YraAyOr5sY=; b=M81y3u7DKvUXsaoU+KZLWvOP5lHYG5v3MGhnTJyPKUSvyyB8PUc+B5W4kkYcCgx/Fy jhPCDHum/wqAVCmkWT++U6TasYpkQjRDiO6ZZCP0Ub8RIP9EF1/iq55+7X9iu5oU61Gw Si0/k8dLaQImlS1L5Q//BbkzyEUoobS/X59caAnYM/j9Ik725ypNcA6AaoOC8HIA6CBy zsgTv7RyllbAlb+x+mKvohO2EvkyduODeJqcCbnhAhiAzO604EdtNnPGBt3JyO5CE73c 8v2cMxGjtzzXAqL3l6LZZ051294mHk9I8tIjHV3jIYIpWhvfy8W366Sfkg0kU7t+qTxL rYKQ== X-Gm-Message-State: APt69E3eq6nTRPu2mVZh4hjB0B++bU9kDUi00VNkXScDKcOsNyVfYBE8 /2wo3p/0YFK+pLJW0A+iExkxsw== X-Google-Smtp-Source: ADUXVKLpbVOojw/2gA1iC/1eQTN6Boq/jSB7sIM2co6Qm64fLXSznpTyC8XIHNrAcb6Zgco0SHpvYg== X-Received: by 2002:a24:250e:: with SMTP id g14-v6mr350395itg.24.1528242721071; Tue, 05 Jun 2018 16:52:01 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id p196-v6sm1080940itb.13.2018.06.05.16.51.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Jun 2018 16:52:00 -0700 (PDT) From: Noam Postavsky To: Alexis Subject: Re: bug#23294: 25.0.92; modify-file-local-variable-prop-line adds extra "; " References: <871t67uwz5.fsf@gmail.com> Date: Tue, 05 Jun 2018 19:51:59 -0400 In-Reply-To: <871t67uwz5.fsf@gmail.com> (Alexis's message of "Fri, 15 Apr 2016 17:55:58 +1000") Message-ID: <87y3fs6bc0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23294 Cc: 23294@debbugs.gnu.org, "Mohammed Sadik P. K." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 23294 minor found 23294 26.1 tags 23294 + confirmed easy quit Alexis writes: > Mohammed Sadik P. K. writes: > >> For the function modify-file-local-variable-prop-line if run with >> 'add-or-replace as the third argument, it should replace the current >> values. It does, but along with replacing the values, it adds an >> extra "; " at the beginning of the variable. > > Reproduced on 24.5 (Debian Jessie x86_64). Right, looks like this expression in modify-file-local-variable-prop-line should be modified to handle some whitespace after the semicolon. (if (and (not (eq (char-before) ?\;)) From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 14 11:20:21 2018 Received: (at 23294) by debbugs.gnu.org; 14 Aug 2018 15:20:21 +0000 Received: from localhost ([127.0.0.1]:50975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fpb7M-0006TF-7A for submit@debbugs.gnu.org; Tue, 14 Aug 2018 11:20:21 -0400 Received: from forward101o.mail.yandex.net ([37.140.190.181]:48051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fpWCi-00043p-S1 for 23294@debbugs.gnu.org; Tue, 14 Aug 2018 06:05:33 -0400 Received: from mxback10g.mail.yandex.net (mxback10g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:171]) by forward101o.mail.yandex.net (Yandex) with ESMTP id 2F3BA134762A for <23294@debbugs.gnu.org>; Tue, 14 Aug 2018 13:05:26 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback10g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id aBlbw4RctL-5PCmrGWK; Tue, 14 Aug 2018 13:05:25 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.com; s=mail; t=1534241125; bh=9zRKtBc6mId/j+cilYRC3PbpuAj8pECNMBIzfNPb6ck=; h=From:To:Subject:Date:Message-Id; b=Mu1dq91gHp4HSXNRbPUURMw3UZl5xNef40ZPCdDdjMQpl3G+84UeALpdTJ1JgxskW 8TmdlPtuoFx3673PFtWB5OVhfwmH+hm8+lO0RQFvDADqPozdYGtvuI2oqCSZOTKhvn F9+BO/IQoX2SZAQzDLHBG7dN+c6NWs52BAbFFaAk= Authentication-Results: mxback10g.mail.yandex.net; dkim=pass header.i=@yandex.com Received: by iva4-f774db2b5297.qloud-c.yandex.net with HTTP; Tue, 14 Aug 2018 13:05:25 +0300 From: Wenjamin Petrenko Envelope-From: wenjamin-petrenko@yandex.ru To: 23294@debbugs.gnu.org Subject: Re: bug#23294 MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Tue, 14 Aug 2018 13:05:25 +0300 Message-Id: <13011331534241125@iva4-f774db2b5297.qloud-c.yandex.net> Content-Type: multipart/mixed; boundary="----==--bound.1301139.iva4-f774db2b5297.qloud-c.yandex.net" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23294 X-Mailman-Approved-At: Tue, 14 Aug 2018 11:20:19 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) ------==--bound.1301139.iva4-f774db2b5297.qloud-c.yandex.net Content-Transfer-Encoding: 7bit Content-Type: text/plain A patch with a fix is attached. ------==--bound.1301139.iva4-f774db2b5297.qloud-c.yandex.net Content-Disposition: attachment; filename="0001-Fix-bug-23294.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name="0001-Fix-bug-23294.patch" RnJvbSBjNTIwYWM5OTJlNjgzYWJiODYyNWJiOTJiZmEzYWM3NTIwOWJjMGZiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBXZW5qYW1pbiBQZXRyZW5rbyA8d2VuamFtaW4ucGV0cmVua29A eWFuZGV4LnJ1PgpEYXRlOiBUdWUsIDE0IEF1ZyAyMDE4IDExOjQ0OjE4ICswMzAwClN1YmplY3Q6 IFtQQVRDSF0gRml4IGJ1ZyMyMzI5NAoKKiBsaXNwL2ZpbGVzLXguZWwgKG1vZGlmeS1maWxlLWxv Y2FsLXZhcmlhYmxlLXByb3AtbGluZSk6IEhhbmRsZQp3aGl0ZXNwYWNlIHdoZW4gY2hlY2tpbmcg aWYgdGhlcmUncyBhICc7JyBiZWZvcmUgdGhlIHZhcmlhYmxlIG5hbWUuCi0tLQogbGlzcC9maWxl cy14LmVsIHwgNCArKystCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9maWxlcy14LmVsIGIvbGlzcC9maWxlcy14LmVsCmlu ZGV4IDJhNTI3OTIyMjIuLmYwZGZhOTdkNDAgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZXMteC5lbAor KysgYi9saXNwL2ZpbGVzLXguZWwKQEAgLTM3Nyw3ICszNzcsOSBAQCBmcm9tIHRoZSAtKi0gbGlu ZSBpZ25vcmluZyB0aGUgaW5wdXQgYXJndW1lbnQgVkFMVUUuIgogCSAgICgoZXEgdmFyaWFibGUg J21vZGUpIChnb3RvLWNoYXIgYmVnKSkKIAkgICAoKG51bGwgcmVwbGFjZWQtcG9zKSAoZ290by1j aGFyIGVuZCkpCiAJICAgKHJlcGxhY2VkLXBvcyAoZ290by1jaGFyIHJlcGxhY2VkLXBvcykpKQot CSAgKGlmIChhbmQgKG5vdCAoZXEgKGNoYXItYmVmb3JlKSA/XDspKQorCSAgKGlmIChhbmQgKHNh dmUtZXhjdXJzaW9uCisJCSAgICAgKHNraXAtY2hhcnMtYmFja3dhcmQgIiBcdCIpCisJCSAgICAg KG5vdCAoZXEgKGNoYXItYmVmb3JlKSA/XDspKSkKIAkJICAgKG5vdCAoZXF1YWwgKHBvaW50KSAo bWFya2VyLXBvc2l0aW9uIGJlZykpKQogCQkgICA7OyBXaGVuIGV4aXN0aW5nIGAtKi0gLSotJyBp cyBlbXB0eSwgYmVnID4gZW5kLgogCQkgICAobm90ICg+IChtYXJrZXItcG9zaXRpb24gYmVnKSAo bWFya2VyLXBvc2l0aW9uIGVuZCkpKSkKLS0gCjIuMTQuMQoK ------==--bound.1301139.iva4-f774db2b5297.qloud-c.yandex.net-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 15 20:02:10 2018 Received: (at 23294) by debbugs.gnu.org; 16 Aug 2018 00:02:10 +0000 Received: from localhost ([127.0.0.1]:52151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fq5ju-0003ET-Cv for submit@debbugs.gnu.org; Wed, 15 Aug 2018 20:02:10 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:36145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fq5js-0003E9-S1; Wed, 15 Aug 2018 20:02:09 -0400 Received: by mail-io0-f179.google.com with SMTP id m4-v6so2468617iop.3; Wed, 15 Aug 2018 17:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=3NM1RtvCgxa3wkOCaH9sw9J49S5Na+AAAL3fM/gUJ4o=; b=XnHZRZzzyI/ojiPxr0nKAP/Bl5VzZXnGhcKpwkGLDUc3e1UUQ+Q1nDdP5QDMvLYJTp Ab9T005LQP0nh31Vuses2dydgpB1THy/crf5uTL9yyu1yfm2+8oZmncyaGk5Iae6INDB +ScWCwlbmDgrVpS6zE7O6elWjQaDYWLdPGqhkBz4/B2mmACi9nn8aI2p4ecLCCpHI9zc F/YDtR18IDvt5eJoXTjjYXE8PNQUPjHn5p0CSvr4Zcpi4c07iWB8X3YY8Jpa2o/kSP4u pQ5+rfLkfOzX5UUGlLbFFQLUfhQY1RIFCsDU2GLPRZtWrT1f/SgNJf6L+am7/pfUfTdX 0c3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3NM1RtvCgxa3wkOCaH9sw9J49S5Na+AAAL3fM/gUJ4o=; b=eL4pw+mLNpFRKGCRLb+wfVzhjqcMvuLtGjWbnbBCXLGJ3QgnGR8Pi7wrCeSYRcaGMd FwGRhNIlxuVz6juBO2qf0oz8FFWKdn+gsHtAGUsOyMFC6lgjqIWCl2V+t6ZZcSmq6FoO 0bSKP3wMdfrxhehpxtwvOEzCu4DrHoBdX6Blt2tMcvp4CBzgwDWwx3JDohG9RTxy8JED Zp6B3tSsa2qbswojMciL8WHlY81v94mEw8z4yGOkDYk5j0Ak5o9hyx49BkRup1aoc+hY Lrat8OlF4fZUYdjEPdlbYybP1iCAFqMS0+E0x3TDAtLPFQ8zFCM5Bi3NrUajLpRNwK/c jFUw== X-Gm-Message-State: AOUpUlHpl+pkNlw47R7hA3eX5rHFnkD4cuvEzlUFc8mXFSy03P/styPC hA6P5Ges/cRLbK0wILMzoBUSxxRG X-Google-Smtp-Source: AA+uWPwcfylsG0PG5J0PCh0Avsxq7IjwIhtixqF5jRXh6zobEKezm9V6gyQx1Y8fvHDQ6v8+b1bO2Q== X-Received: by 2002:a6b:b657:: with SMTP id g84-v6mr23586975iof.210.1534377723222; Wed, 15 Aug 2018 17:02:03 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id o18-v6sm8629879ioa.83.2018.08.15.17.02.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Aug 2018 17:02:02 -0700 (PDT) From: Noam Postavsky To: Wenjamin Petrenko Subject: Re: bug#23294: 25.0.92; modify-file-local-variable-prop-line adds extra "; " References: <13011331534241125@iva4-f774db2b5297.qloud-c.yandex.net> Date: Wed, 15 Aug 2018 20:02:01 -0400 In-Reply-To: <13011331534241125@iva4-f774db2b5297.qloud-c.yandex.net> (Wenjamin Petrenko's message of "Tue, 14 Aug 2018 13:05:25 +0300") Message-ID: <877ekrxjpi.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23294 Cc: 23294@debbugs.gnu.org, "Mohammed Sadik P. K." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 23294 + patch quit Wenjamin Petrenko writes: > Subject: [PATCH] Fix bug#23294 > > * lisp/files-x.el (modify-file-local-variable-prop-line): Handle > whitespace when checking if there's a ';' before the variable name. > - (if (and (not (eq (char-before) ?\;)) > + (if (and (save-excursion > + (skip-chars-backward " \t") > + (not (eq (char-before) ?\;))) This looks reasonable. Could you give a more informative summary line please? I.e., one where I can see what the bug is about without having memorized all bug numbers. And same for your email subject headers, if you don't mind. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 16 11:16:30 2018 Received: (at 23294) by debbugs.gnu.org; 16 Aug 2018 15:16:31 +0000 Received: from localhost ([127.0.0.1]:52720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqK0h-00009y-Pg for submit@debbugs.gnu.org; Thu, 16 Aug 2018 11:16:29 -0400 Received: from forward2o.cmail.yandex.net ([37.9.109.243]:36261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqFvL-000237-AV for 23294@debbugs.gnu.org; Thu, 16 Aug 2018 06:54:40 -0400 Received: from mxback12j.mail.yandex.net (mxback12j.mail.yandex.net [IPv6:2a02:6b8:0:1619::87]) by forward2o.cmail.yandex.net (Yandex) with ESMTP id C2BB2211F6; Thu, 16 Aug 2018 13:54:32 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback12j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id sALq68fqBZ-sVSS1rUK; Thu, 16 Aug 2018 13:54:32 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1534416872; bh=niqOl4Og/pxxKcUTweZrpEcl0+3qKckWNOhJTsBuC7M=; h=From:To:Cc:In-Reply-To:References:Subject:Date:Message-Id; b=RSVWmlnm6UAfPye6DmP7e2GgZW2Mk4cxo5QA1tcJXqhMnVgU+HQ9NG0BoIi9lC1Qk qpSOgCnckrZctT9Cvkot9420PP9xaQofN/vkY9WCy0T1XWlZJoKWBblyGXtMXJ3z0V /5wfq1uyx7u/LvAaxFuEPZQ/a2wXLmIJTe/YscoM= Authentication-Results: mxback12j.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by iva3-a2a8aac410a1.qloud-c.yandex.net with HTTP; Thu, 16 Aug 2018 13:54:31 +0300 From: Wenjamin Petrenko Envelope-From: wenjamin-petrenko@yandex.ru To: Noam Postavsky In-Reply-To: <877ekrxjpi.fsf_-_@gmail.com> References: <13011331534241125@iva4-f774db2b5297.qloud-c.yandex.net> <877ekrxjpi.fsf_-_@gmail.com> Subject: Re: bug#23294: 25.0.92; modify-file-local-variable-prop-line adds extra "; " MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Thu, 16 Aug 2018 13:54:31 +0300 Message-Id: <1012371534416871@iva3-a2a8aac410a1.qloud-c.yandex.net> Content-Type: multipart/mixed; boundary="----==--bound.101239.iva3-a2a8aac410a1.qloud-c.yandex.net" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23294 X-Mailman-Approved-At: Thu, 16 Aug 2018 11:16:26 -0400 Cc: 23294@debbugs.gnu.org, "Mohammed Sadik P. K." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) ------==--bound.101239.iva3-a2a8aac410a1.qloud-c.yandex.net Content-Transfer-Encoding: 7bit Content-Type: text/plain Noam Postavsky gmail.com> writes: > This looks reasonable. Could you give a more informative summary line > please? I.e., one where I can see what the bug is about without having > memorized all bug numbers. And same for your email subject headers, if > you don't mind. Done. ------==--bound.101239.iva3-a2a8aac410a1.qloud-c.yandex.net Content-Disposition: attachment; filename="0001-Prevent-modify-file-local-variable-prop-line-from-ad.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name="0001-Prevent-modify-file-local-variable-prop-line-from-ad.patch" RnJvbSAyZmYyYjgxYWNjNTVlMDI4NmY3Y2Y0YjI2YWM1YjhkNWZmNWUzN2U3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBXZW5qYW1pbiBQZXRyZW5rbyA8d2VuamFtaW4ucGV0cmVua29A eWFuZGV4LnJ1PgpEYXRlOiBUdWUsIDE0IEF1ZyAyMDE4IDExOjQ0OjE4ICswMzAwClN1YmplY3Q6 IFtQQVRDSF0gUHJldmVudCBgbW9kaWZ5LWZpbGUtbG9jYWwtdmFyaWFibGUtcHJvcC1saW5lJyBm cm9tIGFkZGluZyBleHRyYSAnOycKKGJ1ZyMyMzI5NCkKCiogbGlzcC9maWxlcy14LmVsIChtb2Rp ZnktZmlsZS1sb2NhbC12YXJpYWJsZS1wcm9wLWxpbmUpOiBIYW5kbGUKd2hpdGVzcGFjZSB3aGVu IGNoZWNraW5nIGlmIHRoZXJlJ3MgYWxyZWFkeSBhICc7JyBiZWZvcmUgdGhlIHZhcmlhYmxlLgot LS0KIGxpc3AvZmlsZXMteC5lbCB8IDQgKysrLQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9u cygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZmlsZXMteC5lbCBiL2xpc3Av ZmlsZXMteC5lbAppbmRleCAyYTUyNzkyMjIyLi5mMGRmYTk3ZDQwIDEwMDY0NAotLS0gYS9saXNw L2ZpbGVzLXguZWwKKysrIGIvbGlzcC9maWxlcy14LmVsCkBAIC0zNzcsNyArMzc3LDkgQEAgZnJv bSB0aGUgLSotIGxpbmUgaWdub3JpbmcgdGhlIGlucHV0IGFyZ3VtZW50IFZBTFVFLiIKIAkgICAo KGVxIHZhcmlhYmxlICdtb2RlKSAoZ290by1jaGFyIGJlZykpCiAJICAgKChudWxsIHJlcGxhY2Vk LXBvcykgKGdvdG8tY2hhciBlbmQpKQogCSAgIChyZXBsYWNlZC1wb3MgKGdvdG8tY2hhciByZXBs YWNlZC1wb3MpKSkKLQkgIChpZiAoYW5kIChub3QgKGVxIChjaGFyLWJlZm9yZSkgP1w7KSkKKwkg IChpZiAoYW5kIChzYXZlLWV4Y3Vyc2lvbgorCQkgICAgIChza2lwLWNoYXJzLWJhY2t3YXJkICIg XHQiKQorCQkgICAgIChub3QgKGVxIChjaGFyLWJlZm9yZSkgP1w7KSkpCiAJCSAgIChub3QgKGVx dWFsIChwb2ludCkgKG1hcmtlci1wb3NpdGlvbiBiZWcpKSkKIAkJICAgOzsgV2hlbiBleGlzdGlu ZyBgLSotIC0qLScgaXMgZW1wdHksIGJlZyA+IGVuZC4KIAkJICAgKG5vdCAoPiAobWFya2VyLXBv c2l0aW9uIGJlZykgKG1hcmtlci1wb3NpdGlvbiBlbmQpKSkpCi0tIAoyLjE0LjEKCg== ------==--bound.101239.iva3-a2a8aac410a1.qloud-c.yandex.net-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 24 21:59:29 2018 Received: (at 23294) by debbugs.gnu.org; 25 Aug 2018 01:59:29 +0000 Received: from localhost ([127.0.0.1]:60104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ftNrN-0002Ok-CO for submit@debbugs.gnu.org; Fri, 24 Aug 2018 21:59:29 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:33796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ftNrK-0002OH-49; Fri, 24 Aug 2018 21:59:26 -0400 Received: by mail-it0-f51.google.com with SMTP id x79-v6so6702935ita.1; Fri, 24 Aug 2018 18:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=c9wvq/dlUSEl7cB68wjBL8UFuHXFMeKhov1IsZGVjL8=; b=MEW7KQsveTHq6CRCXLtY6n2pvrMJfLtmNRvuEmAtJ32vzxU0e8Ru7NAG10qialXHSc hHv8oCpOG1qfp85kISjHDg3fIf4b+TQPGaBo4R0h3DR8hWN1Yt6+vLhp+GLwbUz/jJ6M MyiymRrX0lr5THIs14P297x+4IONZY8dnf6QDREkuEbieXWJZ//3459hndKl9Eaj/clO Fj4FY8Q2rRlO0NGoasZji5waluaE2BBf4/9ZhcvAE+pi/wXLRLb2WWCpcVb3KJmprp6k szo9x1W+WECSm/mPl33ukFEbpeazpCUySKt/FpwJ7eTO5LZ6MpTjLYMHa3BqCyYY8xdI y4Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=c9wvq/dlUSEl7cB68wjBL8UFuHXFMeKhov1IsZGVjL8=; b=ml38adAGKygKThzBBDc9ikAVh69LOjXmQ/Rbiq0bDxYbeN2/w64opXY+Vuq7AN5o5p 9qZ8/ZWNa3q9Sloc0lZ6gr3sQXqS1nQQklhC+yLArAWBpROFvkYg/bNmANxtxFvbGqBy YgYdSPPoi5Mn9yIfiyx9B+6tiqq1+fqv051rTHqzu4Y6EyyP5CnsjPyfnOGl3LTbyt60 /B/qMz4sq6bEymFuSHHkMpIwj8EJSruSIbx9pYrmWQ2t2IOut0H3oQIHNv2ByEgp8DSn itEA0O7ZkFcrF0zQlDzvuNfzVQDBFlsZN9tbrX+6Emd0r1l6dVVflYLZOWgZXA2gUEg2 6ajA== X-Gm-Message-State: APzg51DH84jOqtcMW+hIPkZSStuTE1KP3erAcAZqnAZb6Ehy3mAnbS5G Immo/YVrAdV7c+lms/3BcKvnPiAt X-Google-Smtp-Source: ANB0VdZe4FbdnRrDQ1qPncMrhhFeqj4iBBJxKnWwEOPd7OyFJ8QHiYv/fMMozjsJax8f+ouIZHpCYQ== X-Received: by 2002:a24:400b:: with SMTP id n11-v6mr210031ita.2.1535162360328; Fri, 24 Aug 2018 18:59:20 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id b85-v6sm1279900itd.37.2018.08.24.18.59.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Aug 2018 18:59:19 -0700 (PDT) From: Noam Postavsky To: Wenjamin Petrenko Subject: Re: bug#23294: 25.0.92; modify-file-local-variable-prop-line adds extra "; " References: <13011331534241125@iva4-f774db2b5297.qloud-c.yandex.net> <877ekrxjpi.fsf_-_@gmail.com> <1012371534416871@iva3-a2a8aac410a1.qloud-c.yandex.net> Date: Fri, 24 Aug 2018 21:59:18 -0400 In-Reply-To: <1012371534416871@iva3-a2a8aac410a1.qloud-c.yandex.net> (Wenjamin Petrenko's message of "Thu, 16 Aug 2018 13:54:31 +0300") Message-ID: <87ftz3uryh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23294 Cc: 23294@debbugs.gnu.org, "Mohammed Sadik P. K." X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 23294 fixed close 23294 26.2 quit Wenjamin Petrenko writes: > Noam Postavsky gmail.com> writes: > >> This looks reasonable. Could you give a more informative summary line >> please? I.e., one where I can see what the bug is about without having >> memorized all bug numbers. And same for your email subject headers, if >> you don't mind. > > Done. Pushed to emacs-26. [1: 9a613d3ed0]: 2018-08-24 21:54:16 -0400 Prevent `modify-file-local-variable-prop-line' from adding extra ';' https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9a613d3ed0331f9fd2528520a96d977ebba57d7d From unknown Sat Aug 09 04:56:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 22 Sep 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator