GNU bug report logs - #23294
25.0.92; modify-file-local-variable-prop-line adds extra "; "

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23294 in the body.
You can then email your comments to 23294 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Mohammed Sadik P. K." <sadiq <at> sadiqpk.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.92; modify-file-local-variable-prop-line adds extra "; "
Date: Fri, 15 Apr 2016 07:22:40 +0530

For the function modify-file-local-variable-prop-line if run with
'add-or-replace as the third argument, it should replace the current
values. It does, but along with replacing the values, it adds an extra "; " at
the beginning of the variable.

Eg.:

my current first line:
   /* -*- mode: c; indent-tabs-mode: t; -*- */

I executed (modify-file-local-variable-prop-line 'indent-tabs-mode 'nil
'add-or-replace)

The result was:

   /* -*- mode: c; ; indent-tabs-mode: nil; -*- */

Expected result:

   /* -*- mode: c; indent-tabs-mode: nil; -*- */

Each time I run the function, an "; " is added.



In GNU Emacs 25.0.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.18.9)
 of 2016-04-13 built on fedora.localdomain
Windowing system distributor 'Fedora Project', version 11.0.11800000
Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS
LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LC_MONETARY: en_IN.UTF-8
  value of $LC_NUMERIC: en_IN.UTF-8
  value of $LC_TIME: en_IN.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: C/l

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent messages:
Undo!
(No changes need to be saved)
For this change to take effect revisit file using M-x revert-buffer
Saving file /home/sadiq/test.c...
Wrote /home/sadiq/test.c
Making completion list... [2 times]
nil
Saving file /home/sadiq/test.c...
Wrote /home/sadiq/test.c
Making completion list...

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message dired format-spec rfc822 mml
mml-sec epg epg-config gnus-util mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils thingatpt help-fns
debug files-x cl-extra help-mode cc-mode cc-fonts easymenu cc-guess
cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
cl-loaddefs pcase cl-lib time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help
simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
dbusbind inotify dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 107079 7193)
 (symbols 48 21723 0)
 (miscs 40 82 182)
 (strings 32 20174 4378)
 (string-bytes 1 689608)
 (vectors 16 14280)
 (vector-slots 8 449743 7625)
 (floats 8 168 213)
 (intervals 56 281 16)
 (buffers 976 14)
 (heap 1024 54266 1231))

Message #8 received at 23294 <at> debbugs.gnu.org (full text, mbox):

From: Alexis <flexibeast <at> gmail.com>
To: "Mohammed Sadik P. K." <sadiq <at> sadiqpk.org>
Cc: 23294 <at> debbugs.gnu.org
Subject: Re: bug#23294: 25.0.92;
 modify-file-local-variable-prop-line adds extra "; "
Date: Fri, 15 Apr 2016 17:55:58 +1000

Mohammed Sadik P. K. <sadiq <at> sadiqpk.org> writes:

> For the function modify-file-local-variable-prop-line if run 
> with 'add-or-replace as the third argument, it should replace 
> the current values. It does, but along with replacing the 
> values, it adds an extra "; " at the beginning of the variable.
>
> Eg.:
>
> my current first line: 
>    /* -*- mode: c; indent-tabs-mode: t; -*- */
>
> I executed (modify-file-local-variable-prop-line 
> 'indent-tabs-mode 'nil 'add-or-replace)
>
> The result was:
>
>    /* -*- mode: c; ; indent-tabs-mode: nil; -*- */
>
> Expected result:
>
>    /* -*- mode: c; indent-tabs-mode: nil; -*- */
>
> Each time I run the function, an "; " is added.

Reproduced on 24.5 (Debian Jessie x86_64).

Message #11 received at 23294 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Alexis <flexibeast <at> gmail.com>
Cc: 23294 <at> debbugs.gnu.org, "Mohammed Sadik P. K." <sadiq <at> sadiqpk.org>
Subject: Re: bug#23294: 25.0.92;
 modify-file-local-variable-prop-line adds extra "; "
Date: Tue, 05 Jun 2018 19:51:59 -0400

severity 23294 minor
found 23294 26.1
tags 23294 + confirmed easy
quit

Alexis <flexibeast <at> gmail.com> writes:

> Mohammed Sadik P. K. <sadiq <at> sadiqpk.org> writes:
>
>> For the function modify-file-local-variable-prop-line if run with
>> 'add-or-replace as the third argument, it should replace the current
>> values. It does, but along with replacing the values, it adds an
>> extra "; " at the beginning of the variable.
>
> Reproduced on 24.5 (Debian Jessie x86_64).

Right, looks like this expression in
modify-file-local-variable-prop-line should be modified to handle some
whitespace after the semicolon.

	  (if (and (not (eq (char-before) ?\;))

Message #20 received at 23294 <at> debbugs.gnu.org (full text, mbox):

From: Wenjamin Petrenko <wenjamin.petrenko <at> yandex.com>
To: 23294 <at> debbugs.gnu.org
Subject: Re: bug#23294
Date: Tue, 14 Aug 2018 13:05:25 +0300

[Message part 1 (text/plain, inline)]

A patch with a fix is attached.

[0001-Fix-bug-23294.patch (text/x-diff, attachment)]

Message #23 received at 23294 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Wenjamin Petrenko <wenjamin.petrenko <at> yandex.com>
Cc: 23294 <at> debbugs.gnu.org, "Mohammed Sadik P. K." <sadiq <at> sadiqpk.org>
Subject: Re: bug#23294: 25.0.92;
 modify-file-local-variable-prop-line adds extra "; "
Date: Wed, 15 Aug 2018 20:02:01 -0400

tags 23294 + patch
quit

Wenjamin Petrenko <wenjamin.petrenko <at> yandex.com> writes:

> Subject: [PATCH] Fix bug#23294
>
> * lisp/files-x.el (modify-file-local-variable-prop-line): Handle
> whitespace when checking if there's a ';' before the variable name.

> -	  (if (and (not (eq (char-before) ?\;))
> +	  (if (and (save-excursion
> +		     (skip-chars-backward " \t")
> +		     (not (eq (char-before) ?\;)))

This looks reasonable.  Could you give a more informative summary line
please?  I.e., one where I can see what the bug is about without having
memorized all bug numbers.  And same for your email subject headers, if
you don't mind.

Message #28 received at 23294 <at> debbugs.gnu.org (full text, mbox):

From: Wenjamin Petrenko <wenjamin.petrenko <at> yandex.ru>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 23294 <at> debbugs.gnu.org, "Mohammed Sadik P. K." <sadiq <at> sadiqpk.org>
Subject: Re: bug#23294: 25.0.92;
 modify-file-local-variable-prop-line adds extra "; "
Date: Thu, 16 Aug 2018 13:54:31 +0300

[Message part 1 (text/plain, inline)]

Noam Postavsky <npostavs <at> gmail.com> writes:

> This looks reasonable. Could you give a more informative summary line
> please? I.e., one where I can see what the bug is about without having
> memorized all bug numbers. And same for your email subject headers, if
> you don't mind.

Done.

[0001-Prevent-modify-file-local-variable-prop-line-from-ad.patch (text/x-diff, attachment)]

Message #31 received at 23294 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Wenjamin Petrenko <wenjamin.petrenko <at> yandex.ru>
Cc: 23294 <at> debbugs.gnu.org, "Mohammed Sadik P. K." <sadiq <at> sadiqpk.org>
Subject: Re: bug#23294: 25.0.92;
 modify-file-local-variable-prop-line adds extra "; "
Date: Fri, 24 Aug 2018 21:59:18 -0400

tags 23294 fixed
close 23294 26.2
quit

Wenjamin Petrenko <wenjamin.petrenko <at> yandex.ru> writes:

> Noam Postavsky <npostavs <at> gmail.com> writes:
>
>> This looks reasonable. Could you give a more informative summary line
>> please? I.e., one where I can see what the bug is about without having
>> memorized all bug numbers. And same for your email subject headers, if
>> you don't mind.
>
> Done.

Pushed to emacs-26.

[1: 9a613d3ed0]: 2018-08-24 21:54:16 -0400
  Prevent `modify-file-local-variable-prop-line' from adding extra ';'
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9a613d3ed0331f9fd2528520a96d977ebba57d7d

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.