GNU bug report logs - #23290
25.1.50; eww: Symbol’s value as variable is void: url-http-response-status

Previous Next

Package: emacs;

Reported by: Michael Heerdegen <michael_heerdegen <at> web.de>

Date: Thu, 14 Apr 2016 19:09:02 UTC

Severity: normal

Tags: fixed

Found in version 25.1.50

Fixed in version 26.1

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tao Fang <fangtao0901 <at> gmail.com>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: bug-gnu-emacs <at> gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: 25.1.50; eww: Symbol’s value as variable is
 void: url-http-response-status
Date: Sun, 17 Apr 2016 01:19:01 +0800
[Message part 1 (text/plain, inline)]
Hi, Michael

After some digging, I found a code bug in commit
3c623c26ae7d695746e05d8a2e16a67a6256b024 introduced by me and maybe
relavant to your report.

lisp/url/url-http.el:

  1319	(defun url-https-proxy-after-change-function (st nd length)
......
  1327	      (url-http-parse-response)
  1328	      (cond
......
  1360	       (t
  1361	        (url-http-activate-callback)
  1362	        (message "error response: %d" url-http-response-status))))))
......

When using url-http in eww and the above "cond" last clause succeed
(i.e. at first connecting to proxy response not HTTP 200), "url-http-activate-callback" will call
function "eww-render" which calls (kill-buffer), so the code next line
visit symbol url-http-response-status will cause the error: "Symbol’s
value as variable is void: url-http-response-status".

This can be fixed simplely transpose that two code lines:
[0001-fix-void-variable-url-http-response-status.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
Can you help to apply the patch and test on that in your environment?

And I'm not sure about this, because only using https proxy will enter
this function(if I do it right?), I still need to find out about it.

Thanks for your help!

-- 
Emacs/Gnus

This bug report was last modified 8 years and 173 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.