From unknown Sat Aug 16 21:01:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23254: 25.0.90; substitute-command-keys does not preserve text properties Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Apr 2016 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23254 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 23254@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.146022832919347 (code B ref -1); Sat, 09 Apr 2016 18:59:01 +0000 Received: (at submit) by debbugs.gnu.org; 9 Apr 2016 18:58:49 +0000 Received: from localhost ([127.0.0.1]:56357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoy5o-00051z-Rw for submit@debbugs.gnu.org; Sat, 09 Apr 2016 14:58:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoy5m-00051l-GD for submit@debbugs.gnu.org; Sat, 09 Apr 2016 14:58:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoy5g-0002TN-BY for submit@debbugs.gnu.org; Sat, 09 Apr 2016 14:58:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoy5g-0002TD-8i for submit@debbugs.gnu.org; Sat, 09 Apr 2016 14:58:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoy5f-0004Iw-0p for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 14:58:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoy5b-0002SR-Qs for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 14:58:38 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:62543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoy5b-0002SL-Hd for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 14:58:35 -0400 Received: from [18.189.83.142] ([18.189.83.142]) by mrelayeu.kundenserver.de (mreue104) with ESMTPSA (Nemesis) id 0LmL6w-1bOr4V0Zve-00ZuTs for ; Sat, 09 Apr 2016 20:58:33 +0200 From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Message-ID: <570950D5.70908@live.com> Date: Sat, 9 Apr 2016 14:58:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d0wdu9eqpQI2FeHEeNGf88afJFduwblVO" X-Provags-ID: V03:K0:QNoVLY0lfycyuuIy61ZbKiTnMIdKZ7/Ztk4jWPOLvkU78WzyKHe 4dHpyOFfFHtxb7N9yQFZST7OPU/dQJRQa7YWGZ7NZ1gXXRaFtf+TRVkk+ub0VL3CB4WuqE5 hn+Wzyqlphnb1RR4qCc5uCZdwCCnxOAcTHG1mAVvy9dRVqaozkoohtuNViLFlNOn6qcSUgH DfHS+PurQaXkbV/wH8Lgw== X-UI-Out-Filterresults: notjunk:1;V01:K0:JftA8wTGq8E=:07wvmd3PPid4Kdxd5MTTN1 tWt3FDPIrcuaULHaredngg29J/BZIOkBRPUV2lEGTnR/ZqpEgNv07QRPEH7qSL7eMtGdXx8ML UA7684j+zOnx7tTGhaXKZHHT9Rz7aFJ+j54kHcZl7DYhpByWlv0lmadvPRdq0xA1x06STBXof iWOEl+p7agwj4UZSw8hzOGXClsFIKnvKS1w4nC6KQ+mUn5s/aownj7s7elZpFO3L469QPvBK9 d4H+9eM/KRfSu8x049s2S9LRzEIPPW8ZJn6a1QH/FbaSKG/NqrCiybZflcHzu6CnTjGN4AhC4 RbMlb60n9DP06OiXCDUwiQPVkl5Ofbt/BLCSntDwf9x+A5uqcTjC8N7ozOW6mTuTWk8qFuWKT Dy7ZwpCOrIe8JYsDYmdnH4+xk91sPiv3ImM/lJTF4w6rZQdeZQAFteBDFbfdn5zADzW8A5Wm9 GqHzezdkkZ1lW50PnJ2ICYV9TJxxbLnxFWdqXkYlCM9DkU8oMbE4e45Z3WUXp+lJgK7ScLFzz f07qAcoxBRTmqOqwYJ7FcCCLIuR5nehuPEGaWrFR9dB/5qe8vxdYWNFl7F+5ZJX6aCZiGS5O2 40gfQ1MoHJlBKw2yDMjIcsVfP33DHIQxHuWaigNWe69KrrdYTVNgAfM+vKFzgy5r4CrbTQJ/K tlDSWwXD8KTh7UOU22qX+D0dkJveXCpNRLHJ3Ue2hm5i0syZpyFpk9i/phgCppFTKylU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d0wdu9eqpQI2FeHEeNGf88afJFduwblVO Content-Type: multipart/mixed; boundary="M6vpRMXDOsvjpSipiFtiaxFG3jCvPhwTS" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: bug-gnu-emacs@gnu.org Message-ID: <570950D5.70908@live.com> Subject: 25.0.90; substitute-command-keys does not preserve text properties --M6vpRMXDOsvjpSipiFtiaxFG3jCvPhwTS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable In Emacs 25, substitute-command-keys removes text properties of strings c= ontaining quotes: > In Emacs 25: (substitute-command-keys (propertize "`a'" 'prop 'val)) "=E2=80=98a=E2=80=99" > In Emacs 24.5: (substitute-command-keys (propertize "`a'" 'prop 'val)) #("`a'" 0 3 (prop val)) As Eli pointed out on the mailing list, > Anything that is substituted has its test properties removed: >=20 > (substitute-command-keys (propertize "\\[forward-char]" 'prop 'val)) > =3D> "C-f" >=20 > The above is from Emacs 24.5. >=20 > I think patches are welcome to reinstate the properties. This is an issue in particular for docstrings: (defcustom my/pretty/set/option nil "Demo text properties in customize." :group 'emacs :type `(set (const :tag ,(concat (propertize "Title of option 1 (bold o= n both 24.5 and 25)" 'face '(:weight bold)) "\n " (propertize "Docs of option 1, in a sm= aller font on both 24.5 and 25." 'face '(:height 0.9)))) (const :tag ,(concat (propertize "Title of option 2 (`bold'= on 24.5 but not 25)" 'face '(:weight bold)) "\n " (propertize "Docs of option 2, in a sm= aller font on 24.5, but not 25." 'face '(:height 0.9)))))) This example uses text properties on `:tag's to make the customize buffer= more readable. This works fine in GNU Emacs 24.5, but it stopped working= on master (and emacs-25), because of substitute-command-keys replacing q= uotes and as a side effect dropping text properties. Cl=C3=A9ment. --M6vpRMXDOsvjpSipiFtiaxFG3jCvPhwTS-- --d0wdu9eqpQI2FeHEeNGf88afJFduwblVO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXCVDWAAoJEPqg+cTm90wjHQsQALGxkHPcnYpAHtzvg0LQLfCu IsczkGbgMrF/UWKlie1fzyjTwQwvZYZ7WleYD2xP+DG3IIJu0u3qkIhLLlllBUzA Z2eBsWA9CzTAM+oq5ugaZYau6tkKAStttiEnI9OdtNSuIbeC9tZ1kr0kpIAdRIQk 5sCrQ4l1XxOeQ5Utyaz017LN6A4jz5HWqZhnzOsIAgmiOcNOOAPzpbITPoY8foUC phSOzOi9ZjeLkZYZMneG8gggZ14mPUVkX7+cJ6CAMwMVf7sk9ptWDDflCPfMWFFE tfLQvG6I94xsvQ+pLD/3k5CdIk5SzHa6cWnLbFVqD9uf2rpo+40oO2kqZeqiwyUZ nZ9dkKL1JQP5F+Hbav+4ySqGAq7ZlfrxrVgA0xs67dM+yC5dXOQ+LpTeMEP5amC+ IXxeBPA5wRHuZuMY70gPlrAaPFLeBiTHrTDaiUIZMDgDpDSWEC6N4rmkNym+6zJZ oKvSTwgblOARfeWnu9fjSKoqwp17zECQaSa5QWecYhbAqL5TCbv5Kd3SYt5KgNzu r8NWHz7G4ATOqwGQWv1/n0/qMsW2MI7ZhnLvr1Ivpp6evZzrDpWMV8FNdwCnAeL3 atS6aP16/brRedXM0hFfLIzWWfp1qbBQ0oUyfqWVfoloHlK1eOBDBkeh82S5SoIu eP/fJbZuus/GcyJBZQpt =4Vcp -----END PGP SIGNATURE----- --d0wdu9eqpQI2FeHEeNGf88afJFduwblVO-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 19:33:43 2016 Received: (at control) by debbugs.gnu.org; 10 Apr 2016 23:33:43 +0000 Received: from localhost ([127.0.0.1]:57697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apOrP-0002Q7-0v for submit@debbugs.gnu.org; Sun, 10 Apr 2016 19:33:43 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1apOrN-0002Po-5C for control@debbugs.gnu.org; Sun, 10 Apr 2016 19:33:41 -0400 Received: by mail-wm0-f45.google.com with SMTP id v188so67073717wme.1 for ; Sun, 10 Apr 2016 16:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:message-id:to:from:subject; bh=ON6JyuwpNgLrzrtcvhFFmU5aFTLbX4SzI5w8lLi85dk=; b=IAObJkmz75MgP4MEtuJHRYA9OPht35tAtt4E6oOQHM3RJQw6Y5wy1JcCzvpwpwzdyf 8xWl0vp/zzqzNRYxM+irElg0bzcJwfKI3Yqi/xizRNvqn2A2AYogrgveXPHMWByDt1ZX 5GdOhNhII7Ho4X8zChJqmiTmqBO9Eb2LmPJH4gWv5ZNr5oXb7zevcJL+5VPdAXro4wyw ycbEwIcuub0mC2dIvSKET6NdBwEPoLmwYp8X8MDkrups8sizzqcsdEnj79W+gINu6eiX oIpXXagDdFe5OXcspc5WKIFfgm7cmEztP7/ClQIapCQ3b9i1c8x9vK+cKzqYj42ex8Db XqTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:message-id:to:from:subject; bh=ON6JyuwpNgLrzrtcvhFFmU5aFTLbX4SzI5w8lLi85dk=; b=CdBugo6r6phUz/drxm6qhqFkGQP8omo8EaYK3KjiXzIVcjnaDfGHNFI1QfCrdBbJeS S6Zv8bHGPpBqFf5SLiTMk7IMsII5zA6QKrXi+RNJmwNhLr1t+/rRrjNuiFiH1JnlLuTs CpflV3POfT32w3W3Mdqj6B2QyBBHzZHPRVqjuOGKke4GUm3hWLKYLTkQiEmCkLX33l94 x+0HBD9i3WbrTW1He6W1MPlV+wbnVrN1+srRKxLlXU5NrXj593yJtaGuOxPEmfFZMHjp KAn21buSUByAtShhY2kAH5UNDKnUe9Bz2PpmtKlNQu+WQqy83mfnCVrxE6M3GH98NkQz uimw== X-Gm-Message-State: AD7BkJLU2xrQvuOa83cGBvJ9ru7JGbysQonYStvKbDWs9C0rjZeNuonLMxeqsac+fRZADg== X-Received: by 10.28.21.14 with SMTP id 14mr14462463wmv.39.1460331215566; Sun, 10 Apr 2016 16:33:35 -0700 (PDT) Received: from axl ([185.105.175.24]) by smtp.gmail.com with ESMTPSA id l124sm14367956wmf.11.2016.04.10.16.33.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Apr 2016 16:33:35 -0700 (PDT) Date: Mon, 11 Apr 2016 02:33:33 +0300 Message-Id: <8637qtkpiq.fsf@yandex.ru> To: control@debbugs.gnu.org From: Dmitry Gutov Subject: control message for bug #19759 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) block 19759 by 23254 From unknown Sat Aug 16 21:01:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Subject: bug#23254: closed (Re: 25.0.90; substitute-command-keys does not preserve text properties) Message-ID: References: <570FB719.7090706@cs.ucla.edu> <570950D5.70908@live.com> X-Gnu-PR-Message: they-closed 23254 X-Gnu-PR-Package: emacs Reply-To: 23254@debbugs.gnu.org Date: Thu, 14 Apr 2016 15:29:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1460647741-22279-1" This is a multi-part message in MIME format... ------------=_1460647741-22279-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #23254: 25.0.90; substitute-command-keys does not preserve text properties which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 23254@debbugs.gnu.org. --=20 23254: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23254 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1460647741-22279-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 23254-done) by debbugs.gnu.org; 14 Apr 2016 15:28:39 +0000 Received: from localhost ([127.0.0.1]:35482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqjCB-0005mk-G3 for submit@debbugs.gnu.org; Thu, 14 Apr 2016 11:28:39 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqjC8-0005mW-WB for 23254-done@debbugs.gnu.org; Thu, 14 Apr 2016 11:28:37 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 17509160E69; Thu, 14 Apr 2016 08:28:31 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id cAKB-ENMNeNG; Thu, 14 Apr 2016 08:28:25 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B5D4716120B; Thu, 14 Apr 2016 08:28:25 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4O4flGs0kqeB; Thu, 14 Apr 2016 08:28:25 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8C57F160E69; Thu, 14 Apr 2016 08:28:25 -0700 (PDT) To: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= From: Paul Eggert Subject: Re: 25.0.90; substitute-command-keys does not preserve text properties Organization: UCLA Computer Science Department Message-ID: <570FB719.7090706@cs.ucla.edu> Date: Thu, 14 Apr 2016 08:28:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060808050006020203050903" X-Spam-Score: -1.0 (-) X-Debbugs-Envelope-To: 23254-done Cc: 23254-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------060808050006020203050903 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Although substitute-command-keys has never kept text properties when it makes a change, it is annoying that merely substituting quotes strips the properties, so I installed the attached patch into emacs-25 to fix this particular problem. Thanks for reporting it. --------------060808050006020203050903 Content-Type: application/x-patch; name="0001-substitute-command-keys-keeps-quotes-text-props.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-substitute-command-keys-keeps-quotes-text-props.patch" RnJvbSA5MzBhNzNiMjYyMWEwM2JiNjNhZTUxOTk3NWIwNGJkZDhkOWFhMWM0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUaHUsIDE0IEFwciAyMDE2IDA4OjIxOjM0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gPT9VVEYtOD9xP3N1YnN0aXR1dGUtY29tbWFuZC1rZXlzPTIwa2VlcHM9MjBxdW90ZXM/ PQogPT9VVEYtOD9xPz1FMj04MD05OT0yMHRleHQ9MjBwcm9wcz89Ck1JTUUtVmVyc2lvbjog MS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRy YW5zZmVyLUVuY29kaW5nOiA4Yml0CgpQcm9ibGVtIHJlcG9ydGVkIGJ5IENsw6ltZW50IFBp dC0tQ2xhdWRlbCAoQnVnIzIzMjU0KS4KKiBzcmMvZG9jLmM6IEluY2x1ZGUgaW50ZXJ2YWxz LmguCihGc3Vic3RpdHV0ZV9jb21tYW5kX2tleXMpOiBJZiB0aGUgb25seSBzdWJzdGl0dXRp b25zIGFyZSBmb3IKcXVvdGVzLCBjb3B5IHRoZSBzb3VyY2Ugc3RyaW5n4oCZcyB0ZXh0IHBy b3BlcnRpZXMgdG9vLCBzaW5jZSBubwpzdWJzdHJpbmcgbGVuZ3RocyBoYXZlIGNoYW5nZWQu Ci0tLQogc3JjL2RvYy5jIHwgMjUgKysrKysrKysrKysrKysrKysrKysrKy0tLQogMSBmaWxl IGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0 IGEvc3JjL2RvYy5jIGIvc3JjL2RvYy5jCmluZGV4IDFkNDY2NjEuLjdjZGIwZDAgMTAwNjQ0 Ci0tLSBhL3NyYy9kb2MuYworKysgYi9zcmMvZG9jLmMKQEAgLTM0LDYgKzM0LDcgQEAgYWxv bmcgd2l0aCBHTlUgRW1hY3MuICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xp Y2Vuc2VzLz4uICAqLwogI2luY2x1ZGUgImNvZGluZy5oIgogI2luY2x1ZGUgImJ1ZmZlci5o IgogI2luY2x1ZGUgImRpc3B0YWIuaCIKKyNpbmNsdWRlICJpbnRlcnZhbHMuaCIKICNpbmNs dWRlICJrZXltYXAuaCIKIAogLyogQnVmZmVyIHVzZWQgZm9yIHJlYWRpbmcgZnJvbSBkb2N1 bWVudGF0aW9uIGZpbGUuICAqLwpAQCAtNzM5LDYgKzc0MCw3IEBAIE90aGVyd2lzZSwgcmV0 dXJuIGEgbmV3IHN0cmluZy4gICovKQogewogICBjaGFyICpidWY7CiAgIGJvb2wgY2hhbmdl ZCA9IGZhbHNlOworICBib29sIG5vbnF1b3Rlc19jaGFuZ2VkID0gZmFsc2U7CiAgIHVuc2ln bmVkIGNoYXIgKnN0cnA7CiAgIGNoYXIgKmJ1ZnA7CiAgIHB0cmRpZmZfdCBpZHg7CkBAIC03 ODYsNyArNzg4LDcgQEAgT3RoZXJ3aXNlLCByZXR1cm4gYSBuZXcgc3RyaW5nLiAgKi8pCiAJ ewogCSAgLyogXD0gcXVvdGVzIHRoZSBuZXh0IGNoYXJhY3RlcjsKIAkgICAgIHRodXMsIHRv IHB1dCBpbiBcWyB3aXRob3V0IGl0cyBzcGVjaWFsIG1lYW5pbmcsIHVzZSBcPVxbLiAgKi8K LQkgIGNoYW5nZWQgPSB0cnVlOworCSAgY2hhbmdlZCA9IG5vbnF1b3Rlc19jaGFuZ2VkID0g dHJ1ZTsKIAkgIHN0cnAgKz0gMjsKIAkgIGlmIChtdWx0aWJ5dGUpCiAJICAgIHsKQEAgLTk0 Niw2ICs5NDgsOCBAQCBPdGhlcndpc2UsIHJldHVybiBhIG5ldyBzdHJpbmcuICAqLykKIAkg IGxlbmd0aCA9IFNDSEFSUyAodGVtKTsKIAkgIGxlbmd0aF9ieXRlID0gU0JZVEVTICh0ZW0p OwogCXN1YnN0OgorCSAgbm9ucXVvdGVzX2NoYW5nZWQgPSB0cnVlOworCXN1YnN0X3F1b3Rl OgogCSAgY2hhbmdlZCA9IHRydWU7CiAJICB7CiAJICAgIHB0cmRpZmZfdCBvZmZzZXQgPSBi dWZwIC0gYnVmOwpAQCAtOTY3LDcgKzk3MSw3IEBAIE90aGVyd2lzZSwgcmV0dXJuIGEgbmV3 IHN0cmluZy4gICovKQogCSAgbGVuZ3RoID0gMTsKIAkgIGxlbmd0aF9ieXRlID0gc2l6ZW9m IHVMU1FNIC0gMTsKIAkgIGlkeCA9IHN0cnAgLSBTREFUQSAoc3RyaW5nKSArIDE7Ci0JICBn b3RvIHN1YnN0OworCSAgZ290byBzdWJzdF9xdW90ZTsKIAl9CiAgICAgICBlbHNlIGlmIChz dHJwWzBdID09ICdgJyAmJiBxdW90aW5nX3N0eWxlID09IFNUUkFJR0hUX1FVT1RJTkdfU1RZ TEUpCiAJewpAQCAtMTAwMyw3ICsxMDA3LDIyIEBAIE90aGVyd2lzZSwgcmV0dXJuIGEgbmV3 IHN0cmluZy4gICovKQogICAgIH0KIAogICBpZiAoY2hhbmdlZCkJCQkvKiBkb24ndCBib3Ro ZXIgaWYgbm90aGluZyBzdWJzdGl0dXRlZCAqLwotICAgIHRlbSA9IG1ha2Vfc3RyaW5nX2Zy b21fYnl0ZXMgKGJ1ZiwgbmNoYXJzLCBidWZwIC0gYnVmKTsKKyAgICB7CisgICAgICB0ZW0g PSBtYWtlX3N0cmluZ19mcm9tX2J5dGVzIChidWYsIG5jaGFycywgYnVmcCAtIGJ1Zik7Cisg ICAgICBpZiAoIW5vbnF1b3Rlc19jaGFuZ2VkKQorCXsKKwkgIC8qIE5vdGhpbmcgaGFzIGNo YW5nZWQgb3RoZXIgdGhhbiBxdW90aW5nLCBzbyBjb3B5IHRoZSBzdHJpbmfigJlzCisJICAg ICB0ZXh0IHByb3BlcnRpZXMuICBGSVhNRTogVGV4dCBwcm9wZXJ0aWVzIHNob3VsZCBzdXJ2 aXZlIG90aGVyCisJICAgICBjaGFuZ2VzIHRvby4gICovCisJICBJTlRFUlZBTCBpbnRlcnZh bF9jb3B5ID0gY29weV9pbnRlcnZhbHMgKHN0cmluZ19pbnRlcnZhbHMgKHN0cmluZyksCisJ CQkJCQkgICAwLCBTQ0hBUlMgKHN0cmluZykpOworCSAgaWYgKGludGVydmFsX2NvcHkpCisJ ICAgIHsKKwkgICAgICBzZXRfaW50ZXJ2YWxfb2JqZWN0IChpbnRlcnZhbF9jb3B5LCB0ZW0p OworCSAgICAgIHNldF9zdHJpbmdfaW50ZXJ2YWxzICh0ZW0sIGludGVydmFsX2NvcHkpOwor CSAgICB9CisJfQorICAgIH0KICAgZWxzZQogICAgIHRlbSA9IHN0cmluZzsKICAgeGZyZWUg KGJ1Zik7Ci0tIAoyLjUuNQoK --------------060808050006020203050903-- ------------=_1460647741-22279-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 9 Apr 2016 18:58:49 +0000 Received: from localhost ([127.0.0.1]:56357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoy5o-00051z-Rw for submit@debbugs.gnu.org; Sat, 09 Apr 2016 14:58:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoy5m-00051l-GD for submit@debbugs.gnu.org; Sat, 09 Apr 2016 14:58:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoy5g-0002TN-BY for submit@debbugs.gnu.org; Sat, 09 Apr 2016 14:58:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51819) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoy5g-0002TD-8i for submit@debbugs.gnu.org; Sat, 09 Apr 2016 14:58:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoy5f-0004Iw-0p for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 14:58:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoy5b-0002SR-Qs for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 14:58:38 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:62543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoy5b-0002SL-Hd for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 14:58:35 -0400 Received: from [18.189.83.142] ([18.189.83.142]) by mrelayeu.kundenserver.de (mreue104) with ESMTPSA (Nemesis) id 0LmL6w-1bOr4V0Zve-00ZuTs for ; Sat, 09 Apr 2016 20:58:33 +0200 From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Subject: 25.0.90; substitute-command-keys does not preserve text properties To: bug-gnu-emacs@gnu.org Message-ID: <570950D5.70908@live.com> Date: Sat, 9 Apr 2016 14:58:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="d0wdu9eqpQI2FeHEeNGf88afJFduwblVO" X-Provags-ID: V03:K0:QNoVLY0lfycyuuIy61ZbKiTnMIdKZ7/Ztk4jWPOLvkU78WzyKHe 4dHpyOFfFHtxb7N9yQFZST7OPU/dQJRQa7YWGZ7NZ1gXXRaFtf+TRVkk+ub0VL3CB4WuqE5 hn+Wzyqlphnb1RR4qCc5uCZdwCCnxOAcTHG1mAVvy9dRVqaozkoohtuNViLFlNOn6qcSUgH DfHS+PurQaXkbV/wH8Lgw== X-UI-Out-Filterresults: notjunk:1;V01:K0:JftA8wTGq8E=:07wvmd3PPid4Kdxd5MTTN1 tWt3FDPIrcuaULHaredngg29J/BZIOkBRPUV2lEGTnR/ZqpEgNv07QRPEH7qSL7eMtGdXx8ML UA7684j+zOnx7tTGhaXKZHHT9Rz7aFJ+j54kHcZl7DYhpByWlv0lmadvPRdq0xA1x06STBXof iWOEl+p7agwj4UZSw8hzOGXClsFIKnvKS1w4nC6KQ+mUn5s/aownj7s7elZpFO3L469QPvBK9 d4H+9eM/KRfSu8x049s2S9LRzEIPPW8ZJn6a1QH/FbaSKG/NqrCiybZflcHzu6CnTjGN4AhC4 RbMlb60n9DP06OiXCDUwiQPVkl5Ofbt/BLCSntDwf9x+A5uqcTjC8N7ozOW6mTuTWk8qFuWKT Dy7ZwpCOrIe8JYsDYmdnH4+xk91sPiv3ImM/lJTF4w6rZQdeZQAFteBDFbfdn5zADzW8A5Wm9 GqHzezdkkZ1lW50PnJ2ICYV9TJxxbLnxFWdqXkYlCM9DkU8oMbE4e45Z3WUXp+lJgK7ScLFzz f07qAcoxBRTmqOqwYJ7FcCCLIuR5nehuPEGaWrFR9dB/5qe8vxdYWNFl7F+5ZJX6aCZiGS5O2 40gfQ1MoHJlBKw2yDMjIcsVfP33DHIQxHuWaigNWe69KrrdYTVNgAfM+vKFzgy5r4CrbTQJ/K tlDSWwXD8KTh7UOU22qX+D0dkJveXCpNRLHJ3Ue2hm5i0syZpyFpk9i/phgCppFTKylU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --d0wdu9eqpQI2FeHEeNGf88afJFduwblVO Content-Type: multipart/mixed; boundary="M6vpRMXDOsvjpSipiFtiaxFG3jCvPhwTS" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: bug-gnu-emacs@gnu.org Message-ID: <570950D5.70908@live.com> Subject: 25.0.90; substitute-command-keys does not preserve text properties --M6vpRMXDOsvjpSipiFtiaxFG3jCvPhwTS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable In Emacs 25, substitute-command-keys removes text properties of strings c= ontaining quotes: > In Emacs 25: (substitute-command-keys (propertize "`a'" 'prop 'val)) "=E2=80=98a=E2=80=99" > In Emacs 24.5: (substitute-command-keys (propertize "`a'" 'prop 'val)) #("`a'" 0 3 (prop val)) As Eli pointed out on the mailing list, > Anything that is substituted has its test properties removed: >=20 > (substitute-command-keys (propertize "\\[forward-char]" 'prop 'val)) > =3D> "C-f" >=20 > The above is from Emacs 24.5. >=20 > I think patches are welcome to reinstate the properties. This is an issue in particular for docstrings: (defcustom my/pretty/set/option nil "Demo text properties in customize." :group 'emacs :type `(set (const :tag ,(concat (propertize "Title of option 1 (bold o= n both 24.5 and 25)" 'face '(:weight bold)) "\n " (propertize "Docs of option 1, in a sm= aller font on both 24.5 and 25." 'face '(:height 0.9)))) (const :tag ,(concat (propertize "Title of option 2 (`bold'= on 24.5 but not 25)" 'face '(:weight bold)) "\n " (propertize "Docs of option 2, in a sm= aller font on 24.5, but not 25." 'face '(:height 0.9)))))) This example uses text properties on `:tag's to make the customize buffer= more readable. This works fine in GNU Emacs 24.5, but it stopped working= on master (and emacs-25), because of substitute-command-keys replacing q= uotes and as a side effect dropping text properties. Cl=C3=A9ment. --M6vpRMXDOsvjpSipiFtiaxFG3jCvPhwTS-- --d0wdu9eqpQI2FeHEeNGf88afJFduwblVO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXCVDWAAoJEPqg+cTm90wjHQsQALGxkHPcnYpAHtzvg0LQLfCu IsczkGbgMrF/UWKlie1fzyjTwQwvZYZ7WleYD2xP+DG3IIJu0u3qkIhLLlllBUzA Z2eBsWA9CzTAM+oq5ugaZYau6tkKAStttiEnI9OdtNSuIbeC9tZ1kr0kpIAdRIQk 5sCrQ4l1XxOeQ5Utyaz017LN6A4jz5HWqZhnzOsIAgmiOcNOOAPzpbITPoY8foUC phSOzOi9ZjeLkZYZMneG8gggZ14mPUVkX7+cJ6CAMwMVf7sk9ptWDDflCPfMWFFE tfLQvG6I94xsvQ+pLD/3k5CdIk5SzHa6cWnLbFVqD9uf2rpo+40oO2kqZeqiwyUZ nZ9dkKL1JQP5F+Hbav+4ySqGAq7ZlfrxrVgA0xs67dM+yC5dXOQ+LpTeMEP5amC+ IXxeBPA5wRHuZuMY70gPlrAaPFLeBiTHrTDaiUIZMDgDpDSWEC6N4rmkNym+6zJZ oKvSTwgblOARfeWnu9fjSKoqwp17zECQaSa5QWecYhbAqL5TCbv5Kd3SYt5KgNzu r8NWHz7G4ATOqwGQWv1/n0/qMsW2MI7ZhnLvr1Ivpp6evZzrDpWMV8FNdwCnAeL3 atS6aP16/brRedXM0hFfLIzWWfp1qbBQ0oUyfqWVfoloHlK1eOBDBkeh82S5SoIu eP/fJbZuus/GcyJBZQpt =4Vcp -----END PGP SIGNATURE----- --d0wdu9eqpQI2FeHEeNGf88afJFduwblVO-- ------------=_1460647741-22279-1-- From unknown Sat Aug 16 21:01:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23254: 25.0.90; substitute-command-keys does not preserve text properties Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Apr 2016 15:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23254 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 23254@debbugs.gnu.org Cc: clement.pitclaudel@live.com, eggert@cs.ucla.edu Received: via spool by 23254-submit@debbugs.gnu.org id=B23254.146064841123508 (code B ref 23254); Thu, 14 Apr 2016 15:41:02 +0000 Received: (at 23254) by debbugs.gnu.org; 14 Apr 2016 15:40:11 +0000 Received: from localhost ([127.0.0.1]:35498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqjNK-000670-Qs for submit@debbugs.gnu.org; Thu, 14 Apr 2016 11:40:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aqjNJ-00066V-Ml for 23254@debbugs.gnu.org; Thu, 14 Apr 2016 11:40:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aqjK4-0005iH-BB for 23254@debbugs.gnu.org; Thu, 14 Apr 2016 11:36:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aqjK4-0005iD-8S; Thu, 14 Apr 2016 11:36:48 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1aqjK3-0006l7-CM; Thu, 14 Apr 2016 11:36:47 -0400 From: Glenn Morris References: <570950D5.70908@live.com> <570FB719.7090706@cs.ucla.edu> X-Spook: Merlin SCUD missile Iraq Wildfire Irish Republican Army X-Ran: JajO*$zi9sme\u7DT9>:x%&|qy!N_]"Hn#rK$v=ju+^MP (Paul Eggert's message of "Thu, 14 Apr 2016 08:28:25 -0700") Message-ID: <6zr3e86w34.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) Paul Eggert wrote: > Although substitute-command-keys has never kept text properties when http://debbugs.gnu.org/17052