GNU bug report logs - #23242
[PATCH] ob-sql.el: set PGPASSWORD environment

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23242 in the body.
You can then email your comments to 23242 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Gerler <baron <at> bundesbrandschatzamt.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Andreas Gerler <baron <at> bundesbrandschatzamt.de>
Subject: [PATCH] ob-sql.el: set PGPASSWORD environment
Date: Fri,  8 Apr 2016 10:24:22 +0000

* postgresql: set environment variable PGPASSWORD if dbpassword was supplied
---
 lisp/ob-sql.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/ob-sql.el b/lisp/ob-sql.el
index 6488afe..bd3a51e 100644
--- a/lisp/ob-sql.el
+++ b/lisp/ob-sql.el
@@ -141,8 +141,9 @@ This function is called by `org-babel-execute-src-block'."
 				    (org-babel-process-file-name in-file)
 				    (org-babel-process-file-name out-file)))
 		    (`postgresql (format
-				  "psql --set=\"ON_ERROR_STOP=1\" %s -A -P \
+				  "%s psql --set=\"ON_ERROR_STOP=1\" %s -A -P \
 footer=off -F \"\t\"  %s -f %s -o %s %s"
+				  (if dbpassword (concat "PGPASSWORD='" dbpassword "'") "")
 				  (if colnames-p "" "-t")
 				  (org-babel-sql-dbstring-postgresql
 				   dbhost dbuser database)
-- 
2.4.5

Message #8 received at 23242 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Andreas Gerler <baron <at> bundesbrandschatzamt.de>
Cc: 23242 <at> debbugs.gnu.org
Subject: Re: bug#23242: [PATCH] ob-sql.el: set PGPASSWORD environment
Date: Fri, 08 Apr 2016 17:45:58 +0200

Andreas Gerler <baron <at> bundesbrandschatzamt.de> writes:

>  		    (`postgresql (format
> -				  "psql --set=\"ON_ERROR_STOP=1\" %s -A -P \
> +				  "%s psql --set=\"ON_ERROR_STOP=1\" %s -A -P \
>  footer=off -F \"\t\"  %s -f %s -o %s %s"
> +				  (if dbpassword (concat "PGPASSWORD='" dbpassword "'") "")

This will fail if dbpassword contains ?\'.  Environment variables should
be passed via process-environment.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #11 received at 23242 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Andreas Gerler <baron <at> bundesbrandschatzamt.de>
Cc: 23242 <at> debbugs.gnu.org
Subject: Re: bug#23242: [PATCH] ob-sql.el: set PGPASSWORD environment
Date: Wed, 14 Jun 2017 19:57:37 -0400

severity 23242 minor
close 23242 
quit

Andreas Gerler <baron <at> bundesbrandschatzamt.de> writes:

> * postgresql: set environment variable PGPASSWORD if dbpassword was supplied

This has been implemented in the org-mode repository.

2016-09-17 08:34:59 (GMT)
ob-sql: Add dbport and dbpassword options to postgresql
* lisp/ob-sql.el (org-babel-sql-dbstring-postgresql): Add port parameter.
(org-babel-execute:sql): Handle password and port in `postgresql' SQL engine.

http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=c257e31d10128f0c6705cee9586e9fc436ddfc28

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.