From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 03 08:59:17 2016 Received: (at submit) by debbugs.gnu.org; 3 Apr 2016 12:59:17 +0000 Received: from localhost ([127.0.0.1]:49505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amhcb-000453-7r for submit@debbugs.gnu.org; Sun, 03 Apr 2016 08:59:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amhcZ-00044p-JW for submit@debbugs.gnu.org; Sun, 03 Apr 2016 08:59:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amhcT-0003iu-99 for submit@debbugs.gnu.org; Sun, 03 Apr 2016 08:59:10 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amhcT-0003iq-5l for submit@debbugs.gnu.org; Sun, 03 Apr 2016 08:59:09 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47801) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amhcS-0001K6-1I for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 08:59:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amhcO-0003iM-Q8 for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 08:59:07 -0400 Received: from calancha-ilc.kek.jp ([130.87.234.234]:41982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amhcO-0003hw-Ad for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 08:59:04 -0400 Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id BD9425528; Sun, 3 Apr 2016 22:02:17 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 9DF8B544E for ; Sun, 3 Apr 2016 22:02:17 +0900 (JST) Date: Sun, 3 Apr 2016 22:02:17 +0900 (JST) From: Tino Calancha X-X-Sender: calancha@calancha-ilc.kek.jp To: bug-gnu-emacs@gnu.org Subject: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish Message-ID: User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="1468197610-560451294-1459688537=:28935" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --1468197610-560451294-1459688537=:28935 Content-Type: text/plain; format=flowed; charset=US-ASCII Good (or morning afternoon evening night) When `dired-do-shell-command' runs COMMAND over FILES in parallel, the `shell-command' process may finish before all the files have being processed. emacs -Q ~ * / & du SPC -s RET ; If the number of lines in # is less ; than (1+ (length (dired-get-marked-files))) then NOT all files ; has being processed. Attached patch fix this issue adding 'wait' at the end of COMMAND when FILES are procesed in parallel. In GNU Emacs 25.0.92.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.30) of 2016-04-01 built on calancha-pc Repository revision: a3daa34336da158555d96d670077eedb9eaeeb9c --1468197610-560451294-1459688537=:28935 Content-Type: text/plain; charset=US-ASCII; name=dired-aux.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=dired-aux.patch YTNkYWEzNDMzNmRhMTU4NTU1ZDk2ZDY3MDA3N2VlZGI5ZWFlZWI5Y2RpZmYg LS1naXQgYS9saXNwL2RpcmVkLWF1eC5lbCBiL2xpc3AvZGlyZWQtYXV4LmVs DQppbmRleCBkMjlhYmYzLi5mMzUxZDc5IDEwMDY0NA0KLS0tIGEvbGlzcC9k aXJlZC1hdXguZWwNCisrKyBiL2xpc3AvZGlyZWQtYXV4LmVsDQpAQCAtNzIy LDMzICs3MjIsNDMgQEAgZGlyZWQtc2hlbGwtc3R1ZmYtaXQNCiA7OyAoY29t aW5nIGZyb20gaW50ZXJhY3RpdmUgUCBhbmQgY3VycmVudGx5IGlnbm9yZWQp IHRvIGRlY2lkZSB3aGF0IHRvIGRvLg0KIDs7IFNtYXJ0IHdvdWxkIGJlIGEg d2F5IHRvIGFjY2VzcyBiYXNlbmFtZSBvciBleHRlbnNpb24gb2YgZmlsZSBu YW1lcy4NCiAgIChsZXQqICgoaW4tYmFja2dyb3VuZCAoc3RyaW5nLW1hdGNo ICJbIFx0XSomWyBcdF0qXFwnIiBjb21tYW5kKSkNCi0JIChjb21tYW5kIChp ZiBpbi1iYWNrZ3JvdW5kDQotCQkgICAgICAoc3Vic3RyaW5nIGNvbW1hbmQg MCAobWF0Y2gtYmVnaW5uaW5nIDApKQ0KLQkJICAgIGNvbW1hbmQpKQ0KLQkg KHNlcXVlbnRpYWxseSAoc3RyaW5nLW1hdGNoICJbIFx0XSo7WyBcdF0qXFwn IiBjb21tYW5kKSkNCi0JIChjb21tYW5kIChpZiBzZXF1ZW50aWFsbHkNCi0J CSAgICAgIChzdWJzdHJpbmcgY29tbWFuZCAwIChtYXRjaC1iZWdpbm5pbmcg MCkpDQotCQkgICAgY29tbWFuZCkpDQotCSAoc3R1ZmYtaXQNCi0JICAoaWYg KG9yIChzdHJpbmctbWF0Y2gtcCBkaXJlZC1zdGFyLXN1YnN0LXJlZ2V4cCBj b21tYW5kKQ0KLQkJICAoc3RyaW5nLW1hdGNoLXAgZGlyZWQtcXVhcmstc3Vi c3QtcmVnZXhwIGNvbW1hbmQpKQ0KLQkgICAgICAobGFtYmRhICh4KQ0KLQkJ KGxldCAoKHJldHZhbCBjb21tYW5kKSkNCi0JCSAgKHdoaWxlIChzdHJpbmct bWF0Y2gNCi0JCQkgICJcXCheXFx8WyBcdF1cXClcXChbKj9dXFwpXFwoWyBc dF1cXHwkXFwpIiByZXR2YWwpDQotCQkgICAgKHNldHEgcmV0dmFsIChyZXBs YWNlLW1hdGNoIHggdCB0IHJldHZhbCAyKSkpDQotCQkgIHJldHZhbCkpDQot CSAgICAobGFtYmRhICh4KSAoY29uY2F0IGNvbW1hbmQgZGlyZWQtbWFyay1z ZXBhcmF0b3IgeCkpKSkpDQorICAgICAgICAgKGNvbW1hbmQgKGlmIGluLWJh Y2tncm91bmQNCisgICAgICAgICAgICAgICAgICAgICAgKGxldCAoKGNtZCBj b21tYW5kKSkNCisgICAgICAgICAgICAgICAgICAgICAgICAod2hpbGUgKHN0 cmluZy1tYXRjaCAiWyBcdF0qWyZdK1sgXHRdKlxcJyIgY21kKQ0KKyAgICAg ICAgICAgICAgICAgICAgICAgICAgKHNldHEgY21kIChzdWJzdHJpbmcgY21k IDAgKG1hdGNoLWJlZ2lubmluZyAwKSkpKSBjbWQpDQorICAgICAgICAgICAg ICAgICAgICBjb21tYW5kKSkNCisgICAgICAgICAoc2VxdWVudGlhbGx5IChz dHJpbmctbWF0Y2ggIlsgXHRdKjtbIFx0XSpcXCciIGNvbW1hbmQpKQ0KKyAg ICAgICAgIChjb21tYW5kIChpZiBzZXF1ZW50aWFsbHkNCisgICAgICAgICAg ICAgICAgICAgICAgKGxldCAoKGNtZCBjb21tYW5kKSkNCisgICAgICAgICAg ICAgICAgICAgICAgICAod2hpbGUgKHN0cmluZy1tYXRjaCAiWyBcdF0qWztd K1sgXHRdKlxcJyIgY21kKQ0KKyAgICAgICAgICAgICAgICAgICAgICAgICAg KHNldHEgY21kIChzdWJzdHJpbmcgY21kIDAgKG1hdGNoLWJlZ2lubmluZyAw KSkpKSBjbWQpDQorICAgICAgICAgICAgICAgICAgICBjb21tYW5kKSkNCisg ICAgICAgICAoaW4tYmFjay1uby1zZXEgKGFuZCBpbi1iYWNrZ3JvdW5kIChu b3Qgc2VxdWVudGlhbGx5KSkpDQorICAgICAgICAgKHN0dWZmLWl0DQorICAg ICAgICAgIChpZiAob3IgKHN0cmluZy1tYXRjaC1wIGRpcmVkLXN0YXItc3Vi c3QtcmVnZXhwIGNvbW1hbmQpDQorICAgICAgICAgICAgICAgICAgKHN0cmlu Zy1tYXRjaC1wIGRpcmVkLXF1YXJrLXN1YnN0LXJlZ2V4cCBjb21tYW5kKSkN CisgICAgICAgICAgICAgIChsYW1iZGEgKHgpDQorICAgICAgICAgICAgICAg IChsZXQgKChyZXR2YWwgY29tbWFuZCkpDQorICAgICAgICAgICAgICAgICAg KHdoaWxlIChzdHJpbmctbWF0Y2gNCisgICAgICAgICAgICAgICAgICAgICAg ICAgICJcXCheXFx8WyBcdF1cXClcXChbKj9dXFwpXFwoWyBcdF1cXHwkXFwp IiByZXR2YWwpDQorICAgICAgICAgICAgICAgICAgICAoc2V0cSByZXR2YWwg KHJlcGxhY2UtbWF0Y2ggeCB0IHQgcmV0dmFsIDIpKSkNCisgICAgICAgICAg ICAgICAgICByZXR2YWwpKQ0KKyAgICAgICAgICAgIChsYW1iZGEgKHgpIChj b25jYXQgY29tbWFuZCBkaXJlZC1tYXJrLXNlcGFyYXRvciB4KSkpKSkNCiAg ICAgKGNvbmNhdA0KLSAgICAgKGlmIG9uLWVhY2gNCi0JIChtYXBjb25jYXQg c3R1ZmYtaXQgKG1hcGNhciAnc2hlbGwtcXVvdGUtYXJndW1lbnQgZmlsZS1s aXN0KQ0KLQkJICAgIChpZiAoYW5kIGluLWJhY2tncm91bmQgKG5vdCBzZXF1 ZW50aWFsbHkpKSAiJiIgIjsiKSkNCi0gICAgICAgKGxldCAoKGZpbGVzICht YXBjb25jYXQgJ3NoZWxsLXF1b3RlLWFyZ3VtZW50DQotCQkJICAgICAgIGZp bGUtbGlzdCBkaXJlZC1tYXJrLXNlcGFyYXRvcikpKQ0KLQkgKGlmICg+IChs ZW5ndGggZmlsZS1saXN0KSAxKQ0KLQkgICAgIChzZXRxIGZpbGVzIChjb25j YXQgZGlyZWQtbWFyay1wcmVmaXggZmlsZXMgZGlyZWQtbWFyay1wb3N0Zml4 KSkpDQotCSAoZnVuY2FsbCBzdHVmZi1pdCBmaWxlcykpKQ0KLSAgICAgKGlm IGluLWJhY2tncm91bmQgIiYiICIiKSkpKQ0KKyAgICAgKGNvbmQgKG9uLWVh Y2gNCisgICAgICAgICAgICAoZm9ybWF0ICIlcyVzIg0KKyAgICAgICAgICAg ICAgICAgICAgKG1hcGNvbmNhdCBzdHVmZi1pdCAobWFwY2FyICdzaGVsbC1x dW90ZS1hcmd1bWVudCBmaWxlLWxpc3QpDQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIChvciAoYW5kIGluLWJhY2stbm8tc2VxICImIikNCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICI7IikpDQorICAg ICAgICAgICAgICAgICAgICAob3IgKGFuZCBpbi1iYWNrLW5vLXNlcSAiJlxu d2FpdCIpOyBXYWl0IGZvciBiYWNrZ3JvdW5kIGpvYnMgZmluaXNoLg0KKyAg ICAgICAgICAgICAgICAgICAgICAgICIiKSkpDQorICAgICAgICAgICAodA0K KyAgICAgICAgICAgIChsZXQgKChmaWxlcyAobWFwY29uY2F0ICdzaGVsbC1x dW90ZS1hcmd1bWVudA0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGZpbGUtbGlzdCBkaXJlZC1tYXJrLXNlcGFyYXRvcikpKQ0KKyAg ICAgICAgICAgICAgKHdoZW4gKGNkciBmaWxlLWxpc3QpDQorICAgICAgICAg ICAgICAgIChzZXRxIGZpbGVzIChjb25jYXQgZGlyZWQtbWFyay1wcmVmaXgg ZmlsZXMgZGlyZWQtbWFyay1wb3N0Zml4KSkpDQorICAgICAgICAgICAgICAo ZnVuY2FsbCBzdHVmZi1pdCBmaWxlcykpKSkNCisgICAgIChvciAoYW5kIGlu LWJhY2tncm91bmQgIiYiKSAiIikpKSkNCiANCiA7OyBUaGlzIGlzIGFuIGV4 dHJhIGZ1bmN0aW9uIHNvIHRoYXQgaXQgY2FuIGJlIHJlZGVmaW5lZCBieSBh bmdlLWZ0cC4NCiA7OzsjIyNhdXRvbG9hZA0K --1468197610-560451294-1459688537=:28935-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 03 11:04:30 2016 Received: (at 23206) by debbugs.gnu.org; 3 Apr 2016 15:04:30 +0000 Received: from localhost ([127.0.0.1]:50095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amjZm-00078e-D0 for submit@debbugs.gnu.org; Sun, 03 Apr 2016 11:04:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amjZk-00078S-6u for 23206@debbugs.gnu.org; Sun, 03 Apr 2016 11:04:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amjZb-00038D-Vc for 23206@debbugs.gnu.org; Sun, 03 Apr 2016 11:04:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amjZb-000389-Rn; Sun, 03 Apr 2016 11:04:19 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3087 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1amjZb-0000Xz-6X; Sun, 03 Apr 2016 11:04:19 -0400 Date: Sun, 03 Apr 2016 18:03:52 +0300 Message-Id: <837fgeraxz.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Sun, 3 Apr 2016 22:02:17 +0900 (JST)) Subject: Re: bug#23206: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 23206 Cc: 23206@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Sun, 3 Apr 2016 22:02:17 +0900 (JST) > From: Tino Calancha > > When `dired-do-shell-command' runs COMMAND over FILES in > parallel, the `shell-command' process may finish before all the > files have being processed. > > emacs -Q ~ > > * / & du SPC -s RET > ; If the number of lines in # is less > ; than (1+ (length (dired-get-marked-files))) then NOT all files > ; has being processed. > > Attached patch fix this issue adding 'wait' at the end of COMMAND > when FILES are procesed in parallel. Thanks. Can you elaborate on why such a wait is needed? From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 03 12:35:42 2016 Received: (at 23206) by debbugs.gnu.org; 3 Apr 2016 16:35:42 +0000 Received: from localhost ([127.0.0.1]:50130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aml02-0000pN-2H for submit@debbugs.gnu.org; Sun, 03 Apr 2016 12:35:42 -0400 Received: from calancha-ilc.kek.jp ([130.87.234.234]:55378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aml00-0000pA-KJ for 23206@debbugs.gnu.org; Sun, 03 Apr 2016 12:35:41 -0400 Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id 66C1D5646; Mon, 4 Apr 2016 01:38:52 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 0BA825459; Mon, 4 Apr 2016 01:38:52 +0900 (JST) Date: Mon, 4 Apr 2016 01:38:52 +0900 (JST) From: Tino Calancha X-X-Sender: calancha@calancha-ilc.kek.jp To: Eli Zaretskii Subject: Re: bug#23206: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish In-Reply-To: <837fgeraxz.fsf@gnu.org> Message-ID: References: <837fgeraxz.fsf@gnu.org> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 23206 Cc: Tino Calancha , 23206@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Thanks. Can you elaborate on why such a wait is needed? Let's assume COMMAND is "du -s" and LIST contains the dirs foo bar baz: foo is ~ Gb with depth > 1 and bar and baz are few kB dirs with depth 1. The effective shell command to run is: du -s foo& du -s bar& du -s baz& This creates a new process PROC in the system. PROC returns with the return code of the last command in the list (du -s baz): this is a shell feature. The output from the remaining jobs is still comming to stdout, but is not associated to PROC, which already succeded. With `dired-do-shell-command', we get all output only if foo is the last dir in LIST. POSIX shells provide the builtin 'wait' to change this behaviour: it forces PROC to wait until all background jobs end. You can run from terminal following scripts: I) #!/bin/sh echo "id $$" du -s foo& du -s bar& du -s baz& II) #!/bin/sh echo "id $$" du -s foo& du -s bar& du -s baz& wait Then list the process id of the scripts while you still have output comming: ps -f -p ID I) No process in the system with ID. II) There is a process with ID. Well, maybe it can be solve in many other ways. I just found very simple: just adding 4 letters fix it; also very natural, because we are building a shell command, so its logical to use the shell sintaxis. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 04 02:17:05 2016 Received: (at 23206) by debbugs.gnu.org; 4 Apr 2016 06:17:06 +0000 Received: from localhost ([127.0.0.1]:50536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amxov-00060n-OF for submit@debbugs.gnu.org; Mon, 04 Apr 2016 02:17:05 -0400 Received: from calancha-ilc.kek.jp ([130.87.234.234]:55601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amxot-00060E-NF for 23206@debbugs.gnu.org; Mon, 04 Apr 2016 02:17:04 -0400 Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id 5F6615970; Mon, 4 Apr 2016 15:20:13 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 45F6E54B3; Mon, 4 Apr 2016 15:20:13 +0900 (JST) Date: Mon, 4 Apr 2016 15:20:13 +0900 (JST) From: Tino Calancha X-X-Sender: calancha@calancha-ilc.kek.jp To: 23206@debbugs.gnu.org Subject: Re: bug#23206: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish In-Reply-To: Message-ID: References: <837fgeraxz.fsf@gnu.org> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 23206 Cc: Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) I must clarify the tittle of this thread (the word wait). Of course, the process is still asynchronous! :-) The command wait just avoid `shell-command-sentinel' be triggered too early. Once all jobs in the background finish, the shell returns with the return code of the last command in the list; then `shell-command-sentinel' do its stuff. The command 'wait' is specified by posix. I have verified that it is present in following shells: bash: 4.3, 3.2 dash: 0.5.8-2.2 posh: 0.12.6 bsd-csh: 1.65 (20110502-2.1) tcsh: 6.18, 6.14 ksh: 93u+ 2012-08-01, 20100202-1 zsh: 5.2, 4.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 04 13:26:01 2016 Received: (at 23206) by debbugs.gnu.org; 4 Apr 2016 17:26:01 +0000 Received: from localhost ([127.0.0.1]:51359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an8GH-0006xL-HL for submit@debbugs.gnu.org; Mon, 04 Apr 2016 13:26:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an8GG-0006x3-0m for 23206@debbugs.gnu.org; Mon, 04 Apr 2016 13:26:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an8G5-000403-VD for 23206@debbugs.gnu.org; Mon, 04 Apr 2016 13:25:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an8G5-0003zz-RE; Mon, 04 Apr 2016 13:25:49 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3041 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1an8G5-0002tr-9V; Mon, 04 Apr 2016 13:25:49 -0400 Date: Mon, 04 Apr 2016 20:25:25 +0300 Message-Id: <83inzxnv5m.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Mon, 4 Apr 2016 01:38:52 +0900 (JST)) Subject: Re: bug#23206: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish References: <837fgeraxz.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 23206 Cc: 23206@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Mon, 4 Apr 2016 01:38:52 +0900 (JST) > From: Tino Calancha > cc: Tino Calancha , 23206@debbugs.gnu.org > > Let's assume COMMAND is "du -s" > and LIST contains the dirs foo bar baz: > foo is ~ Gb with depth > 1 > and bar and baz are few kB dirs with depth 1. > > The effective shell command to run is: > du -s foo& du -s bar& du -s baz& > > This creates a new process PROC in the system. > PROC returns with the return code of the last command in the list > (du -s baz): this is a shell feature. > The output from the remaining jobs is still comming to stdout, > but is not associated to PROC, which already succeded. > > With `dired-do-shell-command', we get all output only if foo > is the last dir in LIST. > > POSIX shells provide the builtin 'wait' to change this behaviour: > it forces PROC to wait until all background jobs end. Thanks. This means the fix should only affect systems with a Posix shell. The stock MS-Windows shells don't have a 'wait' command (and don't need this fix in the first place, as the problem doesn't exist on MS-Windows, AFAICS). Can you modify the patch to do that? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 05 01:21:36 2016 Received: (at 23206) by debbugs.gnu.org; 5 Apr 2016 05:21:36 +0000 Received: from localhost ([127.0.0.1]:51587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anJQm-000442-BD for submit@debbugs.gnu.org; Tue, 05 Apr 2016 01:21:36 -0400 Received: from calancha-ilc.kek.jp ([130.87.234.234]:55964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anJQk-00043n-Al for 23206@debbugs.gnu.org; Tue, 05 Apr 2016 01:21:35 -0400 Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id 8650A5DD1; Tue, 5 Apr 2016 14:24:41 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id F15CA5459; Tue, 5 Apr 2016 14:24:41 +0900 (JST) Date: Tue, 5 Apr 2016 14:24:41 +0900 (JST) From: Tino Calancha X-X-Sender: calancha@calancha-ilc.kek.jp To: Eli Zaretskii Subject: Re: bug#23206: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish In-Reply-To: <83inzxnv5m.fsf@gnu.org> Message-ID: References: <837fgeraxz.fsf@gnu.org> <83inzxnv5m.fsf@gnu.org> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="1468197610-337991981-1459833881=:9018" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 23206 Cc: Tino Calancha , 23206@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --1468197610-337991981-1459833881=:9018 Content-Type: text/plain; format=flowed; charset=US-ASCII >This means the fix should only affect systems with a Posix >shell. >The stock MS-Windows shells don't have a 'wait' command (and >don't need this fix in the first place, as the problem doesn't exist >on MS-Windows, AFAICS). I see. Thank you. I rewrote the patch so that it adds 'wait' when 'system-type' is not in '(ms-dos windows-nt). --1468197610-337991981-1459833881=:9018 Content-Type: text/plain; charset=US-ASCII; name=0001-Wait-until-all-parallel-shell-commands-finish.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-Wait-until-all-parallel-shell-commands-finish.patch RnJvbSA1ZDRiOTlkODRiMWIzMjlkN2EwMDQ3YjlmZjAwYmU5NGRkNThlMThj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogVGlubyBDYWxhbmNo YSA8ZjkyY2FwYWNAZ21haWwuY29tPg0KRGF0ZTogVHVlLCA1IEFwciAyMDE2 IDE0OjA4OjU3ICswOTAwDQpTdWJqZWN0OiBbUEFUQ0hdIFdhaXQgdW50aWwg YWxsIHBhcmFsbGVsIHNoZWxsIGNvbW1hbmRzIGZpbmlzaA0KDQoqIGxpc3Av ZGlyZWQtYXV4LmVsIChkaXJlZC1zaGVsbC1zdHVmZi1pdCk6DQpEcm9wIGFs bCB0cmFpbGluZyAnOycgYW5kICcmJyBpbiBjb21tYW5kOw0KY2hhbmdlIGlu ZGVudGF0aW9uIHdpdGggXHQgdG8gP1xzOw0KRm9yY2UgUE9TSVggc2hlbGxz IHRvIHdhaXQgdW50aWwgYWxsIGJhY2tncm91bmQgam9icyBmaW5pc2guDQoo QnVnIzIzMjA2KS4NCi0tLQ0KIGxpc3AvZGlyZWQtYXV4LmVsIHwgNjkgKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LS0tLS0tLQ0KIDEgZmlsZSBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCspLCAy NiBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2xpc3AvZGlyZWQtYXV4 LmVsIGIvbGlzcC9kaXJlZC1hdXguZWwNCmluZGV4IGQyOWFiZjMuLmY1MTA2 YmIgMTAwNjQ0DQotLS0gYS9saXNwL2RpcmVkLWF1eC5lbA0KKysrIGIvbGlz cC9kaXJlZC1hdXguZWwNCkBAIC03MjIsMzMgKzcyMiw1MCBAQCBkaXJlZC1z aGVsbC1zdHVmZi1pdA0KIDs7IChjb21pbmcgZnJvbSBpbnRlcmFjdGl2ZSBQ IGFuZCBjdXJyZW50bHkgaWdub3JlZCkgdG8gZGVjaWRlIHdoYXQgdG8gZG8u DQogOzsgU21hcnQgd291bGQgYmUgYSB3YXkgdG8gYWNjZXNzIGJhc2VuYW1l IG9yIGV4dGVuc2lvbiBvZiBmaWxlIG5hbWVzLg0KICAgKGxldCogKChpbi1i YWNrZ3JvdW5kIChzdHJpbmctbWF0Y2ggIlsgXHRdKiZbIFx0XSpcXCciIGNv bW1hbmQpKQ0KLQkgKGNvbW1hbmQgKGlmIGluLWJhY2tncm91bmQNCi0JCSAg ICAgIChzdWJzdHJpbmcgY29tbWFuZCAwIChtYXRjaC1iZWdpbm5pbmcgMCkp DQotCQkgICAgY29tbWFuZCkpDQotCSAoc2VxdWVudGlhbGx5IChzdHJpbmct bWF0Y2ggIlsgXHRdKjtbIFx0XSpcXCciIGNvbW1hbmQpKQ0KLQkgKGNvbW1h bmQgKGlmIHNlcXVlbnRpYWxseQ0KLQkJICAgICAgKHN1YnN0cmluZyBjb21t YW5kIDAgKG1hdGNoLWJlZ2lubmluZyAwKSkNCi0JCSAgICBjb21tYW5kKSkN Ci0JIChzdHVmZi1pdA0KLQkgIChpZiAob3IgKHN0cmluZy1tYXRjaC1wIGRp cmVkLXN0YXItc3Vic3QtcmVnZXhwIGNvbW1hbmQpDQotCQkgIChzdHJpbmct bWF0Y2gtcCBkaXJlZC1xdWFyay1zdWJzdC1yZWdleHAgY29tbWFuZCkpDQot CSAgICAgIChsYW1iZGEgKHgpDQotCQkobGV0ICgocmV0dmFsIGNvbW1hbmQp KQ0KLQkJICAod2hpbGUgKHN0cmluZy1tYXRjaA0KLQkJCSAgIlxcKF5cXHxb IFx0XVxcKVxcKFsqP11cXClcXChbIFx0XVxcfCRcXCkiIHJldHZhbCkNCi0J CSAgICAoc2V0cSByZXR2YWwgKHJlcGxhY2UtbWF0Y2ggeCB0IHQgcmV0dmFs IDIpKSkNCi0JCSAgcmV0dmFsKSkNCi0JICAgIChsYW1iZGEgKHgpIChjb25j YXQgY29tbWFuZCBkaXJlZC1tYXJrLXNlcGFyYXRvciB4KSkpKSkNCisgICAg ICAgICAoY29tbWFuZCAoaWYgaW4tYmFja2dyb3VuZA0KKyAgICAgICAgICAg ICAgICAgICAgICAobGV0ICgoY21kIGNvbW1hbmQpKQ0KKyAgICAgICAgICAg ICAgICAgICAgICAgICh3aGlsZSAoc3RyaW5nLW1hdGNoICJbIFx0XSpbJl0r WyBcdF0qXFwnIiBjbWQpDQorICAgICAgICAgICAgICAgICAgICAgICAgICAo c2V0cSBjbWQgKHN1YnN0cmluZyBjbWQgMCAobWF0Y2gtYmVnaW5uaW5nIDAp KSkpIGNtZCkNCisgICAgICAgICAgICAgICAgICAgIGNvbW1hbmQpKQ0KKyAg ICAgICAgIChzZXF1ZW50aWFsbHkgKHN0cmluZy1tYXRjaCAiWyBcdF0qO1sg XHRdKlxcJyIgY29tbWFuZCkpDQorICAgICAgICAgKGNvbW1hbmQgKGlmIHNl cXVlbnRpYWxseQ0KKyAgICAgICAgICAgICAgICAgICAgICAobGV0ICgoY21k IGNvbW1hbmQpKQ0KKyAgICAgICAgICAgICAgICAgICAgICAgICh3aGlsZSAo c3RyaW5nLW1hdGNoICJbIFx0XSpbO10rWyBcdF0qXFwnIiBjbWQpDQorICAg ICAgICAgICAgICAgICAgICAgICAgICAoc2V0cSBjbWQgKHN1YnN0cmluZyBj bWQgMCAobWF0Y2gtYmVnaW5uaW5nIDApKSkpIGNtZCkNCisgICAgICAgICAg ICAgICAgICAgIGNvbW1hbmQpKQ0KKyAgICAgICAgIChpbi1iYWNrLW5vLXNl cSAoYW5kIGluLWJhY2tncm91bmQgKG5vdCBzZXF1ZW50aWFsbHkpKSkNCisg ICAgICAgICAoc3R1ZmYtaXQNCisgICAgICAgICAgKGlmIChvciAoc3RyaW5n LW1hdGNoLXAgZGlyZWQtc3Rhci1zdWJzdC1yZWdleHAgY29tbWFuZCkNCisg ICAgICAgICAgICAgICAgICAoc3RyaW5nLW1hdGNoLXAgZGlyZWQtcXVhcmst c3Vic3QtcmVnZXhwIGNvbW1hbmQpKQ0KKyAgICAgICAgICAgICAgKGxhbWJk YSAoeCkNCisgICAgICAgICAgICAgICAgKGxldCAoKHJldHZhbCBjb21tYW5k KSkNCisgICAgICAgICAgICAgICAgICAod2hpbGUgKHN0cmluZy1tYXRjaA0K KyAgICAgICAgICAgICAgICAgICAgICAgICAgIlxcKF5cXHxbIFx0XVxcKVxc KFsqP11cXClcXChbIFx0XVxcfCRcXCkiIHJldHZhbCkNCisgICAgICAgICAg ICAgICAgICAgIChzZXRxIHJldHZhbCAocmVwbGFjZS1tYXRjaCB4IHQgdCBy ZXR2YWwgMikpKQ0KKyAgICAgICAgICAgICAgICAgIHJldHZhbCkpDQorICAg ICAgICAgICAgKGxhbWJkYSAoeCkgKGNvbmNhdCBjb21tYW5kIGRpcmVkLW1h cmstc2VwYXJhdG9yIHgpKSkpKQ0KICAgICAoY29uY2F0DQotICAgICAoaWYg b24tZWFjaA0KLQkgKG1hcGNvbmNhdCBzdHVmZi1pdCAobWFwY2FyICdzaGVs bC1xdW90ZS1hcmd1bWVudCBmaWxlLWxpc3QpDQotCQkgICAgKGlmIChhbmQg aW4tYmFja2dyb3VuZCAobm90IHNlcXVlbnRpYWxseSkpICImIiAiOyIpKQ0K LSAgICAgICAobGV0ICgoZmlsZXMgKG1hcGNvbmNhdCAnc2hlbGwtcXVvdGUt YXJndW1lbnQNCi0JCQkgICAgICAgZmlsZS1saXN0IGRpcmVkLW1hcmstc2Vw YXJhdG9yKSkpDQotCSAoaWYgKD4gKGxlbmd0aCBmaWxlLWxpc3QpIDEpDQot CSAgICAgKHNldHEgZmlsZXMgKGNvbmNhdCBkaXJlZC1tYXJrLXByZWZpeCBm aWxlcyBkaXJlZC1tYXJrLXBvc3RmaXgpKSkNCi0JIChmdW5jYWxsIHN0dWZm LWl0IGZpbGVzKSkpDQotICAgICAoaWYgaW4tYmFja2dyb3VuZCAiJiIgIiIp KSkpDQorICAgICAoY29uZCAob24tZWFjaA0KKyAgICAgICAgICAgIChmb3Jt YXQgIiVzJXMiDQorICAgICAgICAgICAgICAgICAgICAobWFwY29uY2F0IHN0 dWZmLWl0IChtYXBjYXIgJ3NoZWxsLXF1b3RlLWFyZ3VtZW50IGZpbGUtbGlz dCkNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKG9yIChhbmQg aW4tYmFjay1uby1zZXEgIiYiKSAiOyIpKQ0KKyAgICAgICAgICAgICAgICAg ICAgOzsgUE9TSVggc2hlbGxzIHJ1bm5pbmcgYSBsaXN0IG9mIGNvbW1hbmRz IGluIHRoZSBiYWNrZ3JvdW5kDQorICAgICAgICAgICAgICAgICAgICA7OyAo TElTVCA9IGNtZF8xICYgW2NtZF8yICYgLi4uIGNtZF9pICYgLi4uIGNtZF9O ICZdKQ0KKyAgICAgICAgICAgICAgICAgICAgOzsgcmV0dXJuIG9uY2UgY21k X04gZW5kcywgaS5lLiwgdGhlIHNoZWxsIGRvZXMgbm90DQorICAgICAgICAg ICAgICAgICAgICA7OyB3YWl0IGZvciBjbWRfaSB0byBmaW5pc2ggYmVmb3Jl IGV4ZWN1dGluZyBjbWRfaSsxLg0KKyAgICAgICAgICAgICAgICAgICAgOzsg VGhhdCBtZWFucywgcnVubmluZyAoc2hlbGwtY29tbWFuZCBMSVNUKSBtYXkg bm90IHNob3cNCisgICAgICAgICAgICAgICAgICAgIDs7IHRoZSBvdXRwdXQg b2YgYWxsIHRoZSBjb21tYW5kcyAoQnVnIzIzMjA2KS4NCisgICAgICAgICAg ICAgICAgICAgIDs7IEFkZCAnd2FpdCcgdG8gZm9yY2UgdGhvc2UgUE9TSVgg c2hlbGxzIHRvIHdhaXQgdW50aWwNCisgICAgICAgICAgICAgICAgICAgIDs7 IGFsbCBjb21tYW5kcyBmaW5pc2guDQorICAgICAgICAgICAgICAgICAgICAo b3IgKGFuZCBpbi1iYWNrLW5vLXNlcSAobm90IChtZW1xIHN5c3RlbS10eXBl ICcobXMtZG9zIHdpbmRvd3MtbnQpKSkgIiZ3YWl0IikNCisgICAgICAgICAg ICAgICAgICAgICAgICAiIikpKQ0KKyAgICAgICAgICAgKHQNCisgICAgICAg ICAgICAobGV0ICgoZmlsZXMgKG1hcGNvbmNhdCAnc2hlbGwtcXVvdGUtYXJn dW1lbnQNCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBm aWxlLWxpc3QgZGlyZWQtbWFyay1zZXBhcmF0b3IpKSkNCisgICAgICAgICAg ICAgICh3aGVuIChjZHIgZmlsZS1saXN0KQ0KKyAgICAgICAgICAgICAgICAo c2V0cSBmaWxlcyAoY29uY2F0IGRpcmVkLW1hcmstcHJlZml4IGZpbGVzIGRp cmVkLW1hcmstcG9zdGZpeCkpKQ0KKyAgICAgICAgICAgICAgKGZ1bmNhbGwg c3R1ZmYtaXQgZmlsZXMpKSkpDQorICAgICAob3IgKGFuZCBpbi1iYWNrZ3Jv dW5kICImIikgIiIpKSkpDQogDQogOzsgVGhpcyBpcyBhbiBleHRyYSBmdW5j dGlvbiBzbyB0aGF0IGl0IGNhbiBiZSByZWRlZmluZWQgYnkgYW5nZS1mdHAu DQogOzs7IyMjYXV0b2xvYWQNCi0tIA0KMi44LjAucmMzDQoNCg== --1468197610-337991981-1459833881=:9018-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 05 10:59:59 2016 Received: (at 23206) by debbugs.gnu.org; 5 Apr 2016 14:59:59 +0000 Received: from localhost ([127.0.0.1]:52449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anSSV-0004Jp-26 for submit@debbugs.gnu.org; Tue, 05 Apr 2016 10:59:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anSSU-0004Je-4M for 23206@debbugs.gnu.org; Tue, 05 Apr 2016 10:59:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anSSK-0005J1-3p for 23206@debbugs.gnu.org; Tue, 05 Apr 2016 10:59:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anSSK-0005Ix-0G; Tue, 05 Apr 2016 10:59:48 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4254 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1anSSI-00026v-Ac; Tue, 05 Apr 2016 10:59:47 -0400 Date: Tue, 05 Apr 2016 17:59:22 +0300 Message-Id: <83vb3wm791.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Tue, 5 Apr 2016 14:24:41 +0900 (JST)) Subject: Re: bug#23206: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish References: <837fgeraxz.fsf@gnu.org> <83inzxnv5m.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 23206 Cc: 23206@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Tue, 5 Apr 2016 14:24:41 +0900 (JST) > From: Tino Calancha > cc: Tino Calancha , 23206@debbugs.gnu.org > > >This means the fix should only affect systems with a Posix > >shell. > >The stock MS-Windows shells don't have a 'wait' command (and > >don't need this fix in the first place, as the problem doesn't exist > >on MS-Windows, AFAICS). > I see. Thank you. > I rewrote the patch so that it adds 'wait' when 'system-type' is > not in '(ms-dos windows-nt). Thanks. I have one more nit: > * lisp/dired-aux.el (dired-shell-stuff-it): > Drop all trailing ';' and '&' in command; > change indentation with \t to ?\s; These are unrelated changes, so please don't mix them with the changes that really fix the problem at hand. In particular, removing all the trailing ';' and '&' characters might cause bugs, because the code you are modifying doesn't really understand what the shell command is about, so it might inadvertently delete characters that are there for a reason. It is up to the user to type a correct command, and Emacs shouldn't try second-guessing those commands. So let's only remove a single instance of these characters at the end, as the original code did. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 05 11:55:23 2016 Received: (at 23206) by debbugs.gnu.org; 5 Apr 2016 15:55:23 +0000 Received: from localhost ([127.0.0.1]:50532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anTK6-0002m7-Sb for submit@debbugs.gnu.org; Tue, 05 Apr 2016 11:55:23 -0400 Received: from calancha-ilc.kek.jp ([130.87.234.234]:56122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anTK5-0002lu-1I for 23206@debbugs.gnu.org; Tue, 05 Apr 2016 11:55:21 -0400 Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id 83ADF595D; Wed, 6 Apr 2016 00:58:30 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 292225959; Wed, 6 Apr 2016 00:58:30 +0900 (JST) Date: Wed, 6 Apr 2016 00:58:30 +0900 (JST) From: Tino Calancha X-X-Sender: calancha@calancha-ilc.kek.jp To: Eli Zaretskii Subject: Re: bug#23206: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish In-Reply-To: <83vb3wm791.fsf@gnu.org> Message-ID: References: <837fgeraxz.fsf@gnu.org> <83inzxnv5m.fsf@gnu.org> <83vb3wm791.fsf@gnu.org> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="1468197610-1031740844-1459871910=:10077" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 23206 Cc: Tino Calancha , 23206@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --1468197610-1031740844-1459871910=:10077 Content-Type: text/plain; format=flowed; charset=US-ASCII >These are unrelated changes, so please don't mix them with the changes >that really fix the problem at hand. I am sorry tha's my fault. I should always do atomic changes. >It is up to the user to type a correct command, and Emacs >shouldn't try second-guessing those commands. So let's only remove a >single instance of these characters at the end, as the original code >did. I was 'baby sitting' the user (and my self). Yeah, too much care, Emacs users can protect themselves very well ;-) Attached atomic commits without the extra care. --1468197610-1031740844-1459871910=:10077 Content-Type: text/plain; charset=US-ASCII; name=0001-Wait-until-all-parallel-shell-commands-finish.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0001-Wait-until-all-parallel-shell-commands-finish.patch RnJvbSBiZDQ3NmExZjQzYmU0N2ZlNzlkYjc2ZTdmZWEzNmM3NTA1NDlmNzJi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogVGlubyBDYWxhbmNo YSA8ZjkyY2FwYWNAZ21haWwuY29tPg0KRGF0ZTogV2VkLCA2IEFwciAyMDE2 IDAwOjM2OjE3ICswOTAwDQpTdWJqZWN0OiBbUEFUQ0ggMS8yXSBXYWl0IHVu dGlsIGFsbCBwYXJhbGxlbCBzaGVsbCBjb21tYW5kcyBmaW5pc2gNCg0KKiBs aXNwL2RpcmVkLWF1eC5lbCAoZGlyZWQtc2hlbGwtc3R1ZmYtaXQpOg0KRm9y Y2UgUE9TSVggc2hlbGxzIHRvIHdhaXQgdW50aWwgYWxsIGJhY2tncm91bmQg am9icyBmaW5pc2guDQooQnVnIzIzMjA2KS4NCi0tLQ0KIGxpc3AvZGlyZWQt YXV4LmVsIHwgMzEgKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLQ0K IDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9u cygtKQ0KDQpkaWZmIC0tZ2l0IGEvbGlzcC9kaXJlZC1hdXguZWwgYi9saXNw L2RpcmVkLWF1eC5lbA0KaW5kZXggZDI5YWJmMy4uY2M2ZjE2OCAxMDA2NDQN Ci0tLSBhL2xpc3AvZGlyZWQtYXV4LmVsDQorKysgYi9saXNwL2RpcmVkLWF1 eC5lbA0KQEAgLTcyOSw2ICs3MjksNyBAQCBkaXJlZC1zaGVsbC1zdHVmZi1p dA0KIAkgKGNvbW1hbmQgKGlmIHNlcXVlbnRpYWxseQ0KIAkJICAgICAgKHN1 YnN0cmluZyBjb21tYW5kIDAgKG1hdGNoLWJlZ2lubmluZyAwKSkNCiAJCSAg ICBjb21tYW5kKSkNCisgICAgICAgICAocGFyYWxsZWwtaW4tYmFja2dyb3Vu ZCAoYW5kIGluLWJhY2tncm91bmQgKG5vdCBzZXF1ZW50aWFsbHkpKSkNCiAJ IChzdHVmZi1pdA0KIAkgIChpZiAob3IgKHN0cmluZy1tYXRjaC1wIGRpcmVk LXN0YXItc3Vic3QtcmVnZXhwIGNvbW1hbmQpDQogCQkgIChzdHJpbmctbWF0 Y2gtcCBkaXJlZC1xdWFyay1zdWJzdC1yZWdleHAgY29tbWFuZCkpDQpAQCAt NzQwLDE1ICs3NDEsMjcgQEAgZGlyZWQtc2hlbGwtc3R1ZmYtaXQNCiAJCSAg cmV0dmFsKSkNCiAJICAgIChsYW1iZGEgKHgpIChjb25jYXQgY29tbWFuZCBk aXJlZC1tYXJrLXNlcGFyYXRvciB4KSkpKSkNCiAgICAgKGNvbmNhdA0KLSAg ICAgKGlmIG9uLWVhY2gNCi0JIChtYXBjb25jYXQgc3R1ZmYtaXQgKG1hcGNh ciAnc2hlbGwtcXVvdGUtYXJndW1lbnQgZmlsZS1saXN0KQ0KLQkJICAgIChp ZiAoYW5kIGluLWJhY2tncm91bmQgKG5vdCBzZXF1ZW50aWFsbHkpKSAiJiIg IjsiKSkNCi0gICAgICAgKGxldCAoKGZpbGVzIChtYXBjb25jYXQgJ3NoZWxs LXF1b3RlLWFyZ3VtZW50DQotCQkJICAgICAgIGZpbGUtbGlzdCBkaXJlZC1t YXJrLXNlcGFyYXRvcikpKQ0KLQkgKGlmICg+IChsZW5ndGggZmlsZS1saXN0 KSAxKQ0KLQkgICAgIChzZXRxIGZpbGVzIChjb25jYXQgZGlyZWQtbWFyay1w cmVmaXggZmlsZXMgZGlyZWQtbWFyay1wb3N0Zml4KSkpDQotCSAoZnVuY2Fs bCBzdHVmZi1pdCBmaWxlcykpKQ0KLSAgICAgKGlmIGluLWJhY2tncm91bmQg IiYiICIiKSkpKQ0KKyAgICAgKGNvbmQgKG9uLWVhY2gNCisgICAgICAgICAg ICAoZm9ybWF0ICIlcyVzIg0KKyAgICAgICAgICAgICAgICAgICAgKG1hcGNv bmNhdCBzdHVmZi1pdCAobWFwY2FyICdzaGVsbC1xdW90ZS1hcmd1bWVudCBm aWxlLWxpc3QpDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChv ciAoYW5kIHBhcmFsbGVsLWluLWJhY2tncm91bmQgIiYiKSAiOyIpKQ0KKyAg ICAgICAgICAgICAgICAgICAgOzsgUE9TSVggc2hlbGxzIHJ1bm5pbmcgYSBs aXN0IG9mIGNvbW1hbmRzIGluIHRoZSBiYWNrZ3JvdW5kDQorICAgICAgICAg ICAgICAgICAgICA7OyAoTElTVCA9IGNtZF8xICYgW2NtZF8yICYgLi4uIGNt ZF9pICYgLi4uIGNtZF9OICZdKQ0KKyAgICAgICAgICAgICAgICAgICAgOzsg cmV0dXJuIG9uY2UgY21kX04gZW5kcywgaS5lLiwgdGhlIHNoZWxsIGRvZXMg bm90DQorICAgICAgICAgICAgICAgICAgICA7OyB3YWl0IGZvciBjbWRfaSB0 byBmaW5pc2ggYmVmb3JlIGV4ZWN1dGluZyBjbWRfaSsxLg0KKyAgICAgICAg ICAgICAgICAgICAgOzsgVGhhdCBtZWFucywgcnVubmluZyAoc2hlbGwtY29t bWFuZCBMSVNUKSBtYXkgbm90IHNob3cNCisgICAgICAgICAgICAgICAgICAg IDs7IHRoZSBvdXRwdXQgb2YgYWxsIHRoZSBjb21tYW5kcyAoQnVnIzIzMjA2 KS4NCisgICAgICAgICAgICAgICAgICAgIDs7IEFkZCAnd2FpdCcgdG8gZm9y Y2UgdGhvc2UgUE9TSVggc2hlbGxzIHRvIHdhaXQgdW50aWwNCisgICAgICAg ICAgICAgICAgICAgIDs7IGFsbCBjb21tYW5kcyBmaW5pc2guDQorICAgICAg ICAgICAgICAgICAgICAob3IgKGFuZCBwYXJhbGxlbC1pbi1iYWNrZ3JvdW5k IChub3QgKG1lbXEgc3lzdGVtLXR5cGUgJyhtcy1kb3Mgd2luZG93cy1udCkp KSAiJndhaXQiKQ0KKyAgICAgICAgICAgICAgICAgICAgICAgICIiKSkpDQor ICAgICAgICAgICAodA0KKyAgICAgICAgICAgIChsZXQgKChmaWxlcyAobWFw Y29uY2F0ICdzaGVsbC1xdW90ZS1hcmd1bWVudA0KKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGZpbGUtbGlzdCBkaXJlZC1tYXJrLXNl cGFyYXRvcikpKQ0KKyAgICAgICAgICAgICAgKHdoZW4gKGNkciBmaWxlLWxp c3QpDQorICAgICAgICAgICAgICAgIChzZXRxIGZpbGVzIChjb25jYXQgZGly ZWQtbWFyay1wcmVmaXggZmlsZXMgZGlyZWQtbWFyay1wb3N0Zml4KSkpDQor ICAgICAgICAgICAgICAoZnVuY2FsbCBzdHVmZi1pdCBmaWxlcykpKSkNCisg ICAgIChvciAoYW5kIGluLWJhY2tncm91bmQgIiYiKSAiIikpKSkNCiANCiA7 OyBUaGlzIGlzIGFuIGV4dHJhIGZ1bmN0aW9uIHNvIHRoYXQgaXQgY2FuIGJl IHJlZGVmaW5lZCBieSBhbmdlLWZ0cC4NCiA7OzsjIyNhdXRvbG9hZA0KLS0g DQoyLjguMC5yYzMNCg0K --1468197610-1031740844-1459871910=:10077 Content-Type: text/plain; charset=US-ASCII; name=0002-dired-shell-stuff-it-Consistent-indentation.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=0002-dired-shell-stuff-it-Consistent-indentation.patch RnJvbSBmMGVkNDgzYWEzZThiZjgzNDVjODA3YTZjMGQ5NDRmMTc3MzQ3YzUz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQ0KRnJvbTogVGlubyBDYWxhbmNo YSA8ZjkyY2FwYWNAZ21haWwuY29tPg0KRGF0ZTogV2VkLCA2IEFwciAyMDE2 IDAwOjQ2OjAyICswOTAwDQpTdWJqZWN0OiBbUEFUQ0ggMi8yXSBkaXJlZC1z aGVsbC1zdHVmZi1pdDogQ29uc2lzdGVudCBpbmRlbnRhdGlvbg0KDQoqIGxp c3AvZGlyZWQtYXV4LmVsIChkaXJlZC1zaGVsbC1zdHVmZi1pdCk6DQpVc2Ug c3BhY2VzIGZvciBpbmRlbnQgdGhpcyBmdW5jdGlvbi4NCi0tLQ0KIGxpc3Av ZGlyZWQtYXV4LmVsIHwgMzQgKysrKysrKysrKysrKysrKystLS0tLS0tLS0t LS0tLS0tLQ0KIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAx NyBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2xpc3AvZGlyZWQtYXV4 LmVsIGIvbGlzcC9kaXJlZC1hdXguZWwNCmluZGV4IGNjNmYxNjguLjk5M2I0 NTMgMTAwNjQ0DQotLS0gYS9saXNwL2RpcmVkLWF1eC5lbA0KKysrIGIvbGlz cC9kaXJlZC1hdXguZWwNCkBAIC03MjIsMjQgKzcyMiwyNCBAQCBkaXJlZC1z aGVsbC1zdHVmZi1pdA0KIDs7IChjb21pbmcgZnJvbSBpbnRlcmFjdGl2ZSBQ IGFuZCBjdXJyZW50bHkgaWdub3JlZCkgdG8gZGVjaWRlIHdoYXQgdG8gZG8u DQogOzsgU21hcnQgd291bGQgYmUgYSB3YXkgdG8gYWNjZXNzIGJhc2VuYW1l IG9yIGV4dGVuc2lvbiBvZiBmaWxlIG5hbWVzLg0KICAgKGxldCogKChpbi1i YWNrZ3JvdW5kIChzdHJpbmctbWF0Y2ggIlsgXHRdKiZbIFx0XSpcXCciIGNv bW1hbmQpKQ0KLQkgKGNvbW1hbmQgKGlmIGluLWJhY2tncm91bmQNCi0JCSAg ICAgIChzdWJzdHJpbmcgY29tbWFuZCAwIChtYXRjaC1iZWdpbm5pbmcgMCkp DQotCQkgICAgY29tbWFuZCkpDQotCSAoc2VxdWVudGlhbGx5IChzdHJpbmct bWF0Y2ggIlsgXHRdKjtbIFx0XSpcXCciIGNvbW1hbmQpKQ0KLQkgKGNvbW1h bmQgKGlmIHNlcXVlbnRpYWxseQ0KLQkJICAgICAgKHN1YnN0cmluZyBjb21t YW5kIDAgKG1hdGNoLWJlZ2lubmluZyAwKSkNCi0JCSAgICBjb21tYW5kKSkN CisgICAgICAgICAoY29tbWFuZCAoaWYgaW4tYmFja2dyb3VuZA0KKyAgICAg ICAgICAgICAgICAgICAgICAoc3Vic3RyaW5nIGNvbW1hbmQgMCAobWF0Y2gt YmVnaW5uaW5nIDApKQ0KKyAgICAgICAgICAgICAgICAgICAgY29tbWFuZCkp DQorICAgICAgICAgKHNlcXVlbnRpYWxseSAoc3RyaW5nLW1hdGNoICJbIFx0 XSo7WyBcdF0qXFwnIiBjb21tYW5kKSkNCisgICAgICAgICAoY29tbWFuZCAo aWYgc2VxdWVudGlhbGx5DQorICAgICAgICAgICAgICAgICAgICAgIChzdWJz dHJpbmcgY29tbWFuZCAwIChtYXRjaC1iZWdpbm5pbmcgMCkpDQorICAgICAg ICAgICAgICAgICAgICBjb21tYW5kKSkNCiAgICAgICAgICAocGFyYWxsZWwt aW4tYmFja2dyb3VuZCAoYW5kIGluLWJhY2tncm91bmQgKG5vdCBzZXF1ZW50 aWFsbHkpKSkNCi0JIChzdHVmZi1pdA0KLQkgIChpZiAob3IgKHN0cmluZy1t YXRjaC1wIGRpcmVkLXN0YXItc3Vic3QtcmVnZXhwIGNvbW1hbmQpDQotCQkg IChzdHJpbmctbWF0Y2gtcCBkaXJlZC1xdWFyay1zdWJzdC1yZWdleHAgY29t bWFuZCkpDQotCSAgICAgIChsYW1iZGEgKHgpDQotCQkobGV0ICgocmV0dmFs IGNvbW1hbmQpKQ0KLQkJICAod2hpbGUgKHN0cmluZy1tYXRjaA0KLQkJCSAg IlxcKF5cXHxbIFx0XVxcKVxcKFsqP11cXClcXChbIFx0XVxcfCRcXCkiIHJl dHZhbCkNCi0JCSAgICAoc2V0cSByZXR2YWwgKHJlcGxhY2UtbWF0Y2ggeCB0 IHQgcmV0dmFsIDIpKSkNCi0JCSAgcmV0dmFsKSkNCi0JICAgIChsYW1iZGEg KHgpIChjb25jYXQgY29tbWFuZCBkaXJlZC1tYXJrLXNlcGFyYXRvciB4KSkp KSkNCisgICAgICAgICAoc3R1ZmYtaXQNCisgICAgICAgICAgKGlmIChvciAo c3RyaW5nLW1hdGNoLXAgZGlyZWQtc3Rhci1zdWJzdC1yZWdleHAgY29tbWFu ZCkNCisgICAgICAgICAgICAgICAgICAoc3RyaW5nLW1hdGNoLXAgZGlyZWQt cXVhcmstc3Vic3QtcmVnZXhwIGNvbW1hbmQpKQ0KKyAgICAgICAgICAgICAg KGxhbWJkYSAoeCkNCisgICAgICAgICAgICAgICAgKGxldCAoKHJldHZhbCBj b21tYW5kKSkNCisgICAgICAgICAgICAgICAgICAod2hpbGUgKHN0cmluZy1t YXRjaA0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgIlxcKF5cXHxbIFx0 XVxcKVxcKFsqP11cXClcXChbIFx0XVxcfCRcXCkiIHJldHZhbCkNCisgICAg ICAgICAgICAgICAgICAgIChzZXRxIHJldHZhbCAocmVwbGFjZS1tYXRjaCB4 IHQgdCByZXR2YWwgMikpKQ0KKyAgICAgICAgICAgICAgICAgIHJldHZhbCkp DQorICAgICAgICAgICAgKGxhbWJkYSAoeCkgKGNvbmNhdCBjb21tYW5kIGRp cmVkLW1hcmstc2VwYXJhdG9yIHgpKSkpKQ0KICAgICAoY29uY2F0DQogICAg ICAoY29uZCAob24tZWFjaA0KICAgICAgICAgICAgIChmb3JtYXQgIiVzJXMi DQotLSANCjIuOC4wLnJjMw0KDQo= --1468197610-1031740844-1459871910=:10077-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 08 10:07:24 2016 Received: (at 23206-done) by debbugs.gnu.org; 8 Apr 2016 14:07:24 +0000 Received: from localhost ([127.0.0.1]:54694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoX4G-0003Rh-Br for submit@debbugs.gnu.org; Fri, 08 Apr 2016 10:07:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoX4E-0003RS-5O for 23206-done@debbugs.gnu.org; Fri, 08 Apr 2016 10:07:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aoX43-00045Z-EF for 23206-done@debbugs.gnu.org; Fri, 08 Apr 2016 10:07:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45481) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aoX43-00045T-Al; Fri, 08 Apr 2016 10:07:11 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4588 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aoX42-000328-KB; Fri, 08 Apr 2016 10:07:11 -0400 Date: Fri, 08 Apr 2016 17:06:44 +0300 Message-Id: <838u0ojitn.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Wed, 6 Apr 2016 00:58:30 +0900 (JST)) Subject: Re: bug#23206: 25.0.92; dired-shell-stuff-it: wait until all parallel jobs finish References: <837fgeraxz.fsf@gnu.org> <83inzxnv5m.fsf@gnu.org> <83vb3wm791.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 23206-done Cc: 23206-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Wed, 6 Apr 2016 00:58:30 +0900 (JST) > From: Tino Calancha > cc: Tino Calancha , 23206@debbugs.gnu.org > > Attached atomic commits without the extra care. Thanks, pushed to the master branch. From unknown Fri Sep 05 09:10:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 May 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator