From unknown Thu Sep 11 06:33:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23188: [PATCH] Support completion of at-rules in SCSS mode Resent-From: Etienne Prud'homme Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Apr 2016 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23188 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 23188@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.145962504928571 (code B ref -1); Sat, 02 Apr 2016 19:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Apr 2016 19:24:09 +0000 Received: from localhost ([127.0.0.1]:49110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amR9U-0007Qk-S6 for submit@debbugs.gnu.org; Sat, 02 Apr 2016 15:24:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1am5Ci-0002T9-Ln for submit@debbugs.gnu.org; Fri, 01 Apr 2016 15:58:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1am5Cc-0000F0-OB for submit@debbugs.gnu.org; Fri, 01 Apr 2016 15:57:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1am5Cc-0000Ew-Kj for submit@debbugs.gnu.org; Fri, 01 Apr 2016 15:57:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1am5Cb-0006PQ-Jq for bug-gnu-emacs@gnu.org; Fri, 01 Apr 2016 15:57:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1am5CW-0000ES-JM for bug-gnu-emacs@gnu.org; Fri, 01 Apr 2016 15:57:53 -0400 Received: from mail-qg0-x243.google.com ([2607:f8b0:400d:c04::243]:36439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1am5CW-0000E8-ES for bug-gnu-emacs@gnu.org; Fri, 01 Apr 2016 15:57:48 -0400 Received: by mail-qg0-x243.google.com with SMTP id n34so12172625qge.3 for ; Fri, 01 Apr 2016 12:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version; bh=AKEW/wqlq//xygVKII3RYRKFNzNRhYpB5PoMOB2Ldww=; b=qBD/5PfdAxVp6/9veNNLfW4ceLVTyvPd4B5WT0YNJO2HAjjeqgm35phN7NaM6gKnwq rYXwZQfo4C9w+6PlvmNLGwBdTv0vaa9L8zJP/VFxSBgrEq/8xgyiT8aqzGtSlJYn2dNN 3NoD8s/7VrDf38FhMpkebvVXbCnlthta0QHEvXqx5ew2KkB5oL2U5NF7Ry3+C876PM96 +g+qfdZBkkTte700btsXx2TXasHDb60bxxvOp9VS+oo1WrtzobKjz7e7ZugLSBFOeKsG VtoLr+7DADlBIDn7KCy+zJKaBvgUAldtBlqXUrrTDBZNyN7vlNiW8dgo9wPhudbYhMa2 ZCtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version; bh=AKEW/wqlq//xygVKII3RYRKFNzNRhYpB5PoMOB2Ldww=; b=lxTsDQ6BYnKZ6C5+dCyz3nSYsioNcprX+yt9QgfGAj3GkPZeoB8R/4OOhAXVBcKSgK g8HAU3nfgkKzGRcj/zPh63ElGtPIyuEq17WM7nHqpfCOwdGM+qfmZm7DD3XTSotKS85t Flyu4MePIPwUXmQVUTwzSIQV+cbHiP24a4uQS5Hq3zBXctU/7wAQaD9Ch/0cXg2a9GXB pMMoVJguTExBPkzjyrtisB2XDEJy4n6DCRVKgAxwVGTv/uDn2m7kQrCT16SWhs2zxRXD Nlu5TwW+m4IXORjXZ1eCgTEzDaW0zbeTOxl+9HiUc4wPsjKrc/c9LqiWbz+Fs+ghbW+M YWBQ== X-Gm-Message-State: AD7BkJI/XXM55C29Gm0J/J5oRczRsEqH31AQxVneMGKi6EmGZzN/bwtopGzwKO9duYm54g== X-Received: by 10.140.246.136 with SMTP id r130mr362216qhc.12.1459540667543; Fri, 01 Apr 2016 12:57:47 -0700 (PDT) Received: from ThinkPax ([173.199.65.14]) by smtp.gmail.com with ESMTPSA id s8sm6770709qhb.20.2016.04.01.12.57.46 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 01 Apr 2016 12:57:47 -0700 (PDT) Date: Fri, 1 Apr 2016 15:57:07 -0400 From: Etienne Prud'homme Message-ID: <20160401155707.4730bda5@ThinkPax> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.23; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/qnugWSW/6H_3jAv7cGVHM.I" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Sat, 02 Apr 2016 15:24:07 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --MP_/qnugWSW/6H_3jAv7cGVHM.I Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline The attached patch adds support for at-rules completion in SCSS mode. It=E2=80=99s more or less the same code from bug#23135 (Support completion = of bang-rules in CSS mode). --MP_/qnugWSW/6H_3jAv7cGVHM.I Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-Support-completion-of-at-rules-in-SCSS-mode.patch >From 4ad8f21f11ed9c48f986cfdd8d50883389fa8d2a Mon Sep 17 00:00:00 2001 From: Etienne Prud'homme Date: Fri, 1 Apr 2016 15:09:15 -0400 Subject: [PATCH] Support completion of at-rules in SCSS mode --- lisp/textmodes/css-mode.el | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index cbef3d4..02a5b11 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -56,6 +56,15 @@ '("charset" "font-face" "import" "media" "namespace" "page") "Identifiers that appear in the form @foo.") +(defconst scss-at-ids + '("at-root" "content" "debug" "each" "else" "else if" "error" "extend" "for" + "function" "if" "import" "include" "mixin" "return" "warn" "while") + "Additional identifiers that appear in the form @foo in SCSS.") + +(defvar css--at-ids css-at-ids + "List of at-rules for the current mode.") +(make-variable-buffer-local 'css--at-ids) + (defconst css-bang-ids '("important") "Identifiers that appear in the form !foo.") @@ -759,7 +768,7 @@ cannot be completed sensibly: `angle', `element-reference', (let ((pos (point))) (skip-chars-backward "-[:alnum:]") (when (eq (char-before) ?\@) - (list (point) pos css-at-ids))))) + (list (point) pos css--at-ids))))) (defvar css--property-value-cache (make-hash-table :test 'equal :size (length css-property-alist)) @@ -969,6 +978,7 @@ pseudo-elements, pseudo-classes, at-rules, and bang-rules." (setq-local comment-continue " *") (setq-local comment-start-skip "/[*/]+[ \t]*") (setq-local comment-end-skip "[ \t]*\\(?:\n\\|\\*+/\\)") + (setq-local css--at-ids (append css-at-ids scss-at-ids)) (setq-local css--bang-ids (append css-bang-ids scss-bang-ids)) (setq-local font-lock-defaults (list (scss-font-lock-keywords) nil t))) -- 2.8.0 --MP_/qnugWSW/6H_3jAv7cGVHM.I-- From unknown Thu Sep 11 06:33:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23188: [PATCH] Support completion of at-rules in SCSS mode Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Apr 2016 11:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23188 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Etienne Prud'homme Cc: 23188@debbugs.gnu.org Received: via spool by 23188-submit@debbugs.gnu.org id=B23188.1459682320489 (code B ref 23188); Sun, 03 Apr 2016 11:19:02 +0000 Received: (at 23188) by debbugs.gnu.org; 3 Apr 2016 11:18:40 +0000 Received: from localhost ([127.0.0.1]:49465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amg3E-00007p-6L for submit@debbugs.gnu.org; Sun, 03 Apr 2016 07:18:40 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:33686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amg3C-00007Z-IO for 23188@debbugs.gnu.org; Sun, 03 Apr 2016 07:18:38 -0400 Received: by mail-lb0-f179.google.com with SMTP id u8so121250436lbk.0 for <23188@debbugs.gnu.org>; Sun, 03 Apr 2016 04:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=VORoNYl6rkH4oi+xUeOdLHVKresuCL0mG03WZR14w3s=; b=jk/HatvIzuM/ZOBTArsjl2iOKEIgGQ1llaJo/gZTeS9A4aNGtTMYpc5+8h4vSgXhy4 PjP5r612yJ7StXIdZhAOH9ILc545zrUNiGpvRho8WpprKYtvjC0V5HcNwPoNS3pxHLGa nlEnQNz/QLu3yD30onORQRd3eo5ADH5ci9RjRB6tQPzLN8I1gkZrwa2QaS6EGz1pdXCD xTVIkgrnJcnTJfpOfIS+rO4ESDS9W3IhgAb7HdUfB7Uade1JVhDUGvftIRPpQgFB744b s7O/8FZfaGh6CN+MJ3NZTnXCa405XbTny6hfxCNoyG8q0Qsvv9ewulpN7GQVlN6PUc8q z0hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=VORoNYl6rkH4oi+xUeOdLHVKresuCL0mG03WZR14w3s=; b=duxp+puYO+EWR1iAKbIojAdJbG1pM4r0uJzwJL1njKTcIbrPdTadzgA2Hawelc6V9a UwkhTQtEEOX8Sz4ndI/8qTxviDXL/KfWtrv19tDUjKXy7lKGFoqoeaNpJ3ud+es2/EaT YtpTrc0/X7HjdinG8qiQ1mtOt9EJ3R1ffn62hlW+Kwd9aaJnZiKHAC+D3/lQIhc93GZP GO/NGMesBblM+qpW2Wsvq3IkdIPtNCHewfppD9zU0I7aDpyWoIC0Q2p0r75Mr2jngXt6 yRVUcExTCzI3FjwDfTcF7PSG5UGJIczZx+NzmgqKVFHMTom9sX/TbG6yMsLAb6MRCj3N ov9w== X-Gm-Message-State: AD7BkJK9NP3M4MBDWYXIbLNTkIdpH8+xNR4vmTDf7/AkSIHHFZD0sW5GlRmpr+hLCeMLkw== X-Received: by 10.112.35.130 with SMTP id h2mr5881994lbj.52.1459682312763; Sun, 03 Apr 2016 04:18:32 -0700 (PDT) Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id zk4sm3815391lbb.15.2016.04.03.04.18.31 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 03 Apr 2016 04:18:32 -0700 (PDT) Date: Sun, 03 Apr 2016 13:18:30 +0200 From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Message-Id: <1459682310.18054.1@smtp.gmail.com> In-Reply-To: <20160401155707.4730bda5@ThinkPax> References: <20160401155707.4730bda5@ThinkPax> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-K1xKCwFAbEOyMcdjQfQj" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-K1xKCwFAbEOyMcdjQfQj Content-Type: text/plain; charset=utf-8; format=flowed Hello, Etienne. Many thanks for the patch. I've tested it and it seems to work as intended. Have you made a copyright assignment to the FSF before? Otherwise I think we can mark the patch exempt, since it changes just a few lines. Also, the commit message should follow the format described in CONTRIBUTE (see section "Commit messages"). I can fix this for you if you want to. -- Simen --=-K1xKCwFAbEOyMcdjQfQj Content-Type: text/html; charset=utf-8
Hello, Etienne.

Many thanks for the patch. I've tested it and it seems to work as
intended.

Have you made a copyright assignment to the FSF before? Otherwise I
think we can mark the patch exempt, since it changes just a few lines.

Also, the commit message should follow the format described in
CONTRIBUTE (see section "Commit messages"). I can fix this for you if
you want to.

-- Simen
--=-K1xKCwFAbEOyMcdjQfQj-- From unknown Thu Sep 11 06:33:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23188: [PATCH] Support completion of at-rules in SCSS mode Resent-From: Etienne Prud'homme Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Apr 2016 19:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23188 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Cc: 23188@debbugs.gnu.org Received: via spool by 23188-submit@debbugs.gnu.org id=B23188.14597991166653 (code B ref 23188); Mon, 04 Apr 2016 19:46:01 +0000 Received: (at 23188) by debbugs.gnu.org; 4 Apr 2016 19:45:16 +0000 Received: from localhost ([127.0.0.1]:51409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anAR2-0001jF-9j for submit@debbugs.gnu.org; Mon, 04 Apr 2016 15:45:16 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:35093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anAR0-0001j2-S5 for 23188@debbugs.gnu.org; Mon, 04 Apr 2016 15:45:15 -0400 Received: by mail-qk0-f172.google.com with SMTP id o6so66926765qkc.2 for <23188@debbugs.gnu.org>; Mon, 04 Apr 2016 12:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rRUk+X/0Hp4XGcoIJx/NmuBMtdLiVEznutKWB2K0gaM=; b=zkjm8ha25ToMbbExG9OqSup4JZVjy++UgRmVbhbB65xoh6zKCUN4pTYPjeX6cUk8YX DxtE7LFS3SmhgSsB06xa777ZKYNHduwrt3dwkPPlx4nrUsToXhWV6tMrA6h86nKt1QTz Uyae8EE59MaDCbigduVol9CJhEFWtvysB+ioS6XhTGn+T+uV0e7ViQ3uOVOydmg+kysW Yo98MX4z52KpLecIZS9RmLkS/+AFtHAx+9ZQiqIimZa0rC+Muy48+Lzrli5qaoicZ7z5 ih9BGsGSkhEhAQ31C9E8cndrcJ6VxKjOSbqpbrzt/P5TGMnWuEmX96dtiNz4+T3LcpkI a1Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rRUk+X/0Hp4XGcoIJx/NmuBMtdLiVEznutKWB2K0gaM=; b=RLazweZlSQ1vWRlH5GpYqFceoD1Hdbltd5MzL7VxD7KSPCTTI2Z7bqzrloxF5w62Ha Jk6tYwCAU4frKXSOjKuA5ggLXplM3jRAfFWjxDxRmogCMC9wGDaSJvD0efL54VprXbQO J1wTVO+aMLHmgxDccyWNQqmfMYAg6IQQ4IJZhomhYb50dYPmfCfTAT6C5nCy8w7XDJ9K HaovJtszTPgKpZz5oAEbSrftV1S8q20YwQq2YiD7fVprUbLUa0l/PKSWHToEKGx391h3 8+Gh474TCCozWaT9H9in6TTLJhIe1FsgjcPNgAgvxnTLPxlhXQIe/ulIXTSuzS2abE2c YhIw== X-Gm-Message-State: AD7BkJK8CK+2C/J/teWVavL5SEOFsEHIoi6QpZRkSHpFEqzcvLVrBadQeRQuYP6/K79BLA== X-Received: by 10.55.23.68 with SMTP id i65mr34922764qkh.74.1459799109261; Mon, 04 Apr 2016 12:45:09 -0700 (PDT) Received: from ThinkPax ([173.199.65.7]) by smtp.gmail.com with ESMTPSA id 78sm12971177qhr.4.2016.04.04.12.45.08 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 04 Apr 2016 12:45:08 -0700 (PDT) Date: Mon, 4 Apr 2016 15:44:59 -0400 From: Etienne Prud'homme Message-ID: <20160404154459.5e5389de@ThinkPax> In-Reply-To: <1459682310.18054.1@smtp.gmail.com> References: <20160401155707.4730bda5@ThinkPax> <1459682310.18054.1@smtp.gmail.com> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.23; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 03 Apr 2016 13:18:30 +0200, Simen Heggest=C3=B8yl wrote: > Also, the commit message should follow the format described in > CONTRIBUTE (see section "Commit messages"). I can fix this for you if > you want to. Thanks for pointing me that out. Could you fix it, since it=E2=80=99s the f= irst time I contribute to a GNU project and I=E2=80=99m not sure how to do it? Best regards, From unknown Thu Sep 11 06:33:37 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Etienne Prud'homme Subject: bug#23188: closed (Re: bug#23188: [PATCH] Support completion of at-rules in SCSS mode) Message-ID: References: <1459891126.3255.0@smtp.gmail.com> <20160401155707.4730bda5@ThinkPax> X-Gnu-PR-Message: they-closed 23188 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 23188@debbugs.gnu.org Date: Tue, 05 Apr 2016 21:19:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1459891142-27732-1" This is a multi-part message in MIME format... ------------=_1459891142-27732-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #23188: [PATCH] Support completion of at-rules in SCSS mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 23188@debbugs.gnu.org. --=20 23188: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23188 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1459891142-27732-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 23188-done) by debbugs.gnu.org; 5 Apr 2016 21:18:56 +0000 Received: from localhost ([127.0.0.1]:50769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anYNE-0007D0-BU for submit@debbugs.gnu.org; Tue, 05 Apr 2016 17:18:56 -0400 Received: from mail-lb0-f177.google.com ([209.85.217.177]:34017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anYNC-0007Co-HH for 23188-done@debbugs.gnu.org; Tue, 05 Apr 2016 17:18:54 -0400 Received: by mail-lb0-f177.google.com with SMTP id vo2so17665701lbb.1 for <23188-done@debbugs.gnu.org>; Tue, 05 Apr 2016 14:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:subject:to:cc:message-id:in-reply-to:references :mime-version; bh=rHHtdJAf3kW7hvmJW9LfwyxhPEAu9i8d99Yjm/MuSlQ=; b=aibmUjopverhe43D5MsgPc436P0jSPEn58BdEKvsg7pgFI/EoRJJEQyTXDYdcJR2ZD Rjgm4IIe9L2bTACQVlDeuUJsS3d9wrQDKhlNEMCNlzrCALBM67KuAut09RdNFmy7a48P 3HajsfwO7g79wqk25g2kg+8jC+PwvdUFJ2DZPFIzSkC2lH97bslaoyGTmCL1Nhpk2s/A Is2H1uqjKCno+nqVIe4PGYfFMtgNXJXXuXDIL9kK2+3G+e4yUgn/F5n9R0KK27QQpUWV n7X2o7czzyx7TMmLlbNs0X9qXrfVWW7Jum+uUH4TJvVZ/dh50+ScrAmrbKWmIwnSy9Ij LTiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to :references:mime-version; bh=rHHtdJAf3kW7hvmJW9LfwyxhPEAu9i8d99Yjm/MuSlQ=; b=PT2YHKKMPjUpAL5T8TBAIWHtN/szRgdx2GUqrChPEFtnlHzKW7YoFl/k31t+cswINe 8/DTVaR17g/0Y9azeoSD61vzGRvuz+e833TAgCLj5bn2M7JJ+tO4duQXhHhJ5xWooVdi F2Vojyo2O56/pdOGwnX82M83UTD6uxLQA5XF0w1qMPe/Yfo+UPXV2wrosfhaXjeFCoEf 7Bv01bVfw/bnUBccVgYUkk9Ghex8o2GbtzieMaa1lYe9y6s3lGjsNklPkiN45xckuDeO N3Evdl6HVYKjgP7lNGFt5gIseb1MkIbDoRb273xKzhzQmpq2Ac7eUjqH59cBMvBcJNx2 RDvA== X-Gm-Message-State: AD7BkJL8KNp1W6H50DSx2j4U/vq2EiLCbO7xFhJFpeSYAqR/MX3s33ZmByUl2mtEtxze/w== X-Received: by 10.112.126.36 with SMTP id mv4mr6300963lbb.97.1459891128642; Tue, 05 Apr 2016 14:18:48 -0700 (PDT) Received: from [192.168.100.5] (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id lw1sm426414lbc.15.2016.04.05.14.18.47 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Apr 2016 14:18:48 -0700 (PDT) Date: Tue, 05 Apr 2016 23:18:46 +0200 From: Simen =?iso-8859-1?q?Heggest=F8yl?= Subject: Re: bug#23188: [PATCH] Support completion of at-rules in SCSS mode To: Etienne Prud'homme Message-Id: <1459891126.3255.0@smtp.gmail.com> In-Reply-To: <20160404154459.5e5389de@ThinkPax> References: <20160401155707.4730bda5@ThinkPax> <1459682310.18054.1@smtp.gmail.com> <20160404154459.5e5389de@ThinkPax> X-Mailer: geary/0.10.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-WIyTLDzd3w31u41h4oVZ" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23188-done Cc: 23188-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-WIyTLDzd3w31u41h4oVZ Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On Mon, Apr 4, 2016 at 9:44 PM, Etienne Prud'homme=20 wrote: > Thanks for pointing me that out. Could you fix it, since it=E2=80=99s the= =20 > first > time I contribute to a GNU project and I=E2=80=99m not sure how to do it? >=20 > Best regards, No problem. Fixed and installed in master. Thanks again! -- Simen = --=-WIyTLDzd3w31u41h4oVZ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Apr 4, 2016 at 9:44 PM, Etienne Prud'homme <e.e.f.prudhomme@gmai= l.com> wrote:
Thanks for pointing me that out. Could you fix= it, since it=E2=80=99s the first time I contribute to a GNU project and I=E2=80=99m not sure how to do it? Best regards,

No problem. Fixed and installed in= master.

Thanks again!

--= Simen
= --=-WIyTLDzd3w31u41h4oVZ-- ------------=_1459891142-27732-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Apr 2016 19:24:09 +0000 Received: from localhost ([127.0.0.1]:49110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amR9U-0007Qk-S6 for submit@debbugs.gnu.org; Sat, 02 Apr 2016 15:24:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1am5Ci-0002T9-Ln for submit@debbugs.gnu.org; Fri, 01 Apr 2016 15:58:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1am5Cc-0000F0-OB for submit@debbugs.gnu.org; Fri, 01 Apr 2016 15:57:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1am5Cc-0000Ew-Kj for submit@debbugs.gnu.org; Fri, 01 Apr 2016 15:57:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1am5Cb-0006PQ-Jq for bug-gnu-emacs@gnu.org; Fri, 01 Apr 2016 15:57:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1am5CW-0000ES-JM for bug-gnu-emacs@gnu.org; Fri, 01 Apr 2016 15:57:53 -0400 Received: from mail-qg0-x243.google.com ([2607:f8b0:400d:c04::243]:36439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1am5CW-0000E8-ES for bug-gnu-emacs@gnu.org; Fri, 01 Apr 2016 15:57:48 -0400 Received: by mail-qg0-x243.google.com with SMTP id n34so12172625qge.3 for ; Fri, 01 Apr 2016 12:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version; bh=AKEW/wqlq//xygVKII3RYRKFNzNRhYpB5PoMOB2Ldww=; b=qBD/5PfdAxVp6/9veNNLfW4ceLVTyvPd4B5WT0YNJO2HAjjeqgm35phN7NaM6gKnwq rYXwZQfo4C9w+6PlvmNLGwBdTv0vaa9L8zJP/VFxSBgrEq/8xgyiT8aqzGtSlJYn2dNN 3NoD8s/7VrDf38FhMpkebvVXbCnlthta0QHEvXqx5ew2KkB5oL2U5NF7Ry3+C876PM96 +g+qfdZBkkTte700btsXx2TXasHDb60bxxvOp9VS+oo1WrtzobKjz7e7ZugLSBFOeKsG VtoLr+7DADlBIDn7KCy+zJKaBvgUAldtBlqXUrrTDBZNyN7vlNiW8dgo9wPhudbYhMa2 ZCtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:mime-version; bh=AKEW/wqlq//xygVKII3RYRKFNzNRhYpB5PoMOB2Ldww=; b=lxTsDQ6BYnKZ6C5+dCyz3nSYsioNcprX+yt9QgfGAj3GkPZeoB8R/4OOhAXVBcKSgK g8HAU3nfgkKzGRcj/zPh63ElGtPIyuEq17WM7nHqpfCOwdGM+qfmZm7DD3XTSotKS85t Flyu4MePIPwUXmQVUTwzSIQV+cbHiP24a4uQS5Hq3zBXctU/7wAQaD9Ch/0cXg2a9GXB pMMoVJguTExBPkzjyrtisB2XDEJy4n6DCRVKgAxwVGTv/uDn2m7kQrCT16SWhs2zxRXD Nlu5TwW+m4IXORjXZ1eCgTEzDaW0zbeTOxl+9HiUc4wPsjKrc/c9LqiWbz+Fs+ghbW+M YWBQ== X-Gm-Message-State: AD7BkJI/XXM55C29Gm0J/J5oRczRsEqH31AQxVneMGKi6EmGZzN/bwtopGzwKO9duYm54g== X-Received: by 10.140.246.136 with SMTP id r130mr362216qhc.12.1459540667543; Fri, 01 Apr 2016 12:57:47 -0700 (PDT) Received: from ThinkPax ([173.199.65.14]) by smtp.gmail.com with ESMTPSA id s8sm6770709qhb.20.2016.04.01.12.57.46 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Fri, 01 Apr 2016 12:57:47 -0700 (PDT) Date: Fri, 1 Apr 2016 15:57:07 -0400 From: Etienne Prud'homme To: bug-gnu-emacs@gnu.org Subject: [PATCH] Support completion of at-rules in SCSS mode Message-ID: <20160401155707.4730bda5@ThinkPax> X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.23; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/qnugWSW/6H_3jAv7cGVHM.I" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 02 Apr 2016 15:24:07 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --MP_/qnugWSW/6H_3jAv7cGVHM.I Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline The attached patch adds support for at-rules completion in SCSS mode. It=E2=80=99s more or less the same code from bug#23135 (Support completion = of bang-rules in CSS mode). --MP_/qnugWSW/6H_3jAv7cGVHM.I Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-Support-completion-of-at-rules-in-SCSS-mode.patch >From 4ad8f21f11ed9c48f986cfdd8d50883389fa8d2a Mon Sep 17 00:00:00 2001 From: Etienne Prud'homme Date: Fri, 1 Apr 2016 15:09:15 -0400 Subject: [PATCH] Support completion of at-rules in SCSS mode --- lisp/textmodes/css-mode.el | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index cbef3d4..02a5b11 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -56,6 +56,15 @@ '("charset" "font-face" "import" "media" "namespace" "page") "Identifiers that appear in the form @foo.") +(defconst scss-at-ids + '("at-root" "content" "debug" "each" "else" "else if" "error" "extend" "for" + "function" "if" "import" "include" "mixin" "return" "warn" "while") + "Additional identifiers that appear in the form @foo in SCSS.") + +(defvar css--at-ids css-at-ids + "List of at-rules for the current mode.") +(make-variable-buffer-local 'css--at-ids) + (defconst css-bang-ids '("important") "Identifiers that appear in the form !foo.") @@ -759,7 +768,7 @@ cannot be completed sensibly: `angle', `element-reference', (let ((pos (point))) (skip-chars-backward "-[:alnum:]") (when (eq (char-before) ?\@) - (list (point) pos css-at-ids))))) + (list (point) pos css--at-ids))))) (defvar css--property-value-cache (make-hash-table :test 'equal :size (length css-property-alist)) @@ -969,6 +978,7 @@ pseudo-elements, pseudo-classes, at-rules, and bang-rules." (setq-local comment-continue " *") (setq-local comment-start-skip "/[*/]+[ \t]*") (setq-local comment-end-skip "[ \t]*\\(?:\n\\|\\*+/\\)") + (setq-local css--at-ids (append css-at-ids scss-at-ids)) (setq-local css--bang-ids (append css-bang-ids scss-bang-ids)) (setq-local font-lock-defaults (list (scss-font-lock-keywords) nil t))) -- 2.8.0 --MP_/qnugWSW/6H_3jAv7cGVHM.I-- ------------=_1459891142-27732-1--