GNU bug report logs - #23188
[PATCH] Support completion of at-rules in SCSS mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23188 in the body.
You can then email your comments to 23188 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Etienne Prud'homme <e.e.f.prudhomme <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Support completion of at-rules in SCSS mode
Date: Fri, 1 Apr 2016 15:57:07 -0400

[Message part 1 (text/plain, inline)]

The attached patch adds support for at-rules completion in SCSS mode.
It’s more or less the same code from bug#23135 (Support completion of
bang-rules in CSS mode).

[0001-Support-completion-of-at-rules-in-SCSS-mode.patch (text/x-patch, attachment)]

Message #8 received at 23188 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Etienne Prud'homme <e.e.f.prudhomme <at> gmail.com>
Cc: 23188 <at> debbugs.gnu.org
Subject: Re: bug#23188: [PATCH] Support completion of at-rules in SCSS mode
Date: Sun, 03 Apr 2016 13:18:30 +0200

[Message part 1 (text/plain, inline)]

Hello, Etienne.

Many thanks for the patch. I've tested it and it seems to work as
intended.

Have you made a copyright assignment to the FSF before? Otherwise I
think we can mark the patch exempt, since it changes just a few lines.

Also, the commit message should follow the format described in
CONTRIBUTE (see section "Commit messages"). I can fix this for you if
you want to.

-- Simen

[Message part 2 (text/html, inline)]

Message #11 received at 23188 <at> debbugs.gnu.org (full text, mbox):

From: Etienne Prud'homme <e.e.f.prudhomme <at> gmail.com>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: 23188 <at> debbugs.gnu.org
Subject: Re: bug#23188: [PATCH] Support completion of at-rules in SCSS mode
Date: Mon, 4 Apr 2016 15:44:59 -0400

On Sun, 03 Apr 2016 13:18:30 +0200,
Simen Heggestøyl <simenheg <at> gmail.com> wrote:

> Also, the commit message should follow the format described in
> CONTRIBUTE (see section "Commit messages"). I can fix this for you if
> you want to.

Thanks for pointing me that out. Could you fix it, since it’s the first
time I contribute to a GNU project and I’m not sure how to do it?

Best regards,

Message #16 received at 23188-done <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Etienne Prud'homme <e.e.f.prudhomme <at> gmail.com>
Cc: 23188-done <at> debbugs.gnu.org
Subject: Re: bug#23188: [PATCH] Support completion of at-rules in SCSS mode
Date: Tue, 05 Apr 2016 23:18:46 +0200

[Message part 1 (text/plain, inline)]

On Mon, Apr 4, 2016 at 9:44 PM, Etienne Prud'homme 
<e.e.f.prudhomme <at> gmail.com> wrote:
> Thanks for pointing me that out. Could you fix it, since it’s the 
> first
> time I contribute to a GNU project and I’m not sure how to do it?
> 
> Best regards,

No problem. Fixed and installed in master.

Thanks again!

-- Simen

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.