From unknown Wed Jun 18 00:28:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23164 <23164@debbugs.gnu.org> To: bug#23164 <23164@debbugs.gnu.org> Subject: Status: 25.1.50; xref-find-definitions with local tags-file-name fails Reply-To: bug#23164 <23164@debbugs.gnu.org> Date: Wed, 18 Jun 2025 07:28:03 +0000 retitle 23164 25.1.50; xref-find-definitions with local tags-file-name fails reassign 23164 emacs submitter 23164 Johan Claesson severity 23164 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 30 16:53:41 2016 Received: (at submit) by debbugs.gnu.org; 30 Mar 2016 20:53:41 +0000 Received: from localhost ([127.0.0.1]:45436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1alN7V-00088t-Au for submit@debbugs.gnu.org; Wed, 30 Mar 2016 16:53:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1alN7S-00088g-KX for submit@debbugs.gnu.org; Wed, 30 Mar 2016 16:53:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alN7L-0008Nx-DR for submit@debbugs.gnu.org; Wed, 30 Mar 2016 16:53:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alN7L-0008Nt-Aa for submit@debbugs.gnu.org; Wed, 30 Mar 2016 16:53:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alN7J-0006ur-7K for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2016 16:53:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alN7G-0008Mv-9x for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2016 16:53:29 -0400 Received: from smtprelay-b22.telenor.se ([195.54.99.213]:46466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alN7F-0008GM-P3 for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2016 16:53:26 -0400 Received: from ipb2.telenor.se (ipb2.telenor.se [195.54.127.165]) by smtprelay-b22.telenor.se (Postfix) with ESMTP id DF02DCBF1 for ; Wed, 30 Mar 2016 22:52:07 +0200 (CEST) X-SENDER-IP: [213.114.146.248] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DqJgC6O/xWJ/iSctVdHAGDFx41fYZotCNagRYSB4dEOhMBAQEBAQEBBgEBAQEBAT9AhR4TASckDyUBBBkMCkuIDQGhCKEQGYYFiF4GAQEFZoUIBY1FiWVEj22NJ4YTiH0hAYF2DD8DARiBTDowhwMIF4EdAQEB X-IPAS-Result: A2DqJgC6O/xWJ/iSctVdHAGDFx41fYZotCNagRYSB4dEOhMBAQEBAQEBBgEBAQEBAT9AhR4TASckDyUBBBkMCkuIDQGhCKEQGYYFiF4GAQEFZoUIBY1FiWVEj22NJ4YTiH0hAYF2DD8DARiBTDowhwMIF4EdAQEB X-IronPort-AV: E=Sophos;i="5.24,418,1454972400"; d="scan'208";a="513278877" Received: from c-f89272d5.04-99-73746f3.cust.bredbandsbolaget.se (HELO goblin) ([213.114.146.248]) by ipb2.telenor.se with ESMTP; 30 Mar 2016 22:52:07 +0200 From: Johan Claesson To: bug-gnu-emacs@gnu.org Subject: 25.1.50; xref-find-definitions with local tags-file-name fails User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Date: Wed, 30 Mar 2016 22:52:06 +0200 Message-ID: <87egar3czt.fsf@bredband.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Hi, emacs -Q (fundamental-mode) (setq-local tags-file-name "/dev/zero") (xref-find-definitions "foo") Fails with (wrong-type-argument stringp nil) in visit-tags-table-buffer. The problem also occurs when tags-file-name points to a valid TAGS file (the invalid /dev/zero was chosen just to make the recipe short). If tags-file-name have a global value there is no problem. It is the following line in visit-tags-table-buffer that fails. (setq tags-file-name (tags-expand-table-name tags-file-name)) If this is protected with (when tags-file-name ...) then the problem do not occur. The same if the line is moved down and inside the unless sexp that follows immediately. If either is the right thing to do i don't know. But it seem a bit strange to assume that tags-file-name shall be non-nil at that point. The problem occurs when etags--xref-find-definitions calls visit-tags-table-buffer for the second time. Regards, /Johan In GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, X toolkit) of 2016-03-28 built on goblin Repository revision: a30e7e12ed8465e2565dd318d921bc87f52ce18e Windowing system distributor 'The X.Org Foundation', version 11.0.11702000 System Description: Ubuntu 15.10 Configured using: 'configure --prefix=/ssd/home/jcl/usr --with-x-toolkit=lucid --without-toolkit-scroll-bars --disable-silent-rules --without-compress-install --enable-link-time-optimization PKG_CONFIG_PATH=/home/jcl/usr/lib/pkgconfig' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB LUCID X11 Important settings: value of $LC_MONETARY: en_GB.UTF-8 value of $LC_NUMERIC: en_GB.UTF-8 value of $LC_TIME: en_GB.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix Major mode: Text Minor modes in effect: magit-auto-revert-mode: t display-time-mode: t minibuffer-depth-indicate-mode: t num3-mode: t minibuffer-electric-default-mode: t icomplete-mode: t diff-auto-refine-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t global-git-commit-mode: t async-bytecomp-package-mode: t shell-dirtrack-mode: t wc-mode: t winner-mode: t ido-everywhere: t which-function-mode: t global-eldoc-mode: t electric-layout-mode: t electric-indent-mode: t mouse-wheel-mode: t global-prettify-symbols-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t line-number-mode: t auto-fill-function: do-auto-fill transient-mark-mode: t abbrev-mode: t Recent messages: Saving file /home/jcl/.newsrc.eld... Wrote /home/jcl/.newsrc.eld Saving file /ssd/home/jcl/TAGS_REPORT... Wrote /ssd/home/jcl/TAGS_REPORT Preparing diary...done Preparing diary...done No event to add Mark set [2 times] Quit Mark set Load-path shadows: None found. Features: (nnir emacsbug files-x tramp-cache gnus-dired apropos eieio-opt speedbar sb-image ezimage dframe hippie-exp edmacro autoload lisp-mnt tabify nndoc gnus-dup w3m-cookie jcl-replace jcl-games-init jcl-muse-init htmlize-hack htmlize muse-latex muse-html muse-xml-common muse-colors cus-edit muse-publish muse-project muse-protocols muse-regexps muse muse-nested-tags muse-mode jcl-yaoddmuse-init yaoddmuse-extension yaoddmuse skeleton sgml-mode shadow smiley gnus-cite flow-fill mail-extr gnus-async linum pulse time-stamp cus-start cus-load tempo misearch multi-isearch jcl-renegade-goblin jcl-home-boot vc vc-dispatcher vc-git org-rmail org-mhe org-irc org-info org-gnus org-docview org-bibtex bibtex org-bbdb org-w3m jcl-load jcl-billboard-init typing-practice jcl-elisp-init profiler tagbag-init jcl-grep-init jcl-abbrev-init jcl-ediff-init jcl-term-init jcl-erlang-init jcl-sbg jcl-erlang-log bookmark jcl-erlang-man man jcl-midnite-init jcl-midnite midnight jcl-picpocket-init picpocket-test jcl-erc-init jcl-ido-init jcl-dired-init image-file wdired jcl-register-init jcl-command-subset-init jcl-generic-init generic-x jcl-eww-init eww url-queue shr svg dom jcl-org-init poporg ob-latex ox-beamer org-feed org-capture jcl-shell-init jcl-haskell-init jcl-haskell-old inf-haskell haskell-decl-scan haskell-mode haskell-cabal haskell-utils haskell-font-lock haskell-indentation haskell-string haskell-sort-imports haskell-lexeme haskell-align-imports haskell-compat haskell-complete-module flymake dabbrev haskell-customize jcl-mentor-init mentor xml-rpc url-scgi jcl-google-init jcl-modes-init checkdoc magit-blame magit-stash magit-bisect magit-remote magit-commit magit-sequence magit magit-apply magit-wip magit-log magit-diff smerge-mode magit-core magit-autorevert magit-process magit-popup magit-mode magit-git crm magit-section magit-utils calc calc-loaddefs calc-macs jcl-rfc rfcview goto-addr proced nroff-mode table picture python rx jcl-ruby inf-ruby ruby-mode fpl macrostep-c cmacexp cwarn grep jcl-elpa-init ffap view jcl-global-init time printing mb-depth saveplace num3-mode minibuf-eldef icomplete jcl-sl-init jcl-keys-init kmacro diff-mode jcl-sbg-ssit jcl-google google-translate google-translate-default-ui google-translate-core-ui google-translate-core google-translate-tk jcl-imenu jcl-wesnoth wesnoth-mode wesnoth-wml-data wesnoth-update jcl-erlang jcl-sbg-compile jcl-picpocket jcl-goblin jcl-dired jcl-dired-lexical picpocket fuzzy-match jcl-ediff jcl-elisp jcl-grep edebug jcl-stumpwm jcl-org jcl-erc erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat jcl-vbox jcl-lxc jcl-keys windmove jcl-debbugs-init debbugs-org debbugs-gnu debbugs soap-client warnings rng-xsd rng-dt rng-util xsd-regexp jcl-isearch jcl-sbg-scan tagbag sbg filecache jcl-bugfix loadhist git-commit help-fns with-editor async-bytecomp async tramp-sh tramp tramp-compat tramp-loaddefs trampver ucs-normalize shell log-edit pcvs-util add-log dash jcl-merge jcl-wip jcl-work-buffer ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff jcl-sty jcl-epresent face-remap org-indent epresent ox-latex ox-icalendar ox-html ox-ascii ox-publish ox org-element avl-tree diet ps-print ps-print-loaddefs ps-def lpr jcl-template jcl-copyright jcl-template-lib cperl-mode cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs erlang wc-mode jcl-register jcl-advice jcl-command-subset jcl-duff clearcase reporter jcl-motion jcl-safe-init jcl-site-start jpt-mode erlang-start qp gnus-ml gnus-topic cursor-sensor mm-archive network-stream nsm url-http url-gw puny url-cache url-auth nnrss mm-url nndraft nnmh nnfolder nnml jcl-master jcl-calendar-init jcl-emms-init emms-playlist-limit emms-volume emms-volume-amixer emms-i18n emms-history emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon emms-browser sort emms-playlist-sort emms-last-played emms-player-xine emms-player-mpd tq emms-streams emms-show-all emms-tag-editor emms-mark emms-cache emms-info-ogginfo emms-info-mp3info emms-player-vlc emms-player-mplayer jcl-emms emms-mode-line emms-librefm-stream emms-librefm-scrobbler emms-playing-time emms-info later-do emms-playlist-mode emms-source-playlist xml emms-setup emms-lyrics emms-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf emms-source-file locate emms-player-simple emms emms-compat jcl-gnus-init jcl-gnus jcl-w3m-init jcl-term ange-ftp w3m-search w3m-bookmark w3m-antenna w3m-rss jcl-org-import-icalendar jcl-status jcl-buffer-init org-location-google-maps org-agenda google-maps google-maps-static url-util google-maps-geocode google-maps-base json map org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs autorevert filenotify appt jcl-calendar jcl-swedish-postfix quail holidays hol-loaddefs icalendar diary-lib diary-loaddefs cal-menu calendar cal-loaddefs w3m doc-view jka-compr image-mode timezone w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util dired-aux dired-x gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source tls gnutls utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range gnus-win mailcap starttls smtpmail sendmail message format-spec rfc822 mml mml-sec epa derived epg mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr wid-edit jcl-boot jcl-slime-init slime-fancy slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-autodoc jcl-misc jcl-ert ispell find-lisp jcl-misc-lexical whitespace winner jcl-windows jcl-buffer ido ert find-func ewoc debug jcl-compile slime-editing-commands slime-repl slime-parse slime compile etags xref project arc-mode archive-mode noutline outline easy-mmode pp comint ansi-color hyperspec thingatpt browse-url jcl-face hi-lock dired dired-loaddefs paren mic-paren which-func imenu hl-line jcl-times-init jcl-early-init jcl-compat-init advice jcl-util seq subr-x jcl-times server term disp-table ehelp ring sh-script smie executable jcl-load-path tex-site eimp-autoloads gnugo-autoloads ascii-art-to-unicode-autoloads htmlize-autoloads ipython-autoloads list-utils-autoloads cl memory-usage-autoloads muse-autoloads num3-mode-autoloads finder-inf python-autoloads slime-autoloads info package epg-config url-handlers url-parse auth-source cl-seq eieio byte-opt bytecomp byte-compile cl-extra help-mode easymenu cconv eieio-core cl-macs gv eieio-loaddefs cl-loaddefs pcase cl-lib password-cache url-vars time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 2323635 324305) (symbols 48 95458 0) (miscs 40 4764 9552) (strings 32 440421 52479) (string-bytes 1 13760818) (vectors 16 134524) (vector-slots 8 2805790 70429) (floats 8 2555 2826) (intervals 56 168636 14751) (buffers 976 129) (heap 1024 200613 154140)) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 03 21:29:40 2016 Received: (at 23164) by debbugs.gnu.org; 4 Apr 2016 01:29:40 +0000 Received: from localhost ([127.0.0.1]:50455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amtKl-0007w3-ST for submit@debbugs.gnu.org; Sun, 03 Apr 2016 21:29:40 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:36827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amtKj-0007vp-VN for 23164@debbugs.gnu.org; Sun, 03 Apr 2016 21:29:38 -0400 Received: by mail-lb0-f182.google.com with SMTP id qe11so137939544lbc.3 for <23164@debbugs.gnu.org>; Sun, 03 Apr 2016 18:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=uj4dg0pn1Yn2wuki+SWyKqW2bFXPqrpi4N+vLW3fsJU=; b=nt6Kkbb3+eqn/K3wHSUOxBpQtf8crAgUsoxzPVUPN2ilV8tW0YgT7DGQqdLsNCv0xV gFhyUn+nmf8rSCNn6EeI19/jXcQ/3DTHEe6qZDIxjjovSZ2Q4cVuBt0O/gX52QBk/tkI 1WCn5jdi3/PSmafMKCaUtu1LKNT+WW8pAILn0l+q7lPwDlwzRVobaAg/GZNv/ypNU/bb 1CJgk52VQ9w9Wi6sR1yYZSK2uZQm899BqMtkILciZBpGA+10PEJMLJQhVqMKXqOIohL3 1OXN2cWFM5nOpFdbeIMzV3eEfzUL3+AvAjnGE1+EJuPCFqZh2ZcYCn0H4AQ2zMNI4tdj kn5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=uj4dg0pn1Yn2wuki+SWyKqW2bFXPqrpi4N+vLW3fsJU=; b=m6CRy4xbuaCvsycknvNaRskguvlR5HyltZS4Hb4cPqp4HBSUsfbG4u7czmYGDk+jRn 0UbNM/DEOZecPCP1TxMoSVC5LivhI0tHlGTXwdJIqZX3bmrALzcyXFiz0yBJkFkCQOf8 Qis4jo7jNU7Ik/TdJNTItUgWQ3p6ysZo020Xm3Ne0kUOZ//hVUgnMz2tTA0MJnVvCR90 V5FkiRJ7Op1jviWm+WZcXUWdTbJDHUFapbPo26qovsQeGFM4Q0a/nGYnqIooXNmtjdK4 CkiIQ97hTYyZgBuPtVUffn7lRFrLngpCq9P+2jy5nQzjP2HBhKQ0D1NBBdFiIH7k+pqC WsPg== X-Gm-Message-State: AD7BkJK6IjO6PIxgOX1au9IbuOcHPW5fiO94hHeE0xcM+RgSJKn5hJrjMmG3Uu0k9XbDtg== X-Received: by 10.28.12.80 with SMTP id 77mr9530679wmm.19.1459733372040; Sun, 03 Apr 2016 18:29:32 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id ll9sm26396347wjc.29.2016.04.03.18.29.30 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 03 Apr 2016 18:29:31 -0700 (PDT) Subject: Re: bug#23164: 25.1.50; xref-find-definitions with local tags-file-name fails To: Johan Claesson , 23164@debbugs.gnu.org References: <87egar3czt.fsf@bredband.net> From: Dmitry Gutov Message-ID: <87a497cc-15b1-504b-fd4a-8fb3e484e507@yandex.ru> Date: Mon, 4 Apr 2016 04:29:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87egar3czt.fsf@bredband.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23164 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Hi there! On 03/30/2016 11:52 PM, Johan Claesson wrote: > emacs -Q > > (fundamental-mode) > (setq-local tags-file-name "/dev/zero") > (xref-find-definitions "foo") > > Fails with (wrong-type-argument stringp nil) in > visit-tags-table-buffer. I do see the error with tags-file-name set to /dev/zero. > The problem also occurs when tags-file-name points to a valid TAGS > file (the invalid /dev/zero was chosen just to make the recipe > short). Thanks for the report, but that doesn't seem to be the case here. At least if I replace "/dev/zero" with "~/vc/emacs/src/TAGS", the scenario doesn't lead to an error (I just get "not found"), and if I also use e.g. "CALLN" instead of "foo", the jump to the destination occurs as expected. To be 100% sure we're trying the same code, could you build Emacs from the branch emacs-25? Is there anything else you can tell us to help reproduce the problem? > If tags-file-name have a global value there is no problem. > > It is the following line in visit-tags-table-buffer that fails. > > (setq tags-file-name (tags-expand-table-name tags-file-name)) > > If this is protected with (when tags-file-name ...) then the problem > do not occur. The same if the line is moved down and inside the > unless sexp that follows immediately. If either is the right thing to > do i don't know. But it seem a bit strange to assume that > tags-file-name shall be non-nil at that point. The preceding form tries to make sure to set it to the current value. Depending on the value of CONT, it will ask the user, use the current value, or delegate to some guessing logic. It's not 100% solid, though. > The problem occurs > when etags--xref-find-definitions calls visit-tags-table-buffer for > the second time. The assumption here is that the second time visit-tags-table-buffer is called from the tags file buffer. And that the previous invocation either set tags-file-name locally in that buffer, or at least set tags-table-list. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 03 21:52:41 2016 Received: (at 23164) by debbugs.gnu.org; 4 Apr 2016 01:52:41 +0000 Received: from localhost ([127.0.0.1]:50459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amth2-0008Rf-Qu for submit@debbugs.gnu.org; Sun, 03 Apr 2016 21:52:40 -0400 Received: from smtp10.acens.net ([86.109.99.134]:26065 helo=smtp.movistar.es) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amth0-0008RR-KB for 23164@debbugs.gnu.org; Sun, 03 Apr 2016 21:52:39 -0400 X-CTCH-RefID: str=0001.0A0B0206.5701C8E0.0063, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Received: from qcore (79.153.146.151) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 56F5ABE50082EC52; Mon, 4 Apr 2016 01:52:32 +0000 From: =?utf-8?Q?=C3=93scar_Fuentes?= To: Dmitry Gutov Subject: Re: bug#23164: 25.1.50; xref-find-definitions with local tags-file-name fails References: <87egar3czt.fsf@bredband.net> <87a497cc-15b1-504b-fd4a-8fb3e484e507@yandex.ru> Date: Mon, 04 Apr 2016 03:52:31 +0200 In-Reply-To: <87a497cc-15b1-504b-fd4a-8fb3e484e507@yandex.ru> (Dmitry Gutov's message of "Mon, 4 Apr 2016 04:29:30 +0300") Message-ID: <87zita16ow.fsf@wanadoo.es> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23164 Cc: 23164@debbugs.gnu.org, Johan Claesson X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Dmitry Gutov writes: > Thanks for the report, but that doesn't seem to be the case here. At > least if I replace "/dev/zero" with "~/vc/emacs/src/TAGS", the > scenario doesn't lead to an error (I just get "not found"), and if I > also use e.g. "CALLN" instead of "foo", the jump to the destination > occurs as expected. I can reproduce it here with an existing TAGS file, on emacs -Q. GNU Emacs 25.0.92.3 (x86_64-unknown-linux-gnu, X toolkit) of 2016-04-03 at commit fc3cd53900eb5e80b91b6d2615b3800fd2f59c16 Debugger entered--Lisp error: (wrong-type-argument stringp nil) expand-file-name(nil) tags-expand-table-name(nil) visit-tags-table-buffer(t) etags--xref-find-definitions("foo") #[514 "\300!\207" [etags--xref-find-definitions] 4 "\n\n(fn BACKEND SYMBOL)"](etags "foo") apply(#[514 "\300!\207" [etags--xref-find-definitions] 4 "\n\n(fn BACKEND SYMBOL)"] etags "foo") xref-backend-definitions(etags "foo") xref--find-xrefs("foo" definitions "foo" nil) xref--find-definitions("foo" nil) xref-find-definitions("foo") eval((xref-find-definitions "foo") nil) elisp--eval-last-sexp(nil) eval-last-sexp(nil) funcall-interactively(eval-last-sexp nil) call-interactively(eval-last-sexp nil nil) command-execute(eval-last-sexp) From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 04 04:54:57 2016 Received: (at 23164) by debbugs.gnu.org; 4 Apr 2016 08:54:57 +0000 Received: from localhost ([127.0.0.1]:50587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an0Hg-0001AF-SF for submit@debbugs.gnu.org; Mon, 04 Apr 2016 04:54:57 -0400 Received: from smtprelay-h22.telenor.se ([195.54.99.197]:57040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an0Hf-0001A0-Qq for 23164@debbugs.gnu.org; Mon, 04 Apr 2016 04:54:56 -0400 Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-h22.telenor.se (Postfix) with ESMTP id A787FCC36 for <23164@debbugs.gnu.org>; Mon, 4 Apr 2016 10:54:12 +0200 (CEST) X-SENDER-IP: [213.114.153.250] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CxBgAGKwJX//qZctVdHAGDGoFQgnGoQZADgXKGDQKBKTsSAQEBAQEBAWUnhEIBAQMBIzMjBQsIAxoCBSECAg8BBBkMJBOIEgMKDAGqe4wMIYUDAQEBAQYCAR0ZY4UkhEqEPYMCglYBBI1NijSdF48aJwswg2k6MIgmAQEB X-IPAS-Result: A2CxBgAGKwJX//qZctVdHAGDGoFQgnGoQZADgXKGDQKBKTsSAQEBAQEBAWUnhEIBAQMBIzMjBQsIAxoCBSECAg8BBBkMJBOIEgMKDAGqe4wMIYUDAQEBAQYCAR0ZY4UkhEqEPYMCglYBBI1NijSdF48aJwswg2k6MIgmAQEB X-IronPort-AV: E=Sophos;i="5.24,439,1454972400"; d="scan'208";a="676642276" Received: from c-fa9972d5.04-99-73746f3.cust.bredbandsbolaget.se (HELO goblin) ([213.114.153.250]) by ipb1.telenor.se with ESMTP; 04 Apr 2016 10:53:54 +0200 From: Johan Claesson To: =?utf-8?Q?=C3=93scar?= Fuentes Subject: Re: bug#23164: 25.1.50; xref-find-definitions with local tags-file-name fails References: <87egar3czt.fsf@bredband.net> <87a497cc-15b1-504b-fd4a-8fb3e484e507@yandex.ru> <87zita16ow.fsf@wanadoo.es> Date: Mon, 04 Apr 2016 10:53:41 +0200 In-Reply-To: <87zita16ow.fsf@wanadoo.es> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Mon, 04 Apr 2016 03:52:31 +0200") Message-ID: <87a8l9oiui.fsf@bredband.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23164 Cc: 23164@debbugs.gnu.org, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I can also reproduce it on emacs-25 (commit f501116). With valid TAGS file or /dev/zero. I get the same backtrace. Regards, /Johan =C3=93scar Fuentes writes: > Dmitry Gutov writes: > >> Thanks for the report, but that doesn't seem to be the case here. At >> least if I replace "/dev/zero" with "~/vc/emacs/src/TAGS", the >> scenario doesn't lead to an error (I just get "not found"), and if I >> also use e.g. "CALLN" instead of "foo", the jump to the destination >> occurs as expected. > > I can reproduce it here with an existing TAGS file, on emacs -Q. > > GNU Emacs 25.0.92.3 (x86_64-unknown-linux-gnu, X toolkit) of 2016-04-03 > > at commit fc3cd53900eb5e80b91b6d2615b3800fd2f59c16 > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > expand-file-name(nil) > tags-expand-table-name(nil) > visit-tags-table-buffer(t) > etags--xref-find-definitions("foo") > #[514 "\300!\207" [etags--xref-find-definitions] 4 "\n\n(fn BACKEND SYM= BOL)"](etags "foo") > apply(#[514 "\300!\207" [etags--xref-find-definitions] 4 "\n\n(fn BACKE= ND SYMBOL)"] etags "foo") > xref-backend-definitions(etags "foo") > xref--find-xrefs("foo" definitions "foo" nil) > xref--find-definitions("foo" nil) > xref-find-definitions("foo") > eval((xref-find-definitions "foo") nil) > elisp--eval-last-sexp(nil) > eval-last-sexp(nil) > funcall-interactively(eval-last-sexp nil) > call-interactively(eval-last-sexp nil nil) > command-execute(eval-last-sexp) From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 04 17:14:51 2016 Received: (at 23164) by debbugs.gnu.org; 4 Apr 2016 21:14:51 +0000 Received: from localhost ([127.0.0.1]:51458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anBpi-0005Vc-Rb for submit@debbugs.gnu.org; Mon, 04 Apr 2016 17:14:51 -0400 Received: from smtprelay-h31.telenor.se ([213.150.131.4]:52410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anBpg-0005VL-KV for 23164@debbugs.gnu.org; Mon, 04 Apr 2016 17:14:49 -0400 Received: from ipb2.telenor.se (ipb2.telenor.se [195.54.127.165]) by smtprelay-h31.telenor.se (Postfix) with ESMTP id A66BFD7EB for <23164@debbugs.gnu.org>; Mon, 4 Apr 2016 23:14:42 +0200 (CEST) X-SENDER-IP: [213.114.153.250] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AgCQA42AJXPPqZctVdHAGDGoFQhmq0S4Fyhg0CgTo6EwEBAQEBAQEGAQEBAUJAhEIBAQMBIzMjBQsIAw4MAgUhAgIPAQQZDAoaE4gSAwoMAa0YjE4hhG4BAQEBBgIBHRljhSSESoQ9gwKCVgWNTYo0nRePGiEBhCk6MIgmAQEB X-IPAS-Result: A2AgCQA42AJXPPqZctVdHAGDGoFQhmq0S4Fyhg0CgTo6EwEBAQEBAQEGAQEBAUJAhEIBAQMBIzMjBQsIAw4MAgUhAgIPAQQZDAoaE4gSAwoMAa0YjE4hhG4BAQEBBgIBHRljhSSESoQ9gwKCVgWNTYo0nRePGiEBhCk6MIgmAQEB X-IronPort-AV: E=Sophos;i="5.24,442,1454972400"; d="scan'208";a="526124610" Received: from c-fa9972d5.04-99-73746f3.cust.bredbandsbolaget.se (HELO goblin) ([213.114.153.250]) by ipb2.telenor.se with ESMTP; 04 Apr 2016 23:14:42 +0200 From: Johan Claesson To: Dmitry Gutov Subject: Re: bug#23164: 25.1.50; xref-find-definitions with local tags-file-name fails References: <87egar3czt.fsf@bredband.net> <87a497cc-15b1-504b-fd4a-8fb3e484e507@yandex.ru> <87zita16ow.fsf@wanadoo.es> Date: Mon, 04 Apr 2016 23:14:40 +0200 In-Reply-To: <87zita16ow.fsf@wanadoo.es> (=?utf-8?Q?=22=C3=93scar?= Fuentes"'s message of "Mon, 04 Apr 2016 03:52:31 +0200") Message-ID: <87vb3xm5z3.fsf@bredband.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23164 Cc: =?utf-8?Q?=C3=93scar?= Fuentes , 23164@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi again, I tried again this time with the TAGS of Emacs itself (emacs/src/TAGS). And like you have already established the problem does not occur in this scenario. It does occur with other valid TAGS files, though.=20=20 After a little bit of tracing i think the difference that matters is that emacs/src/TAGS includes two other TAGS file in the very last lines: ../lisp/TAGS,include ../lwlib/TAGS,include I was not aware of this feature with TAGS files including other TAGS files before but after invoking xref-find-definitions emacs is visiting all 3 TAGS files (src/TAGS, lisp/TAGS and lwlib/TAGS). And xref-find-definitions loops through them all. If these last lines in emacs/src/TAGS are deleted the problem occurs. It also occur with other simple TAGS files that do not include other TAGS files. And the TAGS file i was using when observing the problem the first time was this kind of simple TAGS file. Same in master and emacs-25. Regards, /Johan =C3=93scar Fuentes writes: > Dmitry Gutov writes: > >> Thanks for the report, but that doesn't seem to be the case here. At >> least if I replace "/dev/zero" with "~/vc/emacs/src/TAGS", the >> scenario doesn't lead to an error (I just get "not found"), and if I >> also use e.g. "CALLN" instead of "foo", the jump to the destination >> occurs as expected. > > I can reproduce it here with an existing TAGS file, on emacs -Q. > > GNU Emacs 25.0.92.3 (x86_64-unknown-linux-gnu, X toolkit) of 2016-04-03 > > at commit fc3cd53900eb5e80b91b6d2615b3800fd2f59c16 > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > expand-file-name(nil) > tags-expand-table-name(nil) > visit-tags-table-buffer(t) > etags--xref-find-definitions("foo") > #[514 "\300!\207" [etags--xref-find-definitions] 4 "\n\n(fn BACKEND SYM= BOL)"](etags "foo") > apply(#[514 "\300!\207" [etags--xref-find-definitions] 4 "\n\n(fn BACKE= ND SYMBOL)"] etags "foo") > xref-backend-definitions(etags "foo") > xref--find-xrefs("foo" definitions "foo" nil) > xref--find-definitions("foo" nil) > xref-find-definitions("foo") > eval((xref-find-definitions "foo") nil) > elisp--eval-last-sexp(nil) > eval-last-sexp(nil) > funcall-interactively(eval-last-sexp nil) > call-interactively(eval-last-sexp nil nil) > command-execute(eval-last-sexp) From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 04 17:24:25 2016 Received: (at 23164) by debbugs.gnu.org; 4 Apr 2016 21:24:25 +0000 Received: from localhost ([127.0.0.1]:51466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anByz-0005jc-2G for submit@debbugs.gnu.org; Mon, 04 Apr 2016 17:24:25 -0400 Received: from smtprelay-b21.telenor.se ([195.54.99.212]:35956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anByx-0005jP-Qd for 23164@debbugs.gnu.org; Mon, 04 Apr 2016 17:24:24 -0400 Received: from ipb4.telenor.se (ipb4.telenor.se [195.54.127.167]) by smtprelay-b21.telenor.se (Postfix) with ESMTP id 00D41C062 for <23164@debbugs.gnu.org>; Mon, 4 Apr 2016 23:24:15 +0200 (CEST) X-SENDER-IP: [213.114.153.250] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2AfCQB42gJXPPqZctVdHAGDGoFQhmq0S4Fyhg0CgTo6EwEBAQEBAQEGAQEBAUJAhEIBAQQjMyMQCAMODAIFIQICDwEEGQwKGhOIEgMWAa0YjE8hhG4BAQEBBgIBHRljhSSESoQPEQEcgwKCVgWNTYo0nRePGiIBhCg6MIZygTQBAQE X-IPAS-Result: A2AfCQB42gJXPPqZctVdHAGDGoFQhmq0S4Fyhg0CgTo6EwEBAQEBAQEGAQEBAUJAhEIBAQQjMyMQCAMODAIFIQICDwEEGQwKGhOIEgMWAa0YjE8hhG4BAQEBBgIBHRljhSSESoQPEQEcgwKCVgWNTYo0nRePGiIBhCg6MIZygTQBAQE X-IronPort-AV: E=Sophos;i="5.24,442,1454972400"; d="scan'208";a="273318090" Received: from c-fa9972d5.04-99-73746f3.cust.bredbandsbolaget.se (HELO goblin) ([213.114.153.250]) by ipb4.telenor.se with ESMTP; 04 Apr 2016 23:24:15 +0200 From: Johan Claesson To: Dmitry Gutov Subject: Re: bug#23164: 25.1.50; xref-find-definitions with local tags-file-name fails References: <87egar3czt.fsf@bredband.net> <87a497cc-15b1-504b-fd4a-8fb3e484e507@yandex.ru> <87zita16ow.fsf@wanadoo.es> <87vb3xm5z3.fsf@bredband.net> Date: Mon, 04 Apr 2016 23:24:15 +0200 In-Reply-To: <87vb3xm5z3.fsf@bredband.net> (Johan Claesson's message of "Mon, 04 Apr 2016 23:14:40 +0200") Message-ID: <87r3elm5j4.fsf@bredband.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23164 Cc: =?utf-8?Q?=C3=93scar?= Fuentes , 23164@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ooops, i see that the formatting of my last email got messed up because=20 it includes some form-feeds (^L). Here is the same message again without evil form-feeds :) Hi again, I tried again this time with the TAGS of Emacs itself (emacs/src/TAGS). And like you have already established the problem does not occur in this scenario. It does occur with other valid TAGS files, though.=20=20 After a little bit of tracing i think the difference that matters is that emacs/src/TAGS includes two other TAGS file in the very last lines: ^L ../lisp/TAGS,include ^L ../lwlib/TAGS,include I was not aware of this feature with TAGS files including other TAGS files before but after invoking xref-find-definitions emacs is visiting all 3 TAGS files (src/TAGS, lisp/TAGS and lwlib/TAGS). And xref-find-definitions loops through them all. If these last lines in emacs/src/TAGS are deleted the problem occurs. It also occur with other simple TAGS files that do not include other TAGS files. And the TAGS file i was using when observing the problem the first time was this kind of simple TAGS file. Same in master and emacs-25. Regards, /Johan > =C3=93scar Fuentes writes: > >> Dmitry Gutov writes: >> >>> Thanks for the report, but that doesn't seem to be the case here. At >>> least if I replace "/dev/zero" with "~/vc/emacs/src/TAGS", the >>> scenario doesn't lead to an error (I just get "not found"), and if I >>> also use e.g. "CALLN" instead of "foo", the jump to the destination >>> occurs as expected. >> >> I can reproduce it here with an existing TAGS file, on emacs -Q. >> >> GNU Emacs 25.0.92.3 (x86_64-unknown-linux-gnu, X toolkit) of 2016-04-03 >> >> at commit fc3cd53900eb5e80b91b6d2615b3800fd2f59c16 >> >> Debugger entered--Lisp error: (wrong-type-argument stringp nil) >> expand-file-name(nil) >> tags-expand-table-name(nil) >> visit-tags-table-buffer(t) >> etags--xref-find-definitions("foo") >> #[514 "\300!\207" [etags--xref-find-definitions] 4 "\n\n(fn BACKEND SY= MBOL)"](etags "foo") >> apply(#[514 "\300!\207" [etags--xref-find-definitions] 4 "\n\n(fn BACK= END SYMBOL)"] etags "foo") >> xref-backend-definitions(etags "foo") >> xref--find-xrefs("foo" definitions "foo" nil) >> xref--find-definitions("foo" nil) >> xref-find-definitions("foo") >> eval((xref-find-definitions "foo") nil) >> elisp--eval-last-sexp(nil) >> eval-last-sexp(nil) >> funcall-interactively(eval-last-sexp nil) >> call-interactively(eval-last-sexp nil nil) >> command-execute(eval-last-sexp) From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 06 23:15:28 2016 Received: (at 23164) by debbugs.gnu.org; 7 Apr 2016 03:15:28 +0000 Received: from localhost ([127.0.0.1]:52309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ao0Po-00050d-9l for submit@debbugs.gnu.org; Wed, 06 Apr 2016 23:15:28 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:34328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ao0Pn-00050R-Dg for 23164@debbugs.gnu.org; Wed, 06 Apr 2016 23:15:27 -0400 Received: by mail-wm0-f47.google.com with SMTP id l6so7015715wml.1 for <23164@debbugs.gnu.org>; Wed, 06 Apr 2016 20:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=te0pE4n1yda1Ybw5mydr5CvFJk6l/0QyABWb6g/1eNc=; b=CX8Nfaj4u+jUnZfDHhAUGFQZAEmKlMiFVgbl0sPXZWspkseoJU9P9Zx1edhuftS80I 2BdmT0H1m7c9wodJK54KCrm5neteKy0n33u9A6zrnUpzNhx0MCh6j0aC8/2EBmnlR2m6 0GN1D1KepefJy3BO5eL4gDn+Vovq+U1k4HncTUoBxUcHgVwN6Sw4A2PwVHKoJrUNDtS5 FGnHnWD28Jy/hNC4JWT3GwtAa7UtFkXkt01gUpTSSq2coNzS6gUKJqiteFaIAenerZ/j Dt4SZ1I6HfgULYNJGliz3D8GSiIgVq6GXdGufpoWmAemPS6IOraKJ6sjUVAWAyrUD4/Q b3ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=te0pE4n1yda1Ybw5mydr5CvFJk6l/0QyABWb6g/1eNc=; b=jE0ujLl6jc+A67yIKrVctnG0hMzrHNpJS8fWEdeMFO8o5UhVMi9eNsaY8R5PMyVeoZ vh8REJ7BqaFasAT3YzSN6fIiumF+qLRQK55gyjdhv58lyZPtUlZubjWwglog4KqH6Lys 5mordSroY/A8GzuZMnKE6qpdIK64VW9afgTRfFEZND3ufpb2pHxQYocCThg5O/56jnNf sr77zRVN2xyBlIxv2A2X/mWA2kx6PtQT9HsmC2IqUrJt2+B4jnWS+wcpmWaZosRKfaTQ u56pRiKLQQ3n0SciZ2A9U0WqNwexSMevzM/pIsG4tj20OFYqWOYse+ygcmQXQdjUmk0g P6FA== X-Gm-Message-State: AD7BkJKDZFScIvmTDbksDzHfivlUjmkE7JP78FeSGFQXaxubQjEKJ2+Nr+B4Nx/X2PRWWQ== X-Received: by 10.194.111.229 with SMTP id il5mr775224wjb.82.1459998921777; Wed, 06 Apr 2016 20:15:21 -0700 (PDT) Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id p189sm27940165wmb.7.2016.04.06.20.15.20 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 06 Apr 2016 20:15:21 -0700 (PDT) Subject: Re: bug#23164: 25.1.50; xref-find-definitions with local tags-file-name fails To: Johan Claesson References: <87egar3czt.fsf@bredband.net> <87a497cc-15b1-504b-fd4a-8fb3e484e507@yandex.ru> <87zita16ow.fsf@wanadoo.es> <87vb3xm5z3.fsf@bredband.net> <87r3elm5j4.fsf@bredband.net> From: Dmitry Gutov Message-ID: <0cbc0981-a763-39f4-89da-ea955cae3a71@yandex.ru> Date: Thu, 7 Apr 2016 06:15:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <87r3elm5j4.fsf@bredband.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23164 Cc: =?UTF-8?Q?=c3=93scar_Fuentes?= , 23164@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 04/05/2016 12:24 AM, Johan Claesson wrote: > It also occur with other simple TAGS files that do not include other > TAGS files. And the TAGS file i was using when observing the problem > the first time was this kind of simple TAGS file. Right, thank you. Apparently, the long-standing way to make it work is to call visit-tags-table with non-nil second argument, instead of just using setq-local. So, this seems to work correctly: (fundamental-mode) (visit-tags-table "~/examples/ruby/TAGS" t) (xref-find-definitions "a") It performs more work in advance, though, and I'm not sure what's the big picture with keeping variables like tags-table-list global anyway. Here's a patch you can try that makes etags--xref-find-definitions work with your original scenario, but I'm not 100% sure it's good code. The proper solution to setting tags-file-name locally probably looks different. diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el index a2a0df2..856d26b 100644 --- a/lisp/progmodes/etags.el +++ b/lisp/progmodes/etags.el @@ -2111,6 +2111,7 @@ etags--xref-find-definitions tags-case-fold-search case-fold-search))) (save-excursion + (visit-tags-table-buffer) ; Workaround for bug#23164 (while (visit-tags-table-buffer (not first-time)) (setq first-time nil) (dolist (order-fun (cond (regexp? find-tag-regexp-tag-order) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 09 11:00:37 2016 Received: (at 23164) by debbugs.gnu.org; 9 Apr 2016 15:00:37 +0000 Received: from localhost ([127.0.0.1]:56200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aouNJ-0007r9-9d for submit@debbugs.gnu.org; Sat, 09 Apr 2016 11:00:37 -0400 Received: from smtprelay-b32.telenor.se ([213.150.131.21]:33305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aouNH-0007qu-4L for 23164@debbugs.gnu.org; Sat, 09 Apr 2016 11:00:35 -0400 Received: from ipb2.telenor.se (ipb2.telenor.se [195.54.127.165]) by smtprelay-b32.telenor.se (Postfix) with ESMTP id DE621865B5 for <23164@debbugs.gnu.org>; Sat, 9 Apr 2016 17:00:26 +0200 (CEST) X-SENDER-IP: [213.114.153.250] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CcEwCbFwlXPPqZctVdGgEBAYMagVCCcoN5tWqGDQKBKT0QAQEBAQEBAQYBAQEBQkCEQgEBAwFWIwULCAMOEyUPAQQZDAoaExuHdwMKDAG6IQEBAQEBBQIBHRmGCIRLihUBBI1OijaPXY08jyY3hBQ6MIksAQEB X-IPAS-Result: A2CcEwCbFwlXPPqZctVdGgEBAYMagVCCcoN5tWqGDQKBKT0QAQEBAQEBAQYBAQEBQkCEQgEBAwFWIwULCAMOEyUPAQQZDAoaExuHdwMKDAG6IQEBAQEBBQIBHRmGCIRLihUBBI1OijaPXY08jyY3hBQ6MIksAQEB X-IronPort-AV: E=Sophos;i="5.24,454,1454972400"; d="scan'208";a="534204721" Received: from c-fa9972d5.04-99-73746f3.cust.bredbandsbolaget.se (HELO goblin) ([213.114.153.250]) by ipb2.telenor.se with ESMTP; 09 Apr 2016 17:00:26 +0200 From: Johan Claesson To: Dmitry Gutov Subject: Re: bug#23164: 25.1.50; xref-find-definitions with local tags-file-name fails References: <87egar3czt.fsf@bredband.net> <87a497cc-15b1-504b-fd4a-8fb3e484e507@yandex.ru> <87zita16ow.fsf@wanadoo.es> <87vb3xm5z3.fsf@bredband.net> <87r3elm5j4.fsf@bredband.net> <0cbc0981-a763-39f4-89da-ea955cae3a71@yandex.ru> Date: Sat, 09 Apr 2016 17:00:26 +0200 In-Reply-To: <0cbc0981-a763-39f4-89da-ea955cae3a71@yandex.ru> (Dmitry Gutov's message of "Thu, 7 Apr 2016 06:15:19 +0300") Message-ID: <87k2k625f9.fsf@bredband.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23164 Cc: =?utf-8?Q?=C3=93scar?= Fuentes , 23164@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > > (fundamental-mode) > (visit-tags-table "~/examples/ruby/TAGS" t) > (xref-find-definitions "a") This does not work for me. I run into the same error. > Here's a patch you can try that makes etags--xref-find-definitions > work with your original scenario, but I'm not 100% sure it's good > code. The proper solution to setting tags-file-name locally probably > looks different. Thanks, this patch works perfectly as far as i can see. Regards, /Johan From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 22 13:50:37 2016 Received: (at 23164) by debbugs.gnu.org; 22 Nov 2016 18:50:37 +0000 Received: from localhost ([127.0.0.1]:38589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9G9N-0006Uc-FP for submit@debbugs.gnu.org; Tue, 22 Nov 2016 13:50:37 -0500 Received: from mail-pg0-f42.google.com ([74.125.83.42]:35708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c9G9L-0006UN-Tz for 23164@debbugs.gnu.org; Tue, 22 Nov 2016 13:50:36 -0500 Received: by mail-pg0-f42.google.com with SMTP id p66so10246684pga.2 for <23164@debbugs.gnu.org>; Tue, 22 Nov 2016 10:50:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=user-agent:from:to:cc:subject:date:message-id:mime-version; bh=hUyydM9HWlKythhOXmjZTbgg+aij2EdFkgRFfzvtdSw=; b=H/TF5gxxSh/Ld8DUkh8uAYu/2kQM6UXjds1uWbN6zffyZOjwnxptul9nX+/JsYXR2Y MR6U7iPg9vAG63jysF1y39SIW29pTnt0LX4krf5o3ZDRf8MN4R4VexDGoznlH9WxzhLP V0gjwGocwdah6VvYRiqMssxVp1eKZR5gVajD6viIjwWkRkWsfKonSQTx4NfFFYZhnWTp HMuSHtbvT6xx8BNJAvkaL94i7KjJmZJfP1iauqf95KHeMCwtnsU9ZQDn1+rjCJ8mHArx OTk6vtyNPzLOkJEBBAeQ67FYbummgiXyPYd/PzIokpXx5aAHI3HwTzzKBRg+3gVE5J+e GLvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:user-agent:from:to:cc:subject:date:message-id :mime-version; bh=hUyydM9HWlKythhOXmjZTbgg+aij2EdFkgRFfzvtdSw=; b=SozGxWch/W7cnjqAAdmT7POVVhFuI0Wk0lhP6Xetr4bfp4hriZ/vj5h5rP0bRFgLF4 2pz1p6EMZ9SawlGLqQRCdvjhlp++b8nio7fLXV1EVz/TVsP3Z/JUG1L0OolQWcGPzNcC 5Bach3Y5q/HWiWkdJ8rZilWTbQdBlvAItkeyvBMzB9yiLXQqK1Cut4sfjUnYQphFGCft 3EeDCNnz1XWzz9NUznjmoV51ctW67sNbDbA5rrmhXxFk1ys57K8FACEXLMwqtWyBUQV2 4aLDSRdPjr6B7EQvuFhwITFen+NOpY2wmz2r6I682+KL52QL2hOdWARCqI5p6T056My8 w1Iw== X-Gm-Message-State: AKaTC02ZGAvIG8Ltwj1WLNzobTy7d/wNBogWIOgWI2f5KsnRDfusmou4gm6eaDrrmQ8WRw== X-Received: by 10.84.170.195 with SMTP id j61mr2520358plb.13.1479840630224; Tue, 22 Nov 2016 10:50:30 -0800 (PST) Received: from localhost (dhcp-22-75.ucolick.org. [128.114.22.75]) by smtp.gmail.com with ESMTPSA id 65sm46202555pfl.21.2016.11.22.10.50.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Nov 2016 10:50:29 -0800 (PST) User-agent: mu4e 0.9.17; emacs 25.1.1 From: Josiah Schwab To: 23164@debbugs.gnu.org Subject: Re: bug#23164: 25.1.50; xref-find-definitions with local tags-file-name fails Date: Tue, 22 Nov 2016 10:49:19 -0800 Message-ID: <871sy35p00.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23164 Cc: ofv@wanadoo.es, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello, I receive an error from commands like the original bug > (setq-local tags-file-name "fruits/TAGS") > (xref-find-definitions "apple") and the proposed workaround > (visit-tags-table "fruits/TAGS" t) > (xref-find-definitions "apple") under emacs 25.1 and git master (at c542fab). I used a trivial TAGS file, available from https://github.com/jschwab/emacs-tags-issues/blob/master/fruits/TAGS but any simple tags file (that doesn't include other TAGS files; see earlier in this thread) ought to work. Josiah From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 11:54:08 2016 Received: (at control) by debbugs.gnu.org; 1 Dec 2016 16:54:08 +0000 Received: from localhost ([127.0.0.1]:48924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCUca-0003DU-4e for submit@debbugs.gnu.org; Thu, 01 Dec 2016 11:54:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cCUcZ-0003DH-9W for control@debbugs.gnu.org; Thu, 01 Dec 2016 11:54:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cCUcQ-0001DF-47 for control@debbugs.gnu.org; Thu, 01 Dec 2016 11:54:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51879) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cCUcQ-0001DA-0v; Thu, 01 Dec 2016 11:53:58 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3783 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cCUcN-0005ub-4r; Thu, 01 Dec 2016 11:53:57 -0500 Date: Thu, 01 Dec 2016 18:53:48 +0200 Message-Id: <83fum7pp43.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Wed, 30 Nov 2016 03:12:20 +0200) Subject: Re: Bugs related to buffer-local tags-file-name References: <87zikr4a8y.fsf@gmail.com> <3f470a39-6bd4-bbb4-c693-ef889118fdf2@yandex.ru> <87wpfv3qrm.fsf@gmail.com> <838ts86atl.fsf@gnu.org> <83r3603t7o.fsf@gnu.org> <83twau1n0u.fsf@gnu.org> <87poli3ztj.fsf@gmail.com> <83polexkop.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.9 (-------) X-Debbugs-Envelope-To: control Cc: jschwab@gmail.com, emacs-devel@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.9 (-------) close 158 close 17326 close 23164 close 19741 thanks > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > Date: Wed, 30 Nov 2016 03:12:20 +0200 > > On 29.11.2016 19:25, Eli Zaretskii wrote: > > > Dmitry, should I wait for your testing as well, or should I just push > > the changes? > > Yes, sorry. I think you should go ahead with them, maybe with some minor > tweaks. Done. > - In visit-tags-table-buffer's docstring, "optional arg CONT" should > probably be just "CONT", all three times. Fixed. > - More importantly, this patch contains a backward-incompatible change > to the tags-completion-table function. Maybe we should consider how to > make BUF an optional argument. It is optional now. > - It would be great if let-binding tags-table-list around > tags-lazy-completion-table didn't leak it to the global value either > (which happens with company-etags). Alas, this seems to be a harder task. Right, patches welcome. From unknown Wed Jun 18 00:28:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 30 Dec 2016 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator