GNU bug report logs - #23146
grep 2.24: tests broken with --program-prefix

Previous Next

Package: grep;

Reported by: Christian Weisgerber <naddy <at> mips.inka.de>

Date: Tue, 29 Mar 2016 14:21:02 UTC

Severity: normal

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23146 in the body.
You can then email your comments to 23146 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-grep <at> gnu.org:
bug#23146; Package grep. (Tue, 29 Mar 2016 14:21:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Christian Weisgerber <naddy <at> mips.inka.de>:
New bug report received and forwarded. Copy sent to bug-grep <at> gnu.org. (Tue, 29 Mar 2016 14:21:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christian Weisgerber <naddy <at> mips.inka.de>
To: bug-grep <at> gnu.org
Subject: grep 2.24: tests broken with --program-prefix
Date: Mon, 28 Mar 2016 23:21:32 +0200
In GNU grep 2.24 and earlier, the regression tests

  help-version
  reversed-range-endpoints

fail if grep is built with a program prefix (I use --program-prefix=g).

---------- help-version.log ----------
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
FAIL: egrep
/usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
FAIL: fgrep
FAIL help-version (exit status: 1)

---------- reversed-range-endpoints.log ----------
--- exp	Mon Mar 28 22:46:48 2016
+++ out	Mon Mar 28 22:46:48 2016
@@ -1 +1 @@
-Invalid range end
+/usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
FAIL reversed-range-endpoints (exit status: 1)

-- 
Christian "naddy" Weisgerber                          naddy <at> mips.inka.de




Reply sent to Jim Meyering <jim <at> meyering.net>:
You have taken responsibility. (Tue, 29 Mar 2016 17:26:02 GMT) Full text and rfc822 format available.

Notification sent to Christian Weisgerber <naddy <at> mips.inka.de>:
bug acknowledged by developer. (Tue, 29 Mar 2016 17:26:02 GMT) Full text and rfc822 format available.

Message #10 received at 23146-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Christian Weisgerber <naddy <at> mips.inka.de>
Cc: 23146-done <at> debbugs.gnu.org
Subject: Re: bug#23146: grep 2.24: tests broken with --program-prefix
Date: Tue, 29 Mar 2016 10:25:13 -0700
On Mon, Mar 28, 2016 at 2:21 PM, Christian Weisgerber
<naddy <at> mips.inka.de> wrote:
> In GNU grep 2.24 and earlier, the regression tests
>
>   help-version
>   reversed-range-endpoints
>
> fail if grep is built with a program prefix (I use --program-prefix=g).
>
> ---------- help-version.log ----------
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
> FAIL: egrep
> /usr/obj/ggrep-2.24/grep-2.24/tests/../src/fgrep[2]: ggrep: not found
> FAIL: fgrep
> FAIL help-version (exit status: 1)
>
> ---------- reversed-range-endpoints.log ----------
> --- exp Mon Mar 28 22:46:48 2016
> +++ out Mon Mar 28 22:46:48 2016
> @@ -1 +1 @@
> -Invalid range end
> +/usr/obj/ggrep-2.24/grep-2.24/tests/../src/egrep[2]: ggrep: not found
> FAIL reversed-range-endpoints (exit status: 1)

Thanks for the report.
You should be able to cause "make check" to pass in that case
by creating a symlink for each classic name to its prefixed version, e.g.,

  cd src && for i in grep egrep fgrep; do ln -fs g$i $i; done

You're the first to report this, so for now, I'll simply mark this
issue as closed.
By the way, that reversed-range-endpoints test need not use egrep,
since it already tests 'grep -E', so I have fixed that.




Information forwarded to bug-grep <at> gnu.org:
bug#23146; Package grep. (Sun, 03 Apr 2016 08:03:02 GMT) Full text and rfc822 format available.

Message #13 received at 23146-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Christian Weisgerber <naddy <at> mips.inka.de>, 23146-done <at> debbugs.gnu.org
Subject: Re: bug#23146: grep 2.24: tests broken with --program-prefix
Date: Sun, 3 Apr 2016 01:01:55 -0700
[Message part 1 (text/plain, inline)]
Christian Weisgerber wrote:
> In GNU grep 2.24 and earlier, the regression tests
>
>    help-version
>    reversed-range-endpoints
>
> fail if grep is built with a program prefix (I use --program-prefix=g).

Jim fixed the second problem, and the attached patch should fix the first one, 
so I'll mark this bug as done. Thanks for reporting it.

[0001-tests-test-egrep-fgrep-help-only-if-our-grep.patch (text/x-diff, attachment)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 01 May 2016 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 9 years and 107 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.