GNU bug report logs - #23139
[PATCH] test/automated/abbrev-tests.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23139 in the body.
You can then email your comments to 23139 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lee B <lboc.home <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] test/automated/abbrev-tests.el
Date: Tue, 29 Mar 2016 13:04:40 +0900

[Message part 1 (text/plain, inline)]

Hello,

Attached is a patch for the emacs-25 branch
test/automated/abbrev-tests.el. It comprises a couple of tests copied
from the master branch, minor modifications and a bunch of new tests.

In the abbrev-table-p-test, I've commented out a check that works in
master but not in emacs-25 (and vice-versa) - pointers on how to fix
this would be greatly appreciated. Any other hints and advice also
welcome :-)

Thanks,

Lee.

[0001-Copy-tests-from-master-modify-test-add-tests.patch (text/plain, attachment)]

Message #8 received at 23139 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Lee B <lboc.home <at> gmail.com>
Cc: 23139 <at> debbugs.gnu.org
Subject: Re: bug#23139: [PATCH] test/automated/abbrev-tests.el
Date: Sun, 24 Apr 2016 17:01:30 +0200

Lee B <lboc.home <at> gmail.com> writes:

> Attached is a patch for the emacs-25 branch
> test/automated/abbrev-tests.el. It comprises a couple of tests copied
> from the master branch, minor modifications and a bunch of new tests.

Wouldn't it make more sense to just add these new tests to the master
branch?  Adding new tests to the emacs-25 branch at this point
(especially when they are incompatible with master) doesn't seem all
that vital...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 23139 <at> debbugs.gnu.org (full text, mbox):

From: Lee B <lboc.home <at> gmail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 23139 <at> debbugs.gnu.org
Subject: Re: bug#23139: [PATCH] test/automated/abbrev-tests.el
Date: Mon, 25 Apr 2016 09:50:41 +0900

On Sun, Apr 24 2016, Lars Magne Ingebrigtsen wrote:

> Lee B <lboc.home <at> gmail.com> writes:
>
>> Attached is a patch for the emacs-25 branch
>> test/automated/abbrev-tests.el. It comprises a couple of tests copied
>> from the master branch, minor modifications and a bunch of new tests.
>
> Wouldn't it make more sense to just add these new tests to the master
> branch?  Adding new tests to the emacs-25 branch at this point
> (especially when they are incompatible with master) doesn't seem all
> that vital...

Sure, if you think that's the better way. I only patched against
emacs-25 as that's where I'd had some previous patches to this file
applied.

Shall I generate a patch against master and update this bug?

Lee.

Message #14 received at 23139 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Lee B <lboc.home <at> gmail.com>
Cc: 23139 <at> debbugs.gnu.org
Subject: Re: bug#23139: [PATCH] test/automated/abbrev-tests.el
Date: Tue, 26 Apr 2016 01:09:26 +0200

Lee B <lboc.home <at> gmail.com> writes:

> Sure, if you think that's the better way. I only patched against
> emacs-25 as that's where I'd had some previous patches to this file
> applied.
>
> Shall I generate a patch against master and update this bug?

Yes, please do.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 23139 <at> debbugs.gnu.org (full text, mbox):

From: Lee B <lboc.home <at> gmail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 23139 <at> debbugs.gnu.org
Subject: Re: bug#23139: [PATCH] test/automated/abbrev-tests.el
Date: Tue, 26 Apr 2016 14:51:18 +0900

[Message part 1 (text/plain, inline)]

On 月,  4 25 2016, Lars Magne Ingebrigtsen wrote:

> Lee B <lboc.home <at> gmail.com> writes:
>
>> Sure, if you think that's the better way. I only patched against
>> emacs-25 as that's where I'd had some previous patches to this file
>> applied.
>>
>> Shall I generate a patch against master and update this bug?
>
> Yes, please do.

OK, patch against master attached. Contrary to the bug title, the file
is now test/lisp/abbrev-tests.el of course.

Lee.

[0001-Modify-add-abbrev-tests.patch (text/plain, attachment)]

Message #20 received at 23139 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Lee B <lboc.home <at> gmail.com>
Cc: 23139 <at> debbugs.gnu.org
Subject: Re: bug#23139: [PATCH] test/automated/abbrev-tests.el
Date: Tue, 03 May 2016 00:13:15 +0200

Lee B <lboc.home <at> gmail.com> writes:

> OK, patch against master attached. Contrary to the bug title, the file
> is now test/lisp/abbrev-tests.el of course.

Thanks; applied to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.