GNU bug report logs - #23135
[PATCH] Support completion of bang-rules in CSS mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23135 in the body.
You can then email your comments to 23135 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: [PATCH] Support completion of bang-rules in CSS mode
Date: Mon, 28 Mar 2016 14:52:53 +0200

[Message part 1 (text/plain, inline)]

The attached patch adds support for completing bang-rules (rules that
start with "!") in CSS and SCSS mode.

-- Simen

[Message part 2 (text/html, inline)]

[0001-Support-completion-of-bang-rules-in-CSS-mode.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: [PATCH] Support completion of bang-rules in CSS mode
Date: Mon, 28 Mar 2016 11:16:01 -0400

> The attached patch adds support for completing bang-rules (rules that
> start with "!") in CSS and SCSS mode.

Looks fine, thanks.

> +        (list (point) pos (append (if sassy scss-bang-ids)
> +                                  css-bang-ids))))))

This duplicates code that's already elsewhere.  Maybe we should have
a new buffer-local var to keep the (s)css-bang-ids value appropriate for
the current mode.


        Stefan

Message #11 received at 23135 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 23135 <at> debbugs.gnu.org
Subject: Re: bug#23135: [PATCH] Support completion of bang-rules in CSS mode
Date: Wed, 30 Mar 2016 18:33:33 +0200

[Message part 1 (text/plain, inline)]

On Mon, Mar 28, 2016 at 5:16 PM, Stefan Monnier 
<monnier <at> IRO.UMontreal.CA> wrote:
>>  +        (list (point) pos (append (if sassy scss-bang-ids)
>>  +                                  css-bang-ids))))))
> 
> This duplicates code that's already elsewhere.  Maybe we should have
> a new buffer-local var to keep the (s)css-bang-ids value appropriate 
> for
> the current mode.

Something like this?

-- Simen

[Message part 2 (text/html, inline)]

[0001-Support-completion-of-bang-rules-in-CSS-mode.patch (text/x-patch, attachment)]

Message #14 received at 23135 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: 23135 <at> debbugs.gnu.org
Subject: Re: bug#23135: [PATCH] Support completion of bang-rules in CSS mode
Date: Wed, 30 Mar 2016 17:06:42 -0400

> Something like this?

Looks good to me,


        Stefan

Message #19 received at 23135-done <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: 23135-done <at> debbugs.gnu.org
Subject: Re: bug#23135: [PATCH] Support completion of bang-rules in CSS mode
Date: Thu, 31 Mar 2016 21:23:37 +0200

[Message part 1 (text/plain, inline)]

Installed in master.

-- Simen

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.