GNU bug report logs - #23094
icecat is missing a desktop file

Previous Next

Full log

Message #25 received at 23094 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 23094 <at> debbugs.gnu.org
Subject: Re: bug#23094: [PATCHv2] Re: bug#23094: icecat is missing a desktop
 file
Date: Tue, 31 May 2016 15:47:35 +0200

[Message part 1 (text/plain, inline)]

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> On Sat, 28 May 2016 17:22:41 +0200
> ludo <at> gnu.org (Ludovic Courtès) wrote:
>
>> I figured there’s already a desktop entry template in the source, and
>> it’s more complete (it includes translations), hence this patch:
>
> I tried your patch and I get:

Oops, my bad.

I tested the attached one.  It works as expected, but there remain
“%%ifdef” things in it (see attached file), and I’m guessing GNOME &
co. will barf upon them, though I don’t know how to test.

Thoughts?

Thanks,
Ludo’.

[icecat.desktop (application/octet-stream, attachment)]

[Message part 3 (text/x-patch, inline)]

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 7e52534..264a754 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -509,7 +509,24 @@ standards.")
               (format #t "configure flags: ~s~%" flags)
               (zero? (apply system* bash
                             (string-append srcdir "/configure")
-                            flags))))))))
+                            flags)))))
+         (add-before 'configure 'install-desktop-entry
+           (lambda* (#:key outputs #:allow-other-keys)
+             ;; Install the '.desktop' file.
+             (let* ((out (assoc-ref outputs "out"))
+                    (applications (string-append out "/share/applications")))
+               (mkdir-p applications)
+               (copy-file "debian/icecat.desktop.in"
+                          "debian/icecat.desktop")
+               (substitute* "debian/icecat.desktop"
+                 (("@MOZ_DISPLAY_NAME@")
+                  "GNU IceCat")
+                 (("^Exec=@MOZ_APP_NAME@")
+                  (string-append "Exec=" out "/bin/icecat"))
+                 (("@MOZ_APP_NAME@")
+                  "icecat"))
+               (install-file "debian/icecat.desktop" applications)
+               #t))))))
     (home-page "http://www.gnu.org/software/gnuzilla/")
     (synopsis "Entirely free browser derived from Mozilla Firefox")
     (description

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.