GNU bug report logs - #23092
25.0.92; Minibuffer completion fails to resize completion window if reused during same command

Previous Next

Full log

Message #58 received at 23092-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: "N. Jackson" <nljlistbox2 <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 23092-done <at> debbugs.gnu.org
Subject: Re: bug#23092: 25.0.92;
 Minibuffer completion fails to resize completion window if reused
 during same command
Date: Fri, 25 Mar 2016 00:14:41 +0200

>> However, after I looked at this again now, it looks natural to just
>> replace ‘shrink-window-if-larger-than-buffer’ with ‘fit-window-to-buffer’.
>> But I'd leave it to you to decide how good this change is and what
>> consequences it might entail.
>
> It should have two consequences: (1) When there are many completions,
> the *Completions* window might be larger initially.

This doesn't look like a bad consequence since more currently active data
on screen is better.

> (2) The *Completions* window will mostly behave as if ‘temp-buffer-resize-mode’
> were enabled by default.  I think the OP's scenario is much more
> embarrassing so I think we can live with the consequences of your fix.
>
> Please install it and I'll fix the manual accordingly.

Fixed minibuffer-completion-help now.

> Thanks, martin
>
>> diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
>> index ecac0ae..6540059 100644
>> --- a/lisp/minibuffer.el
>> +++ b/lisp/minibuffer.el
>> @@ -1835,7 +1835,7 @@ minibuffer-completion-help
>>                   'display-buffer-below-selected))
>>   	    ,(if temp-buffer-resize-mode
>>   		 '(window-height . resize-temp-buffer-window)
>> -	       '(window-height . shrink-window-if-larger-than-buffer))
>> +	       '(window-height . fit-window-to-buffer))
>>   	    ,(when temp-buffer-resize-mode
>>   	       '(preserve-size . (nil . t))))
>>             nil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.