From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 16 12:14:09 2016 Received: (at submit) by debbugs.gnu.org; 16 Mar 2016 16:14:09 +0000 Received: from localhost ([127.0.0.1]:50365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agE5J-0002n9-CC for submit@debbugs.gnu.org; Wed, 16 Mar 2016 12:14:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agE5H-0002mv-Ei for submit@debbugs.gnu.org; Wed, 16 Mar 2016 12:14:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agE5B-0006Ka-1f for submit@debbugs.gnu.org; Wed, 16 Mar 2016 12:14:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agE5A-0006KW-UL for submit@debbugs.gnu.org; Wed, 16 Mar 2016 12:14:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agE59-0000Mz-Ro for bug-grep@gnu.org; Wed, 16 Mar 2016 12:14:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agE56-0006Jn-Hp for bug-grep@gnu.org; Wed, 16 Mar 2016 12:13:59 -0400 Received: from mail-qk0-x22f.google.com ([2607:f8b0:400d:c09::22f]:33644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agE56-0006Jg-BK for bug-grep@gnu.org; Wed, 16 Mar 2016 12:13:56 -0400 Received: by mail-qk0-x22f.google.com with SMTP id s5so22925673qkd.0 for ; Wed, 16 Mar 2016 09:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=to:from:subject:message-id:date:user-agent:mime-version; bh=VVPtrYEsSzPrkyAvIlzILilmN+K+FsD7u+X06seaqWU=; b=ypHQswL4JZeYDMiUja5ztdHv4U0yCck6jZfNBBmorYr9t2oAPebFvt8Kqpm+z4D/yU DXGQQOb2oxUwPuxDNQS7H5rs9nhuXdxsJuSfF7o7+Ah1X1S6y2lV0IkOXQwfJP8I8ZeH bQF2zy5uk6Y8XuyBikpUSMyFhjNDFxFkfEWfZobt3RCzUSOSn/hSkKlStfRNx0Xl6Qe1 M56bI3qlTn4a1U2dgKahIfCwtGsXw0ERrsbapsGM06mkdc4yxjWh58B3DX/LgttfHmXK 37+zSHyjAnvV1PkrDClpCEmx5lCHOdyda1mIFrVScR6Hkdwi9iiCqItHUzbHjgcpyifz coeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version; bh=VVPtrYEsSzPrkyAvIlzILilmN+K+FsD7u+X06seaqWU=; b=LKUmwynvf1ufv2TKIytSz98ddJq2W9SC8zvEk5jFM1ICeWqg4nQUN1faI/EVIM02h1 fq7Jc3tqa5Xe4j0Q4rDDz/Er+zTc7O6Z7d890Y6tA9QrzDyRfPBDrjaIVg3RSrqAm0Na INIG03VP4x3QPSOliQEwy6IslnnSTgfubSyDo77Tq9nlC+hHxt0Ew4oQ7VaaeWIhefj/ Y9Bnw0k/ASenw0dHQyureRCeHFULoqjS1AdfwtJJzIx1dKQzEDt7+AI4m5PFZbqURJCi 3HC8AuOcemARO3Yfai3xaa+IdRcnAR22w96jp3ew0M2u4QxXnyIr+xv1i9dFZ2S5SZ6o Ka1w== X-Gm-Message-State: AD7BkJKDFE6PQbzDhzjNzz2dbsPQpl3ZG8kB+3arKGcrB1YKBsoRj2aOdK9f5IUxqj/cxQ== X-Received: by 10.55.217.17 with SMTP id u17mr6516010qki.108.1458144835713; Wed, 16 Mar 2016 09:13:55 -0700 (PDT) Received: from disco.erlich.nygenome.org ([69.74.14.178]) by smtp.googlemail.com with ESMTPSA id y200sm1750836qka.48.2016.03.16.09.13.54 for (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 Mar 2016 09:13:54 -0700 (PDT) To: bug-grep@gnu.org From: Assaf Gordon Subject: reporting write errors and handling SIGPIPE Message-ID: <56E98668.5050500@gmail.com> Date: Wed, 16 Mar 2016 12:14:32 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070500030303030705030408" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is a multi-part message in MIME format. --------------070500030303030705030408 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello, First, Attached is a patch that adds errno information to 'write error' messages, e.g.: $ grep [...] > /dev/full grep: write error: No space left on device I hope it is self-explanatory enough (comments and suggestions are welcomed). Second, On one gnu/linux server I'm experiencing a strange behavior (or at least, not understandable to me): grep does not immediately terminates on SIGPIPE, and instead exits and prints "write error" (for EPIPE). which is partially why I wrote the above patch, to try understand what's going on. An example, reproducible on my machine (running on real hardware), though hard to reproduce inside a VM and on other servers: seq 100000 > in for i in $(seq 100) ; do ./src/grep -s --line-buffered -v '^$' < in | head -n1 > /dev/null ; done for some of the runs (out of 100) I get an error "./src/grep: write error: Broken pipe" . attached are strace/ltrace logs of such cases. the key lines: When grep is killed by SIGPIPE: == strace == write(1, "1\n", 2) = 2 write(1, "2\n", 2) = -1 EPIPE (Broken pipe) --- SIGPIPE {si_signo=SIGPIPE, si_code=SI_USER, si_pid=2960, si_uid=1004} --- +++ killed by SIGPIPE +++ == ltrace == fwrite_unlocked("1\n2\n3\n4\n5\n6\n7\n8\n9\n10\n11\n12\n13\n14"..., 1, 2, 0x7efc5dab9400) = 2 __errno_location() = 0x7efc5dee46a0 fflush_unlocked(0x7efc5dab9400, 0x18da000, 10, 4096) = 0 memchr("2\n3\n4\n5\n6\n7\n8\n9\n10\n11\n12\n13\n14\n1"..., '\n', 32766) = 0x18da003 fwrite_unlocked("2\n3\n4\n5\n6\n7\n8\n9\n10\n11\n12\n13\n14\n1"..., 1, 2, 0x7efc5dab9400) = 2 __errno_location() = 0x7efc5dee46a0 fflush_unlocked(0x7efc5dab9400, 0x18da004, 0, 2610 --- SIGPIPE (Broken pipe) --- +++ killed by SIGPIPE +++ When grep is not killed by SIGPIPE: == strace == write(1, "1\n", 2) = 2 write(1, "2\n", 2) = -1 EPIPE (Broken pipe) --- SIGPIPE {si_signo=SIGPIPE, si_code=SI_USER, si_pid=2893, si_uid=1004} --- write(2, "./src/grep: ", 12) = 12 write(2, "write error", 11) = 11 write(2, ": Broken pipe", 13) = 13 write(2, "\n", 1) = 1 exit_group(2) = ? == ltrace == fwrite_unlocked("1\n2\n3\n4\n5\n6\n7\n8\n9\n10\n11\n12\n13\n14"..., 1, 2, 0x7f9e62f50400) = 2 __errno_location() = 0x7f9e6337b6a0 fflush_unlocked(0x7f9e62f50400, 0x25af000, 10, 4096) = 0 memchr("2\n3\n4\n5\n6\n7\n8\n9\n10\n11\n12\n13\n14\n1"..., '\n', 32766) = 0x25af003 fwrite_unlocked("2\n3\n4\n5\n6\n7\n8\n9\n10\n11\n12\n13\n14\n1"..., 1, 2, 0x7f9e62f50400) = 2 __errno_location() = 0x7f9e6337b6a0 fflush_unlocked(0x7f9e62f50400, 0x25af004, 0, 2610 --- SIGPIPE (Broken pipe) --- <... fflush_unlocked resumed> ) = 0xffffffff __errno_location() = 0x7f9e6337b6a0 error(2, 32, 0x41caa0, 32 The server is: $ uname -a Linux x 3.13.0-77-generic #121-Ubuntu SMP Wed Jan 20 10:50:42 UTC 2016 x86_64 GNU/Linux $ gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/local/libexec/gcc/x86_64-unknown-linux-gnu/5.2.0/lto-wrapper Target: x86_64-unknown-linux-gnu Configured with: ../gcc-5.2.0/configure --enable-languages=c,c++ Thread model: posix gcc version 5.2.0 (GCC) Thanks for any feedback, regards, - assaf --------------070500030303030705030408 Content-Type: application/x-xz; name="grep-write-error-msg.patch.xz" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="grep-write-error-msg.patch.xz" /Td6WFoAAATm1rRGAgAhARYAAAB0L+Wj4CNlDHddACMcieb24AtKlej7qIiYgkZecgA99Bje /Zgo2ZHY/g3+0U+pljXkA/iuUXr2lxotpt7d434eJruUq3RE2yt9wwmfJbM24kToq6OuYBRq O78c4uK8aDkInBFh+MC4NSknoZUooaiochjGnV4K33aYhwdRKValLhgmnyx4cnikJyfZlBjt tJ2Tzc4/FNZgsqaBZoe5EdfJ3LezNXMVbxNgsoC+J1BqI7oQp3Tf6CDvpl/LipE+7Lzcwp2w uMji8hK5p+232c98aAMLqBXPSoNo1pbfpKkyCe/4Og+Bw2k3jI1QS229NWsJs4/5jEokj3sX UD7TZRoSyy0/UKvVxKk818Zkh77Ml0lZntFWy4R0VlRSY69uePv0Jg2HPKG795LOYSjOQGCp tuR1phEkxJVUkpihvPeD/HsnojSt7OlZ1Rok3zPsgXep/yMb/MxYXsaEpcLi9voYaAJf0F+e GBfsee+AL14zhIg7ocQHJGV7dg51EPSVxO2i4osd/9SEvvutNW+zLcAYCcsRMJM0U0jYlpPJ dxv78RdG+nmvFdpra5BRqCPjttM1ZP7pEdFIRCYmDoFc+I3/99RQMr8Bow17e7wdYm1jgGzU yXwLRczGS00cIniNwtZtcJpGwYc9U8MiNIEYun/F578MyNj3iiyQTzEdgySJ5lCQ5qMThk7s 2mveUP6QOviG8oux6Q/cl3qNJhVYJW3lHxWPegAQlYinTa8MRW4sey8BFl9iUjytnD2ZEwsV dxKTTJVk1e5ViLdnNd2V/B0dy3ZryOlhHHy7us3K6/O9MZGtof5JSh0Ftg/15UNdcjQho+RE k1qFspfs4UgPxHggUrhG7mwh1ifMb/Fnwgxc9cv3++kdz3f4x5gYaWUB2ndFPJ87xTPXbO4F FPjxqcfrq1FSYrJ7SqWfzKEQTeh9KcfenyTo9DODEKWxa8K+vrGN3OG62qyqs7Wnmw79uOlf qrtPhjSOGaOxDIKzPrvKnA2DgA5zg5b8yD5SDwe1Pjw+MmYbPj8HetnQsktrQXhSHvb/eiSX 2Loozc02aOmix7bUhLMIwXqLs9Un2SpEwZ3DllgG20clg2QPo3+tECQYjyExo3dWggkTQOq5 gjRFzDZ91A19XyuTiCk4uwbb+g5s1LO1zA+6KVDIKtMj9bGr+gQDh2t+76YGlQIsLfSK6mPN EPAXp/0rexDrwFARB9VUpK9GtnT7/JO+B9Hajeb3l9BR/fI3XMmQAStFapS7I/yY+QFbIgj9 NZP2UArJ+B463Foon1RYl0LASXRmZIEqgGpj1FxcWp+ovcMFGQ94iIDR8d3yonjWjNelFY2d pE8G/WRewcf5al2qARLOl6mUfRC1ba73eHejlUT3gQJHCvdNKPMUmaMCENJ0oXvbDJKdI/yp 6pQyQ6PvC+c5/VnGbi3q3Yhu4x441G9MGcTh1hHS7rYnZ0aDF97lxSDwu7uDCjXMZ81pOdG9 6/oLcj/jJwzw0XHFrQxkOSQlBHm82qhOs0ZciMeUGnVL1EHZEVW1PdOn8mRjTSTKP4WzPIdd thuGuUuowsGocp8EGDxn3E7tVKEqkDYAs+N8efHpJ4WJvx4pmdzeV/Gx3sQIiiuhIaJ9ADsC Fa48TP5Z3TckK12ex98LaDnAnMY5bW060RJr2Yz07rvGJCjKwuFKblq7cFhonFu907w9qr9K wBUsbdhGrWcBusaP5JEin9CVrrW/iZqZFsHUzhIMlaXE8/EkMRS9S6mcwbnpGIfCahzT5AwC 6RUU1Y7jDiZEvYIXhZG/6ToABRgZVIvqJI6cJIoVjv1yzenVSMD9TcOxZacujpqBPKLE0z9+ PoxjxBb9Uz5yXB3f8l4aloiDiuRAfOVyhc1JbpSdeNp5K7fdnFFYI1kW5vFlS+UleQrcWNW1 N7V/QKa6QR+33czDxRFBqJgARU2UzhfJv+nAXkbZT2rWpYHpQH6odgkKkNnhIZFhsY5SioBm l0DThqL0LmF6yBrFZZsx5xk8uJX7KKRVXUDbI9jBs0WQujeTCZk9R52QsLvAxWEdr8CrZCFm P1Ov85GjNef1VuB0+fpv/gnVCcGM6Xg1D6OKIKFndsm724xVTDu08fggMs9GygOFbT11MIvW mr6IS96ABHij/duYn0qdsWlPB2kOu5UZ9Hyfth0dXgAysZVnhjxZCsq9uBims9/V2KV+HVGR wg+4/Ay1LKMakapyKZxLVRCAGPqFN6N9OmeM5WQmptQkKQDh+vc+/46ws2+bnj3OG/l9/tvI xHN7stnK8LOzmcExCLIMlywL1QNVbj25nKI/60mFN/GuKI8VRKtamAtzDBGmPOGCaImc2Q+w Zca0TYSV2g+aa9O26AXs2lw4vxKx+cJWvkmInmXPEtWyKSK4oIXlBwYUh1/jJGkGogbvap7p LO3xXLPwhzkuLaw6d7Dsr1zxbX9Mr2JtK6k3qAJcTJU5elG7aep9k8/+Wecx5Glbwh+aywjT 8lCHznqrRbduJCVnYfXlpAIojQrBTUEmTN+I93zz/UKYW9Y7ym5T06+KVcLijFr4yaXMdZ5J uN2+5bxaPmhOqp9+Te+i+3yRC8zg1DJiPQVv3lteS7fd+tve1fvk0OlCq5SZMwfh6V8qnjhp p76B2vvVgnYRh6sycJR7TzTG4CAgSxB3fBmCQPhPiSsdrqYxfefQDFqaovqz5ACPskNUYD22 tk8ux8W/eOvaCjhcEYP5q66iFtcICbou71xsZIlj9QxuLaiS/oX/G1GSnxP4lPGCrOz4ENq8 fCciYJPP4mR0M7Yyl2amGImtRns3ZH0wJevkK8HX71rt1HUKmXSHaX53evrP5FrVYspbMCRP hF/vA9CTA7NcvVq5+lKR3Jkj3DtRy78LBLn0BRGjcMjI9EjRH1v/35SiThCJWyc19xGDWBui SLzo9+HxyTsF7xAKXh3qcYdxYJJPpBquxp4pshzCJYdDw/4bm8524U7sHU6ISMOQNzj7S9nN MmqC7FYeNtlhdXIAgRHouW4F2HcwRx3dND3NTqa/ee43Ye+W0gj3kVkUY7YdmJ/FMSqkXPA0 z7FbaHZXmk5ti+GA/Rdy/yRYzCzOyEy75uoOnDIbp5/2I1pIjNsPVJGsJsecMURNvm6F7cWq U2kEe+d6UxFmPE5je8OtsMWKpHoSd+7LoYwHKiAtuRwxfc4QPUUSrSMTkVanDpmDB5AXFV2Z J/KD+V/bXz2mO5kcpACd/FRT2Z4dJ/e+uXIiQX3LCTVHMi4hh5EHKxLQVCyZbBtde4q1kvat 5nZoCr9JXVzw0aGrxvGKNOdwjVH3a979cZlSukIQQxc6m4Sb/G/DSmn5usEtTiRXLP5LlKlw Lp8Iz6uxc5+I9fliWeu75H60KP+PEuZhCU1WRwImdPPgFRc3oVn/p+MU7F+I//ORFa4tUD2f yLLHWsWD+ZuhhiVUVnDSXWzBl4AZBvIA42OtR39FBPb4xuoFKqOxyDGh5mas4TtXvB+jWCjI RXdZP4zGV1DyIKKQALY+kJTmuBnYXZudCxeQ6AougnEH4Wql6AOs2BzcNvmjv7D6JVxE29Jj nmO4Y7gXSBMLcFl4DwlnupKqSYYcdgYbknSPO0JU2T1nqR9YG1HJzSaYMcJ0rVqO2keDHtCB pvuTkMABKrnZW1r2OSNzn3A/cstiVxnAIJuPS9H8flfhZ6QYzVv1q3e4MmpZdf+sVj+dKs6Q 9iQCS8pFlt9lF/VuoTLhVDDJ4S9WQUBE1Npys3J/tNiZarmpZ6HyJ46kuPecVfBaazmK4RsX s/XCQsond2EDO3spXm4iceMCRc1GYIU7XGHgsuwW9r/eilwsOQr5KD+NJuaxyxpx9UsE0fmL anX8ZQmmjHDrC2tTbOfHBp0JKjoTFzMtKPsa5bVgxp0kbmCrj68u3KT/9XYCVcfda1M/v+Hl MzZPb1VRTdrRpoMAZzkBV0+jR/lHOTyIPvs7vUJupY9UmGLZOwDUEZ1QxZEZQh7G2/Abe48O zhLfjzhujTSiK7xnjYljMyo22FwdhBV2S+zIeC26OFUwDsplI8XYMZFUlmoUmRAjqlr7FY0q uwmnh+IBHVEiRG4qzz+M5B9SmrruwxJLJFxGs86Hu4QRGYfFsSTQDbuRqpcDgqXZp2uSe27A qBwB2HBDBo01BQlJrg93h9R5bRt5pKFEpqMo4QNtLb6eCbGfHY/mCofpG20qBn9W+01o5clU 9gX9/vXJNcotjKuWjO4gIgTfkb+9Wjnm5j6MzH1gB+NmVLhyAAAhrer0I3MOSAABkxnmRgAA VapUsrHEZ/sCAAAAAARZWg== --------------070500030303030705030408 Content-Type: application/x-xz; name="grep-SIGPIPE-killed.ltrace.log.xz" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="grep-SIGPIPE-killed.ltrace.log.xz" /Td6WFoAAATm1rRGAgAhARYAAAB0L+Wj4X7QBlldABiNAyOQcJ5UVa/aUivkxqfefQiXMtAg JH0KlMX5D1vrtPnbH1ycekZ8GXZFnaR8n9/u7p1UJKYJP4XjX9BHpI/IIwVz6KwF1nLwzxKg ckcntOblPSlsnqfRg9pmbQrrmB+GiJtPZFRn51Z9bRJ4vN2hPwRZQiUYFcs81JYCkzc0DVVV PvNCBKngOv2auQyu43rU2TRRyvUJDoD4QjIQdkUJdgQfgGbd9t373XvfMH+krC3Mpz0bkPlh wjVBxoE3s1nAkpPIJUoyqCrlpCrGGLYpBkCrE89adbs+A+a2QKkiPZS25Rf9cgI8NhANRtfw SiV53i9ukAc8NvvjcPJ4v+SdR682N5y7vqebEP6D79/suY3iGPPTUF6ITKzLUU9f7Bd9HprT nOeWOuIbDRfxrBh8WH3LLCQw/9lwHqgkti2o3yCWI9SzJ8xcyottfj6i6oPI/kOfHlQwvvs1 wnAw/mwAHEB7ZPGR46+YaMgVPVRB3L2QWFBt0hV2FNyl9nQ3jHDJybVsWloNJ5zEOj6G/b2m Cg3gjOSlT6dT/i6S5eOSf5dpY9MrdiTyMuENJZB87xfwMMtgCi7tGW53t5j80/YhKAez/rXM Qbuwx9+1W9Uqy4MyXMhbHwfWjSebHgDqtlPbtYr9FFfVSMs5fLx1xeCJAGGqBxJq09SOVUnd MLOMXm+6Ax2h9Jo1/a0g28cmZFDSg3kyj+CqahoNCYTO2kVdBbGKXbrKTsX8lVr9kKl2IGn7 4wo9wEwVNhKBjXw3s2ke5jGqfhPaat3U24WzzDfNO0JpEJhg3YWXf9p1X/7g0qonwroeUV8h QZn09rCdOjas5h517On8G7iVfppgPlhOwwa3sso6G8JvwtZvoTgZTFk6wIyLlvWGethyrAv4 uAy7Wm84E4xok3eCpWfN6a1L4+2k/W+nyR7eVvvyzo2Yrrw8TTwpn0Vkq52l5vo3WlLdJaPD yLIDThE4y9wKiMlGXK+netMASiGYtilcPtOH6EsX6SiOkHbSTD5hGJ/jExRVIEMmggrM01FA wDxhNxpWKNdjvGlHd420nnleetFo8mC+sL0eLg8900G0muTisDu9oHAmPGcH4E875eQiicbi ETwVyHwd5ljbV/D0w0HYNb8XMWAF2O6oMSuu10EViNZ0TZUDDjbeTb57xllrrOoKVQL5FJh9 RXrstrcegZv7nEXyfNgtWSy82UAG3DM2EjPG40U3/cA4w5X29jjQEl/4OdzMRDpqtYsXwMv0 GsFUk9Chct4obkCXAzAA4XL8j88xLRea5kkw8fOGIOMWX8EbfSobID0kXzPR3ZgcF7Em8Y8z KMY5Q63ig7tO2I1Q2TOdMS9iJklIQDLFRCli4I3Q0m7n2FdDTfmLnspcUBxPJ3Hw0U/D+S/l Hoh7pbsYmWeub5EXMopRjVg2eorC7r/iW+hOniO9HFWgBWSGseUzGblp608189sdDLvFmWqL hn+UPrvIsF/z3CroWG4W6I/3s4p06+1hAFaq43aZM0o7mE7qi+BzEivH/ESwAOyY1xG4otta 8ROotQ7nhF4Dcd6S3hYU+IIP1YbAOeAwplgS9EGQdbw8nFZh+QNdLUsLtOJEy2GR7LtGz9MM /sHAxrQzcatkxkRkuRcrepoWEdAVlu4aiDXrqmA+BliRFl2IZSCEfbxm7yaLV2ZUTilSoN42 ec0CCCPU/KziMdkaiG2G/U+86dHbWhHXDe29aKYCJxau0BRhs2ZuWYwY4iC4w01nXP5AT7mT axR7J3UEkx96L3Z5eran/JEkiOJ3WAzM69HvPgZduO8lB86rlC2uEcMD5/btZl69b6kPB2rG EDtbq+LYbNAvD9mC2er1KE/vrPewtG7SfRvV1hDp+sUWMUZqlfwsCVDBpsqoUvpz8T4bi13j JW/emQ7CrDMwIcHjAtWcCy62lOz2hy67H9Iu6ivILyto2zGjUwcQw6p/pZOYeDauIUa6o1RN mbmpk86AP3gXWVdhtN5mWa/pa7mOC74oIR2A1TXrb6uNe0z/Btb9ZtKhGv1xSHd8oo+3dBwb i4GhVGrH3teHz+CJVJdXZHzM8zwNyikDQsASIKh/OuIIL7kA/Ao52z6wMHv5WKdi2fSjpbwC mPOY+cbE9DJQUtWegnZVjbIkBRnP3K8l4o4msmogDGKxJ2kgAAAAAP+zDc1KyJfZAAH1DNH9 BQBMe3kdscRn+wIAAAAABFla --------------070500030303030705030408 Content-Type: application/x-xz; name="grep-SIGPIPE-killed.strace.log.xz" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="grep-SIGPIPE-killed.strace.log.xz" /Td6WFoAAATm1rRGAgAhARYAAAB0L+Wj4BkRBRNdADKeCM2wKVEaxBJ3/cnMTmWjJLJx/hAA suf1l1KF/MNTpo7oTG4HMMkBbcKmRH6ylbPiEX1WvW01MyM+jdt+DXfqI/ih2Ipi93D6mEWu +yU31DWL3IzM1DbnTqpGLP0cM1DsckVOOKERwDCI+UQ5t5yX0W+r7hUUH0ZwdRe1qCMkYNrY I4joClo2Xweir6zrAsvQVqd8bo6atXQUob/oBsFPx0FqgrI+V1AKn1Qyyxh/9AXwHvtC9xBu 7l8M7FPIb9vcVTElKsh7j1cNzvte4VI7TIqXCgk4xaO1T9xTAjP8MDeA5zxI5k1GjdnDf/Nz 8bY0W1YFI314HfclQbBBxSIJDLdhkG6i2r78oY4EY79ea4Vsv8/ty9GNFitosS4O9ep+3Fuj VxI+hTeHRX+gDgYzVN6QnMRXYw8eYrws6uIUUWD0B+3JjFvxfPq6XWYDENBl5ve+ALxI6YGX XO8fo1D/3b4w5iUnOYSIgYqr0Mr6br0usKopL8GxrUegwYTTG2dGXIbT6Wg4u6M+mb6F873X kZ9sJL8+WpmJkTE7Yz7tS8xxx3IWnHxoLa2Wi0md5rSoHPxjkxHmqGrpTuIKk+n+SUa1ckk9 tbqZAS3lokcN08pirOkjgP2HhQYekQPW6p66DKl6NBCytbFG0mrYtKqLw/z+cDQdaC9NXpBT bHJNEkndVzt2HHv+g750OCN5PxFtxu2n9aR2WY6jHM2GppObDdPSMnTRfVV9AEgtMwHgfePM OkQAHhbltQ25OwqviU+DYpvlqYISlDmueQwmLVRQNZ+T9oO810AEPi3xgWh0eaR5kolncyX3 nrUtQjSKP1FJ4y9otvTG3eikSQYIgdv1Ar7KbYO7vuhL2q4Fd/n9rITjhCbMcu0qbuxllt9k ND8uihf4D5dR/O/dk2Wo9FslZC2PFd20ZaG5T7lmhbf9YpLE+GTPz5uSAHm9/E0jgIdJhlk8 FA6Ps6jx+IgxyiQGVN0YjtzGKbbdIAYRARDIAJD4xcjcNNOnpS5ObXG41aw4wO3melN/53hv qGmegKxdXo//4EcZNU6DSTJPlvsAwtAu4GWHheK/2S3tWv4+RUeUepYGDXSmuTezSnWeZKN5 Ou6CHEFRzLc4a1yUc2DiqD9Riz0r8BTW/538AwLSeVyC1Er/Un2cSrD3hTBm+qTgkKCC/Kf5 nLukk69rJNmqBSze4USrnNwCLJXQK7H/rQWYT8q3xAXSslSZujoR1suJm2QFFpfRbez9k7UF g1rKxwquyX1pPOUA6Vb4agA4mEwRfmEfrbrZQp21qnNYZkUYxvb8jXpgKxWuGO9zxowjL1Lx 5z6RF8d1XEk6iu/P6s4PAS5CUvXFt0dfowV1AlggbdIjBkSBwrPqjBbU0EnHbWm1VrmQbwdj HUPrY/iKboK7LgW85db0hYuwgtHixeEaEmwDp0q26TiW5rm/AlL2YYsRGkS48clNNWUn+1Wm /PodClzbxSsPeGYu7dcSj/wlj6mMnpuPUa5SJPulwfE0gWiTQ74Rya/FtKj1WJJ9iGAXTuHl WvKz3J2dve6I4b3aVlm1j8ulQIpQ/wARRU2PzNQz12dYBIwHAgB/aMxQIT4nOflcNrkrbV87 LJ/ySqHk0a6UP7/Cees0iC+UY7eIB4LcshyvUXu5iTEuA06qg348QqRScCavIW54dplPos1T PGMCA3kD0G4mumVDdhqi8AntGnXCx2GWaxr+l8+1QGPRAAAAOAdqcHNoqVYAAa8KkjIAAJZ3 CVGxxGf7AgAAAAAEWVo= --------------070500030303030705030408 Content-Type: application/x-xz; name="grep-SIGPIPE-not-killed.ltrace.log.xz" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="grep-SIGPIPE-not-killed.ltrace.log.xz" /Td6WFoAAATm1rRGAgAhARYAAAB0L+Wj4YChBpBdAC/hrNJjTrcBSh7XmhmJHw136MbYBZZl UcAlW1VLr6wXf0pptw4/Lij2rOpEiTAVT6g5ZecOgNPnRE1EvDMTbjcRBvLpgXor7xfWt56t fjzp4MC8zC0oxWnfVA/uaxrYC8HwUlKRDNTFd7lczX8WXTJ0j/BXjnebt93IPYiKvhMMBd2c jG0flZj0F5hhn4YYeSe3Db29wRUGNN1mK83w8gM9wITZ99LcOenCR+ujUYGiYwMvejibv4uQ VYOdvW8usBeWFYABrJJjLSyyrQkkGLg7VJCrlju9A9PfmvIOsRlYnORk6TEjboSF+3Rp5Sxy hOeLgAxmoOL0YzhXxwL+QpeQ2euZ+lNk7EHF19bbsgUitsdgy0VUDRCLEnYeyYVHDDFm8gCf MqkwskOzbI4WjHK0nHXMPZ3wHTOsK/IwRvEbNkW/4Ba6MB0qR3jzZGv933pNEDWg1KdO1S4v X+gOiD/ToeU52iK4xdog5CxHg+xuSCWTsbxUjyXF+YKz6YWDpRQG8Svcq7ZB714RlsYYYmTy CgzahtwBQLraLQdMs99C2bf2FYZxrmhf7mrxujzRkha5fIxHGRhnwxb41rzU871Ik2ecSLx6 WgYhVfYczPBI2ZlVb9H40WXdjX9K8v11ZWcquIYBV01B3eHRSJPFRdRyFNikE7wzFejN66RG tX6SCHoMHxfrIgaMfTXL8U2ApMeIWaKsThUNrQms94KMnm0OuqFHyBLaNUWp6tPMfAMoa/w0 bEwK5PfN6G5xf5Oq7D45ve+h4ZqTyZvxr67M5eeet++/CJy0kfGr+h04z/1/mePj/opJD37k bpyPHp0FW3ve466yppmQu4IQTyea/f42BK8LTWHr+ISirTEVQe/XVKYI0Mq+pOsydnmqDcG7 /43JbF4Gz7jCysVGM7YHS12lHN1cBxLMrcjmfUk6DFOabqMfvm5vEekNYNsunpta0Tnvbul/ 5OgjDG2jPX+f0zoQnLz27CEXf8ENWa7BnsEanpGlmjiqUj8Wjdx3ACuu7aYSFV74C9ctTpad tYpV3uMwNrZ8+CkpZ1fHirAX4V21lDwn0lTH4tO0B4p9Y3CvqmAdpJVgMsEU+bfPUhK4uld9 8fFTK8Gt9E5W26QQPZJGHJKHRN7F02pFqZFhdTNPw53STXU9qbB6HlyS4dGQJ9fCp3+T5Dec l5Fjg8X6ROzLqvhgHF6df7r/pff/2Kd04FlyZOrMy2IFoxcs8TTOTz2ocKDQj4etC+YRGC3O AYuo07lDQBljBTHGAlD8FcGLd9fCCdwi+wx0HFz+3NF/cpAOVnropNL33yuIkS6596PglMb7 ktRdk2n7dkOVk1AyYD2DidD2iyl1Rd9h6As1gDN5uZR4HHit+neuD69agOVHg4L4CfPQMeJb 3vMXaL+2Emrhrjc3KFI3PBfc1diHBbWEqtWwnOkQ4veX9u+MAsvH8y7EyjC6tZEGF+4VQ9jL KpJZ50R9gF+vFNYLa5Eevy1G2gHemEn39fHm3lE0ncPAkRtZjc3SkCZM7RsVOmlIojQSsy8g px5yT4HU8VPWsIkZXveurTazKCNH683UU6i36HF0h0/KLhMRXfiVevmsEKFyKjWMno6A10PZ Ek7ag6T3dOtW0R76yeasQk0NJGjH+o8XZjpSQhO43Zc4dr3zjmqAI82J08oejKWmUWAZnKLi dHPq+UIi0d5ik5sFF56W78dm9wvcKYN5aABGweAXGpLy8IP7Nq2H9W6ZnZjg4FNQStD3rfkI 2ZtuQvQuIQs6tEmDN16txg0DNU9NW1+VW2JM/0LC9TgOtutTuCkhuPoO1rl2IURQkArstHx2 /DNOrHozzgbf+ll9XzTacg3ex8RdEY3ba8GywM6binPgj7uhboDYd4pFxwpaJa1ACz+dsEzs L1h1ajHve2Kq9k7cepSUgQRPKdYa4Q2Uk6Jk0CHipnA6nY8mpAy2iV9huKmJ2mZiAI88pQoZ 4L2IIFFFRi8q9EKTYGEsiVCtfgb2OljT5oPVCIWSh4YXWu9a+zFOAZd3/NQdIwmBrPSGolgo OtV2XQln6ncf1fbc3Dyvjll05HozekZ5lwDxV+Slrh7+Z5RFKZCaTrZW9Fz4Spmw3wUP0jck AsFG15NSluQAbQZ/YTFNEgzqDQMgjFxBQE9XSugmeWjvjqjeZPiGV0SvnfSYlgBQHuFHpQXi OLCxq+UEbGL0gmbRfomKUtesqTUcSGkgF+171yXqXOMkJZ4njABPHiRxeEaifQABrA2igQYA RsbUBLHEZ/sCAAAAAARZWg== --------------070500030303030705030408 Content-Type: application/x-xz; name="grep-SIGPIPE-not-killed.strace.log.xz" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="grep-SIGPIPE-not-killed.strace.log.xz" /Td6WFoAAATm1rRGAgAhARYAAAB0L+Wj4BuWBWddADKeCM2wKVEaxBJ3/cnMTmWjJLJx/hAA suf1l1JvWd9cN/IOKroEjZ248aMqS0yueYN3bZSmkPQAV7yoR4X5XP0zjYKeqr5ZsRfI0sdy QWKnAW5CF8DF/tulhDkyKnrnGn9pAgDpR3AAbFfc7uSFAy2n9Z/6Aq64LyH2xFHRLGKQOaKG ySqQ5jj7+X9Vtr/JQ2cf/kBRzYLFIRnWDYweBMW7L249sevFQUJfRsIEt9l+ftWftxztvzSp YbsOAIYHbW3Xjbi/1kDrvCejMMO08ISx/y8K5TYsJEEikJrACNpq826DGi1VlA2YDOTt7QNG j6UKf0pOySHySrhe0A3cTS2cTmciaT7OxBKodA9Fc8i/4g8PwvP6APOlc/woW8iaU3lpJtm6 lX8lzXSpU9twMUtCK68FbXPMDs8cdgcdbWBLyxpGYGmNvxMpggEaX6845zcgMAF9reMeUJJo POEUp6f5A+U2DGITpqGoP3S3jixG+ujKeQ3zpsSV4ftgwkxmvn7e4LuERMo47FtxC1WwTUsc 6nQ65HhZFtQ2esP+dKC0knu4ZepGeHRLoMdTdx1JwOwzULU9N+B7TKYPhRXJIBlxrAhzaCut d5s2lNbXSHS2LDQ1vjmXV/k4k8R2AeVU5TA7VpouWvtbDay53f239tFmtlelA8qKHCmnIBTk lkMRZSy/37AouePdreE7/nkJJiPdu9zsUmOWcnzs/dalkjqlgo5NPZg1ue4EoVmjv8TS+Aic BTwqkdJwe1KlnGa6oXGd6xYcGAAAZRNlkR8L3kwZuzcgudT2Tjz2qq0/5Nqsc5eaL+z+t6PJ dYi+rVTrjGzt9k8ECS7M5To6rxUzTElfewyF+qb+3ngHy9ovCX+Jy+1sbhrTvH35134By1Ov gldiGFWfNVro+gDL5euQXOBxrxzskhZG95cPpjl4PP1y8mN/3JB+5/e29cMHG+sZXY6bbYEf oRmkkQwaRh96YgheehF82Tc3SkRel8l4a/lLmyKVe+NpAYItfXHQfhi5HcQKRfPXpkFyqWrA S6aY8U7/WGjSntMFrybMFjw4+Lx1FMdpS/P0SqTHHoJ8ReKPJGWug6xQqu5LE/i0TbfDcOvs mKqTUujh8ymfwjZyPCh50ysgK4VQnE0jUnZEzN1v+gkz9zxNGDgNEX2nPhC3K4txA76CpEMh WWcu40hAo4bK1B4Gne+RHLCIrNHGwlLR38nFhYm7mDcmDX1+sJBRtCvoCz71HJ0vCpXAYwi9 No1INdfLeUQ6w8xMFGAANi4mlN7yBHlI7iq86PKCwmfUhGxJL6MIQvc0ckAXHgpBxmn+/UZb ia48YEtIzuTdHDnKROrYdf7VCTheAg4Kh6dWqCl+pc81wa3zxEbIFrI34TgtlWh+c/k9CM0O 1kIBIuXLRogWOjAacXRpyG4Ag33nWi3TPtE69UQPNCy/dFQwHdRP9KOZOLlOiLclvlY35AVY v7BQyULRxyromBPOpP8iHb3szDR8GaOKvCq6OqPQgdQvoxWzAQpp96PBBN/JYdMSXFJu+o8e eJrnwJ9dCUIxKB80sNQs7yVxEinWa2FGhLXvvCkHeV3H7MWUJCk527yNvemnLUhjS2Bt+uZE IjrOB+d6mozMqlEbeQSgYDQqCQ0PB3yiqnxlyeQ/mQ9HSAA+c9sCMFrELIYEgQlCuIaM2lD5 F+7nANuaDrXqwpBXSq598B7oOgCy/nTq57W8hsgSTSXEv7REILL2MRwxaYB7XBUKxyU52JcO Lq2dBK2ir7D5m42ql8lqAJkhugwFzc5cF2FX87mhp3bWbMirZziVkOtuccKjpHxgthVc3kEI 8M93/UCbTRiqBwAAYmjhnhdHcUIAAYMLlzcAALKpEi2xxGf7AgAAAAAEWVo= --------------070500030303030705030408-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 16 17:23:23 2016 Received: (at 23031) by debbugs.gnu.org; 16 Mar 2016 21:23:24 +0000 Received: from localhost ([127.0.0.1]:50485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agIuZ-0003bk-O0 for submit@debbugs.gnu.org; Wed, 16 Mar 2016 17:23:23 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agIuY-0003bU-0R for 23031@debbugs.gnu.org; Wed, 16 Mar 2016 17:23:22 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8B8A9160E65; Wed, 16 Mar 2016 14:23:16 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id WwvdyxsKxLRe; Wed, 16 Mar 2016 14:23:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C9F4B160F6A; Wed, 16 Mar 2016 14:23:15 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7tyQ1NzUcEAk; Wed, 16 Mar 2016 14:23:15 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B0ECE160E65; Wed, 16 Mar 2016 14:23:15 -0700 (PDT) Subject: Re: bug#23031: reporting write errors and handling SIGPIPE To: Assaf Gordon , 23031@debbugs.gnu.org References: <56E98668.5050500@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <56E9CEC3.3000201@cs.ucla.edu> Date: Wed, 16 Mar 2016 14:23:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E98668.5050500@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23031 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 03/16/2016 09:14 AM, Assaf Gordon wrote: > write(1, "2\n", 2) = -1 EPIPE (Broken pipe) > --- SIGPIPE {si_signo=SIGPIPE, si_code=SI_USER, si_pid=2893, > si_uid=1004} --- > write(2, "./src/grep: ", 12) = 12 Although this looks weird and it's not what I would expect, it's not a POSIX violation as far as I can see. The system is required to send a SIGPIPE signal in this case, but it is not required to deliver the SIGPIPE signal before 'write' returns with errno == EPIPE. Arguably it's a bug in GNU/Linux anyway. Your patch is a step in the right direction, but needs a bit of cleanup; I plan to look into it more carefully later. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 17 14:49:18 2016 Received: (at 23031) by debbugs.gnu.org; 17 Mar 2016 18:49:18 +0000 Received: from localhost ([127.0.0.1]:51414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agcz0-0000q8-59 for submit@debbugs.gnu.org; Thu, 17 Mar 2016 14:49:18 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:39037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agcyy-0000pv-6q for 23031@debbugs.gnu.org; Thu, 17 Mar 2016 14:49:16 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 18B66160D7D; Thu, 17 Mar 2016 11:49:10 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id IPyxTa_EIK7z; Thu, 17 Mar 2016 11:49:09 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 307F1160F8A; Thu, 17 Mar 2016 11:49:09 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 7aM_n-M9qZJw; Thu, 17 Mar 2016 11:49:09 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 138A2160D7D; Thu, 17 Mar 2016 11:49:09 -0700 (PDT) Subject: Re: bug#23031: reporting write errors and handling SIGPIPE To: Assaf Gordon , 23031@debbugs.gnu.org References: <56E98668.5050500@gmail.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <56EAFC24.8010108@cs.ucla.edu> Date: Thu, 17 Mar 2016 11:49:08 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56E98668.5050500@gmail.com> Content-Type: multipart/mixed; boundary="------------050502040501040505080209" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23031 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------050502040501040505080209 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 03/16/2016 09:14 AM, Assaf Gordon wrote: > Attached is a patch that adds errno information to 'write error' messages Thanks, I installed the attached somewhat-tweaked version of that. Among other things I renamed the new static functions to avoid confusion with existing "safer" functions. This doesn't address the SIGPIPE mystery so I'll leave the bug report open, but my guess is that this part isn't really a grep bug. --------------050502040501040505080209 Content-Type: application/x-patch; name="0001-grep-use-errno-consistently-in-write-diagnostics.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-grep-use-errno-consistently-in-write-diagnostics.patch" RnJvbSAxY2VjMjdhN2YwZTVjN2JkYzQ0YTg4ZWY1MWFmMDlmODdhOGNiYzI0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUaHUsIDE3IE1hciAyMDE2IDExOjQ0OjQ2IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gZ3JlcDogdXNlIGVycm5vIGNvbnNpc3RlbnRseSBpbiB3cml0ZSBkaWFnbm9zdGljcwoK RmVhdHVyZSByZXF1ZXN0IGFuZCBpbml0aWFsIHZlcnNpb24gcmVwb3J0ZWQgYnkgQXNzYWYg R29yZG9uIGluOgpodHRwOi8vYnVncy5nbnUub3JnLzIzMDMxCiogTkVXUzogRG9jdW1lbnQg dGhpcy4KKiBzcmMvZ3JlcC5jOiBJbmNsdWRlIDxzdGRhcmcuaD4uCihzdGRvdXRfZXJybm8p OiBOZXcgc3RhdGljIHZhci4KKHdyaXRlX2Vycm9yX3NlZW4pOiBSZW1vdmU7IHN1cGVyc2Vk ZWQgYnkgc3Rkb3V0X2Vycm5vLgpBbGwgdXNlcyBjaGFuZ2VkLgoocHV0Y2hhcl9lcnJubywg ZnB1dHNfZXJybm8sIHByaW50Zl9lcnJubywgZndyaXRlX2Vycm5vKQooZmZsdXNoX2Vycm5v KTogTmV3IHN0YXRpYyBmdW5jdGlvbnMuCihwcmludF9maWxlbmFtZSwgcHJpbnRfc2VwLCBw cmludF9vZmZzZXQsIHByaW50X2xpbmVfaGVhZCkKKHByaW50X2xpbmVfbWlkZGxlLCBwcmlu dF9saW5lX3RhaWwsIHBybGluZSwgcHJ0ZXh0LCBncmVwKQooZ3JlcGRlc2MpOiBVc2UgdGhl bS4KKiB0ZXN0cy93cml0ZS1lcnJvci1tc2c6IE5ldyBmaWxlLgoqIHRlc3RzL01ha2VmaWxl LmFtIChURVNUUyk6IEFkZCBpdC4KLS0tCiBORVdTICAgICAgICAgICAgICAgICAgfCAgNiAr KysrCiBzcmMvZ3JlcC5jICAgICAgICAgICAgfCA5MiArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KIHRlc3RzL01ha2VmaWxlLmFtICAgICB8 ICAxICsKIHRlc3RzL3dyaXRlLWVycm9yLW1zZyB8IDU1ICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAxMjcgaW5zZXJ0aW9ucygrKSwgMjcgZGVs ZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAxMDA3NTUgdGVzdHMvd3JpdGUtZXJyb3ItbXNnCgpk aWZmIC0tZ2l0IGEvTkVXUyBiL05FV1MKaW5kZXggMjYxNjhmYi4uOWRlMDdhYiAxMDA2NDQK LS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC01LDYgKzUsMTIgQEAgR05VIGdyZXAgTkVXUyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0qLSBvdXRsaW5lIC0qLQogCiAq IE5vdGV3b3J0aHkgY2hhbmdlcyBpbiByZWxlYXNlIDIuMjQgKDIwMTYtMDMtMTApIFtzdGFi bGVdCiAKKyoqIEltcHJvdmVtZW50cworCisgIGdyZXAgbm93IG91dHB1dHMgZGV0YWlscyBt b3JlIGNvbnNpc3RlbnRseSB3aGVuIHJlcG9ydGluZyBhIHdyaXRlIGVycm9yLgorICBFLmcu LCAiZ3JlcDogd3JpdGUgZXJyb3I6IE5vIHNwYWNlIGxlZnQgb24gZGV2aWNlIiByYXRoZXIg dGhhbiBqdXN0CisgICJncmVwOiB3cml0ZSBlcnJvciIuCisKICoqIEJ1ZyBmaXhlcwogCiAg IGdyZXAgLXogd291bGQgbWF0Y2ggc3RyaW5ncyBpdCBzaG91bGQgbm90LiAgVG8gdHJpZ2dl ciB0aGUgYnVnLCB5b3UnZApkaWZmIC0tZ2l0IGEvc3JjL2dyZXAuYyBiL3NyYy9ncmVwLmMK aW5kZXggNzNjMzY1MS4uOTRkZGJlZiAxMDA2NDQKLS0tIGEvc3JjL2dyZXAuYworKysgYi9z cmMvZ3JlcC5jCkBAIC0yNSw2ICsyNSw3IEBACiAjaW5jbHVkZSA8d2N0eXBlLmg+CiAjaW5j bHVkZSA8ZmNudGwuaD4KICNpbmNsdWRlIDxpbnR0eXBlcy5oPgorI2luY2x1ZGUgPHN0ZGFy Zy5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSAic3lzdGVtLmgiCiAKQEAgLTI5 Niw2ICsyOTcsNDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBjb2xvcl9jYXAgY29sb3JfZGlj dFtdID0KICAgICB7IE5VTEwsIE5VTEwsICAgICAgICAgICAgICAgICAgTlVMTCB9CiAgIH07 CiAKKy8qIFNhdmVkIGVycm5vIHZhbHVlIGZyb20gZmFpbGVkIG91dHB1dCBmdW5jdGlvbnMg b24gc3Rkb3V0LiAgKi8KK3N0YXRpYyBpbnQgc3Rkb3V0X2Vycm5vOworCitzdGF0aWMgdm9p ZAorcHV0Y2hhcl9lcnJubyAoaW50IGMpCit7CisgIGlmIChwdXRjaGFyIChjKSA8IDApCisg ICAgc3Rkb3V0X2Vycm5vID0gZXJybm87Cit9CisKK3N0YXRpYyB2b2lkCitmcHV0c19lcnJu byAoY2hhciBjb25zdCAqcykKK3sKKyAgaWYgKGZwdXRzIChzLCBzdGRvdXQpIDwgMCkKKyAg ICBzdGRvdXRfZXJybm8gPSBlcnJubzsKK30KKworc3RhdGljIHZvaWQgX0dMX0FUVFJJQlVU RV9GT1JNQVRfUFJJTlRGICgxLCAyKQorcHJpbnRmX2Vycm5vIChjaGFyIGNvbnN0ICpmb3Jt YXQsIC4uLikKK3sKKyAgdmFfbGlzdCBhcDsKKyAgdmFfc3RhcnQgKGFwLCBmb3JtYXQpOwor ICBpZiAodmZwcmludGYgKHN0ZG91dCwgZm9ybWF0LCBhcCkgPCAwKQorICAgIHN0ZG91dF9l cnJubyA9IGVycm5vOworICB2YV9lbmQgKGFwKTsKK30KKworc3RhdGljIHZvaWQKK2Z3cml0 ZV9lcnJubyAodm9pZCBjb25zdCAqcHRyLCBzaXplX3Qgc2l6ZSwgc2l6ZV90IG5tZW1iKQor eworICBpZiAoZndyaXRlIChwdHIsIHNpemUsIG5tZW1iLCBzdGRvdXQpICE9IG5tZW1iKQor ICAgIHN0ZG91dF9lcnJubyA9IGVycm5vOworfQorCitzdGF0aWMgdm9pZAorZmZsdXNoX2Vy cm5vICh2b2lkKQoreworICBpZiAoZmZsdXNoIChzdGRvdXQpICE9IDApCisgICAgc3Rkb3V0 X2Vycm5vID0gZXJybm87Cit9CisKIHN0YXRpYyBzdHJ1Y3QgZXhjbHVkZSAqZXhjbHVkZWRf cGF0dGVybnNbMl07CiBzdGF0aWMgc3RydWN0IGV4Y2x1ZGUgKmV4Y2x1ZGVkX2RpcmVjdG9y eV9wYXR0ZXJuc1syXTsKIC8qIFNob3J0IG9wdGlvbnMuICAqLwpAQCAtMzg2LDcgKzQyOCw2 IEBAIHN0YXRpYyBjaGFyIGNvbnN0ICpmaWxlbmFtZTsKIC8qIE9taXQgbGVhZGluZyAiLi8i IGZyb20gZmlsZSBuYW1lcyBpbiBkaWFnbm9zdGljcy4gICovCiBzdGF0aWMgYm9vbCBvbWl0 X2RvdF9zbGFzaDsKIHN0YXRpYyBib29sIGVycnNlZW47Ci1zdGF0aWMgYm9vbCB3cml0ZV9l cnJvcl9zZWVuOwogCiAvKiBUcnVlIGlmIG91dHB1dCBmcm9tIHRoZSBjdXJyZW50IGlucHV0 IGZpbGUgaGFzIGJlZW4gc3VwcHJlc3NlZAogICAgYmVjYXVzZSBhbiBvdXRwdXQgbGluZSBo YWQgYW4gZW5jb2RpbmcgZXJyb3IuICAqLwpAQCAtNDgwLDcgKzUyMSw3IEBAIHN1cHByZXNz aWJsZV9lcnJvciAoY2hhciBjb25zdCAqbWVzZywgaW50IGVycm51bSkKIHN0YXRpYyB2b2lk CiBjbGVhbl91cF9zdGRvdXQgKHZvaWQpCiB7Ci0gIGlmICghIHdyaXRlX2Vycm9yX3NlZW4p CisgIGlmICghIHN0ZG91dF9lcnJubykKICAgICBjbG9zZV9zdGRvdXQgKCk7CiB9CiAKQEAg LTk0MCw3ICs5ODEsNyBAQCBzdGF0aWMgdm9pZAogcHJpbnRfZmlsZW5hbWUgKHZvaWQpCiB7 CiAgIHByX3Nncl9zdGFydF9pZiAoZmlsZW5hbWVfY29sb3IpOwotICBmcHV0cyAoZmlsZW5h bWUsIHN0ZG91dCk7CisgIGZwdXRzX2Vycm5vIChmaWxlbmFtZSk7CiAgIHByX3Nncl9lbmRf aWYgKGZpbGVuYW1lX2NvbG9yKTsKIH0KIApAQCAtOTQ5LDcgKzk5MCw3IEBAIHN0YXRpYyB2 b2lkCiBwcmludF9zZXAgKGNoYXIgc2VwKQogewogICBwcl9zZ3Jfc3RhcnRfaWYgKHNlcF9j b2xvcik7Ci0gIGZwdXRjIChzZXAsIHN0ZG91dCk7CisgIHB1dGNoYXJfZXJybm8gKHNlcCk7 CiAgIHByX3Nncl9lbmRfaWYgKHNlcF9jb2xvcik7CiB9CiAKQEAgLTk3Niw3ICsxMDE3LDcg QEAgcHJpbnRfb2Zmc2V0ICh1aW50bWF4X3QgcG9zLCBpbnQgbWluX3dpZHRoLCBjb25zdCBj aGFyICpjb2xvcikKICAgICAgICotLXAgPSAnICc7CiAKICAgcHJfc2dyX3N0YXJ0X2lmIChj b2xvcik7Ci0gIGZ3cml0ZSAocCwgMSwgYnVmICsgc2l6ZW9mIGJ1ZiAtIHAsIHN0ZG91dCk7 CisgIGZ3cml0ZV9lcnJubyAocCwgMSwgYnVmICsgc2l6ZW9mIGJ1ZiAtIHApOwogICBwcl9z Z3JfZW5kX2lmIChjb2xvcik7CiB9CiAKQEAgLTEwMTMsNyArMTA1NCw3IEBAIHByaW50X2xp bmVfaGVhZCAoY2hhciAqYmVnLCBzaXplX3QgbGVuLCBjaGFyIGNvbnN0ICpsaW0sIGNoYXIg c2VwKQogICAgICAgaWYgKGZpbGVuYW1lX21hc2spCiAgICAgICAgIHBlbmRpbmdfc2VwID0g dHJ1ZTsKICAgICAgIGVsc2UKLSAgICAgICAgZnB1dGMgKDAsIHN0ZG91dCk7CisgICAgICAg IHB1dGNoYXJfZXJybm8gKDApOwogICAgIH0KIAogICBpZiAob3V0X2xpbmUpCkBAIC0xMDQ3 LDcgKzEwODgsNyBAQCBwcmludF9saW5lX2hlYWQgKGNoYXIgKmJlZywgc2l6ZV90IGxlbiwg Y2hhciBjb25zdCAqbGltLCBjaGFyIHNlcCkKICAgICAgICAgIChhbmQgaXRzIGNvbWJpbmlu ZyBhbmQgd2lkZSBjaGFyYWN0ZXJzKQogICAgICAgICAgZmlsZW5hbWVzIGFuZCB5b3UncmUg d2FzdGluZyB5b3VyIGVmZm9ydHMuICAqLwogICAgICAgaWYgKGFsaWduX3RhYnMpCi0gICAg ICAgIGZwdXRzICgiXHRcYiIsIHN0ZG91dCk7CisgICAgICAgIGZwdXRzX2Vycm5vICgiXHRc YiIpOwogCiAgICAgICBwcmludF9zZXAgKHNlcCk7CiAgICAgfQpAQCAtMTEwNCwxNCArMTE0 NSwxNCBAQCBwcmludF9saW5lX21pZGRsZSAoY2hhciAqYmVnLCBjaGFyICpsaW0sCiAgICAg ICAgICAgICAgICAgICBjdXIgPSBtaWQ7CiAgICAgICAgICAgICAgICAgICBtaWQgPSBOVUxM OwogICAgICAgICAgICAgICAgIH0KLSAgICAgICAgICAgICAgZndyaXRlIChjdXIsIHNpemVv ZiAoY2hhciksIGIgLSBjdXIsIHN0ZG91dCk7CisgICAgICAgICAgICAgIGZ3cml0ZV9lcnJu byAoY3VyLCAxLCBiIC0gY3VyKTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgIHByX3Nn cl9zdGFydF9pZiAobWF0Y2hfY29sb3IpOwotICAgICAgICAgIGZ3cml0ZSAoYiwgc2l6ZW9m IChjaGFyKSwgbWF0Y2hfc2l6ZSwgc3Rkb3V0KTsKKyAgICAgICAgICBmd3JpdGVfZXJybm8g KGIsIDEsIG1hdGNoX3NpemUpOwogICAgICAgICAgIHByX3Nncl9lbmRfaWYgKG1hdGNoX2Nv bG9yKTsKICAgICAgICAgICBpZiAob25seV9tYXRjaGluZykKLSAgICAgICAgICAgIGZwdXRz ICgiXG4iLCBzdGRvdXQpOworICAgICAgICAgICAgcHV0Y2hhcl9lcnJubyAoJ1xuJyk7CiAg ICAgICAgIH0KICAgICB9CiAKQEAgLTExMzYsNyArMTE3Nyw3IEBAIHByaW50X2xpbmVfdGFp bCAoY2hhciAqYmVnLCBjb25zdCBjaGFyICpsaW0sIGNvbnN0IGNoYXIgKmxpbmVfY29sb3Ip CiAgIGlmICh0YWlsX3NpemUgPiAwKQogICAgIHsKICAgICAgIHByX3Nncl9zdGFydCAobGlu ZV9jb2xvcik7Ci0gICAgICBmd3JpdGUgKGJlZywgMSwgdGFpbF9zaXplLCBzdGRvdXQpOwor ICAgICAgZndyaXRlX2Vycm5vIChiZWcsIDEsIHRhaWxfc2l6ZSk7CiAgICAgICBiZWcgKz0g dGFpbF9zaXplOwogICAgICAgcHJfc2dyX2VuZCAobGluZV9jb2xvcik7CiAgICAgfQpAQCAt MTE4OCwxNiArMTIyOSwxMyBAQCBwcmxpbmUgKGNoYXIgKmJlZywgY2hhciAqbGltLCBjaGFy IHNlcCkKICAgICB9CiAKICAgaWYgKCFvbmx5X21hdGNoaW5nICYmIGxpbSA+IGJlZykKLSAg ICBmd3JpdGUgKGJlZywgMSwgbGltIC0gYmVnLCBzdGRvdXQpOworICAgIGZ3cml0ZV9lcnJu byAoYmVnLCAxLCBsaW0gLSBiZWcpOwogCiAgIGlmIChsaW5lX2J1ZmZlcmVkKQotICAgIGZm bHVzaCAoc3Rkb3V0KTsKKyAgICBmZmx1c2hfZXJybm8gKCk7CiAKLSAgaWYgKGZlcnJvciAo c3Rkb3V0KSkKLSAgICB7Ci0gICAgICB3cml0ZV9lcnJvcl9zZWVuID0gdHJ1ZTsKLSAgICAg IGVycm9yIChFWElUX1RST1VCTEUsIDAsIF8oIndyaXRlIGVycm9yIikpOwotICAgIH0KKyAg aWYgKHN0ZG91dF9lcnJubykKKyAgICBlcnJvciAoRVhJVF9UUk9VQkxFLCBzdGRvdXRfZXJy bm8sIF8oIndyaXRlIGVycm9yIikpOwogCiAgIGxhc3RvdXQgPSBsaW07CiB9CkBAIC0xMjUz LDkgKzEyOTEsOSBAQCBwcnRleHQgKGNoYXIgKmJlZywgY2hhciAqbGltKQogICAgICAgICAg ICYmIHAgIT0gbGFzdG91dCAmJiBncm91cF9zZXBhcmF0b3IpCiAgICAgICAgIHsKICAgICAg ICAgICBwcl9zZ3Jfc3RhcnRfaWYgKHNlcF9jb2xvcik7Ci0gICAgICAgICAgZnB1dHMgKGdy b3VwX3NlcGFyYXRvciwgc3Rkb3V0KTsKKyAgICAgICAgICBmcHV0c19lcnJubyAoZ3JvdXBf c2VwYXJhdG9yKTsKICAgICAgICAgICBwcl9zZ3JfZW5kX2lmIChzZXBfY29sb3IpOwotICAg ICAgICAgIGZwdXRjICgnXG4nLCBzdGRvdXQpOworICAgICAgICAgIHB1dGNoYXJfZXJybm8g KCdcbicpOwogICAgICAgICB9CiAKICAgICAgIHdoaWxlIChwIDwgYmVnKQpAQCAtMTQ5OCw5 ICsxNTM2LDkgQEAgZ3JlcCAoaW50IGZkLCBzdHJ1Y3Qgc3RhdCBjb25zdCAqc3QpCiAgIGlm ICghb3V0X3F1aWV0ICYmIChlbmNvZGluZ19lcnJvcl9vdXRwdXQKICAgICAgICAgICAgICAg ICAgICAgIHx8ICgwIDw9IG5saW5lc19maXJzdF9udWxsICYmIG5saW5lc19maXJzdF9udWxs IDwgbmxpbmVzKSkpCiAgICAgewotICAgICAgcHJpbnRmIChfKCJCaW5hcnkgZmlsZSAlcyBt YXRjaGVzXG4iKSwgZmlsZW5hbWUpOworICAgICAgcHJpbnRmX2Vycm5vIChfKCJCaW5hcnkg ZmlsZSAlcyBtYXRjaGVzXG4iKSwgZmlsZW5hbWUpOwogICAgICAgaWYgKGxpbmVfYnVmZmVy ZWQpCi0gICAgICAgIGZmbHVzaCAoc3Rkb3V0KTsKKyAgICAgICAgZmZsdXNoX2Vycm5vICgp OwogICAgIH0KICAgcmV0dXJuIG5saW5lczsKIH0KQEAgLTE3NDIsMjAgKzE3ODAsMjAgQEAg Z3JlcGRlc2MgKGludCBkZXNjLCBib29sIGNvbW1hbmRfbGluZSkKICAgICAgICAgICAgICAg aWYgKGZpbGVuYW1lX21hc2spCiAgICAgICAgICAgICAgICAgcHJpbnRfc2VwIChTRVBfQ0hB Ul9TRUxFQ1RFRCk7CiAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICBmcHV0 YyAoMCwgc3Rkb3V0KTsKKyAgICAgICAgICAgICAgICBwdXRjaGFyX2Vycm5vICgwKTsKICAg ICAgICAgICAgIH0KLSAgICAgICAgICBwcmludGYgKCIlIiBQUklkTUFYICJcbiIsIGNvdW50 KTsKKyAgICAgICAgICBwcmludGZfZXJybm8gKCIlIiBQUklkTUFYICJcbiIsIGNvdW50KTsK ICAgICAgICAgICBpZiAobGluZV9idWZmZXJlZCkKLSAgICAgICAgICAgIGZmbHVzaCAoc3Rk b3V0KTsKKyAgICAgICAgICAgIGZmbHVzaF9lcnJubyAoKTsKICAgICAgICAgfQogCiAgICAg ICBzdGF0dXMgPSAhY291bnQ7CiAgICAgICBpZiAobGlzdF9maWxlcyA9PSAxIC0gMiAqIHN0 YXR1cykKICAgICAgICAgewogICAgICAgICAgIHByaW50X2ZpbGVuYW1lICgpOwotICAgICAg ICAgIGZwdXRjICgnXG4nICYgZmlsZW5hbWVfbWFzaywgc3Rkb3V0KTsKKyAgICAgICAgICBw dXRjaGFyX2Vycm5vICgnXG4nICYgZmlsZW5hbWVfbWFzayk7CiAgICAgICAgICAgaWYgKGxp bmVfYnVmZmVyZWQpCi0gICAgICAgICAgICBmZmx1c2ggKHN0ZG91dCk7CisgICAgICAgICAg ICBmZmx1c2hfZXJybm8gKCk7CiAgICAgICAgIH0KIAogICAgICAgaWYgKGRlc2MgPT0gU1RE SU5fRklMRU5PKQpkaWZmIC0tZ2l0IGEvdGVzdHMvTWFrZWZpbGUuYW0gYi90ZXN0cy9NYWtl ZmlsZS5hbQppbmRleCA1YTJjMGYwLi4wMzI2ZmY0IDEwMDY0NAotLS0gYS90ZXN0cy9NYWtl ZmlsZS5hbQorKysgYi90ZXN0cy9NYWtlZmlsZS5hbQpAQCAtMTQxLDYgKzE0MSw3IEBAIFRF U1RTID0JCQkJCQlcCiAgIHdvcmQtZGVsaW0tbXVsdGlieXRlCQkJCVwKICAgd29yZC1tdWx0 aS1maWxlCQkJCVwKICAgd29yZC1tdWx0aWJ5dGUJCQkJXAorICB3cml0ZS1lcnJvci1tc2cJ CQkJXAogICB5ZXNubwkJCQkJCVwKICAgei1hbmNob3ItbmV3bGluZQogCmRpZmYgLS1naXQg YS90ZXN0cy93cml0ZS1lcnJvci1tc2cgYi90ZXN0cy93cml0ZS1lcnJvci1tc2cKbmV3IGZp bGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAwMC4uMTMwNjQ4YgotLS0gL2Rldi9udWxsCisr KyBiL3Rlc3RzL3dyaXRlLWVycm9yLW1zZwpAQCAtMCwwICsxLDU1IEBACisjIS9iaW4vc2gK KyMgRW5zdXJlIHRoYXQgb3V0cHV0IGVycm9ycyBhcmUgcmVwb3J0ZWQgd2l0aCBlcnJubyBp bmZvcm1hdGlvbi4KKworIyBDb3B5cmlnaHQgMjAxNiBGcmVlIFNvZnR3YXJlIEZvdW5kYXRp b24sIEluYy4KKworIyBUaGlzIHByb2dyYW0gaXMgZnJlZSBzb2Z0d2FyZTogeW91IGNhbiBy ZWRpc3RyaWJ1dGUgaXQgYW5kL29yIG1vZGlmeQorIyBpdCB1bmRlciB0aGUgdGVybXMgb2Yg dGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieQorIyB0aGUg RnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBlaXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNl bnNlLCBvcgorIyAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorCisjIFRo aXMgcHJvZ3JhbSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUg dXNlZnVsLAorIyBidXQgV0lUSE9VVCBBTlkgV0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUg aW1wbGllZCB3YXJyYW50eSBvZgorIyBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1Ig QSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCisjIEdOVSBHZW5lcmFsIFB1YmxpYyBM aWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisKKyMgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVk IGEgY29weSBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UKKyMgYWxvbmcgd2l0 aCB0aGlzIHByb2dyYW0uICBJZiBub3QsIHNlZSA8aHR0cDovL3d3dy5nbnUub3JnL2xpY2Vu c2VzLz4uCisKKy4gIiR7c3JjZGlyPS59L2luaXQuc2giOyBwYXRoX3ByZXBlbmRfIC4uL3Ny YwordGVzdCAtZSAvZGV2L2Z1bGwgfHwgc2tpcF8geW91ciBzeXN0ZW0gbGFja3MgL2Rldi9m dWxsCisKK2V4cG9ydCBMQ19BTEw9QworCisjIGdlbmVyYXRlIGxhcmdlIGlucHV0LCBmaWxs aW5nIHRoZSBsaWJjIHN0ZGlvIGJ1ZmZlcnMKKyMgYW5kIHRyaWdnZXJpbmcgYSB3cml0ZSgy KSBldmVuIHdpdGhvdXQgbGluZSBidWZmZXJpbmcuCit5ZXMgMTIzNDUgfCBoZWFkIC1uIDUw MDAwID4gaW4gfHwgZnJhbWV3b3JrX2ZhaWx1cmVfCisKK2ZhaWw9MAorCisjIGRpc2stZnVs bCBlcnJvciwgbGluZSBidWZmZXJlZAorIyAobm90ZTogR05VIGdyZXAgcmV0dXJucyAyIG9u IGVycm9yKQorcmV0dXJuc18gMiBncmVwIC0tbGluZS1idWZmZXJlZCAtdiAnXiQnIDxpbiA+ L2Rldi9mdWxsIDI+ZXJyMSBcCisgICAgfHwgZnJhbWV3b3JrX2ZhaWx1cmVfCisKKyMgZGlz ay1mdWxsIGVycm9yLCB1bmJ1ZmZlcmVkCisjIChub3RlOiBHTlUgZ3JlcCByZXR1cm5zIDIg b24gZXJyb3IpCityZXR1cm5zXyAyIGdyZXAgLXYgJ14kJyA8aW4gPi9kZXYvZnVsbCAyPmVy cjIgXAorICAgIHx8IGZyYW1ld29ya19mYWlsdXJlXworCisjIGVuc3VyZSBlYWNoIGVycm9y IG1lc3NhZ2UgZmlsZSBjb250YWlucyBhICd3cml0ZSBlcnJvcicgd2l0aCBhZGRpdGlvbmFs IHRleHQKK2ZvciBmIGluIGVycjEgZXJyMiA7CitkbworICAgIGdyZXAgLUVpcSAnXmdyZXA6 IHdyaXRlIGVycm9yOiBbYS16XSsnICRmIFwKKyAgICAgICAgfHwgeworICAgICAgICAgICAg IHdhcm5fICJpbmNvcnJlY3QvbWlzc2luZyBlcnJvciBtZXNzYWdlIGluIGZpbGUgJGYiCisg ICAgICAgICAgICAgY29tcGFyZSAvZGV2L251bGwgJGYgICAjIHByaW50IHRoZSBjb250ZW50 IGluIHRoZSBsb2dzCisgICAgICAgICAgICAgZmFpbD0xCisgICAgICAgICAgIH0KK2RvbmUK KworIyBUaGVzZSBtZXNzYWdlcyBzaG91bGQgYmUgaWRlbnRpY2FsCitjb21wYXJlIGVycjEg ZXJyMiBcCisgICAgfHwgeyB3YXJuXyAiZXJyMSxlcnIyIGNvbnRhaW4gZGlmZmVyZW50IGVy cm9yIG1lc3NhZ2VzIiA7IGZhaWw9MSA7IH0KKworRXhpdCAkZmFpbAotLSAKMi41LjAKCg== --------------050502040501040505080209-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 18 13:29:52 2016 Received: (at 23031-done) by debbugs.gnu.org; 18 Mar 2016 17:29:52 +0000 Received: from localhost ([127.0.0.1]:52898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agyDg-0006gY-4u for submit@debbugs.gnu.org; Fri, 18 Mar 2016 13:29:52 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:33254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agyDe-0006gJ-3k for 23031-done@debbugs.gnu.org; Fri, 18 Mar 2016 13:29:50 -0400 Received: by mail-qg0-f51.google.com with SMTP id a36so74168267qge.0 for <23031-done@debbugs.gnu.org>; Fri, 18 Mar 2016 10:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=xN58uT1dFK6Jm04vb2YS75+W8AVR6l4JBH9tmXYzM0M=; b=ENIq7Sw+eypluUPLsSorXaw0BOsOlsi3fKKWQGCNyUdx3UL9usG5HGcIbJVZ9Pe/uY QO9LuxpYL3oOl+I5vNJoBlVXIh8ubtDnR4x7wPklRjh/zgHPvV636vKGK4IBhdDjl5GO AW3bU1hwLfkxbg1evW4GdtXcSqX9BakxnnKdlZVafxC1AsfFcYM0rQDSUwjzSrvD+sx/ 5CmnkfmqZFTJdzj6+84fJgVUfXkK+ZqbwxKDVDzKfNtIfRMgQ2QlWwJaCwhT1cIR/+qU J+DbKmUJNw9+c1VsCvxL58rEvlnev9aNfj8ISUJBzfaa/1BWJ8aCrUC05mZx1f5e3+1G QGgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=xN58uT1dFK6Jm04vb2YS75+W8AVR6l4JBH9tmXYzM0M=; b=T9CvGEXG8WYUf7qRV8D4uZg07Itsfr3kPw10+1u+Yi2E9t3mAzUeuAvzENx8ywa/qH KHTcB8o6Y4w58K0NuAOI33fae65DJ6iPb0/C+0NYg7jFbHbwqUtUG5DknDq/5VNhnT82 HRaKuVxRIEjhVGC/W8PaQUk+Gtsa0xzVXV9ZBxE8ZcoFUkuwPAhwZONnsbgJgmHjTPHx T09y8rYe5HawPEeP+3npn+lXjOj//aq8bfC3lQx7tAPD0gj5elERcwaj+ZKWQ8ahy2X6 zt4t9KV7iik6BNkgxPV4bR7qp0ElZ7OYnVtEESV4B0Sl5lhEWxF7tu7yF0TQWYIVdARO 6VlA== X-Gm-Message-State: AD7BkJLDyVhroy/3QSIRWyyY9hg8jSHMyQrEJmM9BkYp8EQDn0Us+ZL/Sg0WUh3gzwK/Nw== X-Received: by 10.140.224.18 with SMTP id u18mr25408744qhb.10.1458322184607; Fri, 18 Mar 2016 10:29:44 -0700 (PDT) Received: from disco.erlich.nygenome.org ([69.74.14.178]) by smtp.googlemail.com with ESMTPSA id 7sm6396182qhx.24.2016.03.18.10.29.43 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 18 Mar 2016 10:29:43 -0700 (PDT) Subject: Re: bug#23031: reporting write errors and handling SIGPIPE To: Paul Eggert , 23031-done@debbugs.gnu.org References: <56E98668.5050500@gmail.com> <56EAFC24.8010108@cs.ucla.edu> From: Assaf Gordon Message-ID: <56EC3B2F.7020409@gmail.com> Date: Fri, 18 Mar 2016 13:30:23 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56EAFC24.8010108@cs.ucla.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23031-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hello, On 03/17/2016 02:49 PM, Paul Eggert wrote: > On 03/16/2016 09:14 AM, Assaf Gordon wrote: >> Attached is a patch that adds errno information to 'write error' messages > > Thanks, I installed the attached somewhat-tweaked version of that. Among other things I renamed the new static functions to avoid confusion with existing "safer" functions. > > This doesn't address the SIGPIPE mystery so I'll leave the bug report open, but my guess is that this part isn't really a grep bug. Thanks for the inclusion and the additional information. This is indeed not a bug in grep (and thus closed). I found that on my weird setup, programs start with SIGPIPE set to SIG_IGN by default (not sure how I got myself into such situation). regards, - assaf From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 18 14:18:13 2016 Received: (at 23031) by debbugs.gnu.org; 18 Mar 2016 18:18:13 +0000 Received: from localhost ([127.0.0.1]:52939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agyyT-0007v4-Kc for submit@debbugs.gnu.org; Fri, 18 Mar 2016 14:18:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agyyS-0007uo-19 for 23031@debbugs.gnu.org; Fri, 18 Mar 2016 14:18:12 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 5832A83F45; Fri, 18 Mar 2016 18:18:06 +0000 (UTC) Received: from [10.3.113.69] (ovpn-113-69.phx2.redhat.com [10.3.113.69]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2III51O000329; Fri, 18 Mar 2016 14:18:05 -0400 Subject: Re: bug#23031: reporting write errors and handling SIGPIPE To: 23031@debbugs.gnu.org, assafgordon@gmail.com References: <56E98668.5050500@gmail.com> <56EAFC24.8010108@cs.ucla.edu> <56EC3B2F.7020409@gmail.com> From: Eric Blake Openpgp: url=http://people.redhat.com/eblake/eblake.gpg Organization: Red Hat, Inc. Message-ID: <56EC465D.6020305@redhat.com> Date: Fri, 18 Mar 2016 12:18:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56EC3B2F.7020409@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FFaCmLxRGIBM6ScIrOiBjmT5HFrlrhPIO" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 23031 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FFaCmLxRGIBM6ScIrOiBjmT5HFrlrhPIO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/18/2016 11:30 AM, Assaf Gordon wrote: > I found that on my weird setup, programs start with SIGPIPE set to > SIG_IGN by default (not sure how I got myself into such situation). There have been various automated robot testsuite runners (such as Jenkins at one point in the past, although I don't know if it is still the case) that do the equivalent of 'trap - PIPE' in their master shell; then the rules of POSIX say that 'sh' can't do anything to undo that setting (it's very annoying - inheriting ignored SIGPIPE is impossible to undo in straight shell, and requires an intermediary C program). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FFaCmLxRGIBM6ScIrOiBjmT5HFrlrhPIO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJW7EZdAAoJEKeha0olJ0Nqrp0IAJfiLMrLEVSyye34s+26V1jL ITgG6ktpQgLTuOOqMv8q9wb7340vVOULEuiJHfB2nnf2xYqP7yJZa9fZDGOoVdIi BSC+K1FdxGeJWXsCppJnc3IGqsXRy06TlrDEgqOoaCg7npBD3jgK4hbPIOkvHSt6 lG7V48a4/Do6fJNsU5FeGQotO1ZL+CA97vBDGBnGmy9tPhfrt3dMED2UsgPV/0ok Qgx1qH/u8aRnpqcxvuZqh0nvAHzVfpR92j4cU4WL0kIdlOwpihHq/ZRBeLfYyce5 g471Shx+V0nrQo921COMMAfYWRoS0gdxDqkbEOppwjDrvzZCxVtJ8hr92N46jk0= =3wMr -----END PGP SIGNATURE----- --FFaCmLxRGIBM6ScIrOiBjmT5HFrlrhPIO-- From unknown Sat Sep 13 13:15:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 16 Apr 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator