GNU bug report logs - #23007
24.5; buggy interactive search with middle click

Previous Next

Package: emacs;

Reported by: Vincent Lefevre <vincent <at> vinc17.net>

Date: Mon, 14 Mar 2016 03:11:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 24.5

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

Message #19 received at 23007 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Vincent Lefevre <vincent <at> vinc17.net>, Alex <agrambot <at> gmail.com>,
 23007 <at> debbugs.gnu.org
Subject: Re: bug#23007: 24.5; buggy interactive search with middle click
Date: Mon, 29 May 2017 20:53:24 -0400

Drew Adams <drew.adams <at> oracle.com> writes:

>> > +      (let ((overriding-terminal-local-map nil))
>> > +        (setq binding (key-binding (this-command-keys-vector) t)))
>> 
>> IMO, it would be better style to do something like
>> 
>> (let ((binding (let ((overriding-terminal-local-map nil))
>>                  (key-binding (this-command-keys-vector) t))))
>>   ...)
>  
> (let* ((overriding-terminal-local-map nil)
>        (binding (key-binding (this-command-keys-vector) t)))
>   ...)

Check https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23007#8, we need to
avoid binding `overriding-terminal-local-map' in "...".
This bug report was last modified 8 years and 42 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.