GNU bug report logs - #23007
24.5; buggy interactive search with middle click

Previous Next

Package: emacs;

Reported by: Vincent Lefevre <vincent <at> vinc17.net>

Date: Mon, 14 Mar 2016 03:11:02 UTC

Severity: normal

Tags: fixed, patch

Found in version 24.5

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Drew Adams <drew.adams <at> oracle.com>
To: npostavs <at> users.sourceforge.net, Alex <agrambot <at> gmail.com>
Cc: Vincent Lefevre <vincent <at> vinc17.net>, 23007 <at> debbugs.gnu.org
Subject: bug#23007: 24.5; buggy interactive search with middle click
Date: Mon, 29 May 2017 17:41:43 -0700 (PDT)

> > +      (let ((overriding-terminal-local-map nil))
> > +        (setq binding (key-binding (this-command-keys-vector) t)))
> 
> IMO, it would be better style to do something like
> 
> (let ((binding (let ((overriding-terminal-local-map nil))
>                  (key-binding (this-command-keys-vector) t))))
>   ...)
 
(let* ((overriding-terminal-local-map nil)
       (binding (key-binding (this-command-keys-vector) t)))
  ...)

;-)
This bug report was last modified 7 years and 358 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.