GNU bug report logs - #22996
[PATCH] Use directory_files_internal_unwind() in directory_files_internal ()

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alexander Kuleshov <kuleshovmail <at> gmail.com>
Subject: bug#22996: closed (Re: [PATCH] Use directory_files_internal_unwind()
 in directory_files_internal ())
Date: Sun, 20 Mar 2016 01:49:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#22996: [PATCH] Use directory_files_internal_unwind() in directory_files_internal ()

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 22996 <at> debbugs.gnu.org.

-- 
22996: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22996
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Alexander Kuleshov <kuleshovmail <at> gmail.com>
Cc: 22996-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Use directory_files_internal_unwind() in
 directory_files_internal ()
Date: Sat, 19 Mar 2016 18:47:47 -0700

[Message part 3 (text/plain, inline)]

Thanks for pointing out the code infelicity. I installed the attached, which 
cleans it up in a more-general way.

[0001-No-need-to-block-input-when-reading-directories.txt (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Alexander Kuleshov <kuleshovmail <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Alexander Kuleshov <kuleshovmail <at> gmail.com>
Subject: [PATCH] Use directory_files_internal_unwind() in
 directory_files_internal ()
Date: Sat, 12 Mar 2016 19:49:37 +0600

src/dired.c (directory_files_internal): use directory_files_internal_unwind()
to prevent code duplication.
---
 src/dired.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/dired.c b/src/dired.c
index ebc7029..b5b6af6 100644
--- a/src/dired.c
+++ b/src/dired.c
@@ -307,9 +307,7 @@ directory_files_internal (Lisp_Object directory, Lisp_Object full,
 	}
     }
 
-  block_input ();
-  closedir (d);
-  unblock_input ();
+  directory_files_internal_unwind ((void*) d);
 #ifdef WINDOWSNT
   if (attrs)
     Vw32_get_true_file_attributes = w32_save;
-- 
2.8.0.rc0.61.g9f22707

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.