GNU bug report logs - #22991
25.0.92: C-u C-s does not display "Regexp I-search:" in the echo area

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#22991: closed (25.0.92: C-u C-s does not display "Regexp
 I-search:" in the echo area)
Date: Mon, 14 Mar 2016 18:19:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 14 Mar 2016 20:17:38 +0200
with message-id <83d1qwdiv1.fsf <at> gnu.org>
and subject line Re: bug#22991: 25.0.92: C-u C-s does not display "Regexp I-search:" in the echo area
has caused the debbugs.gnu.org bug report #22991,
regarding 25.0.92: C-u C-s does not display "Regexp I-search:" in the echo area
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
22991: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22991
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>,
 Artur Malabarba <arturmalabarba <at> gmail.com>
Subject: 25.0.92: C-u C-s does not display "Regexp I-search:" in the echo area
Date: Fri, 11 Mar 2016 14:48:29 -0500

[Message part 3 (text/plain, inline)]

Tested in the latest emacs-25 build as of today.

emacs -Q
C-u C-s

The echo area will show "I-search:".
Earlier it used to show "Regexp I-search:" and that made it clear that we
are doing regexp search.

This change happened after this revert:
http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-25&id=b417c5a3b35bf31e66a170529c5aeb34cb3318d0

So it looks like that isearch-message-prefix was bound to
search-default-mode being non-nil.

I verified that "C-u C-s" shows "Regexp I-search:" fine in emacs 24.5. But
that version did not have the search-default-mode.

I believe that the clarity of regexp isearch being on/off is missing,
especially when C-u C-s DOES do regexp search and still displays "I-search:
" in the echo.

If I set search-default-mode back to "#'character-fold-to-regexp", this
issue is gone. So displaying of "Regexp I-search:" should be decoupled from
the character-fold.el library.

--
Kaushal Modi

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: bruce.connor.am <at> gmail.com
Cc: 22991-done <at> debbugs.gnu.org, Kaushal <kaushal.modi <at> gmail.com>
Subject: Re: bug#22991: 25.0.92: C-u C-s does not display "Regexp I-search:"
 in the echo area
Date: Mon, 14 Mar 2016 20:17:38 +0200

> Date: Mon, 14 Mar 2016 13:29:24 -0300
> From: Artur Malabarba <bruce.connor.am <at> gmail.com>
> Cc: 22991 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>, 
> 	Michael Heerdegen <michael_heerdegen <at> web.de>, Juri Linkov <juri <at> linkov.net>, Eli Zaretskii <eliz <at> gnu.org>
> 
> I can't push for the time being, but I agree with the patch. 
> 
> Eli, if you agree with it too, could you push it? 

Pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.