GNU bug report logs - #22978
25.0.92; log-view-diff: TMM required for non-consecutive revisions

Previous Next

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> gmail.com>
To: Bob Rogers <rogers <at> modulargenetics.com>
Cc: 22978 <at> debbugs.gnu.org
Subject: bug#22978: 25.0.92; log-view-diff:  TMM required for non-consecutive revisions
Date: Wed, 20 Jun 2018 00:00:25 -0400

Bob Rogers <rogers <at> modulargenetics.com> writes:

>    The documentation for log-view-diff implies that this is the correct
> behavior (since the region is perpetually inactive if TMM is disabled),
> but this is extremely non-featureful, as there is then no way to find
> the diff between two non-consecutive revisions without enabling TMM.

You can still use C-SPC C-SPC to activate the mark temporarily.

> The patch included at the bottom restores the original behavior for us
> non-TMM users while keeping TMM behavior.

Not sure if it makes sense to change this.

> --- /usr/share/emacs/25.0.92/lisp/vc/log-view.el.gz
> +++ #<buffer log-view.el.gz>
> @@ -591,7 +591,9 @@
>  file(s)."
>    (interactive
>     (list (if (use-region-p) (region-beginning) (point))
> -         (if (use-region-p) (region-end) (point))))
> +         (if (use-region-p)
> +	     (region-end)
> +	     (or (and (not transient-mark-mode) (mark)) (point)))))
>    (log-view-diff-common beg end))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.