From unknown Fri Jun 20 07:11:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#22957 <22957@debbugs.gnu.org> To: bug#22957 <22957@debbugs.gnu.org> Subject: Status: C-u C-x = prints garbage for a text property with value '(string . ?") Reply-To: bug#22957 <22957@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:11:36 +0000 retitle 22957 C-u C-x =3D prints garbage for a text property with value '(s= tring . ?") reassign 22957 emacs submitter 22957 Alan Mackenzie severity 22957 normal tag 22957 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 00:52:19 2016 Received: (at submit) by debbugs.gnu.org; 9 Mar 2016 05:52:19 +0000 Received: from localhost ([127.0.0.1]:40386 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adX2h-0007m8-52 for submit@debbugs.gnu.org; Wed, 09 Mar 2016 00:52:19 -0500 Received: from eggs.gnu.org ([208.118.235.92]:36223) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adX2f-0007lu-QJ for submit@debbugs.gnu.org; Wed, 09 Mar 2016 00:52:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adX2a-0001K0-17 for submit@debbugs.gnu.org; Wed, 09 Mar 2016 00:52:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,GAPPY_SUBJECT autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adX2Z-0001Jl-UJ for submit@debbugs.gnu.org; Wed, 09 Mar 2016 00:52:11 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adX2Z-00023p-1a for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 00:52:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adX2V-0001Ip-Mc for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 00:52:10 -0500 Received: from mail.muc.de ([193.149.48.3]:59144) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adX2V-0001Ie-DC for bug-gnu-emacs@gnu.org; Wed, 09 Mar 2016 00:52:07 -0500 Received: (qmail 23135 invoked by uid 3782); 9 Mar 2016 05:52:05 -0000 Received: from acm.muc.de (p548A46A1.dip0.t-ipconnect.de [84.138.70.161]) by colin.muc.de (tmda-ofmipd) with ESMTP; Wed, 09 Mar 2016 06:52:04 +0100 Received: (qmail 2550 invoked by uid 1000); 9 Mar 2016 05:54:41 -0000 Date: Wed, 9 Mar 2016 05:54:41 +0000 To: bug-gnu-emacs@gnu.org Subject: C-u C-x = prints garbage for a text property with value '(string . ?") Message-ID: <20160309055441.GA2490@acm.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.1 (---) Hello, Emacs. In the master branch: emacs -Q . In the *scratch* buffer, with point at any character, do: M-: (put-text-property (point) (1+ (point)) 'asdf '(string . ?\")) . Without moving point, C-u C-x = . There appears in the *Help* buffer the following: There are text properties here: asdf string (widget)Top face font-lock-comment-face fontified t . The entry for "asdf" is garbage. It should show the actual value of the text property just set, not "string (widget)Top". The same thing happens in Emacs 24.5 (and presumably the emacs-25 branch). ######################################################################### Initial investigation: The symbol 'string has a 'widget-type property. Without validating the structure (or lack thereof) of the assumed widget value, `describe-property-list' attempts to enter the "widget browser" rather than printing the full value of the 'asdf text property. -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 29 09:09:20 2019 Received: (at 22957) by debbugs.gnu.org; 29 Jul 2019 13:09:20 +0000 Received: from localhost ([127.0.0.1]:47816 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hs5Oy-0007ov-8q for submit@debbugs.gnu.org; Mon, 29 Jul 2019 09:09:20 -0400 Received: from quimby.gnus.org ([80.91.231.51]:43148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hs5Ot-0007oa-Ad for 22957@debbugs.gnu.org; Mon, 29 Jul 2019 09:09:16 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hs5Oo-0002AL-SX; Mon, 29 Jul 2019 15:09:13 +0200 From: Lars Ingebrigtsen To: Alan Mackenzie Subject: Re: bug#22957: C-u C-x = prints garbage for a text property with value '(string . ?") References: <20160309055441.GA2490@acm.fritz.box> Date: Mon, 29 Jul 2019 15:09:10 +0200 In-Reply-To: <20160309055441.GA2490@acm.fritz.box> (Alan Mackenzie's message of "Wed, 9 Mar 2016 05:54:41 +0000") Message-ID: <87lfwh7zt5.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alan Mackenzie writes: > Hello, Emacs. > > In the master branch: > emacs -Q > . > In the *scratch* buffer, with point at any character, do: > > M-: (put-text-property (point) (1+ (point)) 'asdf '(string . ?\")) > > . Withou [...] Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 2.0 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 22957 Cc: 22957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Alan Mackenzie writes: > Hello, Emacs. > > In the master branch: > emacs -Q > . > In the *scratch* buffer, with point at any character, do: > > M-: (put-text-property (point) (1+ (point)) 'asdf '(string . ?\")) > > . Without moving point, > > C-u C-x = > > . There appears in the *Help* buffer the following: > > There are text properties here: > asdf string (widget)Top > face font-lock-comment-face > fontified t > > . The entry for "asdf" is garbage. It should show the actual value of > the text property just set, not "string (widget)Top". The same thing > happens in Emacs 24.5 (and presumably the emacs-25 branch). Indeed. > Initial investigation: > > The symbol 'string has a 'widget-type property. Without validating the > structure (or lack thereof) of the assumed widget value, > `describe-property-list' attempts to enter the "widget browser" rather > than printing the full value of the 'asdf text property. `describe-property-list' is a very general-sounding function, and doesn't mention anything about widgets, so having it do widget stuff is rather surprising. The only callers to this function are from descr-text and as far as I can tell, none of them are widget-ey. Looking at the commit log, it looks like there was a bunch of widget stuff in here before, but it's been removed. Perhaps this was just forgotten? The following trivial patch fixes the problem. Any opinions? diff --git a/lisp/descr-text.el b/lisp/descr-text.el index 8be2b94458..ba53aeb385 100644 --- a/lisp/descr-text.el +++ b/lisp/descr-text.el @@ -88,8 +88,6 @@ describe-property-list (insert-text-button (format "%S" value) 'type 'help-face 'help-args (list value))) - ((widgetp value) - (describe-text-widget value)) (t (describe-text-sexp value)))) (insert "\n"))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 29 09:09:24 2019 Received: (at control) by debbugs.gnu.org; 29 Jul 2019 13:09:25 +0000 Received: from localhost ([127.0.0.1]:47818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hs5P2-0007p6-KU for submit@debbugs.gnu.org; Mon, 29 Jul 2019 09:09:24 -0400 Received: from quimby.gnus.org ([80.91.231.51]:43162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hs5Ox-0007oo-F8 for control@debbugs.gnu.org; Mon, 29 Jul 2019 09:09:20 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hs5Ou-0002AT-UR for control@debbugs.gnu.org; Mon, 29 Jul 2019 15:09:18 +0200 Date: Mon, 29 Jul 2019 15:09:16 +0200 Message-Id: <87k1c17zsz.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22957 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 22957 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 22957 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 05:46:03 2019 Received: (at 22957) by debbugs.gnu.org; 30 Jul 2019 09:46:03 +0000 Received: from localhost ([127.0.0.1]:49557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsOhm-0007dy-Ka for submit@debbugs.gnu.org; Tue, 30 Jul 2019 05:46:03 -0400 Received: from colin.muc.de ([193.149.48.1]:24123 helo=mail.muc.de) by debbugs.gnu.org with smtp (Exim 4.84_2) (envelope-from ) id 1hsOhk-0007Zq-1g for 22957@debbugs.gnu.org; Tue, 30 Jul 2019 05:46:00 -0400 Received: (qmail 84033 invoked by uid 3782); 30 Jul 2019 08:53:27 -0000 Received: from acm.muc.de (p4FE15868.dip0.t-ipconnect.de [79.225.88.104]) by colin.muc.de (tmda-ofmipd) with ESMTP; Tue, 30 Jul 2019 10:53:26 +0200 Received: (qmail 5490 invoked by uid 1000); 30 Jul 2019 09:45:56 -0000 Date: Tue, 30 Jul 2019 09:45:56 +0000 To: Lars Ingebrigtsen Subject: Re: bug#22957: C-u C-x = prints garbage for a text property with value '(string . ?") Message-ID: <20190730094556.GB5427@ACM> References: <20160309055441.GA2490@acm.fritz.box> <87lfwh7zt5.fsf@mouse.gnus.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lfwh7zt5.fsf@mouse.gnus.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 22957 Cc: 22957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Hello, Lars. On Mon, Jul 29, 2019 at 15:09:10 +0200, Lars Ingebrigtsen wrote: > Alan Mackenzie writes: > > Hello, Emacs. > > In the master branch: > > emacs -Q > > . > > In the *scratch* buffer, with point at any character, do: > > M-: (put-text-property (point) (1+ (point)) 'asdf '(string . ?\")) > > . Without moving point, > > C-u C-x = > > . There appears in the *Help* buffer the following: > > There are text properties here: > > asdf string (widget)Top > > face font-lock-comment-face > > fontified t > > . The entry for "asdf" is garbage. It should show the actual value of > > the text property just set, not "string (widget)Top". The same thing > > happens in Emacs 24.5 (and presumably the emacs-25 branch). > Indeed. > > Initial investigation: > > The symbol 'string has a 'widget-type property. Without validating the > > structure (or lack thereof) of the assumed widget value, > > `describe-property-list' attempts to enter the "widget browser" rather > > than printing the full value of the 'asdf text property. > `describe-property-list' is a very general-sounding function, and > doesn't mention anything about widgets, so having it do widget stuff is > rather surprising. > The only callers to this function are from descr-text and as far as I > can tell, none of them are widget-ey. Looking at the commit log, it > looks like there was a bunch of widget stuff in here before, but it's > been removed. Perhaps this was just forgotten? > The following trivial patch fixes the problem. Any opinions? It does indeed fix the problem. I haven't tracked down anything in the commit log, but I can believe there's no widget stuff left to drive that cond arm. And even if there were, it would only be a corner case (like the original bug scenario was). I feel only a slight unease at removing that cond arm, which would no doubt dissipate if I took more time to look at it again. So, I would agree with you: apply the patch and close the bug. :-) > diff --git a/lisp/descr-text.el b/lisp/descr-text.el > index 8be2b94458..ba53aeb385 100644 > --- a/lisp/descr-text.el > +++ b/lisp/descr-text.el > @@ -88,8 +88,6 @@ describe-property-list > (insert-text-button > (format "%S" value) > 'type 'help-face 'help-args (list value))) > - ((widgetp value) > - (describe-text-widget value)) > (t > (describe-text-sexp value)))) > (insert "\n"))) > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 06:10:43 2019 Received: (at 22957) by debbugs.gnu.org; 30 Jul 2019 10:10:43 +0000 Received: from localhost ([127.0.0.1]:49588 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsP5f-0000wQ-DH for submit@debbugs.gnu.org; Tue, 30 Jul 2019 06:10:43 -0400 Received: from quimby.gnus.org ([80.91.231.51]:58806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsP5d-0000wE-5I for 22957@debbugs.gnu.org; Tue, 30 Jul 2019 06:10:42 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsP5Z-0006cW-Qw; Tue, 30 Jul 2019 12:10:40 +0200 From: Lars Ingebrigtsen To: Alan Mackenzie Subject: Re: bug#22957: C-u C-x = prints garbage for a text property with value '(string . ?") References: <20160309055441.GA2490@acm.fritz.box> <87lfwh7zt5.fsf@mouse.gnus.org> <20190730094556.GB5427@ACM> Date: Tue, 30 Jul 2019 12:10:37 +0200 In-Reply-To: <20190730094556.GB5427@ACM> (Alan Mackenzie's message of "Tue, 30 Jul 2019 09:45:56 +0000") Message-ID: <87a7cvvnmq.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Alan Mackenzie writes: > So, I would agree with you: apply the patch and close the bug. :-) OK; done. I tried following the logic of the code in descr-text, and I think it's the right fix. There may be code paths I've overlooked, though, but I guess we'll find out later. Content analysis details: (-0.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 2.0 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 22957 Cc: 22957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Alan Mackenzie writes: > So, I would agree with you: apply the patch and close the bug. :-) OK; done. I tried following the logic of the code in descr-text, and I think it's the right fix. There may be code paths I've overlooked, though, but I guess we'll find out later. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 06:10:49 2019 Received: (at control) by debbugs.gnu.org; 30 Jul 2019 10:10:49 +0000 Received: from localhost ([127.0.0.1]:49591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsP5k-0000wj-Ny for submit@debbugs.gnu.org; Tue, 30 Jul 2019 06:10:48 -0400 Received: from quimby.gnus.org ([80.91.231.51]:58820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsP5j-0000wb-8V for control@debbugs.gnu.org; Tue, 30 Jul 2019 06:10:47 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsP5g-0006ce-MM for control@debbugs.gnu.org; Tue, 30 Jul 2019 12:10:46 +0200 Date: Tue, 30 Jul 2019 12:10:44 +0200 Message-Id: <878ssfvnmj.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22957 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 22957 fixed close 22957 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 22957 fixed close 22957 27.1 quit From unknown Fri Jun 20 07:11:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 27 Aug 2019 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator