From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 06 22:36:44 2016 Received: (at submit) by debbugs.gnu.org; 7 Mar 2016 03:36:44 +0000 Received: from localhost ([127.0.0.1]:37218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aclyO-0001vr-Iz for submit@debbugs.gnu.org; Sun, 06 Mar 2016 22:36:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:34128) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aclyM-0001ve-P7 for submit@debbugs.gnu.org; Sun, 06 Mar 2016 22:36:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aclyG-0004SS-ME for submit@debbugs.gnu.org; Sun, 06 Mar 2016 22:36:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aclyG-0004SM-JM for submit@debbugs.gnu.org; Sun, 06 Mar 2016 22:36:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aclyF-0003cF-N2 for bug-coreutils@gnu.org; Sun, 06 Mar 2016 22:36:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aclyE-0004Rz-Mp for bug-coreutils@gnu.org; Sun, 06 Mar 2016 22:36:35 -0500 Received: from mail-ob0-x22a.google.com ([2607:f8b0:4003:c01::22a]:33318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aclyE-0004Rv-Ho for bug-coreutils@gnu.org; Sun, 06 Mar 2016 22:36:34 -0500 Received: by mail-ob0-x22a.google.com with SMTP id fz5so95259204obc.0 for ; Sun, 06 Mar 2016 19:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to; bh=XFQzcHxRIojYSOhpOCmFMVFVCT0rtzTLqfN+BQhzdcE=; b=FJh3l+ackIvXvN+MDe2ddjYsQ0XI9DO0lJQe5Iug/zs8Npa5dwWVP297rfw8PL0nyb nTtkuRiT6IEDZzrZFC5ISLVhtukykXv+6tN63zG4SnoPCPu8QCeQ+svaqYWeizN2kv9a aQC4/xFyNCz20HQ/YxKK92JbHko2oUMrNVSJjnYYwrHFR0NXVxjYjD+6ccKIQg9lEFAy CDpGOfsN6L5eq0oGJYfp/OyfFYVbOxGssy+59Vfyoo//9DRz8fCY1lpbwqH8DlyogTrE 1zEfGusWl7otTQBx66rnk3e5XEzMm3+pkQBrRCbsVJdNpM+mkPtYiWuvKzrp0NXKUnV9 1yYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=XFQzcHxRIojYSOhpOCmFMVFVCT0rtzTLqfN+BQhzdcE=; b=dac8c4AkOtD2VdN5+2jAiwk3uK1p7S1d0C9/bEOkYAFT0peP7/QV1vw4EMhCQveUM5 WnaKZjFg5RRMgUfXsEyoxMZx2E2RRgsZDdgdKxdG31YD6GW68tuJF/xNWj9hocXu49Y7 QppD9VxFte8a4mhH6UjCyDD7MmL6Nfy0gxiEmZ6U9b28dyzA3OW11NqMsMmq8fqI8XDA /Aj05wsaDtXZ4zL23wVVD99ED+6YVg4n+XmLK5TnoCWnlrq8KmINe4eDi+17pxeq2zNQ HIklOOnVmgfnckpIT1hPxa3SPBUPhy2fqMdpeqzealvtep2ORzNDvN4u9da0a9gDmEoG Yaog== X-Gm-Message-State: AD7BkJKuqzZnEcxOeN03t3TEnMD7fdAGBaExR4An0Z4CsmNtYFM24O2p0i97PtviKe8XJq7IBVfFC37Mpwxo3g== X-Received: by 10.182.158.197 with SMTP id ww5mr1340237obb.71.1457321793595; Sun, 06 Mar 2016 19:36:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.82.194 with HTTP; Sun, 6 Mar 2016 19:36:13 -0800 (PST) From: Jim Meyering Date: Sun, 6 Mar 2016 19:36:13 -0800 X-Google-Sender-Auth: FLeu6B4vh4KFDFqVni56IR46TDg Message-ID: Subject: tests/split/filter.sh fails on an XFS file system To: bug-coreutils@gnu.org Content-Type: multipart/mixed; boundary=089e0149c28ed57d3b052d6d2bd7 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) --089e0149c28ed57d3b052d6d2bd7 Content-Type: text/plain; charset=UTF-8 The split/filter.sh test would fail like this: $ make check TESTS=tests/split/filter.sh VERBOSE=yes SUBDIRS=. + truncate -s9223372036854775807 zero.in + timeout 10 sh -c 'split --filter="head -c1 >/dev/null" -n 1 zero.in' split: zero.in: cannot determine file size: Value too large for defined data type That value is 2^63-1 (nearly 8 exabytes), and split.c explicitly handles a file of that size, because that is the size reported for /dev/zero on GNU/Hurd systems, according to the comment. This fixes the test not to trigger that work-around: [I'll update the commit log with the issue URL as soon as it's assigned] --089e0149c28ed57d3b052d6d2bd7 Content-Type: text/x-patch; charset=US-ASCII; name="0001-tests-avoid-false-failure-of-split-filter.sh-on-XFS.patch" Content-Disposition: attachment; filename="0001-tests-avoid-false-failure-of-split-filter.sh-on-XFS.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ilhfq17i0 RnJvbSA4ODk0MTVhYjM1OWM5NDNlZTRjMzU4ZjhjNWZiMDdiY2E5NWE0ZWFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U3VuLCA2IE1hciAyMDE2IDE2OjM4OjAxIC0wODAwClN1YmplY3Q6IFtQQVRDSF0gdGVzdHM6IGF2 b2lkIGZhbHNlLWZhaWx1cmUgb2Ygc3BsaXQvZmlsdGVyLnNoIG9uIFhGUwoKKiB0ZXN0cy9zcGxp dC9maWx0ZXIuc2g6IFVzZSBPRkZfVF9NQVgtMSByYXRoZXIgdGhhbiBPRkZfVF9NQVgKYXMgdGhl IHNpemUgb2YgYSB0ZXN0IGZpbGUsIHRvIGF2b2lkIGZhbHNlIGZhaWx1cmUgb24gYW4gWEZTIGZp bGUKc3lzdGVtIChvciBhbnkgZmlsZSBzeXN0ZW0gcGVybWl0dGluZyBhIGZpbGUgb2Ygc2l6ZSBP RkZfVF9NQVgpLgotLS0KIHRlc3RzL3NwbGl0L2ZpbHRlci5zaCB8IDYgKysrKystCiAxIGZpbGUg Y2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvdGVz dHMvc3BsaXQvZmlsdGVyLnNoIGIvdGVzdHMvc3BsaXQvZmlsdGVyLnNoCmluZGV4IGE5MzAwOGIu LmJkMmYyMTAgMTAwNzU1Ci0tLSBhL3Rlc3RzL3NwbGl0L2ZpbHRlci5zaAorKysgYi90ZXN0cy9z cGxpdC9maWx0ZXIuc2gKQEAgLTUyLDkgKzUyLDEzIEBAIHJldHVybnNfIDEgc3BsaXQgLW4gMS8y IC0tZmlsdGVyPSd0cnVlJyAvZGV2L251bGwgMj4mMSB8fCBmYWlsPTEKICMgd2hlcmUgdGhleSB3 b3VsZCByZXN1bHQgaW4gYSBub24gemVybyBleGl0IGZyb20gc3BsaXQuCiB5ZXMgfCBoZWFkIC1u MjAwSyB8IHNwbGl0IC1iMUcgLS1maWx0ZXI9J2hlYWQgLWMxID4vZGV2L251bGwnIHx8IGZhaWw9 MQoKKyMgRG8gbm90IHVzZSBhIHNpemUgb2YgT0ZGX1RfTUFYLCBzaW5jZSBzcGxpdC5jIGFwcGxp ZXMgYSBHTlUvSHVyZAorIyAvZGV2L3plcm8gd29ya2Fyb3VuZCBmb3IgZmlsZXMgb2YgdGhhdCBz aXplLiAgVXNlIG9uZSBsZXNzOgorTj0kKGV4cHIgJE9GRl9UX01BWCAtIDEpCisKICMgRW5zdXJl IHRoYXQgImVuZGxlc3MiIGlucHV0IGlzIGlnbm9yZWQgd2hlbiBhbGwgZmlsdGVycyBmaW5pc2gK IHRpbWVvdXQgMTAgc2ggLWMgJ3llcyB8IHNwbGl0IC0tZmlsdGVyPSJoZWFkIC1jMSA+L2Rldi9u dWxsIiAtbiByLzEnIHx8IGZhaWw9MQotaWYgdHJ1bmNhdGUgLXMkT0ZGX1RfTUFYIHplcm8uaW47 IHRoZW4KK2lmIHRydW5jYXRlIC1zJE4gemVyby5pbjsgdGhlbgogICB0aW1lb3V0IDEwIHNoIC1j ICdzcGxpdCAtLWZpbHRlcj0iaGVhZCAtYzEgPi9kZXYvbnVsbCIgLW4gMSB6ZXJvLmluJyB8fCBm YWlsPTEKIGZpCgotLSAKMi43LjIKCg== --089e0149c28ed57d3b052d6d2bd7-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 07 01:39:04 2016 Received: (at 22931) by debbugs.gnu.org; 7 Mar 2016 06:39:04 +0000 Received: from localhost ([127.0.0.1]:37267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acoop-0006D1-PL for submit@debbugs.gnu.org; Mon, 07 Mar 2016 01:39:03 -0500 Received: from mail-ob0-f180.google.com ([209.85.214.180]:35285) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acoon-0006CX-N8 for 22931@debbugs.gnu.org; Mon, 07 Mar 2016 01:39:02 -0500 Received: by mail-ob0-f180.google.com with SMTP id xx9so97210716obc.2 for <22931@debbugs.gnu.org>; Sun, 06 Mar 2016 22:39:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=FxrsQCx1w+iJaZjKExncKxxI39M6Ypj02FpYYkwMJXA=; b=coJLUJYkmx3OlmO2jTREkolIuvtyMPmyAnt5LN081p5fxpt0qoUCb9omhd/ZAQZP2W 7SG4Kws6us6trFG822L7W7dTk0oBz/b1gE8A2uEBWg3njRE0amoxyeGTWTEonMlTY3Yo 2jxopTsveqrb0U9raDHQ7RS1Tuc5pTvCW4voFpVUP+sB9Wlq71Vig8un4n1nKphwp0N2 mYeEZSVpQZHGAutO1XmA3SS6HJJUY4wJ0W2om8L1Mo+4CQ/i7+YVSBoGaHsLDUHxJJQ6 9vHDz5747qWn5dcSPNzM8R4ELGTKU8EXxM6WhZdTdk0gobLnQbs6HCbqjWehggdKdinG TfFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=FxrsQCx1w+iJaZjKExncKxxI39M6Ypj02FpYYkwMJXA=; b=GULf6LChBBiXkwVA44OC3jxl/17ndGCXxMkOW6KIerAwtFLTpWVpFGWCStsgjQ6oXZ h3qUwJGWo/6Gw84VvTU2jvdSJv1fZpyejUDtKTDzuAKPkcDXQGWJpnv67hW1iYe+BMm0 Xrhec6vzsygOCW9aVnwCvd3DaE5tfy8OZgbrzAj6fuGxoXOqO1EW1/dI3198KKQOJNTa LkiRSqGuYGZsSnWpq3Lw9e0qsS4wXCjmDSmW0idVtPzb1uxn2jHFFUhjfuCWP/4YJFlp aRSirtL5cItAoYjSTOhwkmnf9f58T5z858DXg1k7HI20UPqWv4C5INO/XpB3AMPpwyah VilQ== X-Gm-Message-State: AD7BkJJZ0e9f/MZwQ6TTnCNgMJrP0Kp7BLiq7taCD5fo4OiTFQxn/pT0dWtLWnshe7/qO5Ilr45ATo/LKJVZjg== X-Received: by 10.182.225.231 with SMTP id rn7mr13680579obc.2.1457332735970; Sun, 06 Mar 2016 22:38:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.82.194 with HTTP; Sun, 6 Mar 2016 22:38:36 -0800 (PST) In-Reply-To: References: From: Jim Meyering Date: Sun, 6 Mar 2016 22:38:36 -0800 X-Google-Sender-Auth: CmOG2v0dNlBA-JEAzEDYet5OqB4 Message-ID: Subject: Re: bug#22931: tests/split/filter.sh fails on an XFS file system To: 22931@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22931 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sun, Mar 6, 2016 at 7:36 PM, Jim Meyering wrote: > The split/filter.sh test would fail like this: > > $ make check TESTS=tests/split/filter.sh VERBOSE=yes SUBDIRS=. > + truncate -s9223372036854775807 zero.in > + timeout 10 sh -c 'split --filter="head -c1 >/dev/null" -n 1 zero.in' > split: zero.in: cannot determine file size: Value too large for > defined data type > > That value is 2^63-1 (nearly 8 exabytes), and split.c > explicitly handles a file of that size, because that is > the size reported for /dev/zero on GNU/Hurd systems, > according to the comment. > > This fixes the test not to trigger that work-around: > [I'll update the commit log with the issue URL as soon as it's assigned] A possible addition is to #ifdef-out the offending code in src/split.c, so that the original example works -- at least on non-Hurd systems. One might argue that we should make these tools work consistently across all systems, but in a corner case like this, I have a slight preference for keeping the usual-case code slightly cleaner, and working with an edge-case file size like the one in this example. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 16:01:36 2016 Received: (at 22931-done) by debbugs.gnu.org; 8 Mar 2016 21:01:36 +0000 Received: from localhost ([127.0.0.1]:40120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adOl5-0002dE-UX for submit@debbugs.gnu.org; Tue, 08 Mar 2016 16:01:36 -0500 Received: from mail-ob0-f170.google.com ([209.85.214.170]:34891) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adOl4-0002cw-Ep for 22931-done@debbugs.gnu.org; Tue, 08 Mar 2016 16:01:35 -0500 Received: by mail-ob0-f170.google.com with SMTP id fp4so26707753obb.2 for <22931-done@debbugs.gnu.org>; Tue, 08 Mar 2016 13:01:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=3a/k+LCda4uOEoGPn2uE22U5ixdfUKJc9YKsa/VE2rs=; b=WaF5CAEmMiMlhVNoXuL5s1XU9rp61MOavqtqTmKTj5zn6jvhyduUUynjFSBy5dRSr4 FEFy2GU7CkgLaP5DsaI48MwCsnqmtk5AxyJ1V3kVd95JgpEJj3la+jmjRhhadbsl6uOF 0Nv1IBc2tOPLpUzhPr7EAWO76kPujxA2FWoBTQq3wE3aCB7l7gEydmFsnkHT2AH+qcWG IBM8Dv+doMvSbccuoCmGp6dud8Kbl63PglofiG3BOPMBaqkj05ILExxiYJTPtOetv+h4 H2BhtEksBNuOSUzMs2JUUT1jCcuX5q2p48tJdrvwYCxPWhcOGKIOsh1a3bcsG1wO463U j6Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=3a/k+LCda4uOEoGPn2uE22U5ixdfUKJc9YKsa/VE2rs=; b=b9tYaMfZbJbRWu8iOElImK1iN24LUBeiNPIfkytnucwyo8zB+Ih0dfzvKb5iJaS/bT MlFFIN6M5NTpgvZM606zE7phPRlQAMHZcwNP8CFmzSs+mUjb6Is7kcW2Ga/C6GxSiVB5 4EdHucvf1Xf/D0tPBg/1mpdoRUAL3KJU0NEX85bhI7k4HseB7TXU2QD4RhE8eH8+L69a VTGbN6CCu6hOIsVgehKJkTjCP+R3dsRGfrrT1EuLQbNLmvw0+MqV04XJ/b1zyUTMRAPP NChO2HZvsfyY133YrUPkuMYvygk55opptAFUp8qKeaoa+9o6kA0Lc0PXVFneTEAbG1Rk WX0Q== X-Gm-Message-State: AD7BkJKVKxlGJOtzCatzS2Vi2Fm7Xv1272BgACW9gEMC3Mwk0T6B7lnencoMKDqOEDnceJ7bOGshJRGCUN4lEA== X-Received: by 10.182.158.197 with SMTP id ww5mr7494779obb.71.1457470888711; Tue, 08 Mar 2016 13:01:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.202.82.194 with HTTP; Tue, 8 Mar 2016 13:01:08 -0800 (PST) In-Reply-To: References: From: Jim Meyering Date: Tue, 8 Mar 2016 13:01:08 -0800 X-Google-Sender-Auth: E72gPj4rEnzhOdw0jBD_hHD3hnw Message-ID: Subject: Re: bug#22931: tests/split/filter.sh fails on an XFS file system To: 22931-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 22931-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sun, Mar 6, 2016 at 7:36 PM, Jim Meyering wrote: > The split/filter.sh test would fail like this: > > $ make check TESTS=tests/split/filter.sh VERBOSE=yes SUBDIRS=. > + truncate -s9223372036854775807 zero.in > + timeout 10 sh -c 'split --filter="head -c1 >/dev/null" -n 1 zero.in' > split: zero.in: cannot determine file size: Value too large for > defined data type > > That value is 2^63-1 (nearly 8 exabytes), and split.c > explicitly handles a file of that size, because that is > the size reported for /dev/zero on GNU/Hurd systems, > according to the comment. > > This fixes the test not to trigger that work-around: > [I'll update the commit log with the issue URL as soon as it's assigned] No feedback, so I presume no objection. Pushed with the mentioned commit-log addition. From unknown Sat Aug 09 13:19:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 06 Apr 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator