GNU bug report logs - #22928
25.1.50; shr stops rendering when encountering invalid data: images

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22928 in the body.
You can then email your comments to 22928 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; shr stops rendering when encountering invalid data: images
Date: Sun, 06 Mar 2016 22:45:41 +0100

It should instead just ignore the errors:

Debugger entered--Lisp error: (error "Invalid base64 data")
  base64-decode-string("R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs")
  shr-image-from-data("image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs")
  shr-tag-img((img ((src . "data:image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs") (alt . "19th before") (data-cid . "site/dynamic_size_image-1456543289_395_3047") (data-cdata . "{\"asset_id\":6106077,\"ratio\":\"*\"}"))))
  shr-descend((img ((src . "data:image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs") (alt . "19th before") (data-cid . "site/dynamic_size_image-1456543289_395_3047") (data-cdata . "{\"asset_id\":6106077,\"ratio\":\"*\"}"))))
  shr-tag-span((span nil "\n" (img ((src . "data:image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs") (alt . "19th before") (data-cid . "site/dynamic_size_image-1456543289_395_3047") (data-cdata . "{\"asset_id\":6106077,\"ratio\":\"*\"}")))))

...



In GNU Emacs 25.1.50.23 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
 of 2016-03-06 built on stories
Repository revision: 20cc4182598c6c724f4556faf6bc322c9e58ad1d
Windowing system distributor 'The X.Org Foundation', version 11.0.11204000
System Description:	Debian GNU/Linux 7.9 (wheezy)

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GSETTINGS NOTIFY GNUTLS
LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_US
  locale-coding-system: iso-latin-1-unix

Major mode: Group

Minor modes in effect:
  shell-dirtrack-mode: t
  diff-auto-refine-mode: t
  gnus-topic-mode: t
  gnus-undo-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t

Recent messages:
Quit
gnutls.c: [0] (Emacs) Received alert:  Handshake failed
shr-image-from-data: Invalid base64 data [2 times]
nil
(args-out-of-range arith-error buffer-read-only end-of-file file-error invalid-function invalid-regexp no-catch search-failed setting-constant void-function void-variable wrong-number-of-arguments wrong-type-argument)
shr-image-from-data: Invalid base64 data
t
Entering debugger...
Mark set
Back to top level

Load-path shadows:
/home/larsi/src/clock.el/clock hides /home/larsi/lisp/clock
/home/larsi/src/cddb.el/expect hides /home/larsi/lisp/expect
/home/larsi/src/pvr.el/pvr hides /home/larsi/lisp/pvr
~/pgnus/contrib/vcard hides /home/larsi/lisp/vcard
/home/larsi/src/cddb.el/captitle hides /home/larsi/lisp/captitle
~/lisp/zenirc-2.112/src/zenirc-example hides /home/larsi/lisp/zenirc-example
/home/larsi/lisp/dom hides /home/larsi/src/emacs/trunk/lisp/dom
~/pgnus/contrib/compface hides /home/larsi/src/emacs/trunk/lisp/image/compface

Features:
(etags tramp-cache tramp tramp-compat tramp-loaddefs trampver
ucs-normalize advice log-edit pcvs-util noutline outline csid atom json
vcalendar shell pcomplete grep compile comint vc-bzr dired-aux cc-mode
cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars
cc-defs pulse xref project ring sh-script smie executable mailalias
smtpmail vc-git diff-mode map pp shadow emacsbug sendmail binhex canlock
ecomplete flow-fill eieio-opt speedbar sb-image ezimage dframe find-func
thingatpt view sgml-mode misearch multi-isearch tabify imenu man vc
vc-dispatcher copyright vc-cvs eww shr-color color gnus-html url-queue
help-fns url-cache gnus-picon sort gnus-cite smiley ansi-color
mm-archive gnus-async gnus-dup qp gnus-ml gmane spam-gmane dns mm-url
disp-table gnus-fun gnus-mdrtn gnus-topic pop3 nndoc nnmbox nndraft
utf-7 nnmh nnml nnfolder network-stream nsm starttls nnir spam-report
spam spam-stat gnus-uu yenc gnus-agent gnus-srvr gnus-score score-mode
nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime dig
nntp gnus-cache gnus-sum gnus-group gnus-undo gnus-start gnus-cloud
nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int
gnus-range message format-spec rfc822 mml mml-sec epa epg mailabbrev
gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail
rmail-loaddefs mail-utils movie mkv shr svg imdb dom pvr debug
debbugs-gnu easy-mmode derived debbugs soap-client mm-decode mm-bodies
mm-encode url-http tls gnutls url-auth mail-parse rfc2231 rfc2047
rfc2045 ietf-drums url-gw puny url url-proxy url-privacy url-expand
url-methods url-history url-cookie url-domsuf url-util mailcap warnings
rng-xsd rng-dt rng-util xsd-regexp xml ido seq flyspell ispell benchmark
w3m browse-url doc-view subr-x dired dired-loaddefs image-mode timezone
w3m-hist w3m-fb w3m-ems wid-edit w3m-ccl ccl w3m-favicon w3m-image
w3m-proc w3m-util add-log mail-extr mm-util mail-prsvr jka-compr cl
finder-inf package epg-config url-handlers url-parse auth-source cl-seq
eieio byte-opt bytecomp byte-compile cl-extra help-mode easymenu cconv
eieio-core cl-macs gv eieio-loaddefs cl-loaddefs pcase cl-lib
password-cache url-vars time-date mule-util tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote inotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty make-network-process emacs)

Memory information:
((conses 16 8075342 352702)
 (symbols 48 176911 513)
 (miscs 40 1569 7692)
 (strings 32 462838 39486)
 (string-bytes 1 25923987)
 (vectors 16 72674)
 (vector-slots 8 2092469 177193)
 (floats 8 7423 7822)
 (intervals 56 1930600 20211)
 (buffers 976 218)
 (heap 1024 441915 218094))

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #8 received at 22928 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: 22928 <at> debbugs.gnu.org
Subject: Re: bug#22928: 25.1.50;
 shr stops rendering when encountering invalid data: images
Date: Sun, 20 Mar 2016 13:57:25 +0100

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

> It should instead just ignore the errors:
>
> Debugger entered--Lisp error: (error "Invalid base64 data")
>   base64-decode-string("R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs")
>   shr-image-from-data("image/gif;base64,R0lGODlhAQABAIAAAAUEBAAAACwAAAAAAQABAAACAkQBADs")

Now fixed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.