GNU bug report logs - #2291
23.0.90; finder-commentary

Previous Next

Full log

Message #36 received at 2291 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 2291 <at> debbugs.gnu.org
Subject: RE: bug#2291: 23.0.90; finder-commentary
Date: Wed, 27 Apr 2016 10:53:30 -0700 (PDT)

> > 1. This sexp in finder-commentary is inappropriate:
> > (delete-other-windows).  The original buffer is current when this is
> > called, and it makes no sense to delete the other windows.  And the
> > call is immediately followed by pop-to-buffer to display and select
> > the Finder commentary buffer.
> 
> This looks like it's fixed now?

Yes, I guess so - it seems to have been removed in Emacs 23.
Dunno whether the bad effect is gone, but I'll assume so.

> > 2. The Commentary buffer name should not be "*Finder-package*".  That
> > prohibits you from having more than one such buffer. Also, the name
> > should reflect the content: this is the Commentary section of a
> > particular Lisp file.  Please use something like this:
> >
> > (pop-to-buffer
> >  (concat "*Commentary, " (file-name-sans-extension file) "*"))
> >
> > instead of this:
> > (pop-to-buffer "*Finder-package*")
> >
> > The result will then be a name like this: *Commentary, buff-menu*
> 
> Wouldn't it make more sense just to use the *Help* buffer?  It has a
> nice history and stuff...

No, certainly not.  It should be commentary-specific, and file-specific,
as described in the bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.