GNU bug report logs - #2291
23.0.90; finder-commentary

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: "Drew Adams" <drew.adams <at> oracle.com>
Subject: bug#2291 closed by Chong Yidong <cyd <at> stupidchicken.com> (Re: 
 23.0.90; finder-commentary)
Date: Sun, 08 Mar 2009 20:05:08 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#2291: 23.0.90; finder-commentary

It has been closed by Chong Yidong <cyd <at> stupidchicken.com>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Chong Yidong <cyd <at> stupidchicken.com> by
replying to this email.


-- 
2291: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2291
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 2291-done <at> debbugs.gnu.org
Subject: Re: 23.0.90; finder-commentary
Date: Sun, 08 Mar 2009 15:58:45 -0400

> 1. This sexp in finder-commentary is inappropriate:
> (delete-other-windows).

I've removed it.  Thanks for pointing this out.
 
> 2. The Commentary buffer name should not be "*Finder-package*".  That
> prohibits you from having more than one such buffer.

That would be problematic, as it leaves a trail of finder-commentary
buffers that you have to delete manually.  That's the same reason we
don't uniquify *Help* buffers.

[Message part 3 (message/rfc822, inline)]

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <emacs-pretest-bug <at> gnu.org>
Subject: 23.0.90; finder-commentary
Date: Wed, 11 Feb 2009 10:36:25 -0800

1. This sexp in finder-commentary is inappropriate:
(delete-other-windows).  The original buffer is current when this is
called, and it makes no sense to delete the other windows.  And the
call is immediately followed by pop-to-buffer to display and select
the Finder commentary buffer.
 
2. The Commentary buffer name should not be "*Finder-package*".  That
prohibits you from having more than one such buffer. Also, the name
should reflect the content: this is the Commentary section of a
particular Lisp file.  Please use something like this:
 
(pop-to-buffer
 (concat "*Commentary, " (file-name-sans-extension file) "*"))
 
instead of this:
(pop-to-buffer "*Finder-package*")
 
The result will then be a name like this: *Commentary, buff-menu*
 
Among other things, being able to have more than one Finder commentary
buffer lets you use the Commentary section of Lisp files for
documentation that refers to other Lisp file Commentary sections.
With a simple link facility (e.g. `linkd.el' or Org mode), this doc
becomes hypertext among Commentary sections, each in Finder mode, with
the comment characters removed etc.
 

In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600)
 of 2009-02-01 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.