GNU bug report logs - #22906
SGML-mode can't validate unsaved buffers

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Live System User <nyc4bos <at> aol.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: 24.5; eww SGML validate error
Date: Wed, 07 Sep 2016 18:49:51 +0200

I can reproduce this on the current master branch (ec12c670).

The issue seems to be that `sgml-validate' assumes that the buffer is
visiting a file, which is not the case when you view a web page's source
from eww.

Maybe we could offer to save the buffer when it's not visiting a file?

diff --git a/lisp/textmodes/sgml-mode.el b/lisp/textmodes/sgml-mode.el
index 990c09b..b98db7e 100644
--- a/lisp/textmodes/sgml-mode.el
+++ b/lisp/textmodes/sgml-mode.el
@@ -1109,8 +1109,10 @@ sgml-validate
 				  " "
 				  (shell-quote-argument
 				   (let ((name (buffer-file-name)))
-				     (and name
-					  (file-name-nondirectory name)))))))))
+                                     (unless name
+                                       (save-buffer)
+                                       (setq name (buffer-file-name)))
+				     (file-name-nondirectory name))))))))
   (setq sgml-saved-validate-command command)
   (save-some-buffers (not compilation-ask-about-save) nil)
   (compilation-start command))


-- Simen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.