GNU bug report logs - #22906
SGML-mode can't validate unsaved buffers

Previous Next

Package: emacs;

Reported by: Live System User <nyc4bos <at> aol.com>

Date: Fri, 4 Mar 2016 14:40:02 UTC

Severity: wishlist

Tags: fixed

Found in version 24.5

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #18 received at 22906 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: Live System User <nyc4bos <at> aol.com>, 22906 <at> debbugs.gnu.org
Subject: Re: bug#22906: 24.5; eww SGML validate error
Date: Tue, 15 Sep 2020 18:12:55 +0200
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> I can reproduce this on the current master branch (ec12c670).
>>
>> The issue seems to be that `sgml-validate' assumes that the buffer is
>> visiting a file, which is not the case when you view a web page's source
>> from eww.
>>
>> Maybe we could offer to save the buffer when it's not visiting a file?
>
> I think that would be unusual for commands like this (that have to be
> written out to work).  Instead it could save the buffer to a temporary
> file, validate and then delete it again.

Actually, looking at the code again, I think it's just a simple bug.  It
checks whether buffer-file-name is non-nil, but then it ends up with
(shell-quote-argument nil), which is invalid.

I've now fixed this in Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 244 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.