From unknown Sat Aug 16 20:56:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#22892 <22892@debbugs.gnu.org> To: bug#22892 <22892@debbugs.gnu.org> Subject: Status: 25.1.50; dired-get-marked-files distinguish marks Reply-To: bug#22892 <22892@debbugs.gnu.org> Date: Sun, 17 Aug 2025 03:56:15 +0000 retitle 22892 25.1.50; dired-get-marked-files distinguish marks reassign 22892 emacs submitter 22892 Tino Calancha severity 22892 wishlist tag 22892 wontfix patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 04:33:57 2016 Received: (at submit) by debbugs.gnu.org; 3 Mar 2016 09:33:57 +0000 Received: from localhost ([127.0.0.1]:58579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1abPdt-0006wq-Jv for submit@debbugs.gnu.org; Thu, 03 Mar 2016 04:33:57 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53242) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1abPds-0006wZ-2L for submit@debbugs.gnu.org; Thu, 03 Mar 2016 04:33:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abPdl-0003Gb-Vo for submit@debbugs.gnu.org; Thu, 03 Mar 2016 04:33:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abPdl-0003GX-Sq for submit@debbugs.gnu.org; Thu, 03 Mar 2016 04:33:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abPdk-0005KF-Mg for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2016 04:33:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1abPde-0003G0-My for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2016 04:33:48 -0500 Received: from calancha-ilc.kek.jp ([130.87.234.234]:55096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1abPde-0003Fk-4m for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2016 04:33:42 -0500 Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id 9930095DC; Thu, 3 Mar 2016 18:36:56 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 37DBD5B for ; Thu, 3 Mar 2016 18:36:56 +0900 (JST) Date: Thu, 3 Mar 2016 18:36:56 +0900 (JST) From: Tino Calancha X-X-Sender: calancha@calancha-ilc.kek.jp To: bug-gnu-emacs@gnu.org Subject: 25.1.50; dired-get-marked-files distinguish marks Message-ID: User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="1468197610-1449390403-1456997816=:25062" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --1468197610-1449390403-1456997816=:25062 Content-Type: text/plain; format=flowed; charset=US-ASCII * lisp/dired.el(dired-get-marked-files): Added optional argument `marker-char'. If non-nil, the files retrieved are those marked with MARKER-CHAR. Otherwise the returned files are those marked with `dired-marker-char'. Callers are not affected: the arg is optional and added at the end of the parameter list. In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.29) of 2016-03-03 built on calancha-pc Repository revision: 887f6126c5ce9084f93083765ac026ca6b28175c --1468197610-1449390403-1456997816=:25062 Content-Type: text/plain; charset=US-ASCII; name=dired.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=dired.patch ZGlmZiAtLWdpdCBhL2xpc3AvZGlyZWQuZWwgYi9saXNwL2RpcmVkLmVsDQpp bmRleCA2Yzc0NDVjLi5iNjllNjExIDEwMDY0NA0KLS0tIGEvbGlzcC9kaXJl ZC5lbA0KKysrIGIvbGlzcC9kaXJlZC5lbA0KQEAgLTYyNyw3ICs2MjcsNyBA QCBkaXJlZC1tYXAtb3Zlci1tYXJrcw0KICAgICAgOzsgc2F2ZS1leGN1cnNp b24gbG9zZXMsIGFnYWluDQogICAgICAoZGlyZWQtbW92ZS10by1maWxlbmFt ZSkpKQ0KIA0KLShkZWZ1biBkaXJlZC1nZXQtbWFya2VkLWZpbGVzICgmb3B0 aW9uYWwgbG9jYWxwIGFyZyBmaWx0ZXIgZGlzdGluZ3Vpc2gtb25lLW1hcmtl ZCkNCisoZGVmdW4gZGlyZWQtZ2V0LW1hcmtlZC1maWxlcyAoJm9wdGlvbmFs IGxvY2FscCBhcmcgZmlsdGVyIGRpc3Rpbmd1aXNoLW9uZS1tYXJrZWQgbWFy a2VyLWNoYXIpDQogICAiUmV0dXJuIHRoZSBtYXJrZWQgZmlsZXMnIG5hbWVz IGFzIGxpc3Qgb2Ygc3RyaW5ncy4NCiBUaGUgbGlzdCBpcyBpbiB0aGUgc2Ft ZSBvcmRlciBhcyB0aGUgYnVmZmVyLCB0aGF0IGlzLCB0aGUgY2FyIGlzIHRo ZQ0KICAgZmlyc3QgbWFya2VkIGZpbGUuDQpAQCAtNjQ0LDIyICs2NDQsMjYg QEAgZGlyZWQtZ2V0LW1hcmtlZC1maWxlcw0KIA0KIElmIERJU1RJTkdVSVNI LU9ORS1NQVJLRUQgaXMgbm9uLW5pbCwgdGhlbiBpZiB3ZSBmaW5kIGp1c3Qg b25lIG1hcmtlZCBmaWxlLA0KIHJldHVybiAodCBGSUxFTkFNRSkgaW5zdGVh ZCBvZiAoRklMRU5BTUUpLg0KLURvbid0IHVzZSB0aGF0IHRvZ2V0aGVyIHdp dGggRklMVEVSLiINCi0gIChsZXQgKChhbGwtb2YtdGhlbQ0KLQkgKHNhdmUt ZXhjdXJzaW9uDQotCSAgIChkZWxxIG5pbCAoZGlyZWQtbWFwLW92ZXItbWFy a3MNCi0JCSAgICAgIChkaXJlZC1nZXQtZmlsZW5hbWUgbG9jYWxwICduby1l cnJvci1pZi1ub3QtZmlsZXApDQotCQkgICAgICBhcmcgbmlsIGRpc3Rpbmd1 aXNoLW9uZS1tYXJrZWQpKSkpDQotCXJlc3VsdCkNCitEb24ndCB1c2UgdGhh dCB0b2dldGhlciB3aXRoIEZJTFRFUi4NCisNCitPcHRpb25hbCBhcmcgTUFS S0VSLUNIQVIsIGlmIG5vbi1uaWwsIHRoZW4gaXQgaXMgdGhlIG1hcmtlcg0K K2NoYXIgdG8gc2VhcmNoLiBPdGhlcndpc2UgYGRpcmVkLW1hcmtlci1jaGFy JyBpcyB1c2VkLiINCisgIChsZXQqICgoZGlyZWQtbWFya2VyLWNoYXIgKG9y IG1hcmtlci1jaGFyIGRpcmVkLW1hcmtlci1jaGFyKSkNCisgICAgICAgICAo YWxsLW9mLXRoZW0NCisgICAgICAgICAgKHNhdmUtZXhjdXJzaW9uDQorICAg ICAgICAgICAgKGRlbHEgbmlsIChkaXJlZC1tYXAtb3Zlci1tYXJrcw0KKyAg ICAgICAgICAgICAgICAgICAgICAgKGRpcmVkLWdldC1maWxlbmFtZSBsb2Nh bHAgJ25vLWVycm9yLWlmLW5vdC1maWxlcCkNCisgICAgICAgICAgICAgICAg ICAgICAgIGFyZyBuaWwgZGlzdGluZ3Vpc2gtb25lLW1hcmtlZCkpKSkNCisg ICAgICAgICByZXN1bHQpDQogICAgICh3aGVuIChlcXVhbCBhbGwtb2YtdGhl bSAnKHQpKQ0KICAgICAgIChzZXRxIGFsbC1vZi10aGVtIG5pbCkpDQogICAg IChpZiAobm90IGZpbHRlcikNCi0JKGlmIChhbmQgZGlzdGluZ3Vpc2gtb25l LW1hcmtlZCAoZXEgKGNhciBhbGwtb2YtdGhlbSkgdCkpDQotCSAgICBhbGwt b2YtdGhlbQ0KLQkgIChucmV2ZXJzZSBhbGwtb2YtdGhlbSkpDQorICAgIChp ZiAoYW5kIGRpc3Rpbmd1aXNoLW9uZS1tYXJrZWQgKGVxIChjYXIgYWxsLW9m LXRoZW0pIHQpKQ0KKyAgICAgICAgYWxsLW9mLXRoZW0NCisgICAgICAobnJl dmVyc2UgYWxsLW9mLXRoZW0pKQ0KICAgICAgIChkb2xpc3QgKGZpbGUgYWxs LW9mLXRoZW0pDQotCShpZiAoZnVuY2FsbCBmaWx0ZXIgZmlsZSkNCi0JICAg IChwdXNoIGZpbGUgcmVzdWx0KSkpDQorICAgIChpZiAoZnVuY2FsbCBmaWx0 ZXIgZmlsZSkNCisgICAgICAgIChwdXNoIGZpbGUgcmVzdWx0KSkpDQogICAg ICAgcmVzdWx0KSkpDQogDA0KIDs7IFRoZSBkaXJlZCBjb21tYW5kDQo= --1468197610-1449390403-1456997816=:25062-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 06:12:24 2016 Received: (at control) by debbugs.gnu.org; 3 Mar 2016 11:12:24 +0000 Received: from localhost ([127.0.0.1]:58629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1abRB9-0000oG-PH for submit@debbugs.gnu.org; Thu, 03 Mar 2016 06:12:23 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:52959) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1abRB7-0000o7-5H for control@debbugs.gnu.org; Thu, 03 Mar 2016 06:12:22 -0500 Received: from host86-187-68-58.range86-187.btcentralplus.com ([86.187.68.58] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1abRAd-0001Ch-RG for control@debbugs.gnu.org; Thu, 03 Mar 2016 12:11:51 +0100 Date: Thu, 03 Mar 2016 11:11:51 +0000 Message-Id: <87povbhl3c.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22892 X-MailScanner-ID: 1abRAd-0001Ch-RG X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457608312.42013@Dv+cnYtSf4JfUhq5eaOuOw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 22892 patch From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 04 10:34:27 2016 Received: (at 22892) by debbugs.gnu.org; 4 Mar 2016 15:34:27 +0000 Received: from localhost ([127.0.0.1]:33677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1abrkJ-0000Bp-AP for submit@debbugs.gnu.org; Fri, 04 Mar 2016 10:34:27 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:47275) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1abrkG-0000BQ-Se for 22892@debbugs.gnu.org; Fri, 04 Mar 2016 10:34:25 -0500 Received: from 2.150.35.31.tmi.telenormobil.no ([2.150.35.31] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1abrjJ-0004PY-4m; Fri, 04 Mar 2016 16:33:25 +0100 From: Lars Ingebrigtsen To: Tino Calancha Subject: Re: bug#22892: 25.1.50; dired-get-marked-files distinguish marks In-Reply-To: (Tino Calancha's message of "Thu, 3 Mar 2016 18:36:56 +0900 (JST)") Date: Fri, 04 Mar 2016 12:34:28 +0000 Message-ID: <87io12l8vf.fsf@gnus.org> References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1abrjJ-0004PY-4m X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1457710405.91002@JH++IKU4mHQeZgvYYSfzyg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22892 Cc: 22892@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Tino Calancha writes: > * lisp/dired.el(dired-get-marked-files): > > Added optional argument `marker-char'. If non-nil, > the files retrieved are those marked with MARKER-CHAR. > Otherwise the returned files are those marked with > `dired-marker-char'. > > Callers are not affected: the arg is optional and > added at the end of the parameter list. Is this a subset of the subsequent bug report in 22893? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 05 08:10:00 2016 Received: (at 22892) by debbugs.gnu.org; 5 Mar 2016 13:10:00 +0000 Received: from localhost ([127.0.0.1]:34350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acBy4-0001a5-N3 for submit@debbugs.gnu.org; Sat, 05 Mar 2016 08:10:00 -0500 Received: from calancha-ilc.kek.jp ([130.87.234.234]:57588) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1acBy2-0001Zp-V4 for 22892@debbugs.gnu.org; Sat, 05 Mar 2016 08:09:59 -0500 Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id D1C92DA83; Sat, 5 Mar 2016 22:13:05 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 6F7C054C0; Sat, 5 Mar 2016 22:13:05 +0900 (JST) Date: Sat, 5 Mar 2016 22:13:05 +0900 (JST) From: Tino Calancha X-X-Sender: calancha@calancha-ilc.kek.jp To: Lars Ingebrigtsen Subject: Re: bug#22892: 25.1.50; dired-get-marked-files distinguish marks In-Reply-To: <87io12l8vf.fsf@gnus.org> Message-ID: References: <87io12l8vf.fsf@gnus.org> User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 22892 Cc: Tino Calancha , 22892@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Is this a subset of the subsequent bug report in 22893? Exactly. Its a conservative proposal which just modified one function. I though maybe the maintainers would hesitate to add #22893 which introduce more changes. We can close this thread. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 19:11:24 2016 Received: (at control) by debbugs.gnu.org; 10 Mar 2016 00:11:24 +0000 Received: from localhost ([127.0.0.1]:42070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adoCJ-0007kd-SJ for submit@debbugs.gnu.org; Wed, 09 Mar 2016 19:11:23 -0500 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:46725 helo=homiemail-a15.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1adoCH-0007kO-Vc; Wed, 09 Mar 2016 19:11:22 -0500 Received: from homiemail-a15.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a15.g.dreamhost.com (Postfix) with ESMTP id B4E7376C06B; Wed, 9 Mar 2016 16:11:16 -0800 (PST) Received: from localhost.linkov.net (62.65.227.103.cable.starman.ee [62.65.227.103]) (Authenticated sender: jurta@jurta.org) by homiemail-a15.g.dreamhost.com (Postfix) with ESMTPA id 5E30F76C069; Wed, 9 Mar 2016 16:11:15 -0800 (PST) From: Juri Linkov To: Tino Calancha Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked Organization: LINKOV.NET References: <87mvqel8xy.fsf@gnus.org> <83io0xrmam.fsf@gnu.org> Date: Thu, 10 Mar 2016 01:57:17 +0200 In-Reply-To: (Tino Calancha's message of "Thu, 10 Mar 2016 00:27:35 +0900 (JST)") Message-ID: <87h9gfus7a.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.91 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control Cc: Eli Zaretskii , 22893@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) merge 22893 22892 thanks > +*** New optional arg ALL-MARKS for `dired-map-over-marks' > +allow to operate over all marked files, not just those > +marked with `dired-marker-char'. > + > +*** New optional args MARKER-CHAR and ALL-MARKS for > +`dired-get-marked-files' to retrieve marked files with a > +particular mark character or with any. Since you are changing the function signatures anyway, you could make them consistent between `dired-map-over-marks' and `dired-get-marked-files' by adding an explicit arg `marker-char', i.e. both `dired-get-marked-files' and `dired-map-over-marks' could end with "distinguish-one-marked marker-char all-marks", thus explicitly passing `marker-char' arg down the call chain. Then you'll need `(or marker-char dired-marker-char)' in `dired-marker-regexp' for backward-compatibility. And then also no need to let-bind `dired-marker-char' in `dired-get-marked-files' (it's better to avoid dynamically binding global variables where possible). From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 10:07:46 2019 Received: (at 22892) by debbugs.gnu.org; 25 Jun 2019 14:07:46 +0000 Received: from localhost ([127.0.0.1]:33106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfm6r-0008R4-Qi for submit@debbugs.gnu.org; Tue, 25 Jun 2019 10:07:46 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfm6p-0008Qq-60; Tue, 25 Jun 2019 10:07:43 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfm6k-0000fq-6F; Tue, 25 Jun 2019 16:07:40 +0200 From: Lars Ingebrigtsen To: Tino Calancha Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked References: <87mvqel8xy.fsf@gnus.org> <83io0xrmam.fsf@gnu.org> <87h9gfus7a.fsf@mail.linkov.net> Date: Tue, 25 Jun 2019 16:07:38 +0200 In-Reply-To: (Tino Calancha's message of "Thu, 10 Mar 2016 13:19:10 +0900 (JST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Tino Calancha writes: >> Since you are changing the function signatures anyway, >> you could make them consistent between `dired-map-over-marks' >> and `dired-get-marked-files' by adding an explicit arg `marker-char', >> i [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22892 Cc: 22892@debbugs.gnu.org, 22893@debbugs.gnu.org, Eli Zaretskii , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tino Calancha writes: >> Since you are changing the function signatures anyway, >> you could make them consistent between `dired-map-over-marks' >> and `dired-get-marked-files' by adding an explicit arg `marker-char', >> i.e. both `dired-get-marked-files' and `dired-map-over-marks' >> could end with "distinguish-one-marked marker-char all-marks", >> thus explicitly passing `marker-char' arg down the call chain. >> Then you'll need `(or marker-char dired-marker-char)' in >> `dired-marker-regexp' for backward-compatibility. And then also >> no need to let-bind `dired-marker-char' in `dired-get-marked-files' >> (it's better to avoid dynamically binding global variables where possible). > > It sounds good. Thank you. Implemented in the new patch. I think the consensus was to apply the patch, but it was never done at the time, and now it won't apply since this code has changed substantially in the meantime. Would it be possible for you to rework the patch and resubmit? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 07:58:58 2020 Received: (at 22892) by debbugs.gnu.org; 12 Aug 2020 11:58:58 +0000 Received: from localhost ([127.0.0.1]:43131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5pPG-0002HR-9h for submit@debbugs.gnu.org; Wed, 12 Aug 2020 07:58:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5pPE-0002H8-2P; Wed, 12 Aug 2020 07:58:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KGvgQ8v16KjHrTpgh4ST1mWBLCI4ShGeSVMiOAZHgOI=; b=kh2bxUqcGKKDxleAncWBXOzLAQ 2Z8L1W6LlPof3R/rmWDUSREuiQ0qj93J71uXkyXBLfFlBQe35VRANPIiPiZnXcguhHoLgk3SyTonV QUbzQ/DFRMP6aiXjvAp7igFSuUrhK0qW5cm3Rg7kThN5hdaMNAWDfZ+9PjVLNMFhWHX8=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5pOv-0000LA-Gu; Wed, 12 Aug 2020 13:58:46 +0200 From: Lars Ingebrigtsen To: Tino Calancha Subject: Re: bug#22893: 25.1.50; dired-get-marked-files get all marked References: <87mvqel8xy.fsf@gnus.org> <83io0xrmam.fsf@gnu.org> <87h9gfus7a.fsf@mail.linkov.net> Date: Wed, 12 Aug 2020 13:58:35 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Tue, 25 Jun 2019 16:07:38 +0200") Message-ID: <87364snkic.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I think the consensus was to apply the patch, but it was never done at > the time, and now it won't apply since this code has changed > substantially in the meantime. > > Would it be possible for yo [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 22892 Cc: 22892@debbugs.gnu.org, 22893@debbugs.gnu.org, Eli Zaretskii , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I think the consensus was to apply the patch, but it was never done at > the time, and now it won't apply since this code has changed > substantially in the meantime. > > Would it be possible for you to rework the patch and resubmit? I tried fixing up this myself, but the interface for all the marker functions touched by this patch has changed too much for the patch to even make sense, as far as I can see. So I'm closing this bug report; a new one can be opened if this is something somebody still wants to have in Dired. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 12 07:59:14 2020 Received: (at control) by debbugs.gnu.org; 12 Aug 2020 11:59:14 +0000 Received: from localhost ([127.0.0.1]:43134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5pPJ-0002Ho-Ia for submit@debbugs.gnu.org; Wed, 12 Aug 2020 07:59:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5pPG-0002HB-Lq for control@debbugs.gnu.org; Wed, 12 Aug 2020 07:58:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xIz3hpxXDqf0M1Tn/D+MvkqwdSf+oT8i68+94/UG2G0=; b=LLHW09MTeu4rTsGvHHknVvPRTV 69nCemnDM0u+9bUk4n/3YOvfqViZ+TfKmTdUW72eZoylGERqa89nHS5R0RLfvJTX1L+6aUekmeE5b thFffLyklLrAlJ8P12uTAes4sMgndZk2pOMKT1PG84ACqXiY2g1nRA+cHgrx/FOVgFJc=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5pP8-0000LJ-UB for control@debbugs.gnu.org; Wed, 12 Aug 2020 13:58:53 +0200 Date: Wed, 12 Aug 2020 13:58:49 +0200 Message-Id: <871rkcnkhy.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #22892 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 22892 wontfix close 22892 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 22892 wontfix close 22892 quit From unknown Sat Aug 16 20:56:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 10 Sep 2020 11:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator