GNU bug report logs - #22824
Use smtpmail-smtp-user if auth-source-search doesn't return user field

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Jun Hao <jun_hao <at> aol.com>
Cc: 22824 <at> debbugs.gnu.org
Subject: bug#22824: Use smtpmail-smtp-user if auth-source-search doesn't return user field
Date: Wed, 02 Mar 2016 16:58:34 +0000

Jun Hao <jun_hao <at> aol.com> writes:

> Please review this patch. I didn't find existing function to do the
> conversion so write a simple helper function to do it. Tested with slash
> and Chinese char in label, account and password field.

Looks good, I think...

[...]

> * auth-source.el (auth-source-macos-keychain-search-items): Handle
>   keychain output correctly when has special char. (Bug#22824)
>
> Copyright-paperwork-exempt: yes

[...]

> +  (defun* decode-octal-string (string)

The name here should be "auth-source-", though.

And the patch is longer than what we can accept without a copyright
assignment.  Would you be willing to sign such a thing?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.