GNU bug report logs - #2282
23.0.90; rmail -- rmail-summary splits frame into three parts...

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2282 in the body.
You can then email your comments to 2282 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Alfred M\. Szmidt" <ams <at> gnu.org>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.90; rmail -- rmail-summary splits frame into three parts...
Date: Wed, 11 Feb 2009 12:17:58 +0100

When one does a M-x rmail, and then invokes rmail-summary, the frame
is split into three parts:

+-----------+----------+
|           |          |
| *scratch* |  rmail   |
|           |          |
+-----------+----------+
|   rmail-summary      |
|                      |
+----------------------+


In GNU Emacs 23.0.90.1 (i686-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2009-02-11 on beryx
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  'PATH=/home/ams/l/bin:/usr/local/bin:/usr/bin:/bin:/usr/games' 'PKG_CONFIG_PATH=/home/ams/l/lib/pkgconfig''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: RMAIL Summary

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x r m a i l <return> y n d d d h M-x r e p o <tab> 
r t <tab> <return>

Recent messages:
Getting mail from the remote server ...
Counting new messages...done (5)
Saving file /home/ams/RMAIL...
Wrote /home/ams/RMAIL
5 new messages read
Added to /home/ams/RMAIL.inbox:sysadmin <at> kreditor
Added to /home/ams/RMAIL.inbox:ams <at> kreditor
No following nondeleted message
Computing summary lines...done
Making completion list...

Message #10 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: ams <at> gnu.org, 2282 <at> debbugs.gnu.org
Subject: Re: bug#2282: 23.0.90;	rmail -- rmail-summary splits frame into three parts...
Date: Wed, 11 Feb 2009 22:31:28 +0200

> From: "Alfred M\. Szmidt" <ams <at> gnu.org>
> Date: Wed, 11 Feb 2009 12:17:58 +0100
> Cc: 
> 
> When one does a M-x rmail, and then invokes rmail-summary, the frame
> is split into three parts:
> 
> +-----------+----------+
> |           |          |
> | *scratch* |  rmail   |
> |           |          |
> +-----------+----------+
> |   rmail-summary      |
> |                      |
> +----------------------+

Does this happen with "emacs -Q"? cause it never happened to me.

Or perhaps you started Rmail from this window configuration:

 +-----------+----------+
 |                      |
 |      *scratch*       |
 |                      |
 +-----------+----------+
 |        rmail         |
 |                      |
 +----------------------+

in the first place??

Message #17 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Alfred M\. Szmidt" <ams <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 2282 <at> debbugs.gnu.org
Subject: Re: bug#2282: 23.0.90;	rmail -- rmail-summary splits frame into three parts...
Date: Thu, 12 Feb 2009 12:29:29 +0100

   > When one does a M-x rmail, and then invokes rmail-summary, the frame
   > is split into three parts:
   > 
   > +-----------+----------+
   > |           |          |
   > | *scratch* |  rmail   |
   > |           |          |
   > +-----------+----------+
   > |   rmail-summary      |
   > |                      |
   > +----------------------+

   Does this happen with "emacs -Q"? cause it never happened to me.

Even with -Q.

   Or perhaps you started Rmail from this window configuration:

    +-----------+----------+
    |                      |
    |      *scratch*       |
    |                      |
    +-----------+----------+
    |        rmail         |
    |                      |
    +----------------------+

   in the first place??

No, initial window configuration looks like this:

    +----------------------+
    |                      |
    |      *scratch*       |
    |                      |
    |                      |
    |                      |
    |                      |
    +----------------------+

But if rmail would split into three frames, based on the window
configuration you mentioned, then I would consider it a bug as well.
Atleast, it was not the behaviour of rmail before the mbox merge.

Message #24 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Alfred M\. Szmidt" <ams <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 2282 <at> debbugs.gnu.org
Subject: Re: bug#2282: 23.0.90;	rmail -- rmail-summary splits frame into three parts...
Date: Fri, 27 Feb 2009 09:42:27 +0100

I have narrowed the problem down a bit, it seems to only happen when I
hook a external monitor to my laptop.

If I am on my laptop without a external monitor, everything works as
expected.  If I hook the external monitor, it gets the behaviour I
mentioned (three windows).

How can I go about debugging this?  I am guessing it has to do with
emacs' sframe splitting code where it calculates the size somehow, and
that gets messed up so it fails to split the frame correctly.

Message #29 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 2282 <at> debbugs.gnu.org
Cc: "Alfred M. Szmidt" <ams <at> gnu.org>, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: Bug#2282: rmail-summary splits frame into three parts
Date: Mon, 09 Nov 2009 21:09:48 -0500

(Replying to old bug)

The behaviour described in the original report happens if you make the
Emacs frame wider than `split-width-threshold'. Setting that variable
to nil will prevent it.

I don't know what to do about this. There are lots of pop-to-buffers
in rmailsum.el, and any of them could cause such behaviour.

See the confusion in bug#1806.

Message #34 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 2282 <at> debbugs.gnu.org, "Alfred M. Szmidt" <ams <at> gnu.org>
Subject: Re: bug#2282: Bug#2282: rmail-summary splits frame into three parts
Date: Tue, 10 Nov 2009 09:48:46 +0200

> The behaviour described in the original report happens if you make the
> Emacs frame wider than `split-width-threshold'. Setting that variable
> to nil will prevent it.
>
> I don't know what to do about this. There are lots of pop-to-buffers
> in rmailsum.el, and any of them could cause such behaviour.
>
> See the confusion in bug#1806.

With the current CVS after `M-x rmail-summary' I see

+---------------+---------------+
|               |               |
| RMAIL-summary |     RMAIL     |
|               |               |
+---------------+---------------+
|                               |
|         RMAIL-summary         |
|                               |
+-------------------------------+

I think for RMAIL both following layouts make equal sense
on a wide frame:

+---------------+---------------+
|               |               |
| RMAIL-summary |     RMAIL     |
|               |               |
|               |               |
|               |               |
|               |               |
|               |               |
+---------------+---------------+

and

+-------------------------------+
|                               |
|        RMAIL-summary          |
|                               |
+-------------------------------+
|                               |
|            RMAIL              |
|                               |
+-------------------------------+

The question is what options are necessary to be able to configure RMAIL
window layouts?  Maybe like `gnus-buffer-configuration' in Gnus?

-- 
Juri Linkov
http://www.jurta.org/emacs/

Message #39 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Juri Linkov <juri <at> jurta.org>
Cc: 2282 <at> debbugs.gnu.org, Glenn Morris <rgm <at> gnu.org>,
        "Alfred M. Szmidt" <ams <at> gnu.org>
Subject: Re: bug#2282: Bug#2282: rmail-summary splits frame into three parts
Date: Tue, 10 Nov 2009 12:59:13 -0500

> With the current CVS after `M-x rmail-summary' I see

> +---------------+---------------+
> |               |               |
> | RMAIL-summary |     RMAIL     |
> |               |               |
> +---------------+---------------+
> |                               |
> |         RMAIL-summary         |
> |                               |
> +-------------------------------+

This is a bug, please someone fix it.


        Stefan

Message #44 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Alfred M. Szmidt" <ams <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 2282 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: Re: Bug#2282: rmail-summary splits frame into three parts
Date: Wed, 11 Nov 2009 12:22:05 -0500

Thanks for doing a follow up on this bug.

Message #47 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: ams <at> gnu.org
Cc: 2282 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: Re: Bug#2282: rmail-summary splits frame into three parts
Date: Thu, 12 Nov 2009 02:24:15 -0500

"Alfred M. Szmidt" wrote:

> Thanks for doing a follow up on this bug.

Could you confirm your problem goes away after:

(setq split-width-threshold nil)


I'm tempted to just replace all pop-to-buffers in rmail*.el with

(defun rmail-pop-to-buffer (buffer-or-name &optional other-window norecord)
  (let (split-width-threshold)
    (pop-to-buffer buffer-or-name other-window norecord)))

Message #52 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Glenn Morris <rgm <at> gnu.org>, 2282 <at> debbugs.gnu.org
Cc: ams <at> gnu.org
Subject: Re: bug#2282: Bug#2282: rmail-summary splits frame into three parts
Date: Thu, 12 Nov 2009 09:19:35 +0100

> I'm tempted to just replace all pop-to-buffers in rmail*.el with
>
> (defun rmail-pop-to-buffer (buffer-or-name &optional other-window norecord)
>   (let (split-width-threshold)
>     (pop-to-buffer buffer-or-name other-window norecord)))

I suppose the following code in `rmail-new-summary' is responsible for
the behavior described earlier.

      (if (and (one-window-p)
	       pop-up-windows
	       (not pop-up-frames))
	  ;; If there is just one window, put the summary on the top.
	  (progn
	    (split-window (selected-window) rmail-summary-window-size)
	    (select-window (next-window (frame-first-window)))
	    (pop-to-buffer rmail-summary-buffer)
	    ;; If pop-to-buffer did not use that window, delete that
	    ;; window.  (This can happen if it uses another frame.)
	    (if (not (eq rmail-summary-buffer
			 (window-buffer (frame-first-window))))
		(delete-other-windows)))
	(pop-to-buffer rmail-summary-buffer))

What is that code supposed to do what a simple `pop-to-buffer' cannot
accomplish?  If it's to display the summary on top of the frame, then
splitting horizontally obviously won't make sense here.

martin

Message #57 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 2282 <at> debbugs.gnu.org, ams <at> gnu.org
Subject: Re: bug#2282: Bug#2282: rmail-summary splits frame into three parts
Date: Thu, 12 Nov 2009 10:41:32 -0500

> I'm tempted to just replace all pop-to-buffers in rmail*.el with

> (defun rmail-pop-to-buffer (buffer-or-name &optional other-window norecord)
>   (let (split-width-threshold)
>     (pop-to-buffer buffer-or-name other-window norecord)))

No, please don't: the problem is in pop-to-buffer which should never
create 3 windows out of 1.


        Stefan

Message #62 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 2282 <at> debbugs.gnu.org, Glenn Morris <rgm <at> gnu.org>, ams <at> gnu.org
Subject: Re: bug#2282: Bug#2282: rmail-summary splits frame into three parts
Date: Thu, 12 Nov 2009 10:42:27 -0500

>> I'm tempted to just replace all pop-to-buffers in rmail*.el with
>> 
>> (defun rmail-pop-to-buffer (buffer-or-name &optional other-window norecord)
>> (let (split-width-threshold)
>> (pop-to-buffer buffer-or-name other-window norecord)))

> I suppose the following code in `rmail-new-summary' is responsible for
> the behavior described earlier.

>       (if (and (one-window-p)
> 	       pop-up-windows
> 	       (not pop-up-frames))
> 	  ;; If there is just one window, put the summary on the top.
> 	  (progn
> 	    (split-window (selected-window) rmail-summary-window-size)
> 	    (select-window (next-window (frame-first-window)))
> 	    (pop-to-buffer rmail-summary-buffer)
> 	    ;; If pop-to-buffer did not use that window, delete that
> 	    ;; window.  (This can happen if it uses another frame.)
> 	    (if (not (eq rmail-summary-buffer
> 			 (window-buffer (frame-first-window))))
> 		(delete-other-windows)))
> 	(pop-to-buffer rmail-summary-buffer))

> What is that code supposed to do what a simple `pop-to-buffer' cannot
> accomplish?  If it's to display the summary on top of the frame, then
> splitting horizontally obviously won't make sense here.

Hmm... maybe I misunderstood and the problem may indeed not be in
pop-to-buffer, in the end.


        Stefan

Message #67 received at 2282 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, 2282 <at> debbugs.gnu.org
Cc: Glenn Morris <rgm <at> gnu.org>, ams <at> gnu.org
Subject: Re: bug#2282: Bug#2282: rmail-summary splits frame into three parts
Date: Thu, 12 Nov 2009 18:40:31 +0100

> No, please don't: the problem is in pop-to-buffer which should never
> create 3 windows out of 1.

Well, we _could_ implement that ;-)

martin

Message #72 received at 2282-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 2282-done <at> debbugs.gnu.org
Subject: Re: bug#2282: rmail-summary splits frame into three parts
Date: Tue, 01 Dec 2009 22:05:34 -0500

  * mail/rmail.el (rmail-pop-to-buffer): New function.  (Bug#2282)
  (rmail-select-summary): Use rmail-pop-to-buffer.
  * mail/rmailsum.el: Replace all pop-to-buffer calls with
  rmail-pop-to-buffer, to prevent horizontal splits.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.