From unknown Mon Aug 18 17:56:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22808: Add a function to simplify many of the new python2-foo definitions Resent-From: Christopher Allan Webber Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 25 Feb 2016 21:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22808 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 22808@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.145643488120834 (code B ref -1); Thu, 25 Feb 2016 21:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Feb 2016 21:14:41 +0000 Received: from localhost ([127.0.0.1]:46414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZ3FB-0005Py-1a for submit@debbugs.gnu.org; Thu, 25 Feb 2016 16:14:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47252) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZ3F9-0005Pm-6i for submit@debbugs.gnu.org; Thu, 25 Feb 2016 16:14:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZ3F3-00048w-Ai for submit@debbugs.gnu.org; Thu, 25 Feb 2016 16:14:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ3F3-00048p-7X for submit@debbugs.gnu.org; Thu, 25 Feb 2016 16:14:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ3F2-0003kO-Bx for bug-guix@gnu.org; Thu, 25 Feb 2016 16:14:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZ3Ey-00047n-0o for bug-guix@gnu.org; Thu, 25 Feb 2016 16:14:32 -0500 Received: from dustycloud.org ([50.116.34.160]:56622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ3Ex-00047b-SK for bug-guix@gnu.org; Thu, 25 Feb 2016 16:14:27 -0500 Received: from oolong (localhost [127.0.0.1]) by dustycloud.org (Postfix) with ESMTPS id 978A42661D for ; Thu, 25 Feb 2016 16:14:25 -0500 (EST) User-agent: mu4e 0.9.13; emacs 24.5.1 From: Christopher Allan Webber Date: Thu, 25 Feb 2016 13:14:25 -0800 Message-ID: <87vb5cebm6.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Right now we have a lot of these that look very similar: (define-public python2-chardet (package (inherit (package-with-python2 (strip-python2-variant python-chardet))) (native-inputs `(("python2-setuptools" ,python2-setuptools))))) (define-public python2-translitcodec (package (inherit (package-with-python2 (strip-python2-variant python-translitcodec))) (native-inputs `(("python2-setuptools" ,python2-setuptools))))) (define-public python2-celery (let ((celery (package-with-python2 (strip-python2-variant python-celery)))) (package (inherit celery) (native-inputs `(("python2-setuptools" ,python2-setuptools) ("python2-unittest2" ,python2-unittest2) ("python2-mock" ,python2-mock) ,@(package-native-inputs celery)))))) Time for an abstraction? From unknown Mon Aug 18 17:56:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22808: Add a function to simplify many of the new python2-foo definitions Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 26 Feb 2016 23:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22808 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Christopher Allan Webber Cc: 22808@debbugs.gnu.org Received: via spool by 22808-submit@debbugs.gnu.org id=B22808.14565291979898 (code B ref 22808); Fri, 26 Feb 2016 23:27:02 +0000 Received: (at 22808) by debbugs.gnu.org; 26 Feb 2016 23:26:37 +0000 Received: from localhost ([127.0.0.1]:47976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZRmP-0002ZZ-M0 for submit@debbugs.gnu.org; Fri, 26 Feb 2016 18:26:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49580) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZRmO-0002ZN-7W for 22808@debbugs.gnu.org; Fri, 26 Feb 2016 18:26:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZRmE-0003Lf-5J for 22808@debbugs.gnu.org; Fri, 26 Feb 2016 18:26:31 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZRmE-0003Lb-1y; Fri, 26 Feb 2016 18:26:26 -0500 Received: from reverse-83.fdn.fr ([80.67.176.83]:57936 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aZRmC-00020z-IK; Fri, 26 Feb 2016 18:26:25 -0500 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87vb5cebm6.fsf@dustycloud.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?UTF-8?Q?Vent=C3=B4se?= an 224 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x3D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sat, 27 Feb 2016 00:26:22 +0100 In-Reply-To: <87vb5cebm6.fsf@dustycloud.org> (Christopher Allan Webber's message of "Thu, 25 Feb 2016 13:14:25 -0800") Message-ID: <8760xbyrxd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Christopher Allan Webber skribis: > Right now we have a lot of these that look very similar: > > (define-public python2-chardet > (package > (inherit (package-with-python2 > (strip-python2-variant python-chardet))) > (native-inputs `(("python2-setuptools" ,python2-setuptools))))) Right, we discussed before adding the python2-setuptools dependency automatically as part of =E2=80=98package-with-python2=E2=80=99. I think t= his would be a good idea, indeed. We need to see if there are exceptions to this rule. Any takers? :-) Ludo=E2=80=99. From unknown Mon Aug 18 17:56:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22808: Add a function to simplify many of the new python2-foo definitions Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 26 Apr 2016 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22808 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Christopher Allan Webber Cc: 22808@debbugs.gnu.org Received: via spool by 22808-submit@debbugs.gnu.org id=B22808.146166448320557 (code B ref 22808); Tue, 26 Apr 2016 09:55:02 +0000 Received: (at 22808) by debbugs.gnu.org; 26 Apr 2016 09:54:43 +0000 Received: from localhost ([127.0.0.1]:47478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auzhb-0005LU-5d for submit@debbugs.gnu.org; Tue, 26 Apr 2016 05:54:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auzhZ-0005LK-74 for 22808@debbugs.gnu.org; Tue, 26 Apr 2016 05:54:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auzhP-0002aF-FP for 22808@debbugs.gnu.org; Tue, 26 Apr 2016 05:54:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auzhP-0002aB-BG; Tue, 26 Apr 2016 05:54:31 -0400 Received: from pluto.bordeaux.inria.fr ([193.50.110.57]:37086 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1auzhO-0000fV-Jp; Tue, 26 Apr 2016 05:54:31 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87vb5cebm6.fsf@dustycloud.org> <8760xbyrxd.fsf@gnu.org> Date: Tue, 26 Apr 2016 11:54:28 +0200 In-Reply-To: <8760xbyrxd.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Sat, 27 Feb 2016 00:26:22 +0100") Message-ID: <87lh40wv8r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.4 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Christopher Allan Webber skribis: > >> Right now we have a lot of these that look very similar: >> >> (define-public python2-chardet >> (package >> (inherit (package-with-python2 >> (strip-python2-variant python-chardet))) >> (native-inputs `(("python2-setuptools" ,python2-setuptools))))) > > Right, we discussed before adding the python2-setuptools dependency > automatically as part of =E2=80=98package-with-python2=E2=80=99. I think= this would be > a good idea, indeed. What about this: --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -345,6 +345,14 @@ instead of @command{python3}."))) (define-public python-wrapper (wrap-python3 python)) (define-public python-minimal-wrapper (wrap-python3 python-minimal)) +(define (package-with-python2+setuptools p) + (let ((base (package-with-python2 (strip-python2-variant p)))) + (package + (inherit base) + (native-inputs `(("python2-setuptools" ,python2-setuptools) + ,@(package-native-inputs base)))))) + + (define-public python-psutil (package (name "python-psutil") --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Then we need to change all the occurrences of this pattern to use this new procedure. Thoughts? Ludo=E2=80=99. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 05:54:54 2016 Received: (at control) by debbugs.gnu.org; 26 Apr 2016 09:54:54 +0000 Received: from localhost ([127.0.0.1]:47481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auzhm-0005Lu-ED for submit@debbugs.gnu.org; Tue, 26 Apr 2016 05:54:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auzhk-0005Lg-PO for control@debbugs.gnu.org; Tue, 26 Apr 2016 05:54:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auzha-0002ck-PG for control@debbugs.gnu.org; Tue, 26 Apr 2016 05:54:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auzha-0002cg-Ly for control@debbugs.gnu.org; Tue, 26 Apr 2016 05:54:42 -0400 Received: from pluto.bordeaux.inria.fr ([193.50.110.57]:37088 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1auzhZ-0000gG-Q8 for control@debbugs.gnu.org; Tue, 26 Apr 2016 05:54:42 -0400 Date: Tue, 26 Apr 2016 11:54:39 +0200 Message-Id: <87k2jkwv8g.fsf@gnu.org> To: control@debbugs.gnu.org From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: control message for bug #22808 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) tags 22808 patch From unknown Mon Aug 18 17:56:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22808: Add a function to simplify many of the new python2-foo definitions Resent-From: Efraim Flashner Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 26 Apr 2016 12:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22808 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Christopher Allan Webber , 22808@debbugs.gnu.org Received: via spool by 22808-submit@debbugs.gnu.org id=B22808.146167467516982 (code B ref 22808); Tue, 26 Apr 2016 12:45:02 +0000 Received: (at 22808) by debbugs.gnu.org; 26 Apr 2016 12:44:35 +0000 Received: from localhost ([127.0.0.1]:47572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1av2Lz-0004Pq-1A for submit@debbugs.gnu.org; Tue, 26 Apr 2016 08:44:35 -0400 Received: from flashner.co.il ([178.62.234.194]:44807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1av2Lw-0004Ph-MC for 22808@debbugs.gnu.org; Tue, 26 Apr 2016 08:44:33 -0400 Received: from debian-netbook (ool-45706c69.dyn.optonline.net [69.112.108.105]) by flashner.co.il (Postfix) with ESMTPSA id 26F9740022; Tue, 26 Apr 2016 12:44:31 +0000 (UTC) Date: Tue, 26 Apr 2016 15:44:28 +0300 From: Efraim Flashner Message-ID: <20160426124428.GA12637@debian-netbook> References: <87vb5cebm6.fsf@dustycloud.org> <8760xbyrxd.fsf@gnu.org> <87lh40wv8r.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline In-Reply-To: <87lh40wv8r.fsf@gnu.org> User-Agent: Mutt/1.6.0 (2016-04-01) X-Spam-Score: -1.0 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 26, 2016 at 11:54:28AM +0200, Ludovic Court=C3=A8s wrote: > ludo@gnu.org (Ludovic Court=C3=A8s) skribis: >=20 > > Christopher Allan Webber skribis: > > > >> Right now we have a lot of these that look very similar: > >> > >> (define-public python2-chardet > >> (package > >> (inherit (package-with-python2 > >> (strip-python2-variant python-chardet))) > >> (native-inputs `(("python2-setuptools" ,python2-setuptools))))) > > > > Right, we discussed before adding the python2-setuptools dependency > > automatically as part of =E2=80=98package-with-python2=E2=80=99. I thi= nk this would be > > a good idea, indeed. >=20 > What about this: >=20 > --- a/gnu/packages/python.scm > +++ b/gnu/packages/python.scm > @@ -345,6 +345,14 @@ instead of @command{python3}."))) > (define-public python-wrapper (wrap-python3 python)) > (define-public python-minimal-wrapper (wrap-python3 python-minimal)) > =20 > +(define (package-with-python2+setuptools p) > + (let ((base (package-with-python2 (strip-python2-variant p)))) > + (package > + (inherit base) > + (native-inputs `(("python2-setuptools" ,python2-setuptools) > + ,@(package-native-inputs base)))))) > + > +=0C > (define-public python-psutil > (package > (name "python-psutil") >=20 > Then we need to change all the occurrences of this pattern to use this > new procedure. >=20 > Thoughts? >=20 > Ludo=E2=80=99. Would we still need the properties field in python-foo? What would this mean for packages that need python2-setuptools and other python2- specific packages? Specifically, would all the calls to package-native-inputs cause a slowdown in computing the package? --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --Dxnq1zWXvFF0Q93v Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXH2KpAAoJEPTB05F+rO6T8agP/ixI27Wjdg50tniOsEpWT3CM uZUo7LZ5JYRTXXk/mYTKo16DXwvNssr+BiQBs7D68J1a59lff24/HZ0fUWc3bdzz 71UG+TFMvqKPEbxbCjWAcBjedL3j9TMxQuI5lFZ4nAs/nBm/2fZGG+2WQt4wZrKa t+Mgue/Wg4udP/6CUZQVc0j3ieB7oOvYiMSC0fMLDiDZ1nnDjf3WkJzUc18VYKjE dmzTS73AX7FeOPcvWet0dsz7JCn3e5ycJJHoF4OcR1yHoz28XI+fViuQWlv3VkIL JLXTxu9HblmpjRGCCU5cfR7AIta0BgVaOmVzRmTRrRpRp+/Y0beGzcxYh2ZTZ1C3 d0iQz1oIPDpTb44OXvxmex36yLq0bWbA+icOrBuSUpTxMSyUqSGRsV0IIQtqJW/7 RSBhkQSU9acxAPrRG6Cam47VjrjX3Z+xzOqbifxg/iIiWCwIEOMvYdbrzcqlAzc1 Y+7Zua4zcIhL2YGSPUguzH505TstmgzCYlL8YDZn54aGsHKVqVjLpNG2+x2TUbmw 5czMpuiwQtFPTKeomIMuoWpmkOo7hUjr6XxJFBg3RhVqRsmYo+9WHnl5HpyUKRje cpliBsbkWYr0JLYRQ6/CVuezdysl8jqkHLIsZ1kfmcthHes7uq6k5ReTwsFsDn4A cbQkajpq3rhgs24czN8V =4zh4 -----END PGP SIGNATURE----- --Dxnq1zWXvFF0Q93v-- From unknown Mon Aug 18 17:56:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#22808: Add a function to simplify many of the new python2-foo definitions Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 26 Apr 2016 13:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22808 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: Christopher Allan Webber , 22808@debbugs.gnu.org Received: via spool by 22808-submit@debbugs.gnu.org id=B22808.146167617219663 (code B ref 22808); Tue, 26 Apr 2016 13:10:02 +0000 Received: (at 22808) by debbugs.gnu.org; 26 Apr 2016 13:09:32 +0000 Received: from localhost ([127.0.0.1]:47582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1av2k7-000575-U7 for submit@debbugs.gnu.org; Tue, 26 Apr 2016 09:09:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1av2k3-00056o-Bq for 22808@debbugs.gnu.org; Tue, 26 Apr 2016 09:09:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1av2ju-0000ju-5S for 22808@debbugs.gnu.org; Tue, 26 Apr 2016 09:09:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49472) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av2ju-0000jo-2b; Tue, 26 Apr 2016 09:09:18 -0400 Received: from pluto.bordeaux.inria.fr ([193.50.110.57]:37380 helo=pluto) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1av2jt-00052D-29; Tue, 26 Apr 2016 09:09:17 -0400 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87vb5cebm6.fsf@dustycloud.org> <8760xbyrxd.fsf@gnu.org> <87lh40wv8r.fsf@gnu.org> <20160426124428.GA12637@debian-netbook> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 =?UTF-8?Q?Flor=C3=A9al?= an 224 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x3D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 26 Apr 2016 15:09:15 +0200 In-Reply-To: <20160426124428.GA12637@debian-netbook> (Efraim Flashner's message of "Tue, 26 Apr 2016 15:44:28 +0300") Message-ID: <87oa8wtt38.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -4.4 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) Efraim Flashner skribis: > On Tue, Apr 26, 2016 at 11:54:28AM +0200, Ludovic Court=C3=A8s wrote: >> ludo@gnu.org (Ludovic Court=C3=A8s) skribis: [...] >> What about this: >>=20 > >> --- a/gnu/packages/python.scm >> +++ b/gnu/packages/python.scm >> @@ -345,6 +345,14 @@ instead of @command{python3}."))) >> (define-public python-wrapper (wrap-python3 python)) >> (define-public python-minimal-wrapper (wrap-python3 python-minimal)) >>=20=20 >> +(define (package-with-python2+setuptools p) >> + (let ((base (package-with-python2 (strip-python2-variant p)))) >> + (package >> + (inherit base) >> + (native-inputs `(("python2-setuptools" ,python2-setuptools) >> + ,@(package-native-inputs base)))))) >> + >> + >> (define-public python-psutil >> (package >> (name "python-psutil") > >>=20 >> Then we need to change all the occurrences of this pattern to use this >> new procedure. >>=20 >> Thoughts? >>=20 >> Ludo=E2=80=99. > > Would we still need the properties field in python-foo? Yes. > What would this mean for packages that need python2-setuptools and other > python2- specific packages? Specifically, would all the calls to > package-native-inputs cause a slowdown in computing the package? It wouldn=E2=80=99t change anything, since this exact same pattern is alrea= dy used in many different places in python.scm (search for =E2=80=9Cpython2-setuptools=E2=80=9D and you=E2=80=99ll see :-)). It would= simply allow us to factorize it. Ludo=E2=80=99. From unknown Mon Aug 18 17:56:32 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Allan Webber Subject: bug#22808: closed (Close) Message-ID: References: <20190131143955.GA25613@jurong> <87vb5cebm6.fsf@dustycloud.org> X-Gnu-PR-Message: they-closed 22808 X-Gnu-PR-Package: guix X-Gnu-PR-Keywords: patch Reply-To: 22808@debbugs.gnu.org Date: Thu, 31 Jan 2019 14:41:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1548945662-26602-1" This is a multi-part message in MIME format... ------------=_1548945662-26602-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #22808: Add a function to simplify many of the new python2-foo definitions which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 22808@debbugs.gnu.org. --=20 22808: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D22808 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1548945662-26602-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 22808-done) by debbugs.gnu.org; 31 Jan 2019 14:40:03 +0000 Received: from localhost ([127.0.0.1]:52255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpDVa-0006td-0B for submit@debbugs.gnu.org; Thu, 31 Jan 2019 09:40:03 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:40070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gpDVY-0006t9-9w for 22808-done@debbugs.gnu.org; Thu, 31 Jan 2019 09:40:00 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 7218F9A00; Thu, 31 Jan 2019 15:39:58 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jJHhK9AtX7Pw; Thu, 31 Jan 2019 15:39:58 +0100 (CET) Received: from jurong (cable-78.29.213.16.coditel.net [78.29.213.16]) by hera.aquilenet.fr (Postfix) with ESMTPSA id AF61099FE; Thu, 31 Jan 2019 15:39:57 +0100 (CET) Date: Thu, 31 Jan 2019 15:39:55 +0100 From: Andreas Enge To: 22808-done@debbugs.gnu.org Subject: Close Message-ID: <20190131143955.GA25613@jurong> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.11.0 (2018-11-25) X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 22808-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) This seems to be solved using package-with-python2. Andreas ------------=_1548945662-26602-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 25 Feb 2016 21:14:41 +0000 Received: from localhost ([127.0.0.1]:46414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZ3FB-0005Py-1a for submit@debbugs.gnu.org; Thu, 25 Feb 2016 16:14:41 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47252) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aZ3F9-0005Pm-6i for submit@debbugs.gnu.org; Thu, 25 Feb 2016 16:14:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZ3F3-00048w-Ai for submit@debbugs.gnu.org; Thu, 25 Feb 2016 16:14:33 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ3F3-00048p-7X for submit@debbugs.gnu.org; Thu, 25 Feb 2016 16:14:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38211) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ3F2-0003kO-Bx for bug-guix@gnu.org; Thu, 25 Feb 2016 16:14:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aZ3Ey-00047n-0o for bug-guix@gnu.org; Thu, 25 Feb 2016 16:14:32 -0500 Received: from dustycloud.org ([50.116.34.160]:56622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aZ3Ex-00047b-SK for bug-guix@gnu.org; Thu, 25 Feb 2016 16:14:27 -0500 Received: from oolong (localhost [127.0.0.1]) by dustycloud.org (Postfix) with ESMTPS id 978A42661D for ; Thu, 25 Feb 2016 16:14:25 -0500 (EST) User-agent: mu4e 0.9.13; emacs 24.5.1 From: Christopher Allan Webber To: bug-guix@gnu.org Subject: Add a function to simplify many of the new python2-foo definitions Date: Thu, 25 Feb 2016 13:14:25 -0800 Message-ID: <87vb5cebm6.fsf@dustycloud.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Right now we have a lot of these that look very similar: (define-public python2-chardet (package (inherit (package-with-python2 (strip-python2-variant python-chardet))) (native-inputs `(("python2-setuptools" ,python2-setuptools))))) (define-public python2-translitcodec (package (inherit (package-with-python2 (strip-python2-variant python-translitcodec))) (native-inputs `(("python2-setuptools" ,python2-setuptools))))) (define-public python2-celery (let ((celery (package-with-python2 (strip-python2-variant python-celery)))) (package (inherit celery) (native-inputs `(("python2-setuptools" ,python2-setuptools) ("python2-unittest2" ,python2-unittest2) ("python2-mock" ,python2-mock) ,@(package-native-inputs celery)))))) Time for an abstraction? ------------=_1548945662-26602-1--