GNU bug report logs - #22808
Add a function to simplify many of the new python2-foo definitions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 22808 in the body.
You can then email your comments to 22808 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Allan Webber <cwebber <at> dustycloud.org>
To: bug-guix <at> gnu.org
Subject: Add a function to simplify many of the new python2-foo definitions
Date: Thu, 25 Feb 2016 13:14:25 -0800

Right now we have a lot of these that look very similar:

  (define-public python2-chardet
    (package
      (inherit (package-with-python2
                (strip-python2-variant python-chardet)))
      (native-inputs `(("python2-setuptools" ,python2-setuptools)))))

  (define-public python2-translitcodec
    (package
      (inherit (package-with-python2
                (strip-python2-variant python-translitcodec)))
      (native-inputs `(("python2-setuptools" ,python2-setuptools)))))

  (define-public python2-celery
    (let ((celery (package-with-python2
                   (strip-python2-variant python-celery))))
      (package
        (inherit celery)
        (native-inputs `(("python2-setuptools" ,python2-setuptools)
                         ("python2-unittest2" ,python2-unittest2)
                         ("python2-mock" ,python2-mock)
                         ,@(package-native-inputs celery))))))

Time for an abstraction?

Message #8 received at 22808 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Christopher Allan Webber <cwebber <at> dustycloud.org>
Cc: 22808 <at> debbugs.gnu.org
Subject: Re: bug#22808: Add a function to simplify many of the new python2-foo
 definitions
Date: Sat, 27 Feb 2016 00:26:22 +0100

Christopher Allan Webber <cwebber <at> dustycloud.org> skribis:

> Right now we have a lot of these that look very similar:
>
>   (define-public python2-chardet
>     (package
>       (inherit (package-with-python2
>                 (strip-python2-variant python-chardet)))
>       (native-inputs `(("python2-setuptools" ,python2-setuptools)))))

Right, we discussed before adding the python2-setuptools dependency
automatically as part of ‘package-with-python2’.  I think this would be
a good idea, indeed.

We need to see if there are exceptions to this rule.

Any takers?  :-)

Ludo’.

Message #11 received at 22808 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Christopher Allan Webber <cwebber <at> dustycloud.org>
Cc: 22808 <at> debbugs.gnu.org
Subject: Re: bug#22808: Add a function to simplify many of the new python2-foo
 definitions
Date: Tue, 26 Apr 2016 11:54:28 +0200

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Christopher Allan Webber <cwebber <at> dustycloud.org> skribis:
>
>> Right now we have a lot of these that look very similar:
>>
>>   (define-public python2-chardet
>>     (package
>>       (inherit (package-with-python2
>>                 (strip-python2-variant python-chardet)))
>>       (native-inputs `(("python2-setuptools" ,python2-setuptools)))))
>
> Right, we discussed before adding the python2-setuptools dependency
> automatically as part of ‘package-with-python2’.  I think this would be
> a good idea, indeed.

What about this:

[Message part 2 (text/x-patch, inline)]

--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -345,6 +345,14 @@ instead of @command{python3}.")))
 (define-public python-wrapper (wrap-python3 python))
 (define-public python-minimal-wrapper (wrap-python3 python-minimal))
 
+(define (package-with-python2+setuptools p)
+  (let ((base (package-with-python2 (strip-python2-variant p))))
+    (package
+      (inherit base)
+      (native-inputs `(("python2-setuptools" ,python2-setuptools)
+                       ,@(package-native-inputs base))))))
+
+
 (define-public python-psutil
   (package
     (name "python-psutil")

[Message part 3 (text/plain, inline)]

Then we need to change all the occurrences of this pattern to use this
new procedure.

Thoughts?

Ludo’.

Message #16 received at 22808 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Christopher Allan Webber <cwebber <at> dustycloud.org>, 22808 <at> debbugs.gnu.org
Subject: Re: bug#22808: Add a function to simplify many of the new
 python2-foo definitions
Date: Tue, 26 Apr 2016 15:44:28 +0300

[Message part 1 (text/plain, inline)]

On Tue, Apr 26, 2016 at 11:54:28AM +0200, Ludovic Courtès wrote:
> ludo <at> gnu.org (Ludovic Courtès) skribis:
> 
> > Christopher Allan Webber <cwebber <at> dustycloud.org> skribis:
> >
> >> Right now we have a lot of these that look very similar:
> >>
> >>   (define-public python2-chardet
> >>     (package
> >>       (inherit (package-with-python2
> >>                 (strip-python2-variant python-chardet)))
> >>       (native-inputs `(("python2-setuptools" ,python2-setuptools)))))
> >
> > Right, we discussed before adding the python2-setuptools dependency
> > automatically as part of ‘package-with-python2’.  I think this would be
> > a good idea, indeed.
> 
> What about this:
> 

> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -345,6 +345,14 @@ instead of @command{python3}.")))
>  (define-public python-wrapper (wrap-python3 python))
>  (define-public python-minimal-wrapper (wrap-python3 python-minimal))
>  
> +(define (package-with-python2+setuptools p)
> +  (let ((base (package-with-python2 (strip-python2-variant p))))
> +    (package
> +      (inherit base)
> +      (native-inputs `(("python2-setuptools" ,python2-setuptools)
> +                       ,@(package-native-inputs base))))))
> +
> +
>  (define-public python-psutil
>    (package
>      (name "python-psutil")

> 
> Then we need to change all the occurrences of this pattern to use this
> new procedure.
> 
> Thoughts?
> 
> Ludo’.

Would we still need the properties field in python-foo?

What would this mean for packages that need python2-setuptools and other
python2- specific packages? Specifically, would all the calls to
package-native-inputs cause a slowdown in computing the package?

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 22808 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: Christopher Allan Webber <cwebber <at> dustycloud.org>, 22808 <at> debbugs.gnu.org
Subject: Re: bug#22808: Add a function to simplify many of the new python2-foo
 definitions
Date: Tue, 26 Apr 2016 15:09:15 +0200

Efraim Flashner <efraim <at> flashner.co.il> skribis:

> On Tue, Apr 26, 2016 at 11:54:28AM +0200, Ludovic Courtès wrote:
>> ludo <at> gnu.org (Ludovic Courtès) skribis:

[...]

>> What about this:
>> 
>
>> --- a/gnu/packages/python.scm
>> +++ b/gnu/packages/python.scm
>> @@ -345,6 +345,14 @@ instead of @command{python3}.")))
>>  (define-public python-wrapper (wrap-python3 python))
>>  (define-public python-minimal-wrapper (wrap-python3 python-minimal))
>>  
>> +(define (package-with-python2+setuptools p)
>> +  (let ((base (package-with-python2 (strip-python2-variant p))))
>> +    (package
>> +      (inherit base)
>> +      (native-inputs `(("python2-setuptools" ,python2-setuptools)
>> +                       ,@(package-native-inputs base))))))
>> +
>> +
>>  (define-public python-psutil
>>    (package
>>      (name "python-psutil")
>
>> 
>> Then we need to change all the occurrences of this pattern to use this
>> new procedure.
>> 
>> Thoughts?
>> 
>> Ludo’.
>
> Would we still need the properties field in python-foo?

Yes.

> What would this mean for packages that need python2-setuptools and other
> python2- specific packages? Specifically, would all the calls to
> package-native-inputs cause a slowdown in computing the package?

It wouldn’t change anything, since this exact same pattern is already
used in many different places in python.scm (search for
“python2-setuptools” and you’ll see :-)).  It would simply allow us to
factorize it.

Ludo’.

Message #24 received at 22808-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 22808-done <at> debbugs.gnu.org
Subject: Close
Date: Thu, 31 Jan 2019 15:39:55 +0100

This seems to be solved using package-with-python2.

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.