GNU bug report logs - #22780
25.1.50; wrong average width picked for bold face for 7x13 X11 font

Previous Next

Full log

Message #20 received at 22780 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Kenichi Handa <handa <at> gnu.org>, 22780 <at> debbugs.gnu.org, alex <at> khesin.com,
 "Andrew M. Bishop" <gnubugs <at> gedanken.org.uk>
Subject: Re: bug#22780: 25.1.50; wrong average width picked for bold face
 for 7x13 X11 font
Date: Sun, 17 Nov 2019 07:55:04 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Using 'git bisect' I traced down the change that caused it and
>> demonstrated that it can be fixed by this patch.
>> 
>> -------------------- src/xfaces.c patch --------------------
>> diff --git a/src/xfaces.c b/src/xfaces.c
>> index 5077cb2d94..c898b7886f 100644
>> --- a/src/xfaces.c
>> +++ b/src/xfaces.c
>> @@ -5485,7 +5485,7 @@ realize_x_face (struct face_cache *cache, Lisp_Object attrs[LFACE_VECTOR_SIZE])
>>  	}
>>        if (! FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
>>  	attrs[LFACE_FONT_INDEX]
>> -	  = font_load_for_lface (f, attrs, Ffont_spec (0, NULL));
>> +	  = font_load_for_lface (f, attrs, attrs[LFACE_FONT_INDEX]);
>>        if (FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
>>  	{
>>  	  face->font = XFONT_OBJECT (attrs[LFACE_FONT_INDEX]);
>> -------------------- src/xfaces.c patch --------------------
>> 
>> This reverts a patch that was made as part of bug #17973.  The change
>> in src/font.c that was also made in that bug report seems to not be
>> relevant.
>> 
>> This is clearly a regression from Emacs 24 but since this change was
>> made to fix another bug it might be quite difficult to find a change
>> that works for both.
>
> I'm CC'ing Handa-san who was involved in solving that bug.  Reverting
> the solution for that bug is clearly not TRT, but I hope Handa-san
> will have comments about your particular problem.

I tried the recipe with Emacs 27, and the problem still seems to be
present there:

"-misc-fixed-medium-r-normal--13-120-75-75-c-70-iso8859-1"
"-misc-fixed-bold-r-normal--13-120-75-75-c-80-iso8859-1"

The code in realize_gui_face hasn't changed since the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.