GNU bug report logs - #22737
25.1; Finalizer should be optional in dynamic modules

Previous Next

Package: emacs;

Reported by: Jess Balint <jbalint <at> gmail.com>

Date: Thu, 18 Feb 2016 21:58:02 UTC

Severity: normal

Tags: notabug, wontfix

Found in version 25.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jess Balint <jbalint <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1; Finalizer should be optional in dynamic modules
Date: Thu, 18 Feb 2016 15:52:55 -0600

Dynamic modules are really cool so far, but I think finalizers should
not be mandatory for user pointers (alloc.c):

#ifdef HAVE_MODULES
	      else if (mblk->markers[i].m.u_any.type == Lisp_Misc_User_Ptr)
		{
		  struct Lisp_User_Ptr *uptr = &mblk->markers[i].m.u_user_ptr;
		  uptr->finalizer (uptr->p); <----- should NULL-check first
		}
#endif

c.f. https://github.com/emacs-mirror/emacs/blob/master/src/alloc.c#L6893

Thanks!

Jess
This bug report was last modified 5 years and 316 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.